201554 2019-09-06 12:43:34 -0700 [LFC] A formatting context root is always a containing block for relative: static boxes. 2019-09-06 13:51:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1568638 0 zalan 2019-09-06 12:43:34 -0700 https://www.w3.org/TR/CSS22/visudet.html#containing-block-details 1568639 1 webkit-bug-importer 2019-09-06 12:44:07 -0700 <rdar://problem/55123295> 1568640 2 378219 zalan 2019-09-06 12:46:40 -0700 Created attachment 378219 Patch 1568642 3 378219 koivisto 2019-09-06 12:51:17 -0700 Comment on attachment 378219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378219&action=review > Source/WebCore/layout/layouttree/LayoutBox.cpp:191 > + // content edge of the nearest block container ancestor box or which establishes a formatting context. Recent spec change? 1568643 4 zalan 2019-09-06 12:54:07 -0700 (In reply to Antti Koivisto from comment #3) > Comment on attachment 378219 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378219&action=review > > > Source/WebCore/layout/layouttree/LayoutBox.cpp:191 > > + // content edge of the nearest block container ancestor box or which establishes a formatting context. > > Recent spec change? Not really. Back then my screen had some dead pixels and I must have missed that last part of the sentence. 1568645 5 koivisto 2019-09-06 12:56:38 -0700 > Not really. Back then my screen had some dead pixels and I must have missed > that last part of the sentence. Try moving the window around. 1568674 6 commit-queue 2019-09-06 13:50:42 -0700 The commit-queue encountered the following flaky tests while processing attachment 378219: media/remote-control-command-seek.html bug 192381 (authors: eric.carlson@apple.com and graouts@apple.com) The commit-queue is continuing to process your patch. 1568677 7 378219 commit-queue 2019-09-06 13:51:27 -0700 Comment on attachment 378219 Patch Clearing flags on attachment: 378219 Committed r249590: <https://trac.webkit.org/changeset/249590> 1568678 8 commit-queue 2019-09-06 13:51:29 -0700 All reviewed patches have been landed. Closing bug. 378219 2019-09-06 12:46:40 -0700 2019-09-06 13:51:27 -0700 Patch bug-201554-20190906124626.patch text/plain 3189 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzk4ZDNlYzkzOGVlNmYx NDg1MDlmNjkxY2E0MjhkYzA1MTgyZjkzYS4uNmFhY2NmODIzNzEwOWM4MjI3OWNhMzYyYzJhNzZj N2RhY2U1M2RiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA5LTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQSBmb3JtYXR0aW5n IGNvbnRleHQgcm9vdCBpcyBhbHdheXMgYSBjb250YWluaW5nIGJsb2NrIGZvciByZWxhdGl2ZTog c3RhdGljIGJveGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAxNTU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTEyMzI5NT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAiRm9yIG90aGVyIGVsZW1l bnRzLCBpZiB0aGUgZWxlbWVudCdzIHBvc2l0aW9uIGlzICdyZWxhdGl2ZScgb3IgJ3N0YXRpYycs IHRoZSBjb250YWluaW5nIGJsb2NrIGlzIGZvcm1lZCBieSB0aGUgY29udGVudAorICAgICAgICBl ZGdlIG9mIHRoZSBuZWFyZXN0IGFuY2VzdG9yIGJveCB0aGF0IGlzIGEgYmxvY2sgY29udGFpbmVy IG9yIHdoaWNoIGVzdGFibGlzaGVzIGEgZm9ybWF0dGluZyBjb250ZXh0LiIKKworICAgICAgICAq IGxheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlv dXQ6OkJveDo6Y29udGFpbmluZ0Jsb2NrIGNvbnN0KToKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmll d0xheW91dENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bGF5b3V0VXNpbmdGb3JtYXR0 aW5nQ29udGV4dCk6CisKIDIwMTktMDktMDUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbTEZDXVtURkNdIFNldCBjb21wdXRlZCByb3cgd2lkdGguCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNwcAppbmRleCA4NzI4MGY4 MWFmY2I0NjVmYzQ4ZTM3N2RhYmVjNjFiZjgzOWM2MGRkLi43ZWJjNGFjM2Q2NTEwZGIwYWNhMzhi NDQ2NWQ0NWNmMzJkMTg0MjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5 b3V0dHJlZS9MYXlvdXRCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0 cmVlL0xheW91dEJveC5jcHAKQEAgLTE4OCw3ICsxODgsNyBAQCBjb25zdCBDb250YWluZXIqIEJv eDo6Y29udGFpbmluZ0Jsb2NrKCkgY29uc3QKICAgICBBU1NFUlQoIVBoYXNlOjppc0luVHJlZUJ1 aWxkaW5nKCkpOwogICAgIC8vIFRoZSBjb250YWluaW5nIGJsb2NrIGluIHdoaWNoIHRoZSByb290 IGVsZW1lbnQgbGl2ZXMgaXMgYSByZWN0YW5nbGUgY2FsbGVkIHRoZSBpbml0aWFsIGNvbnRhaW5p bmcgYmxvY2suCiAgICAgLy8gRm9yIG90aGVyIGVsZW1lbnRzLCBpZiB0aGUgZWxlbWVudCdzIHBv c2l0aW9uIGlzICdyZWxhdGl2ZScgb3IgJ3N0YXRpYycsIHRoZSBjb250YWluaW5nIGJsb2NrIGlz IGZvcm1lZCBieSB0aGUKLSAgICAvLyBjb250ZW50IGVkZ2Ugb2YgdGhlIG5lYXJlc3QgYmxvY2sg Y29udGFpbmVyIGFuY2VzdG9yIGJveC4KKyAgICAvLyBjb250ZW50IGVkZ2Ugb2YgdGhlIG5lYXJl c3QgYmxvY2sgY29udGFpbmVyIGFuY2VzdG9yIGJveCBvciB3aGljaCBlc3RhYmxpc2hlcyBhIGZv cm1hdHRpbmcgY29udGV4dC4KICAgICAvLyBJZiB0aGUgZWxlbWVudCBoYXMgJ3Bvc2l0aW9uOiBm aXhlZCcsIHRoZSBjb250YWluaW5nIGJsb2NrIGlzIGVzdGFibGlzaGVkIGJ5IHRoZSB2aWV3cG9y dAogICAgIC8vIElmIHRoZSBlbGVtZW50IGhhcyAncG9zaXRpb246IGFic29sdXRlJywgdGhlIGNv bnRhaW5pbmcgYmxvY2sgaXMgZXN0YWJsaXNoZWQgYnkgdGhlIG5lYXJlc3QgYW5jZXN0b3Igd2l0 aCBhCiAgICAgLy8gJ3Bvc2l0aW9uJyBvZiAnYWJzb2x1dGUnLCAncmVsYXRpdmUnIG9yICdmaXhl ZCcuCkBAIC0xOTYsOSArMTk2LDEzIEBAIGNvbnN0IENvbnRhaW5lciogQm94Ojpjb250YWluaW5n QmxvY2soKSBjb25zdAogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIGlmICghaXNQb3Np dGlvbmVkKCkgfHwgaXNJbkZsb3dQb3NpdGlvbmVkKCkpIHsKLSAgICAgICAgYXV0byogbmVhcmVz dEJsb2NrQ29udGFpbmVyID0gcGFyZW50KCk7Ci0gICAgICAgIGZvciAoOyBuZWFyZXN0QmxvY2tD b250YWluZXItPnBhcmVudCgpICYmICFuZWFyZXN0QmxvY2tDb250YWluZXItPmlzQmxvY2tDb250 YWluZXJCb3goKTsgbmVhcmVzdEJsb2NrQ29udGFpbmVyID0gbmVhcmVzdEJsb2NrQ29udGFpbmVy LT5wYXJlbnQoKSkgeyB9Ci0gICAgICAgIHJldHVybiBuZWFyZXN0QmxvY2tDb250YWluZXI7Cisg ICAgICAgIGZvciAoYXV0byogbmVhcmVzdEJsb2NrQ29udGFpbmVyT3JGb3JtYXR0aW5nQ29udGV4 dFJvb3QgPSBwYXJlbnQoKTsgbmVhcmVzdEJsb2NrQ29udGFpbmVyT3JGb3JtYXR0aW5nQ29udGV4 dFJvb3Q7IG5lYXJlc3RCbG9ja0NvbnRhaW5lck9yRm9ybWF0dGluZ0NvbnRleHRSb290ID0gbmVh cmVzdEJsb2NrQ29udGFpbmVyT3JGb3JtYXR0aW5nQ29udGV4dFJvb3QtPnBhcmVudCgpKSB7Cisg ICAgICAgICAgICBpZiAobmVhcmVzdEJsb2NrQ29udGFpbmVyT3JGb3JtYXR0aW5nQ29udGV4dFJv b3QtPmlzQmxvY2tDb250YWluZXJCb3goKSB8fCBuZWFyZXN0QmxvY2tDb250YWluZXJPckZvcm1h dHRpbmdDb250ZXh0Um9vdC0+ZXN0YWJsaXNoZXNGb3JtYXR0aW5nQ29udGV4dCgpKQorICAgICAg ICAgICAgICAgIHJldHVybiBuZWFyZXN0QmxvY2tDb250YWluZXJPckZvcm1hdHRpbmdDb250ZXh0 Um9vdDsgCisgICAgICAgIH0KKyAgICAgICAgLy8gV2Ugc2hvdWxkIGFsd2F5cyBtYW5hZ2UgdG8g ZmluZCB0aGUgSUNCLgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0 dXJuIG51bGxwdHI7CiAgICAgfQogCiAgICAgaWYgKGlzRml4ZWRQb3NpdGlvbmVkKCkpIHsK