201440 2019-09-03 17:04:59 -0700 REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts 2019-09-05 18:07:09 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 201344 1 ryanhaddad cdumez achristensen beidson commit-queue ggaren koivisto repstein webkit-bot-watchers-bugzilla webkit-bug-importer wilander oldest_to_newest 1567561 0 ryanhaddad 2019-09-03 17:04:59 -0700 http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html have recently become flaky timeouts on macOS WK2 queues. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FadClickAttribution%2Fsecond-attribution-converted-with-higher-priority.html%20http%2Ftests%2FadClickAttribution%2Fsecond-attribution-converted-with-lower-priority.html The earliest blamed revision range is https://trac.webkit.org/log/webkit/?verbose=on&rev=249350&stop_rev=249349 1567562 1 webkit-bug-importer 2019-09-03 17:05:27 -0700 <rdar://problem/54998427> 1568162 2 repstein 2019-09-05 10:28:36 -0700 I was able to reproduce this timeout starting with r249350 using the following command: run-webkit-tests --iter 1000 -f --no-sample-on-timeout --no-retry http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html 1568196 3 cdumez 2019-09-05 12:17:43 -0700 It is weird, when it times out, I actually see the test running to completion and calling testRunner.notifyDone(). This seems like a potential issue with WebKitTestRunner where it fails to stop even though notifyDone() was called. 1568202 4 cdumez 2019-09-05 12:25:17 -0700 (In reply to Chris Dumez from comment #3) > It is weird, when it times out, I actually see the test running to > completion and calling testRunner.notifyDone(). This seems like a potential > issue with WebKitTestRunner where it fails to stop even though notifyDone() > was called. It seems the InjectedBundle in the WebContent process is sending the "Done" IPC to the UIProcess but this IPC is not getting received in the UIProcess. 1568203 5 cdumez 2019-09-05 12:34:09 -0700 (In reply to Chris Dumez from comment #4) > (In reply to Chris Dumez from comment #3) > > It is weird, when it times out, I actually see the test running to > > completion and calling testRunner.notifyDone(). This seems like a potential > > issue with WebKitTestRunner where it fails to stop even though notifyDone() > > was called. > > It seems the InjectedBundle in the WebContent process is sending the "Done" > IPC to the UIProcess but this IPC is not getting received in the UIProcess. I have confirmed that the WebProcessProxy is dropping this IPC message on the floor (likely because there is not WebPageProxy listening anymore for this identifier). I am investigating to find out why. 1568208 6 cdumez 2019-09-05 12:43:42 -0700 (In reply to Chris Dumez from comment #5) > (In reply to Chris Dumez from comment #4) > > (In reply to Chris Dumez from comment #3) > > > It is weird, when it times out, I actually see the test running to > > > completion and calling testRunner.notifyDone(). This seems like a potential > > > issue with WebKitTestRunner where it fails to stop even though notifyDone() > > > was called. > > > > It seems the InjectedBundle in the WebContent process is sending the "Done" > > IPC to the UIProcess but this IPC is not getting received in the UIProcess. > > I have confirmed that the WebProcessProxy is dropping this IPC message on > the floor (likely because there is not WebPageProxy listening anymore for > this identifier). I am investigating to find out why. It looks like the WebKitTestRunner's injected bundle gets confused when we use a process for a new load that already had a WKTR injected bundle. It still tries to talk to the previous page in that process (which is now suspended). 1568209 7 cdumez 2019-09-05 12:44:51 -0700 (In reply to Chris Dumez from comment #6) > (In reply to Chris Dumez from comment #5) > > (In reply to Chris Dumez from comment #4) > > > (In reply to Chris Dumez from comment #3) > > > > It is weird, when it times out, I actually see the test running to > > > > completion and calling testRunner.notifyDone(). This seems like a potential > > > > issue with WebKitTestRunner where it fails to stop even though notifyDone() > > > > was called. > > > > > > It seems the InjectedBundle in the WebContent process is sending the "Done" > > > IPC to the UIProcess but this IPC is not getting received in the UIProcess. > > > > I have confirmed that the WebProcessProxy is dropping this IPC message on > > the floor (likely because there is not WebPageProxy listening anymore for > > this identifier). I am investigating to find out why. > > It looks like the WebKitTestRunner's injected bundle gets confused when we > use a process for a new load that already had a WKTR injected bundle. It > still tries to talk to the previous page in that process (which is now > suspended). I think the issue lies here: InjectedBundlePage* InjectedBundle::page() const { // It might be better to have the UI process send over a reference to the main // page instead of just assuming it's the first one. return m_pages[0].get(); } We always assume the *first* page that was created in the process is the one we want to talk to. 1568214 8 378106 cdumez 2019-09-05 13:03:27 -0700 Created attachment 378106 Patch 1568334 9 378106 commit-queue 2019-09-05 18:07:07 -0700 Comment on attachment 378106 Patch Clearing flags on attachment: 378106 Committed r249557: <https://trac.webkit.org/changeset/249557> 1568335 10 commit-queue 2019-09-05 18:07:09 -0700 All reviewed patches have been landed. Closing bug. 378106 2019-09-05 13:03:27 -0700 2019-09-05 18:07:07 -0700 Patch bug-201440-20190905130327.patch text/plain 5120 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmYzZhNmE0YjI1NmE3ZTJi MDY3ODYzNmVjZjVlNDYxYTEyNWEyYzAuLjcxMGQ5NWNkOTFjZWE0ODJlN2M0NWRmMzdkY2YzNzE2 ZWRmYTJiMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDktMDUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBodHRwL3Rlc3Rz L2FkQ2xpY2tBdHRyaWJ1dGlvbi9zZWNvbmQtYXR0cmlidXRpb24tY29udmVydGVkLXdpdGgtaGln aGVyLXByaW9yaXR5Lmh0bWwgYW5kIGh0dHAvdGVzdHMvYWRDbGlja0F0dHJpYnV0aW9uL3NlY29u ZC1hdHRyaWJ1dGlvbi1jb252ZXJ0ZWQtd2l0aC1sb3dlci1wcmlvcml0eS5odG1sIGFyZSBmbGFr eSB0aW1lb3V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAxNDQwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDk5ODQyNz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcHJpdmF0ZSBXS0J1bmRs ZVBhZ2UgQVBJIHRvIHF1ZXJ5IGlmIHRoZSBXZWJQYWdlIGlzIGN1cnJlbnRseSBzdXNwZW5kZWQg b3Igbm90LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1 bmRsZVBhZ2UuY3BwOgorICAgICAgICAoV0tCdW5kbGVQYWdlSXNTdXNwZW5kZWQpOgorICAgICAg ICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlUHJpdmF0ZS5o OgorCiAyMDE5LTA5LTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNDkyNzUpOiBbR1RLXVtXUEVdIHdyb25nIHBhZ2Ug SUQgcmV0dXJuZWQgYnkgd2Via2l0X3dlYl92aWV3X2dldF9wYWdlX2lkKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBh Z2UuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dL QnVuZGxlUGFnZS5jcHAKaW5kZXggZGMwNzU4YWQ3NWFmMzYxZGZiZTgxNmViMTEzZjQxYzdmMDlk ODFjZC4uZDFmMWRlMGJhYzgyMWRiZGFhZDBiMTI2MDI1YjE2MzIxNGI3ODg5MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxl UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQ SS9jL1dLQnVuZGxlUGFnZS5jcHAKQEAgLTcyNCw2ICs3MjQsMTEgQEAgdm9pZCBXS0J1bmRsZVBh Z2VQb3N0U3luY2hyb25vdXNNZXNzYWdlRm9yVGVzdGluZyhXS0J1bmRsZVBhZ2VSZWYgcGFnZVJl ZiwgV0tTdHIKICAgICAgICAgKnJldHVyblJldGFpbmVkRGF0YVJlZiA9IFdlYktpdDo6dG9BUEko cmV0dXJuRGF0YS5sZWFrUmVmKCkpOwogfQogCitib29sIFdLQnVuZGxlUGFnZUlzU3VzcGVuZGVk KFdLQnVuZGxlUGFnZVJlZiBwYWdlUmVmKQoreworICAgIHJldHVybiBXZWJLaXQ6OnRvSW1wbChw YWdlUmVmKS0+aXNTdXNwZW5kZWQoKTsKK30KKwogdm9pZCBXS0J1bmRsZVBhZ2VBZGRVc2VyU2Ny aXB0KFdLQnVuZGxlUGFnZVJlZiBwYWdlUmVmLCBXS1N0cmluZ1JlZiBzb3VyY2UsIF9XS1VzZXJT Y3JpcHRJbmplY3Rpb25UaW1lIGluamVjdGlvblRpbWUsIFdLVXNlckNvbnRlbnRJbmplY3RlZEZy YW1lcyBpbmplY3RlZEZyYW1lcykKIHsKICAgICBXZWJLaXQ6OnRvSW1wbChwYWdlUmVmKS0+YWRk VXNlclNjcmlwdChXZWJLaXQ6OnRvV1RGU3RyaW5nKHNvdXJjZSksIFdlYktpdDo6dG9Vc2VyQ29u dGVudEluamVjdGVkRnJhbWVzKGluamVjdGVkRnJhbWVzKSwgV2ViS2l0Ojp0b1VzZXJTY3JpcHRJ bmplY3Rpb25UaW1lKGluamVjdGlvblRpbWUpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2VQcml2YXRlLmggYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdl UHJpdmF0ZS5oCmluZGV4IDNhN2IzMTZlOGI1M2NlZjIyM2MyMzdhYzFhY2FlNDQyZTQ0MjEwNWQu LmFjNmNkOTZmNmM2NGFlZmM4NGFjOTFlNDJhNzM0Zjg0MjExNzIxNDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2VQ cml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQ SS9jL1dLQnVuZGxlUGFnZVByaXZhdGUuaApAQCAtMTA1LDYgKzEwNSw4IEBAIFdLX0VYUE9SVCBX S0FycmF5UmVmIFdLQnVuZGxlUGFnZUNvcHlDb250ZXh0TWVudUF0UG9pbnRJbldpbmRvdyhXS0J1 bmRsZVBhZ2VSZWYsCiAKIFdLX0VYUE9SVCB2b2lkIFdLQnVuZGxlUGFnZUluc2VydE5ld2xpbmVJ blF1b3RlZENvbnRlbnQoV0tCdW5kbGVQYWdlUmVmIHBhZ2UpOwogCitXS19FWFBPUlQgYm9vbCBX S0J1bmRsZVBhZ2VJc1N1c3BlbmRlZChXS0J1bmRsZVBhZ2VSZWYgcGFnZSk7CisKIC8vIFRoaXMg b25seSB3b3JrcyBpZiB0aGUgU3VwcHJlc3Nlc0luY3JlbWVudGFsUmVuZGVyaW5nIHByZWZlcmVu Y2UgaXMgc2V0IGFzIHdlbGwuCiB0eXBlZGVmIHVuc2lnbmVkIFdLUmVuZGVyaW5nU3VwcHJlc3Np b25Ub2tlbjsKIFdLX0VYUE9SVCBXS1JlbmRlcmluZ1N1cHByZXNzaW9uVG9rZW4gV0tCdW5kbGVQ YWdlRXh0ZW5kSW5jcmVtZW50YWxSZW5kZXJpbmdTdXBwcmVzc2lvbihXS0J1bmRsZVBhZ2VSZWYp OwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBl ZTcyZjBiYTM5OTI1YmJmZjU0NDkxYzY2ZTZhYjU4ZjdiMWE2YjMuLmUzMzgwYjhjODc1MzZkZWIy YTcyNjNmNjMyYWRhMWM1YWI3MzA4OGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxOS0wOS0wNSAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IGh0dHAvdGVzdHMv YWRDbGlja0F0dHJpYnV0aW9uL3NlY29uZC1hdHRyaWJ1dGlvbi1jb252ZXJ0ZWQtd2l0aC1oaWdo ZXItcHJpb3JpdHkuaHRtbCBhbmQgaHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24vc2Vjb25k LWF0dHJpYnV0aW9uLWNvbnZlcnRlZC13aXRoLWxvd2VyLXByaW9yaXR5Lmh0bWwgYXJlIGZsYWt5 IHRpbWVvdXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDE0NDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU0OTk4NDI3PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHIyNDkzNTAsIGl0IGlz IG5vdyBwb3NzaWJsZSBmb3IgYSBXZWJDb250ZW50IHByb2Nlc3MgdG8gaGF2ZSBhIHN1c3BlbmRl ZCBXZWJQYWdlIGZvciB0aGUgY3VycmVudCB3ZWIgdmlldy4KKyAgICAgICAgVGhpcyB3YXMgY29u ZnVzaW5nIEluamVjdGVkQnVuZGxlOjpwYWdlKCkgaW4gV2ViS2l0VGVzdFJ1bm5lciB3aGljaCB3 YXMgYXNzdW1pbmcgdGhhdCB0aGUgV2ViUGFnZSB0aGF0IHdhcyBmaXJzdAorICAgICAgICBjcmVh dGVkIGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3MgaXMgdGhlIG9uZSB0aGF0IGlzIGN1cnJlbnRs eSBydW5uaW5nIHRoZSB0ZXN0IGFuZCB0aGF0IHdlIHdhbnQgdG8gdGFsayB0by4KKyAgICAgICAg VXBkYXRlIEluamVjdGVkQnVuZGxlOjpwYWdlKCkgdG8gaWdub3JlIHN1c3BlbmRlZCBXZWJQYWdl cyBpbiBvcmRlciB0byBhZGRyZXNzIHRoZSBpc3N1ZS4KKworICAgICAgICAqIFdlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgorICAgICAgICAoV1RSOjpJ bmplY3RlZEJ1bmRsZTo6cGFnZSBjb25zdCk6CisKIDIwMTktMDktMDUgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBBZGQgcHJvcGVyIGxheW91dCB0ZXN0 IHN1cHBvcnQgZm9yIGVwaGVtZXJhbCBzZXNzaW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAgYi9Ub29scy9XZWJL aXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcAppbmRleCA4M2Iy YjMwYjEzMzJlYzc3YmZlZmNjMjlmZGQxYTJlNDgzY2I1ZjIzLi5hZWJkZDY5OWNiYjRiNjJmMTQw MDc1ODIyOTdjYWJhMGMzNTM5OGViIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcApAQCAtMTY0LDcgKzE2NCwx MSBAQCB2b2lkIEluamVjdGVkQnVuZGxlOjpzZXRVcEluamVjdGVkQnVuZGxlQ2xpZW50cyhXS0J1 bmRsZVBhZ2VSZWYgcGFnZSkKIEluamVjdGVkQnVuZGxlUGFnZSogSW5qZWN0ZWRCdW5kbGU6OnBh Z2UoKSBjb25zdAogewogICAgIC8vIEl0IG1pZ2h0IGJlIGJldHRlciB0byBoYXZlIHRoZSBVSSBw cm9jZXNzIHNlbmQgb3ZlciBhIHJlZmVyZW5jZSB0byB0aGUgbWFpbgotICAgIC8vIHBhZ2UgaW5z dGVhZCBvZiBqdXN0IGFzc3VtaW5nIGl0J3MgdGhlIGZpcnN0IG9uZS4KKyAgICAvLyBwYWdlIGlu c3RlYWQgb2YganVzdCBhc3N1bWluZyBpdCdzIHRoZSBmaXJzdCBub24tc3VzcGVuZGVkIG9uZS4K KyAgICBmb3IgKGF1dG8mIHBhZ2UgOiBtX3BhZ2VzKSB7CisgICAgICAgIGlmICghV0tCdW5kbGVQ YWdlSXNTdXNwZW5kZWQocGFnZS0+cGFnZSgpKSkKKyAgICAgICAgICAgIHJldHVybiBwYWdlLmdl dCgpOworICAgIH0KICAgICByZXR1cm4gbV9wYWdlc1swXS5nZXQoKTsKIH0KIAo=