<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>201439</bug_id>
          
          <creation_ts>2019-09-03 16:57:26 -0700</creation_ts>
          <short_desc>[WebAuthn] Make WebAuthn default off and let clients turn it on at will</short_desc>
          <delta_ts>2019-09-06 17:08:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=201369</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>181943</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jiewen Tan">jiewen_tan</reporter>
          <assigned_to name="Jiewen Tan">jiewen_tan</assigned_to>
          <cc>achristensen</cc>
    
    <cc>alex.gaynor</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jiewen_tan</cc>
    
    <cc>mitz</cc>
    
    <cc>sam</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1567559</commentid>
    <comment_count>0</comment_count>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2019-09-03 16:57:26 -0700</bug_when>
    <thetext>Add a SPI to enable WebAuthentication in WKPreferences.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1567560</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-09-03 16:58:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/54998154&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1567572</commentid>
    <comment_count>2</comment_count>
      <attachid>377937</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2019-09-03 17:24:21 -0700</bug_when>
    <thetext>Created attachment 377937
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1567574</commentid>
    <comment_count>3</comment_count>
      <attachid>377937</attachid>
    <who name="">mitz</who>
    <bug_when>2019-09-03 17:28:28 -0700</bug_when>
    <thetext>Comment on attachment 377937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377937&amp;action=review

&gt; Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:160
&gt; +@property (nonatomic, setter=_setWebAuthenticationEnabled:) BOOL _webAuthenticationEnabled WK_API_AVAILABLE(macos(10.13), ios(13.0));

macOS 10.13 has already shipped without this SPI, and I suspect that iOS 13.0 is also incorrect here. We typically use WK_MAC_TBA and WK_IOS_TBA until after the GM seed of the OS is available to developers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1567578</commentid>
    <comment_count>4</comment_count>
      <attachid>377937</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2019-09-03 17:38:17 -0700</bug_when>
    <thetext>Comment on attachment 377937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377937&amp;action=review

Thanks Dan for reviewing the patch.

&gt;&gt; Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:160
&gt;&gt; +@property (nonatomic, setter=_setWebAuthenticationEnabled:) BOOL _webAuthenticationEnabled WK_API_AVAILABLE(macos(10.13), ios(13.0));
&gt; 
&gt; macOS 10.13 has already shipped without this SPI, and I suspect that iOS 13.0 is also incorrect here. We typically use WK_MAC_TBA and WK_IOS_TBA until after the GM seed of the OS is available to developers.

WebAuthentication is enabled for Safari 13 and we are shipping Safari 13 on High Sierra, Mojave, and Catalina. I think specify WK_MAC_TBA for macOS might be risky as someone might later change it to 10.15 and breaks Safari.

Fixed iOS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1567581</commentid>
    <comment_count>5</comment_count>
    <who name="">mitz</who>
    <bug_when>2019-09-03 17:41:34 -0700</bug_when>
    <thetext>(In reply to Jiewen Tan from comment #4)
&gt; Comment on attachment 377937 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=377937&amp;action=review
&gt; 
&gt; Thanks Dan for reviewing the patch.
&gt; 
&gt; &gt;&gt; Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:160
&gt; &gt;&gt; +@property (nonatomic, setter=_setWebAuthenticationEnabled:) BOOL _webAuthenticationEnabled WK_API_AVAILABLE(macos(10.13), ios(13.0));
&gt; &gt; 
&gt; &gt; macOS 10.13 has already shipped without this SPI, and I suspect that iOS 13.0 is also incorrect here. We typically use WK_MAC_TBA and WK_IOS_TBA until after the GM seed of the OS is available to developers.
&gt; 
&gt; WebAuthentication is enabled for Safari 13 and we are shipping Safari 13 on
&gt; High Sierra, Mojave, and Catalina. I think specify WK_MAC_TBA for macOS
&gt; might be risky as someone might later change it to 10.15 and breaks Safari.
&gt; 
&gt; Fixed iOS.

The SPI that’s available to Safari when deployed to an already-shipping macOS release is different from what’s in those release. Please use WK_MAC_TBA or consult folks who are familiar with how Apple manages WebKit API availability.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1567590</commentid>
    <comment_count>6</comment_count>
      <attachid>377937</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2019-09-03 17:53:38 -0700</bug_when>
    <thetext>Comment on attachment 377937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377937&amp;action=review

&gt;&gt;&gt;&gt; Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:160
&gt;&gt;&gt;&gt; +@property (nonatomic, setter=_setWebAuthenticationEnabled:) BOOL _webAuthenticationEnabled WK_API_AVAILABLE(macos(10.13), ios(13.0));
&gt;&gt;&gt; 
&gt;&gt;&gt; macOS 10.13 has already shipped without this SPI, and I suspect that iOS 13.0 is also incorrect here. We typically use WK_MAC_TBA and WK_IOS_TBA until after the GM seed of the OS is available to developers.
&gt;&gt; 
&gt;&gt; WebAuthentication is enabled for Safari 13 and we are shipping Safari 13 on High Sierra, Mojave, and Catalina. I think specify WK_MAC_TBA for macOS might be risky as someone might later change it to 10.15 and breaks Safari.
&gt;&gt; 
&gt;&gt; Fixed iOS.
&gt; 
&gt; The SPI that’s available to Safari when deployed to an already-shipping macOS release is different from what’s in those release. Please use WK_MAC_TBA or consult folks who are familiar with how Apple manages WebKit API availability.

I see. Fixed macOS as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1567591</commentid>
    <comment_count>7</comment_count>
      <attachid>377944</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2019-09-03 17:55:11 -0700</bug_when>
    <thetext>Created attachment 377944
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568366</commentid>
    <comment_count>8</comment_count>
      <attachid>378153</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2019-09-05 19:46:10 -0700</bug_when>
    <thetext>Created attachment 378153
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568725</commentid>
    <comment_count>9</comment_count>
      <attachid>378153</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2019-09-06 15:07:39 -0700</bug_when>
    <thetext>Comment on attachment 378153
Patch

Thanks Youenn for r+ the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568771</commentid>
    <comment_count>10</comment_count>
      <attachid>378153</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-06 17:08:19 -0700</bug_when>
    <thetext>Comment on attachment 378153
Patch

Clearing flags on attachment: 378153

Committed r249600: &lt;https://trac.webkit.org/changeset/249600&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568772</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-09-06 17:08:20 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>377937</attachid>
            <date>2019-09-03 17:24:21 -0700</date>
            <delta_ts>2019-09-03 17:55:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201439-20190903172421.patch</filename>
            <type>text/plain</type>
            <size>7549</size>
            <attacher name="Jiewen Tan">jiewen_tan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiNmU1MDJkZjEwNjU1NmFi
MDYzMDllMjhmNjQ4MWQ5ZjJhOGU3ZGUuLjA4YTJjZGJiZjU5NDBhMTc2MTVhN2Y0MzcxNzhhNzIz
ZjE1M2VkNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDktMDMgIEppZXdlbiBU
YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEFkZCBhIFNQ
SSB0byBlbmFibGUgV2ViQXV0aGVudGljYXRpb24gaW4gV0tQcmVmZXJlbmNlcworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNDM5CisgICAgICAgIDxy
ZGFyOi8vcHJvYmxlbS81NDk5ODE1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBTUEkgdG8gZW5hYmxlIFdlYkF1dGhl
bnRpY2F0aW9uIGluIFdLUHJlZmVyZW5jZXMgYW5kIG1ha2UgaXQgZGVmYXVsdCBvZmYgc3VjaCB0
aGF0CisgICAgICAgIGNsaWVudHMgdGhhdCBoYXZlIHRoZSByaWdodCBlbnRpdGxlbWVudHMgY291
bGQgdHVybiBpdCBvbiBhbmQgd2UgZG9uJ3QgcmlzayBhdCB0dXJuaW5nIG9uIGEgV2ViIEFQSQor
ICAgICAgICB0aGF0IGRvZXMgbm90aGluZyBieSBkZWZhdWx0LgorCisgICAgICAgICogU2hhcmVk
L1dlYlByZWZlcmVuY2VzLnlhbWw6CisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVm
YXVsdFZhbHVlcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OmRlZmF1bHRXZWJBdXRoZW50aWNhdGlv
bkVuYWJsZWQpOiBEZWxldGVkLgorICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1
bHRWYWx1ZXMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMu
bW06CisgICAgICAgICgtW1dLUHJlZmVyZW5jZXMgX3dlYkF1dGhlbnRpY2F0aW9uRW5hYmxlZF0p
OgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIF9zZXRXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQ6
XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5o
OgorCiAyMDE5LTA5LTAzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgog
CiAgICAgICAgIE51bGwgZGVyZWYgdW5kZXIgLVtXS1dlYlZpZXcgX2FkZFVwZGF0ZVZpc2libGVD
b250ZW50UmVjdFByZUNvbW1pdEhhbmRsZXJdJ3MgaGFuZGxlciBibG9jawpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XZWJLaXQv
U2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKaW5kZXggNzBiMGU0ODhiNzAzY2Y2ZTM0ZTBlYjhl
MzQ1OTJmNmI3YmFjZWNiYS4uYjE5ZGY3YmM2NjljOGI3MzRiOGQ2OWFmODJjZjI5ZWU5YzhlYTQy
MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAor
KysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCkBAIC03NjcsNyAr
NzY3LDcgQEAgSW5wdXRFdmVudHNFbmFibGVkOgogCiBXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQ6
CiAgIHR5cGU6IGJvb2wKLSAgZGVmYXVsdFZhbHVlOiBkZWZhdWx0V2ViQXV0aGVudGljYXRpb25F
bmFibGVkKCkKKyAgZGVmYXVsdFZhbHVlOiBmYWxzZQogICBodW1hblJlYWRhYmxlTmFtZTogIldl
YiBBdXRoZW50aWNhdGlvbiIKICAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiRW5hYmxlIFdl
YiBBdXRoZW50aWNhdGlvbiBzdXBwb3J0IgogICB3ZWJjb3JlQmluZGluZzogUnVudGltZUVuYWJs
ZWRGZWF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5j
ZXNEZWZhdWx0VmFsdWVzLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2Vz
RGVmYXVsdFZhbHVlcy5jcHAKaW5kZXggZmUxNGUzZjkyMjZlZWExOTRkNmJiNDU5YTJiMWZiMzYx
MmJjYzk3Ny4uYWU2NTBhNjY3ODZiYWU3OThiNzA3MWJkZTU0Njg0NTQ0MGYyNDNkYSAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmNw
cAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMu
Y3BwCkBAIC03NywxNSArNzcsNCBAQCBib29sIGRlZmF1bHRUZXh0QXV0b3NpemluZ1VzZXNJZGVt
cG90ZW50TW9kZSgpCiAKICNlbmRpZiAvLyBFTkFCTEUoVEVYVF9BVVRPU0laSU5HKSAmJiAhUExB
VEZPUk0oSU9TX0ZBTUlMWSkKIAotYm9vbCBkZWZhdWx0V2ViQXV0aGVudGljYXRpb25FbmFibGVk
KCkKLXsKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKQotICAgIHJldHVybiBXZWJDb3JlOjpJT1NB
cHBsaWNhdGlvbjo6aXNNb2JpbGVTYWZhcmkoKSB8fCBXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6
aXNTYWZhcmlWaWV3U2VydmljZSgpOwotI2VsaWYgUExBVEZPUk0oTUFDKQotICAgIHJldHVybiB0
cnVlOwotI2Vsc2UKLSAgICByZXR1cm4gZmFsc2U7Ci0jZW5kaWYKLX0KLQogfSAvLyBuYW1lc3Bh
Y2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNl
c0RlZmF1bHRWYWx1ZXMuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVm
YXVsdFZhbHVlcy5oCmluZGV4IDAxMWRjNDQ2NTAyZGY4MWUyNTNiN2I5MjMzYWI3YzI1OGIyZWYy
MmQuLjhmYzEzNDU5NTk4NmU5NTAyMmI5ZDMxODc3M2RkZjM0MmU1NjBiMTMgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oCisrKyBi
L1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oCkBAIC0y
ODAsNiArMjgwLDQgQEAgYm9vbCBkZWZhdWx0Q1NTT01WaWV3U2Nyb2xsaW5nQVBJRW5hYmxlZCgp
OwogYm9vbCBkZWZhdWx0VGV4dEF1dG9zaXppbmdVc2VzSWRlbXBvdGVudE1vZGUoKTsKICNlbmRp
ZgogCi1ib29sIGRlZmF1bHRXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQoKTsKLQogfSAvLyBuYW1l
c3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j
b2EvV0tQcmVmZXJlbmNlcy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X
S1ByZWZlcmVuY2VzLm1tCmluZGV4IDE5NDI2MGUwYzJlY2RjMDlmNGJmYWE5NjY3NTg3NWZiYTU4
MmZiNDAuLmJhYTZkYTUyYWVkYzEzMjMzMDdmODNhYjZhMDk5ZWM4NGQ3NmNlZjIgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCisr
KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCkBA
IC04NjEsNiArODYxLDIyIEBAIC0gKHZvaWQpX3NldFNlY3VyZUNvbnRleHRDaGVja3NFbmFibGVk
OihCT09MKWVuYWJsZWQKICAgICBfcHJlZmVyZW5jZXMtPnNldFNlY3VyZUNvbnRleHRDaGVja3NF
bmFibGVkKGVuYWJsZWQpOwogfQogCistIChCT09MKV93ZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQK
K3sKKyNpZiBFTkFCTEUoV0VCX0FVVEhOKQorICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPndlYkF1
dGhlbnRpY2F0aW9uRW5hYmxlZCgpOworI2Vsc2UKKyAgICByZXR1cm4gTk87CisjZW5kaWYKK30K
KworLSAodm9pZClfc2V0V2ViQXV0aGVudGljYXRpb25FbmFibGVkOihCT09MKWVuYWJsZWQKK3sK
KyNpZiBFTkFCTEUoV0VCX0FVVEhOKQorICAgIF9wcmVmZXJlbmNlcy0+c2V0V2ViQXV0aGVudGlj
YXRpb25FbmFibGVkKGVuYWJsZWQpOworI2VuZGlmCit9CisKICNpZiBQTEFURk9STShNQUMpCiAt
ICh2b2lkKV9zZXRKYXZhRW5hYmxlZEZvckxvY2FsRmlsZXM6KEJPT0wpZW5hYmxlZAogewpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQ
cml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNl
c1ByaXZhdGUuaAppbmRleCAyNmZjYTdmMzA5NzhhOTM5ZjIxMDFjYzhjZTFkOTExYmYyODljZmZj
Li5jNWUzYjkwNTAwNDc0ZmZlZjczNDA5ZDhlZjU2ZmQ5NWU4ZTk4M2MwIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaAor
KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZh
dGUuaApAQCAtMTU3LDYgKzE1Nyw3IEBAIHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIsIF9XS0Vk
aXRhYmxlTGlua0JlaGF2aW9yKSB7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRJ
dHBEZWJ1Z01vZGVFbmFibGVkOikgQk9PTCBfaXRwRGVidWdNb2RlRW5hYmxlZCBXS19BUElfQVZB
SUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogQHByb3BlcnR5IChu
b25hdG9taWMsIHNldHRlcj1fc2V0TWVkaWFTb3VyY2VFbmFibGVkOikgQk9PTCBfbWVkaWFTb3Vy
Y2VFbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTMuNCksIGlvcyhXS19JT1NfVEJB
KSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRTZWN1cmVDb250ZXh0Q2hlY2tz
RW5hYmxlZDopIEJPT0wgX3NlY3VyZUNvbnRleHRDaGVja3NFbmFibGVkIFdLX0FQSV9BVkFJTEFC
TEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CitAcHJvcGVydHkgKG5vbmF0
b21pYywgc2V0dGVyPV9zZXRXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQ6KSBCT09MIF93ZWJBdXRo
ZW50aWNhdGlvbkVuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvcygxMC4xMyksIGlvcygxMy4w
KSk7CiAKICNpZiAhVEFSR0VUX09TX0lQSE9ORQogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRl
cj1fc2V0V2ViR0xFbmFibGVkOikgQk9PTCBfd2ViR0xFbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUo
bWFjb3MoMTAuMTMuNCkpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh
bmdlTG9nCmluZGV4IGI3NjY3ZmRkMmVhNDVlNWZkMTgxZWI4OWJhMjIwNGE1YWNlYjdhNzIuLjc3
YWYyY2UxNDBlNjBmOTU3ZjkxZGJiZjhjMGM0YTIwYTczNDA4NTYgMTAwNjQ0Ci0tLSBhL1Rvb2xz
L0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0w
OS0wMyAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgorCisgICAgICAgIFtXZWJB
dXRobl0gQWRkIGEgU1BJIHRvIGVuYWJsZSBXZWJBdXRoZW50aWNhdGlvbiBpbiBXS1ByZWZlcmVu
Y2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE0
MzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU0OTk4MTU0PgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL0FwcERlbGVn
YXRlLm06CisgICAgICAgIChkZWZhdWx0Q29uZmlndXJhdGlvbik6CisgICAgICAgIFR1cm4gV2Vi
QXV0aGVudGljYXRpb24gb24gYnkgZGVmYXVsdC4gVGhpcyBwYXRjaCBhbHNvIG1vdmVzIG90aGVy
IHByZWZlcmVuY2Ugc2V0dGluZyBjb2RlCisgICAgICAgIGJlbG93IHRoZSBjb2RlIHRoYXQgc2V0
IHRoZW0gdG8gZGVmYXVsdCB2YWx1ZXMgc3VjaCB0aGF0IGl0IGNhbiB0YWtlIGVmZmVjdHMuCisK
IDIwMTktMDktMDMgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAg
ICAgIHJlc3VsdHMud2Via2l0Lm9yZzogTW92ZSBsZWdlbmQgaW50byBzaWRlYmFyCmRpZmYgLS1n
aXQgYS9Ub29scy9NaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUubSBiL1Rvb2xzL01pbmlCcm93
c2VyL21hYy9BcHBEZWxlZ2F0ZS5tCmluZGV4IGVmMTlmMGQ5YzZlMDk0MTgyNmMwMTNmNDk2OTQ4
MGEwYWM0NTMxZDYuLjkwOTNmMmJjYTYzNDUxOWQ0YmZhMDgxYjJhNTUzYjJkMWZkN2QyZmUgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tCisrKyBiL1Rvb2xz
L01pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tCkBAIC04NCwxMCArODQsNiBAQCAtICh2b2lk
KWF3YWtlRnJvbU5pYgogCiAgICAgaWYgKCFjb25maWd1cmF0aW9uKSB7CiAgICAgICAgIGNvbmZp
Z3VyYXRpb24gPSBbW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gYWxsb2NdIGluaXRdOwotICAgICAg
ICBjb25maWd1cmF0aW9uLnByZWZlcmVuY2VzLl9mdWxsU2NyZWVuRW5hYmxlZCA9IFlFUzsKLSAg
ICAgICAgY29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcy5fZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCA9
IFlFUzsKLSAgICAgICAgY29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcy5fbWVkaWFEZXZpY2VzRW5h
YmxlZCA9IFlFUzsKLSAgICAgICAgY29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcy5fbW9ja0NhcHR1
cmVEZXZpY2VzRW5hYmxlZCA9IFlFUzsKIAogICAgICAgICBfV0tQcm9jZXNzUG9vbENvbmZpZ3Vy
YXRpb24gKnByb2Nlc3NDb25maWd1cmF0aW9uID0gW1tbX1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0
aW9uIGFsbG9jXSBpbml0XSBhdXRvcmVsZWFzZV07CiAgICAgICAgIHByb2Nlc3NDb25maWd1cmF0
aW9uLmRpc2tDYWNoZVNwZWN1bGF0aXZlVmFsaWRhdGlvbkVuYWJsZWQgPSAhW1NldHRpbmdzQ29u
dHJvbGxlciBzaGFyZWRdLm5ldHdvcmtDYWNoZVNwZWN1bGF0aXZlUmV2YWxpZGF0aW9uRGlzYWJs
ZWQ7CkBAIC0xMTcsNiArMTEzLDEyIEBAIC0gKHZvaWQpYXdha2VGcm9tTmliCiAgICAgICAgICAg
ICAgICAgZW5hYmxlZCA9IFtmZWF0dXJlIGRlZmF1bHRWYWx1ZV07CiAgICAgICAgICAgICBbY29u
ZmlndXJhdGlvbi5wcmVmZXJlbmNlcyBfc2V0RW5hYmxlZDplbmFibGVkIGZvckludGVybmFsRGVi
dWdGZWF0dXJlOmZlYXR1cmVdOwogICAgICAgICB9CisKKyAgICAgICAgY29uZmlndXJhdGlvbi5w
cmVmZXJlbmNlcy5fZnVsbFNjcmVlbkVuYWJsZWQgPSBZRVM7CisgICAgICAgIGNvbmZpZ3VyYXRp
b24ucHJlZmVyZW5jZXMuX2RldmVsb3BlckV4dHJhc0VuYWJsZWQgPSBZRVM7CisgICAgICAgIGNv
bmZpZ3VyYXRpb24ucHJlZmVyZW5jZXMuX21lZGlhRGV2aWNlc0VuYWJsZWQgPSBZRVM7CisgICAg
ICAgIGNvbmZpZ3VyYXRpb24ucHJlZmVyZW5jZXMuX21vY2tDYXB0dXJlRGV2aWNlc0VuYWJsZWQg
PSBZRVM7CisgICAgICAgIGNvbmZpZ3VyYXRpb24ucHJlZmVyZW5jZXMuX3dlYkF1dGhlbnRpY2F0
aW9uRW5hYmxlZCA9IFlFUzsKICAgICB9CiAKICAgICBjb25maWd1cmF0aW9uLnN1cHByZXNzZXNJ
bmNyZW1lbnRhbFJlbmRlcmluZyA9IFtTZXR0aW5nc0NvbnRyb2xsZXIgc2hhcmVkXS5pbmNyZW1l
bnRhbFJlbmRlcmluZ1N1cHByZXNzZWQ7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>377944</attachid>
            <date>2019-09-03 17:55:11 -0700</date>
            <delta_ts>2019-09-05 19:46:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201439-20190903175511.patch</filename>
            <type>text/plain</type>
            <size>7560</size>
            <attacher name="Jiewen Tan">jiewen_tan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiNmU1MDJkZjEwNjU1NmFi
MDYzMDllMjhmNjQ4MWQ5ZjJhOGU3ZGUuLjA4YTJjZGJiZjU5NDBhMTc2MTVhN2Y0MzcxNzhhNzIz
ZjE1M2VkNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDktMDMgIEppZXdlbiBU
YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEFkZCBhIFNQ
SSB0byBlbmFibGUgV2ViQXV0aGVudGljYXRpb24gaW4gV0tQcmVmZXJlbmNlcworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNDM5CisgICAgICAgIDxy
ZGFyOi8vcHJvYmxlbS81NDk5ODE1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBTUEkgdG8gZW5hYmxlIFdlYkF1dGhl
bnRpY2F0aW9uIGluIFdLUHJlZmVyZW5jZXMgYW5kIG1ha2UgaXQgZGVmYXVsdCBvZmYgc3VjaCB0
aGF0CisgICAgICAgIGNsaWVudHMgdGhhdCBoYXZlIHRoZSByaWdodCBlbnRpdGxlbWVudHMgY291
bGQgdHVybiBpdCBvbiBhbmQgd2UgZG9uJ3QgcmlzayBhdCB0dXJuaW5nIG9uIGEgV2ViIEFQSQor
ICAgICAgICB0aGF0IGRvZXMgbm90aGluZyBieSBkZWZhdWx0LgorCisgICAgICAgICogU2hhcmVk
L1dlYlByZWZlcmVuY2VzLnlhbWw6CisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVm
YXVsdFZhbHVlcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OmRlZmF1bHRXZWJBdXRoZW50aWNhdGlv
bkVuYWJsZWQpOiBEZWxldGVkLgorICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1
bHRWYWx1ZXMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMu
bW06CisgICAgICAgICgtW1dLUHJlZmVyZW5jZXMgX3dlYkF1dGhlbnRpY2F0aW9uRW5hYmxlZF0p
OgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIF9zZXRXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQ6
XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5o
OgorCiAyMDE5LTA5LTAzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgog
CiAgICAgICAgIE51bGwgZGVyZWYgdW5kZXIgLVtXS1dlYlZpZXcgX2FkZFVwZGF0ZVZpc2libGVD
b250ZW50UmVjdFByZUNvbW1pdEhhbmRsZXJdJ3MgaGFuZGxlciBibG9jawpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XZWJLaXQv
U2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKaW5kZXggNzBiMGU0ODhiNzAzY2Y2ZTM0ZTBlYjhl
MzQ1OTJmNmI3YmFjZWNiYS4uYjE5ZGY3YmM2NjljOGI3MzRiOGQ2OWFmODJjZjI5ZWU5YzhlYTQy
MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAor
KysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCkBAIC03NjcsNyAr
NzY3LDcgQEAgSW5wdXRFdmVudHNFbmFibGVkOgogCiBXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQ6
CiAgIHR5cGU6IGJvb2wKLSAgZGVmYXVsdFZhbHVlOiBkZWZhdWx0V2ViQXV0aGVudGljYXRpb25F
bmFibGVkKCkKKyAgZGVmYXVsdFZhbHVlOiBmYWxzZQogICBodW1hblJlYWRhYmxlTmFtZTogIldl
YiBBdXRoZW50aWNhdGlvbiIKICAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiRW5hYmxlIFdl
YiBBdXRoZW50aWNhdGlvbiBzdXBwb3J0IgogICB3ZWJjb3JlQmluZGluZzogUnVudGltZUVuYWJs
ZWRGZWF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5j
ZXNEZWZhdWx0VmFsdWVzLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2Vz
RGVmYXVsdFZhbHVlcy5jcHAKaW5kZXggZmUxNGUzZjkyMjZlZWExOTRkNmJiNDU5YTJiMWZiMzYx
MmJjYzk3Ny4uYWU2NTBhNjY3ODZiYWU3OThiNzA3MWJkZTU0Njg0NTQ0MGYyNDNkYSAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmNw
cAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMu
Y3BwCkBAIC03NywxNSArNzcsNCBAQCBib29sIGRlZmF1bHRUZXh0QXV0b3NpemluZ1VzZXNJZGVt
cG90ZW50TW9kZSgpCiAKICNlbmRpZiAvLyBFTkFCTEUoVEVYVF9BVVRPU0laSU5HKSAmJiAhUExB
VEZPUk0oSU9TX0ZBTUlMWSkKIAotYm9vbCBkZWZhdWx0V2ViQXV0aGVudGljYXRpb25FbmFibGVk
KCkKLXsKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKQotICAgIHJldHVybiBXZWJDb3JlOjpJT1NB
cHBsaWNhdGlvbjo6aXNNb2JpbGVTYWZhcmkoKSB8fCBXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6
aXNTYWZhcmlWaWV3U2VydmljZSgpOwotI2VsaWYgUExBVEZPUk0oTUFDKQotICAgIHJldHVybiB0
cnVlOwotI2Vsc2UKLSAgICByZXR1cm4gZmFsc2U7Ci0jZW5kaWYKLX0KLQogfSAvLyBuYW1lc3Bh
Y2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNl
c0RlZmF1bHRWYWx1ZXMuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVm
YXVsdFZhbHVlcy5oCmluZGV4IDAxMWRjNDQ2NTAyZGY4MWUyNTNiN2I5MjMzYWI3YzI1OGIyZWYy
MmQuLjhmYzEzNDU5NTk4NmU5NTAyMmI5ZDMxODc3M2RkZjM0MmU1NjBiMTMgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oCisrKyBi
L1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oCkBAIC0y
ODAsNiArMjgwLDQgQEAgYm9vbCBkZWZhdWx0Q1NTT01WaWV3U2Nyb2xsaW5nQVBJRW5hYmxlZCgp
OwogYm9vbCBkZWZhdWx0VGV4dEF1dG9zaXppbmdVc2VzSWRlbXBvdGVudE1vZGUoKTsKICNlbmRp
ZgogCi1ib29sIGRlZmF1bHRXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQoKTsKLQogfSAvLyBuYW1l
c3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j
b2EvV0tQcmVmZXJlbmNlcy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X
S1ByZWZlcmVuY2VzLm1tCmluZGV4IDE5NDI2MGUwYzJlY2RjMDlmNGJmYWE5NjY3NTg3NWZiYTU4
MmZiNDAuLmJhYTZkYTUyYWVkYzEzMjMzMDdmODNhYjZhMDk5ZWM4NGQ3NmNlZjIgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCisr
KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCkBA
IC04NjEsNiArODYxLDIyIEBAIC0gKHZvaWQpX3NldFNlY3VyZUNvbnRleHRDaGVja3NFbmFibGVk
OihCT09MKWVuYWJsZWQKICAgICBfcHJlZmVyZW5jZXMtPnNldFNlY3VyZUNvbnRleHRDaGVja3NF
bmFibGVkKGVuYWJsZWQpOwogfQogCistIChCT09MKV93ZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQK
K3sKKyNpZiBFTkFCTEUoV0VCX0FVVEhOKQorICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPndlYkF1
dGhlbnRpY2F0aW9uRW5hYmxlZCgpOworI2Vsc2UKKyAgICByZXR1cm4gTk87CisjZW5kaWYKK30K
KworLSAodm9pZClfc2V0V2ViQXV0aGVudGljYXRpb25FbmFibGVkOihCT09MKWVuYWJsZWQKK3sK
KyNpZiBFTkFCTEUoV0VCX0FVVEhOKQorICAgIF9wcmVmZXJlbmNlcy0+c2V0V2ViQXV0aGVudGlj
YXRpb25FbmFibGVkKGVuYWJsZWQpOworI2VuZGlmCit9CisKICNpZiBQTEFURk9STShNQUMpCiAt
ICh2b2lkKV9zZXRKYXZhRW5hYmxlZEZvckxvY2FsRmlsZXM6KEJPT0wpZW5hYmxlZAogewpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQ
cml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNl
c1ByaXZhdGUuaAppbmRleCAyNmZjYTdmMzA5NzhhOTM5ZjIxMDFjYzhjZTFkOTExYmYyODljZmZj
Li41YjVmMjUwOGFiODA0M2M3Y2RjNDY4YzA5OGE1Y2FiNTRmZjcyOWNiIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaAor
KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZh
dGUuaApAQCAtMTU3LDYgKzE1Nyw3IEBAIHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIsIF9XS0Vk
aXRhYmxlTGlua0JlaGF2aW9yKSB7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRJ
dHBEZWJ1Z01vZGVFbmFibGVkOikgQk9PTCBfaXRwRGVidWdNb2RlRW5hYmxlZCBXS19BUElfQVZB
SUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogQHByb3BlcnR5IChu
b25hdG9taWMsIHNldHRlcj1fc2V0TWVkaWFTb3VyY2VFbmFibGVkOikgQk9PTCBfbWVkaWFTb3Vy
Y2VFbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTMuNCksIGlvcyhXS19JT1NfVEJB
KSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRTZWN1cmVDb250ZXh0Q2hlY2tz
RW5hYmxlZDopIEJPT0wgX3NlY3VyZUNvbnRleHRDaGVja3NFbmFibGVkIFdLX0FQSV9BVkFJTEFC
TEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CitAcHJvcGVydHkgKG5vbmF0
b21pYywgc2V0dGVyPV9zZXRXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQ6KSBCT09MIF93ZWJBdXRo
ZW50aWNhdGlvbkVuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvcyhXS19NQUNfVEJBKSwgaW9z
KFdLX0lPU19UQkEpKTsKIAogI2lmICFUQVJHRVRfT1NfSVBIT05FCiBAcHJvcGVydHkgKG5vbmF0
b21pYywgc2V0dGVyPV9zZXRXZWJHTEVuYWJsZWQ6KSBCT09MIF93ZWJHTEVuYWJsZWQgV0tfQVBJ
X0FWQUlMQUJMRShtYWNvcygxMC4xMy40KSk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjc2NjdmZGQyZWE0NWU1ZmQxODFlYjg5YmEyMjA0YTVh
Y2ViN2E3Mi4uNzdhZjJjZTE0MGU2MGY5NTdmOTFkYmJmOGMwYzRhMjBhNzM0MDg1NiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDE5LTA5LTAzICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAg
ICAgICAgW1dlYkF1dGhuXSBBZGQgYSBTUEkgdG8gZW5hYmxlIFdlYkF1dGhlbnRpY2F0aW9uIGlu
IFdLUHJlZmVyZW5jZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIwMTQzOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQ5OTgxNTQ+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9t
YWMvQXBwRGVsZWdhdGUubToKKyAgICAgICAgKGRlZmF1bHRDb25maWd1cmF0aW9uKToKKyAgICAg
ICAgVHVybiBXZWJBdXRoZW50aWNhdGlvbiBvbiBieSBkZWZhdWx0LiBUaGlzIHBhdGNoIGFsc28g
bW92ZXMgb3RoZXIgcHJlZmVyZW5jZSBzZXR0aW5nIGNvZGUKKyAgICAgICAgYmVsb3cgdGhlIGNv
ZGUgdGhhdCBzZXQgdGhlbSB0byBkZWZhdWx0IHZhbHVlcyBzdWNoIHRoYXQgaXQgY2FuIHRha2Ug
ZWZmZWN0cy4KKwogMjAxOS0wOS0wMyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5j
b20+CiAKICAgICAgICAgcmVzdWx0cy53ZWJraXQub3JnOiBNb3ZlIGxlZ2VuZCBpbnRvIHNpZGVi
YXIKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tIGIvVG9v
bHMvTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0KaW5kZXggZWYxOWYwZDljNmUwOTQxODI2
YzAxM2Y0OTY5NDgwYTBhYzQ1MzFkNi4uOTA5M2YyYmNhNjM0NTE5ZDRiZmEwODFiMmE1NTNiMmQx
ZmQ3ZDJmZSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0K
KysrIGIvVG9vbHMvTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0KQEAgLTg0LDEwICs4NCw2
IEBAIC0gKHZvaWQpYXdha2VGcm9tTmliCiAKICAgICBpZiAoIWNvbmZpZ3VyYXRpb24pIHsKICAg
ICAgICAgY29uZmlndXJhdGlvbiA9IFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5p
dF07Ci0gICAgICAgIGNvbmZpZ3VyYXRpb24ucHJlZmVyZW5jZXMuX2Z1bGxTY3JlZW5FbmFibGVk
ID0gWUVTOwotICAgICAgICBjb25maWd1cmF0aW9uLnByZWZlcmVuY2VzLl9kZXZlbG9wZXJFeHRy
YXNFbmFibGVkID0gWUVTOwotICAgICAgICBjb25maWd1cmF0aW9uLnByZWZlcmVuY2VzLl9tZWRp
YURldmljZXNFbmFibGVkID0gWUVTOwotICAgICAgICBjb25maWd1cmF0aW9uLnByZWZlcmVuY2Vz
Ll9tb2NrQ2FwdHVyZURldmljZXNFbmFibGVkID0gWUVTOwogCiAgICAgICAgIF9XS1Byb2Nlc3NQ
b29sQ29uZmlndXJhdGlvbiAqcHJvY2Vzc0NvbmZpZ3VyYXRpb24gPSBbW1tfV0tQcm9jZXNzUG9v
bENvbmZpZ3VyYXRpb24gYWxsb2NdIGluaXRdIGF1dG9yZWxlYXNlXTsKICAgICAgICAgcHJvY2Vz
c0NvbmZpZ3VyYXRpb24uZGlza0NhY2hlU3BlY3VsYXRpdmVWYWxpZGF0aW9uRW5hYmxlZCA9ICFb
U2V0dGluZ3NDb250cm9sbGVyIHNoYXJlZF0ubmV0d29ya0NhY2hlU3BlY3VsYXRpdmVSZXZhbGlk
YXRpb25EaXNhYmxlZDsKQEAgLTExNyw2ICsxMTMsMTIgQEAgLSAodm9pZClhd2FrZUZyb21OaWIK
ICAgICAgICAgICAgICAgICBlbmFibGVkID0gW2ZlYXR1cmUgZGVmYXVsdFZhbHVlXTsKICAgICAg
ICAgICAgIFtjb25maWd1cmF0aW9uLnByZWZlcmVuY2VzIF9zZXRFbmFibGVkOmVuYWJsZWQgZm9y
SW50ZXJuYWxEZWJ1Z0ZlYXR1cmU6ZmVhdHVyZV07CiAgICAgICAgIH0KKworICAgICAgICBjb25m
aWd1cmF0aW9uLnByZWZlcmVuY2VzLl9mdWxsU2NyZWVuRW5hYmxlZCA9IFlFUzsKKyAgICAgICAg
Y29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcy5fZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCA9IFlFUzsK
KyAgICAgICAgY29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcy5fbWVkaWFEZXZpY2VzRW5hYmxlZCA9
IFlFUzsKKyAgICAgICAgY29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcy5fbW9ja0NhcHR1cmVEZXZp
Y2VzRW5hYmxlZCA9IFlFUzsKKyAgICAgICAgY29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcy5fd2Vi
QXV0aGVudGljYXRpb25FbmFibGVkID0gWUVTOwogICAgIH0KIAogICAgIGNvbmZpZ3VyYXRpb24u
c3VwcHJlc3Nlc0luY3JlbWVudGFsUmVuZGVyaW5nID0gW1NldHRpbmdzQ29udHJvbGxlciBzaGFy
ZWRdLmluY3JlbWVudGFsUmVuZGVyaW5nU3VwcHJlc3NlZDsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>378153</attachid>
            <date>2019-09-05 19:46:10 -0700</date>
            <delta_ts>2019-09-06 17:08:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201439-20190905194610.patch</filename>
            <type>text/plain</type>
            <size>3097</size>
            <attacher name="Jiewen Tan">jiewen_tan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiNmU1MDJkZjEwNjU1NmFi
MDYzMDllMjhmNjQ4MWQ5ZjJhOGU3ZGUuLjk3ZDc5YTE3MDU4ZjI0ZWQxZTBjN2E0NzU1Yjg5NDUy
Y2MzY2I5ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDktMDMgIEppZXdlbiBU
YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIE1ha2UgV2Vi
QXV0aG4gZGVmYXVsdCBvZmYgYW5kIGxldCBjbGllbnRzIHR1cm4gaXQgb24gYXQgd2lsbAorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNDM5CisgICAg
ICAgIDxyZGFyOi8vcHJvYmxlbS81NDk5ODE1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIFdlYkF1dGhuIGRlZmF1bHQg
b2ZmIHN1Y2ggdGhhdCBjbGllbnRzIHRoYXQgaGF2ZSB0aGUgcmlnaHQgZW50aXRsZW1lbnRzCisg
ICAgICAgIGNvdWxkIHR1cm4gaXQgb24gYW5kIHdlIGRvbid0IHJpc2sgYXQgdHVybmluZyBvbiBh
IFdlYiBBUEkgdGhhdCBkb2VzIG5vdGhpbmcgYnkgZGVmYXVsdC4KKworICAgICAgICBUaGlzIHBh
dGNoIGRvZXNuJ3QgYWRkIGFueSBTUEkgdG8gdHVybiB0aGUgZmVhdHVyZSBvbiBhcyBpdCBpcyBj
dXJyZW50bHkgZG9hYmxlIHZpYQorICAgICAgICAtIFtXS1ByZWZlcmVuY2VzUHJpdmF0ZSBfc2V0
RW5hYmxlZDpmb3JFeHBlcmltZW50YWxGZWF0dXJlOl0uCisKKyAgICAgICAgKiBTaGFyZWQvV2Vi
UHJlZmVyZW5jZXMueWFtbDoKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0
VmFsdWVzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6ZGVmYXVsdFdlYkF1dGhlbnRpY2F0aW9uRW5h
YmxlZCk6IERlbGV0ZWQuCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZh
bHVlcy5oOgorCiAyMDE5LTA5LTAzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu
Y29tPgogCiAgICAgICAgIE51bGwgZGVyZWYgdW5kZXIgLVtXS1dlYlZpZXcgX2FkZFVwZGF0ZVZp
c2libGVDb250ZW50UmVjdFByZUNvbW1pdEhhbmRsZXJdJ3MgaGFuZGxlciBibG9jawpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9X
ZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKaW5kZXggNzBiMGU0ODhiNzAzY2Y2ZTM0
ZTBlYjhlMzQ1OTJmNmI3YmFjZWNiYS4uYjE5ZGY3YmM2NjljOGI3MzRiOGQ2OWFmODJjZjI5ZWU5
YzhlYTQyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMu
eWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCkBAIC03
NjcsNyArNzY3LDcgQEAgSW5wdXRFdmVudHNFbmFibGVkOgogCiBXZWJBdXRoZW50aWNhdGlvbkVu
YWJsZWQ6CiAgIHR5cGU6IGJvb2wKLSAgZGVmYXVsdFZhbHVlOiBkZWZhdWx0V2ViQXV0aGVudGlj
YXRpb25FbmFibGVkKCkKKyAgZGVmYXVsdFZhbHVlOiBmYWxzZQogICBodW1hblJlYWRhYmxlTmFt
ZTogIldlYiBBdXRoZW50aWNhdGlvbiIKICAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiRW5h
YmxlIFdlYiBBdXRoZW50aWNhdGlvbiBzdXBwb3J0IgogICB3ZWJjb3JlQmluZGluZzogUnVudGlt
ZUVuYWJsZWRGZWF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJl
ZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZl
cmVuY2VzRGVmYXVsdFZhbHVlcy5jcHAKaW5kZXggZmUxNGUzZjkyMjZlZWExOTRkNmJiNDU5YTJi
MWZiMzYxMmJjYzk3Ny4uYWU2NTBhNjY3ODZiYWU3OThiNzA3MWJkZTU0Njg0NTQ0MGYyNDNkYSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFs
dWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRW
YWx1ZXMuY3BwCkBAIC03NywxNSArNzcsNCBAQCBib29sIGRlZmF1bHRUZXh0QXV0b3NpemluZ1Vz
ZXNJZGVtcG90ZW50TW9kZSgpCiAKICNlbmRpZiAvLyBFTkFCTEUoVEVYVF9BVVRPU0laSU5HKSAm
JiAhUExBVEZPUk0oSU9TX0ZBTUlMWSkKIAotYm9vbCBkZWZhdWx0V2ViQXV0aGVudGljYXRpb25F
bmFibGVkKCkKLXsKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKQotICAgIHJldHVybiBXZWJDb3Jl
OjpJT1NBcHBsaWNhdGlvbjo6aXNNb2JpbGVTYWZhcmkoKSB8fCBXZWJDb3JlOjpJT1NBcHBsaWNh
dGlvbjo6aXNTYWZhcmlWaWV3U2VydmljZSgpOwotI2VsaWYgUExBVEZPUk0oTUFDKQotICAgIHJl
dHVybiB0cnVlOwotI2Vsc2UKLSAgICByZXR1cm4gZmFsc2U7Ci0jZW5kaWYKLX0KLQogfSAvLyBu
YW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVm
ZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVu
Y2VzRGVmYXVsdFZhbHVlcy5oCmluZGV4IDAxMWRjNDQ2NTAyZGY4MWUyNTNiN2I5MjMzYWI3YzI1
OGIyZWYyMmQuLjhmYzEzNDU5NTk4NmU5NTAyMmI5ZDMxODc3M2RkZjM0MmU1NjBiMTMgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5o
CisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5o
CkBAIC0yODAsNiArMjgwLDQgQEAgYm9vbCBkZWZhdWx0Q1NTT01WaWV3U2Nyb2xsaW5nQVBJRW5h
YmxlZCgpOwogYm9vbCBkZWZhdWx0VGV4dEF1dG9zaXppbmdVc2VzSWRlbXBvdGVudE1vZGUoKTsK
ICNlbmRpZgogCi1ib29sIGRlZmF1bHRXZWJBdXRoZW50aWNhdGlvbkVuYWJsZWQoKTsKLQogfSAv
LyBuYW1lc3BhY2UgV2ViS2l0Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>