201429 2019-09-03 10:17:09 -0700 REGRESSION (r249338): Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https.html is a flaky failure 2019-09-07 13:25:54 -0700 1 1 1 Unclassified WebKit Service Workers Other Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=201169 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned ap cdumez webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1567420 0 ryanhaddad 2019-09-03 10:17:09 -0700 The following layout test is failing on [insert platform] imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https.html Probable cause: This appears to have started with: "Add support for postMessage buffering between the service worker and window" https://trac.webkit.org/changeset/249338/webkit Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fpostmessage-to-client-message-queue.https.html --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https-actual.txt @@ -2,6 +2,6 @@ PASS Messages from ServiceWorker to Client only received after DOMContentLoaded event. PASS Messages from ServiceWorker to Client only received after calling startMessages(). PASS Messages from ServiceWorker to Client only received after setting onmessage. -PASS Microtasks run before dispatching messages after calling startMessages(). -PASS Microtasks run before dispatching messages after setting onmessage. +FAIL Microtasks run before dispatching messages after calling startMessages(). promise_test: Unhandled rejection with value: object "Error: wait_for_state must be passed a ServiceWorker" +FAIL Microtasks run before dispatching messages after setting onmessage. promise_test: Unhandled rejection with value: object "Error: wait_for_state must be passed a ServiceWorker" 1567421 1 webkit-bug-importer 2019-09-03 10:17:37 -0700 <rdar://problem/54979900> 1567422 2 ryanhaddad 2019-09-03 10:18:35 -0700 (In reply to Ryan Haddad from comment #0) > The following layout test is failing on [insert platform] The test is a flaky failure on macOS Debug WK2, GTK, and WPE. 1567423 3 cdumez 2019-09-03 10:30:56 -0700 (In reply to Ryan Haddad from comment #2) > (In reply to Ryan Haddad from comment #0) > > The following layout test is failing on [insert platform] > > The test is a flaky failure on macOS Debug WK2, GTK, and WPE. Ok, it is the test I unskipped in https://trac.webkit.org/changeset/249338/webkit. I think we should mark it as flaky for now. 1568907 4 ap 2019-09-07 11:54:09 -0700 > I think we should mark it as flaky for now. Is that really the right thing to do? r249338 implemented a feature, and the only test for it is flaky. Typically, we roll back changes like that. 1568914 5 ryanhaddad 2019-09-07 13:06:10 -0700 (In reply to Alexey Proskuryakov from comment #4) > > I think we should mark it as flaky for now. > > Is that really the right thing to do? r249338 implemented a feature, and the > only test for it is flaky. Typically, we roll back changes like that. Yes, I should have rolled this out. I forgot to revisit this bug. 1568916 6 ryanhaddad 2019-09-07 13:21:35 -0700 Rolled out in <https://trac.webkit.org/changeset/249615>. 1568918 7 cdumez 2019-09-07 13:25:54 -0700 (In reply to Ryan Haddad from comment #6) > Rolled out in <https://trac.webkit.org/changeset/249615>. Not sure that could not wait until Monday but ok.