201191 2019-08-27 11:18:44 -0700 Fix applying diffs that only change file mode 2020-03-11 17:12:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198948 201156 1 jdarpinian jdarpinian commit-queue dbates ddkilzer dino ews-watchlist jbedard kbr webkit-bug-importer oldest_to_newest 1565417 0 jdarpinian 2019-08-27 11:18:44 -0700 Fix applying diffs that only change file mode 1565421 1 377356 jdarpinian 2019-08-27 11:19:53 -0700 Created attachment 377356 Patch 1565427 2 jdarpinian 2019-08-27 11:25:54 -0700 See bug 201156 for an example of a patch that fails without this change. 1565486 3 377356 dbates 2019-08-27 13:03:19 -0700 Comment on attachment 377356 Patch I can't remember if we have tests for svn-apply the actually driver program. Can you please check if we do in Tools/Scripts/webkitperl? If we do then please write a test. Otherwise, this change is fine as-is since we tend not to test the driver code - we test the library code. 1565490 4 dbates 2019-08-27 13:06:24 -0700 Thanks for the patch! 1565574 5 jdarpinian 2019-08-27 16:44:03 -0700 Thanks for reviewing! I looked but don't see any tests for the svn-apply driver program itself. 1565616 6 dbates 2019-08-27 19:20:17 -0700 Ok 1565629 7 commit-queue 2019-08-27 20:14:53 -0700 The commit-queue encountered the following flaky tests while processing attachment 377356: fullscreen/full-screen-request-removed-with-raf.html bug 201188 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch. 1565631 8 377356 commit-queue 2019-08-27 20:15:40 -0700 Comment on attachment 377356 Patch Clearing flags on attachment: 377356 Committed r249190: <https://trac.webkit.org/changeset/249190> 1565632 9 commit-queue 2019-08-27 20:15:41 -0700 All reviewed patches have been landed. Closing bug. 1565634 10 webkit-bug-importer 2019-08-27 20:16:23 -0700 <rdar://problem/54775598> 377356 2019-08-27 11:19:53 -0700 2019-08-27 20:15:40 -0700 Patch bug-201191-20190827111952.patch text/plain 1219 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MTI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2Y5YTJkZDFkZWM2ZTgxMjYzNWFmMjMzMjk4NjU0ZDRm MTE2ZGMwNi4uMzIxYTNjZGQ2YzllN2VhMmZhZmRiY2Y0M2YyYjhjY2Y0NDg1MGIwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA4LTI3ICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGdvb2dsZS5jb20+ CisKKyAgICAgICAgRml4IGFwcGx5aW5nIGRpZmZzIHRoYXQgb25seSBjaGFuZ2UgZmlsZSBtb2Rl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDExOTEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvc3ZuLWFwcGx5OgorICAgICAgICAocGF0Y2gpOiBIYW5kbGUgY2FzZSBvZiBmaWxlIG1vZGUg Y2hhbmdlIHdpdGhvdXQgY29udGVudCBjaGFuZ2UKKwogMjAxOS0wOC0yNiAgV2Vuc29uIEhzaWVo ICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgVUlIZWxwZXIuYWN0 aXZhdGVFbGVtZW50QXRIdW1hblNwZWVkCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3N2bi1h cHBseSBiL1Rvb2xzL1NjcmlwdHMvc3ZuLWFwcGx5CmluZGV4IGVjYWU0ZWFkM2Y3NWM3ZjhlMGNk YzcwZTIyYTI0MmY3MGE4Y2ViMjYuLmJiMjY2MDRkMWM2ZTVkYWNhZTJmNDcyNjZhODA3NDU5Yzc2 YmUwMzIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvc3ZuLWFwcGx5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvc3ZuLWFwcGx5CkBAIC0zODIsNyArMzgyLDcgQEAgc3ViIHBhdGNoKCQpCiAgICAgICAg ICAgICBvcGVuKG15ICRGSCwgIj4+IiwgJGZ1bGxQYXRoKSBvciBkaWUgIkNvdWxkIG5vdCBvcGVu IFwiJGZ1bGxQYXRoXCIgZm9yIHdyaXRpbmc6ICQhIjsKICAgICAgICAgICAgIGNsb3NlKCRGSCk7 CiAgICAgICAgICAgICBzY21BZGQoJGZ1bGxQYXRoKTsKLSAgICAgICAgfSBlbHNlIHsKKyAgICAg ICAgfSBlbHNpZiAoIWRlZmluZWQoJGRpZmZIYXNoUmVmLT57ZXhlY3V0YWJsZUJpdERlbHRhfSkp IHsKICAgICAgICAgICAgIGRpZSAiQ2FuJ3QgaGFuZGxlIHBhdGNoIGZvciBcIiRmdWxsUGF0aFwi LiI7CiAgICAgICAgIH0KICAgICB9Cg==