201175 2019-08-27 01:25:12 -0700 Do not clear the pending api request when there's no navigation ID 2019-09-13 03:33:20 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200108 InRadar P2 Normal --- 201176 1 cgarcia webkit-unassigned cdumez commit-queue jiewen_tan mcatanzaro webkit-bug-importer oldest_to_newest 1565289 0 cgarcia 2019-08-27 01:25:12 -0700 I've noticed that after r247851, the pending API request URL is cleared for subresources in some cases. 1565290 1 377327 cgarcia 2019-08-27 01:26:57 -0700 Created attachment 377327 Patch 1565358 2 377327 commit-queue 2019-08-27 09:08:54 -0700 Comment on attachment 377327 Patch Clearing flags on attachment: 377327 Committed r249142: <https://trac.webkit.org/changeset/249142> 1565359 3 commit-queue 2019-08-27 09:08:56 -0700 All reviewed patches have been landed. Closing bug. 1565361 4 webkit-bug-importer 2019-08-27 09:09:22 -0700 <rdar://problem/54749832> 1570019 5 mcatanzaro 2019-09-11 15:38:43 -0700 This caused bug #201544. (In reply to Carlos Garcia Campos from comment #0) > I've noticed that after r247851, the pending API request URL is cleared for > subresources in some cases. What did that break? 1570544 6 cgarcia 2019-09-13 03:33:20 -0700 (In reply to Michael Catanzaro from comment #5) > This caused bug #201544. > > (In reply to Carlos Garcia Campos from comment #0) > > I've noticed that after r247851, the pending API request URL is cleared for > > subresources in some cases. > > What did that break? See bug #200341. The thing is that when a new page starts while the previous one didn't finish, the active URL changes after webkit_kit_web_view_load_uri() and before load-failed because the pending API request URL is reset by a subresoure load of the still ongoing load. So, what happens is that load-failed reports the failing URI correctly, but the active URL is also the failing one, but it should be the new one after webkit_kit_web_view_load_uri(). I'm writing a unit test. 377327 2019-08-27 01:26:57 -0700 2019-08-27 09:08:54 -0700 Patch wk2-clear-pending-api-request-url.diff text/plain 1866 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTYwNTdkOGFmNGYuLjBiNDBjNjEwMDFmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE5LTA4LTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBEbyBub3QgY2xlYXIgdGhlIHBlbmRpbmcgYXBpIHJlcXVlc3Qgd2hl biB0aGVyZSdzIG5vIG5hdmlnYXRpb24gSUQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMTE3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFmdGVyIHIyNDc4NTEsIHRoZSBwZW5kaW5nIEFQSSByZXF1ZXN0 IFVSTCBpcyBjbGVhcmVkIGZvciBzdWJyZXNvdXJjZXMgaW4gc29tZSBjYXNlcy4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdl UHJveHk6OmRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWVTaGFyZWQpOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24pOgor CiAyMDE5LTA4LTI2ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiB1c2UgbW9yZSBDKysga2V5d29yZHMgZm9yIGRlZmluaW5nIGFnZW50 cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggZWZhZTZkZjBk OTQuLjljOTVmMDJmYzg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAKQEAgLTQwMDksNyArNDAwOSw4IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRTdGFydFByb3Zp c2lvbmFsTG9hZEZvckZyYW1lU2hhcmVkKFJlZjxXZWJQcm9jZXNzUHJveHk+JiYKIAogICAgIGF1 dG8gdHJhbnNhY3Rpb24gPSBtX3BhZ2VMb2FkU3RhdGUudHJhbnNhY3Rpb24oKTsKIAotICAgIG1f cGFnZUxvYWRTdGF0ZS5jbGVhclBlbmRpbmdBUElSZXF1ZXN0KHRyYW5zYWN0aW9uKTsKKyAgICBp ZiAobmF2aWdhdGlvbikKKyAgICAgICAgbV9wYWdlTG9hZFN0YXRlLmNsZWFyUGVuZGluZ0FQSVJl cXVlc3QodHJhbnNhY3Rpb24pOwogCiAgICAgaWYgKGZyYW1lLT5pc01haW5GcmFtZSgpKSB7CiAg ICAgICAgIHByb2Nlc3MtPmRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yTWFpbkZyYW1lKHVybCk7 CkBAIC00NjU3LDcgKzQ2NTgsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5Rm9y TmF2aWdhdGlvbkFjdGlvbihSZWY8V2ViUHJvY2Vzc1Byb3h5PiYmIHByb2NlcwogICAgIGF1dG8g dHJhbnNhY3Rpb24gPSBtX3BhZ2VMb2FkU3RhdGUudHJhbnNhY3Rpb24oKTsKIAogICAgIGJvb2wg ZnJvbUFQSSA9IHJlcXVlc3QudXJsKCkgPT0gbV9wYWdlTG9hZFN0YXRlLnBlbmRpbmdBUElSZXF1 ZXN0VVJMKCk7Ci0gICAgaWYgKCFmcm9tQVBJKQorICAgIGlmIChuYXZpZ2F0aW9uSUQgJiYgIWZy b21BUEkpCiAgICAgICAgIG1fcGFnZUxvYWRTdGF0ZS5jbGVhclBlbmRpbmdBUElSZXF1ZXN0KHRy YW5zYWN0aW9uKTsKIAogICAgIGlmICghY2hlY2tVUkxSZWNlaXZlZEZyb21DdXJyZW50T3JQcmV2 aW91c1dlYlByb2Nlc3MocHJvY2VzcywgcmVxdWVzdC51cmwoKSkpIHsK