201154 2019-08-26 15:02:01 -0700 [bmalloc] Disable IsoHeap completely if DebugHeap is enabled 2019-08-26 15:33:24 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201061 InRadar P2 Normal --- 1 ysuzuki ysuzuki ggaren mark.lam simon.fraser webkit-bug-importer oldest_to_newest 1565110 0 ysuzuki 2019-08-26 15:02:01 -0700 When DebugHeap is enabled, we would like to get information about Malloc. In this case, enabling IsoHeap makes Malloc stack logging information broken for IsoHeaped one. This is not what we want. Given that, 1. IsoHeap is currently only used for WebCore and upper 2. Gigacage is also disabled when DebugHeap is enabled 3. The existing code is assuming that IsoHeap should be disabled when DebugHeap is enabled we should disable IsoHeap if DebugHeap is enabled. 1565113 1 ysuzuki 2019-08-26 15:08:12 -0700 We had an assertion that IsoHeap is disabled when Malloc=1 is specified. And it worked because IsoHeap is disabled when Gigacage is disabled, and Gigacage is disabled when Malloc=1 is specified. But from https://bugs.webkit.org/show_bug.cgi?id=201061, IsoHeap can become enabled while Gigacage is disabled. So now, the above invariant is now broken. 1565123 2 377276 ysuzuki 2019-08-26 15:25:20 -0700 Created attachment 377276 Patch 1565125 3 ysuzuki 2019-08-26 15:32:07 -0700 Committed r249121: <https://trac.webkit.org/changeset/249121> 1565126 4 377276 mark.lam 2019-08-26 15:32:14 -0700 Comment on attachment 377276 Patch r=me too. 1565128 5 webkit-bug-importer 2019-08-26 15:33:24 -0700 <rdar://problem/54724969> 377276 2019-08-26 15:25:20 -0700 2019-08-26 15:29:49 -0700 Patch bug-201154-20190826152519.patch text/plain 2751 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMTgxNjEzMjRiMGRmNWNk OTBhZTk2MTRkZTlhNzcwYmM1ZGM2OWQ4Yi4uZjJjZjRlODY3MGIwY2QwOTdmMWI1ZGYxNGRkYmE3 ZTkyNWNiYWM3YSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE5LTA4LTI2ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW2JtYWxsb2NdIERpc2Fi bGUgSXNvSGVhcCBjb21wbGV0ZWx5IGlmIERlYnVnSGVhcCBpcyBlbmFibGVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDExNTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5IHdlIGhhZCB0 aGUgZ3VhcmFudGVlIHRoYXQgSXNvSGVhcCBpcyBkaXNhYmxlZCB3aGVuIERlYnVnSGVhcCBpcyBl bmFibGVkLgorICAgICAgICBCdXQgdGhpcyBpcyBndWFyYW50ZWVkIGluIGEgYml0IHRyaWNreSB3 YXk6IHdoZW4gRGVidWdIZWFwIGlzIGVuYWJsZWQsIEdpZ2FjYWdlIGlzIGRpc2FibGVkLgorICAg ICAgICBBbmQgSXNvSGVhcCBpcyBkaXNhYmxlZCB3aGVuIEdpZ2FjYWdlIGlzIGRpc2FibGVkLiBI b3dldmVyIHIyNDkwNjUgZW5hYmxlZCBJc29IZWFwIGV2ZW4gaWYKKyAgICAgICAgR2lnYWNhZ2Ug aXMgZGlzYWJsZWQuIFRoaXMgYWNjaWRlbnRhbGx5IGVuYWJsZWQgSXNvSGVhcCBldmVuIGlmIERl YnVnSGVhcCBpcyBlbmFibGVkLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhpcyBpcyBpbmNvcnJl Y3QuIFdoZW4gRGVidWdIZWFwIGlzIGVuYWJsZWQsIHdlIGRvIG5vdCBzdGFydCBibWFsbG9jOjpT Y2F2ZW5nZXIuCisgICAgICAgIFNvIElzb0hlYXAgZG9lcyBub3Qgd29yay4gSW4gYWRkaXRpb24s IHdoZW4gRGVidWdIZWFwIGlzIGVuYWJsZWQsIHdlIHdhbnQgdG8gaW52ZXN0aWdhdGUgdGhlIE1h bGxvYyBkYXRhLgorICAgICAgICBIb3dldmVyIElzb0hlYXAgd2lwZXMgdGhlc2UgaW5mb3JtYXRp b24gZm9yIElzb0hlYXBlZCBvYmplY3RzLiBNb3Jlb3ZlciBlbmFibGluZyBJc29IZWFwIGlzIG5v dCBmcmVlCisgICAgICAgIGluIHRlcm1zIG9mIG1lbW9yeSB1c2FnZTogYm1hbGxvYzo6U2NhdmVu Z2VyIHN0YXJ0cyB3b3JraW5nLgorCisgICAgICAgIFNvIHdlIHNob3VsZCBub3QgZW5hYmxlIElz b0hlYXAgaW4gc3VjaCBhbiBhY2NpZGVudGFsIHdheSBmb3IgRGVidWdIZWFwIGVudmlyb25tZW50 LiBJZiB3ZSBjb25zaWRlciBlbmFibGluZworICAgICAgICBJc29IZWFwIGV2ZW4gaWYgYE1hbGxv Yz0xYCBpcyBzcGVjaWZpZWQsIHdlIHNob3VsZCBmaXJzdCBleGFtaW5lIGhvdyBtZW1vcnkgaXMg dXNlZCBieSB0aGlzIGNoYW5nZSBiZWNhdXNlCisgICAgICAgIHRoZSB1c2VycyBvZiBgTWFsbG9j PTFgIHJlcXVpcmVzIGV4cGxpY2l0bHkgdGlnaHQgbWVtb3J5IHVzYWdlLgorCisgICAgICAgIElu IHRoaXMgcGF0Y2gsIHdlIHJlbW92ZSB0aGUgYWNjaWRlbnRhbCBlbmFibGluZyBvZiBJc29IZWFw IGZvciBEZWJ1Z0hlYXAgYnkgY2hlY2tpbmcgRGVidWdIZWFwIHN0YXR1cyBpbiBJc29UTFMuCisK KyAgICAgICAgKiBibWFsbG9jL0lzb1RMUy5jcHA6CisgICAgICAgIChibWFsbG9jOjpJc29UTFM6 OmRldGVybWluZU1hbGxvY0ZhbGxiYWNrU3RhdGUpOgorCiAyMDE5LTA4LTIyICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBVbmRvIGRpc2FibGluZyBvZiBJc29IZWFw cyB3aGVuIEdpZ2FjYWdlIGlzIG9mZi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxs b2MvSXNvVExTLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvSXNvVExTLmNwcAppbmRleCBj ZjZlN2NiZWZlYTNiMGQzYjRiNjgyYjVlZTJjNThkZTYyMTFkZmE2Li4yNmJmYzIzM2E5ODFiZTYw YTU4ZjgzMTZjYjlkM2E4MTQ4YjVlOGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFs bG9jL0lzb1RMUy5jcHAKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29UTFMuY3BwCkBA IC0xODMsNiArMTgzLDExIEBAIHZvaWQgSXNvVExTOjpkZXRlcm1pbmVNYWxsb2NGYWxsYmFja1N0 YXRlKCkKICAgICAgICAgICAgIGlmIChzX21hbGxvY0ZhbGxiYWNrU3RhdGUgIT0gTWFsbG9jRmFs bGJhY2tTdGF0ZTo6VW5kZWNpZGVkKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAg ICAgICAgaWYgKEVudmlyb25tZW50OjpnZXQoKS0+aXNEZWJ1Z0hlYXBFbmFibGVkKCkpIHsKKyAg ICAgICAgICAgICAgICBzX21hbGxvY0ZhbGxiYWNrU3RhdGUgPSBNYWxsb2NGYWxsYmFja1N0YXRl OjpGYWxsQmFja1RvTWFsbG9jOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAg IH0KKwogICAgICAgICAgICAgY29uc3QgY2hhciogZW52ID0gZ2V0ZW52KCJibWFsbG9jX0lzb0hl YXAiKTsKICAgICAgICAgICAgIGlmIChlbnYgJiYgKCFzdHJjYXNlY21wKGVudiwgImZhbHNlIikg fHwgIXN0cmNhc2VjbXAoZW52LCAibm8iKSB8fCAhc3RyY21wKGVudiwgIjAiKSkpCiAgICAgICAg ICAgICAgICAgc19tYWxsb2NGYWxsYmFja1N0YXRlID0gTWFsbG9jRmFsbGJhY2tTdGF0ZTo6RmFs bEJhY2tUb01hbGxvYzsK