<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>201109</bug_id>
          
          <creation_ts>2019-08-23 17:34:05 -0700</creation_ts>
          <short_desc>Add a script to update ANGLE</short_desc>
          <delta_ts>2020-03-11 14:43:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>ANGLE</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>198948</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="James Darpinian">jdarpinian</reporter>
          <assigned_to name="James Darpinian">jdarpinian</assigned_to>
          <cc>achristensen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>graouts</cc>
    
    <cc>kbr</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1564719</commentid>
    <comment_count>0</comment_count>
    <who name="James Darpinian">jdarpinian</who>
    <bug_when>2019-08-23 17:34:05 -0700</bug_when>
    <thetext>Add a script to update ANGLE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1564720</commentid>
    <comment_count>1</comment_count>
      <attachid>377186</attachid>
    <who name="James Darpinian">jdarpinian</who>
    <bug_when>2019-08-23 17:35:57 -0700</bug_when>
    <thetext>Created attachment 377186
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1564722</commentid>
    <comment_count>2</comment_count>
    <who name="James Darpinian">jdarpinian</who>
    <bug_when>2019-08-23 17:37:19 -0700</bug_when>
    <thetext>*** Bug 201013 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1564723</commentid>
    <comment_count>3</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-08-23 17:38:13 -0700</bug_when>
    <thetext>Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1564726</commentid>
    <comment_count>4</comment_count>
    <who name="James Darpinian">jdarpinian</who>
    <bug_when>2019-08-23 17:40:04 -0700</bug_when>
    <thetext>This is no longer moving ANGLE to a different directory, it&apos;s just a single script file now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1564980</commentid>
    <comment_count>5</comment_count>
      <attachid>377186</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-08-26 10:03:34 -0700</bug_when>
    <thetext>Comment on attachment 377186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377186&amp;action=review

&gt; Source/ThirdParty/ANGLE/update-angle.sh:51
&gt; +if ! git am changes.diff; then

This won&apos;t work for anyone using svn, but that&apos;s probably no big deal.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1564997</commentid>
    <comment_count>6</comment_count>
      <attachid>377186</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-26 10:36:35 -0700</bug_when>
    <thetext>Comment on attachment 377186
Patch

Clearing flags on attachment: 377186

Committed r249103: &lt;https://trac.webkit.org/changeset/249103&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1564998</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-26 10:36:36 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565000</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-08-26 10:38:39 -0700</bug_when>
    <thetext>&lt;rdar://problem/54712643&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565002</commentid>
    <comment_count>9</comment_count>
    <who name="James Darpinian">jdarpinian</who>
    <bug_when>2019-08-26 10:41:41 -0700</bug_when>
    <thetext>Thanks! I believe the script should work for svn users as long as they have git installed. The script runs git in a clone of the ANGLE git repo, not the main WebKit repo.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>377186</attachid>
            <date>2019-08-23 17:35:57 -0700</date>
            <delta_ts>2019-08-26 10:36:35 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201109-20190823173556.patch</filename>
            <type>text/plain</type>
            <size>2723</size>
            <attacher name="James Darpinian">jdarpinian</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k
ZXggZDRiNDBjYzIyNGQ3YmUzNTVlYWQ4ZmUwOTYwOGUzNjNiNTVlMTg3Ny4uMDUzZjEwZjgyOGYw
YjU0YTQzNzM2OWZlYzhiMmYzNTJlMmE4MWRlZCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy
dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA4LTIzICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGlu
aWFuQGdvb2dsZS5jb20+CisKKyAgICAgICAgQWRkIGEgc2NyaXB0IHRvIHVwZGF0ZSBBTkdMRQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMTA5CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB1cGRhdGUt
YW5nbGUuc2g6IEFkZGVkLgorCiAyMDE5LTA4LTE2ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFw
cGxlLmNvbT4KIAogICAgICAgICBBZGQgWENCdWlsZCBzdXBwb3J0IHRvIEFOR0xFCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS91cGRhdGUtYW5nbGUuc2ggYi9Tb3VyY2UvVGhp
cmRQYXJ0eS9BTkdMRS91cGRhdGUtYW5nbGUuc2gKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXgg
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjkzZDljMDc1YzU0NTUx
MDdmZWYxMjczNWFlZDYyODJiYTcxZGFjMAotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9UaGly
ZFBhcnR5L0FOR0xFL3VwZGF0ZS1hbmdsZS5zaApAQCAtMCwwICsxLDY4IEBACisjIS9iaW4vYmFz
aAorCitzZXQgLWUKK2NkICIkKGRpcm5hbWUgJHtCQVNIX1NPVVJDRVswXX0pIgorCitBTkdMRV9E
SVI9IiRQV0QiCisKK2VjaG8gIlRoaXMgd2lsbCBjbG9iYmVyIGFueSBjaGFuZ2VzIHlvdSBoYXZl
IG1hZGUgaW46IgorZWNobyAiJEFOR0xFX0RJUiIKK3JlYWQgLXAgIkFyZSB5b3Ugc3VyZT8gW3kv
Tl0gIiAtbiAxIC1yCitlY2hvCitpZiBbWyAhICRSRVBMWSA9fiBeW1l5XSQgXV07IHRoZW4KKyAg
ICBlY2hvICJDYW5jZWxlZC4iCisgICAgZXhpdAorZmkKKworIyBGaXJzdCwgcHJlc2VydmUgV2Vi
S2l0J3MgYWRkaXRpb25hbCBmaWxlcworVEVNUERJUj1gbWt0ZW1wIC1kYAorZnVuY3Rpb24gY2xl
YW51cCB7CisgICAgY3AgLWEgIiRURU1QRElSLy4iICIkQU5HTEVfRElSIgorICAgIHJtIC1yZiAi
JFRFTVBESVIiCit9Cit0cmFwIGNsZWFudXAgRVhJVAorbXYgXAorICAgIEFOR0xFLnBsaXN0IFwK
KyAgICBBTkdMRS54Y29kZXByb2ogXAorICAgIENNYWtlTGlzdHMudHh0IFwKKyAgICBDaGFuZ2VM
b2cgXAorICAgICouY21ha2UgXAorICAgIENvbmZpZ3VyYXRpb25zIFwKKyAgICBNYWtlZmlsZSBc
CisgICAgYWRqdXN0LWFuZ2xlLWluY2x1ZGUtKiBcCisgICAgdXBkYXRlLWFuZ2xlLnNoIFwKKyAg
ICBjaGFuZ2VzLmRpZmYgXAorICAgICIkVEVNUERJUiIKK21rZGlyICIkVEVNUERJUi9pbmNsdWRl
IgorbXYgaW5jbHVkZS9DTWFrZUxpc3RzLnR4dCAiJFRFTVBESVIvaW5jbHVkZSIKKworIyBSZW1v
dmUgYWxsIGZpbGVzIGluY2x1ZGluZyBoaWRkZW4gb25lcywgYnV0IG5vdCAuIG9yIC4uCitybSAt
cmYgLi4/KiAuWyEuXSogKgorZWNobyAiRG93bmxvYWRpbmcgbGF0ZXN0IEFOR0xFIHZpYSBnaXQg
Y2xvbmUuIgorZ2l0IGNsb25lIGh0dHBzOi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9hbmds
ZS9hbmdsZSAuIC0tZGVwdGggMQorZWNobyAiU3VjY2Vzc2Z1bGx5IGRvd25sb2FkZWQgbGF0ZXN0
IEFOR0xFLiIKK2VjaG8gLW4gIkNvbW1pdCBoYXNoOiAiCitnaXQgcmV2LXBhcnNlIEhFQUQKKwor
dHJhcCAtIEVYSVQKK2NsZWFudXAKKworZWNobyAiQXBwbHlpbmcgcGF0Y2ggZnJvbSBjaGFuZ2Vz
LmRpZmYuIgoraWYgISBnaXQgYW0gY2hhbmdlcy5kaWZmOyB0aGVuCisgICAgZWNobyAiRVJST1I6
IFBhdGNoIGZhaWxlZC4iCisgICAgZWNobyAiWW91IG11c3QgcmVzb2x2ZSBhbnkgbWVyZ2UgY29u
ZmxpY3RzLCB0aGVuIHVzZSBcYGdpdCBmb3JtYXQtcGF0Y2ggbWFzdGVyXGAiCisgICAgZWNobyAi
dG8gcmVnZW5lcmF0ZSBjaGFuZ2VzLmRpZmYgc28gdGhhdCBpdCB3aWxsIGFwcGx5IGNsZWFubHkg
bmV4dCB0aW1lLiIKKyAgICBlY2hvICJPbmNlIHlvdSBhcmUgZG9uZSwgYmUgc3VyZSB0byBkZWxl
dGUgdGhlIC5naXQgZGlyZWN0b3J5LiIKKyAgICBGQUlMRURfUEFUQ0g9dHJ1ZQorZWxzZQorICAg
IHJtIC1yZiAuZ2l0CitmaQorCitlY2hvCitlY2hvICJSZXF1aXJlZCBtYW51YWwgc3RlcHM6Igor
aWYgWyAiJEZBSUxFRF9QQVRDSCIgPSB0cnVlIF07IHRoZW4KKyAgICBlY2hvICIgICAgLSBGaW5p
c2ggdGhlIHBhdGNoaW5nIHByb2Nlc3MgYXMgZGVzY3JpYmVkIGFib3ZlLiIKK2ZpCitlY2hvICIg
ICAgLSBVcGRhdGUgdGhlIFhDb2RlIHByb2plY3Qgd2l0aCBhbnkgbmV3IG9yIGRlbGV0ZWQgQU5H
TEUgc291cmNlIGZpbGVzLiIKK2VjaG8gIiAgICAtIFVwZGF0ZSB0aGUgQ01ha2UgZmlsZXMgd2l0
aCBhbnkgbmV3IG9yIGRlbGV0ZWQgQU5HTEUgc291cmNlIGZpbGVzLiIKK2VjaG8gIiAgICAtIFVw
ZGF0ZSBBTkdMRS5wbGlzdCB3aXRoIHRoZSBuZXcgY29tbWl0IGhhc2guIgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>