200991 2019-08-21 12:24:07 -0700 Crash under StringImpl::endsWith() in RegistrationDatabase::openSQLiteDatabase() 2019-08-21 15:17:56 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1563614 0 cdumez 2019-08-21 12:24:07 -0700 Crash under StringImpl::endsWith() in RegistrationDatabase::openSQLiteDatabase(): Thread 7 name: Dispatch queue: ServiceWorker I/O Thread Thread 7 Crashed ↩: 0 JavaScriptCore 0x00000001b6f0a3bc WTF::StringImpl::endsWith(unsigned short) const + 24 (StringImpl.h:1100) 1 JavaScriptCore 0x00000001b6ee6298 WTF::FileSystemImpl::pathByAppendingComponent(WTF::String const&, WTF::String const&) + 52 (WTFString.h:221) 2 WebCore 0x00000001b1823b3c WebCore::RegistrationDatabase::openSQLiteDatabase(WTF::String const&) + 92 (RegistrationDatabase.cpp:93) 3 WebCore 0x00000001b18256a8 WebCore::RegistrationDatabase::doPushChanges(WTF::Vector<WebCore::ServiceWorkerContextData, 0ul, WTF::CrashOnOverflow, 16ul>&&) + 96 (RegistrationDatabase.cpp:311) 4 WebCore 0x00000001b182aa30 WTF::Detail::CallableWrapper<WebCore::RegistrationDatabase::pushChanges(WTF::Vector<WebCore::ServiceWorkerContextData, 0ul, WTF::CrashOnOverflow, 16ul>&&, WTF::CompletionHandler<void ()>&&)::$_23, void>::call() + 32 (RegistrationDatabase.cpp:279) 5 libdispatch.dylib 0x00000001a81ae658 _dispatch_call_block_and_release + 24 (init.c:1408) 6 libdispatch.dylib 0x00000001a81af1cc _dispatch_client_callout + 16 (object.m:495) 7 libdispatch.dylib 0x00000001a815b524 _dispatch_lane_serial_drain$VARIANT$mp + 608 (inline_internal.h:2487) 8 libdispatch.dylib 0x00000001a815bf18 _dispatch_lane_invoke$VARIANT$mp + 420 (queue.c:3820) 9 libdispatch.dylib 0x00000001a8165400 _dispatch_workloop_worker_thread + 588 (queue.c:6380) 10 libsystem_pthread.dylib 0x00000001a81fefa8 _pthread_wqthread + 276 (pthread.c:2323) 11 libsystem_pthread.dylib 0x00000001a8201ae4 start_wqthread + 8 1563615 1 webkit-bug-importer 2019-08-21 12:24:26 -0700 <rdar://problem/54566689> 1563625 2 376905 cdumez 2019-08-21 12:32:35 -0700 Created attachment 376905 Patch 1563682 3 376905 ggaren 2019-08-21 14:15:10 -0700 Comment on attachment 376905 Patch r=me 1563718 4 commit-queue 2019-08-21 15:17:13 -0700 The commit-queue encountered the following flaky tests while processing attachment 376905: media/remote-control-command-seek.html bug 192381 (authors: eric.carlson@apple.com and graouts@apple.com) The commit-queue is continuing to process your patch. 1563720 5 376905 commit-queue 2019-08-21 15:17:55 -0700 Comment on attachment 376905 Patch Clearing flags on attachment: 376905 Committed r248967: <https://trac.webkit.org/changeset/248967> 1563721 6 commit-queue 2019-08-21 15:17:56 -0700 All reviewed patches have been landed. Closing bug. 376905 2019-08-21 12:32:35 -0700 2019-08-21 15:17:55 -0700 Patch bug-200991-20190821123234.patch text/plain 3302 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk5MTMwYTE4MmM3MWFj YTQyMDQxZmYzMWM1YjJlOTY2ZDAwZjg1Ni4uNjBmMzc3ZjBjOGEyYTY5YTJlYTlmOWIwZjViY2Q5 ZjYyMmRhYzVjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA4LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggdW5kZXIgU3RyaW5n SW1wbDo6ZW5kc1dpdGgoKSBpbiBSZWdpc3RyYXRpb25EYXRhYmFzZTo6b3BlblNRTGl0ZURhdGFi YXNlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MDk5MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQ1NjY2ODk+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlIGNhbGwgaXNvbGF0 ZWRDb3B5KCkgb24gUmVnaXN0cmF0aW9uRGF0YWJhc2U6Om1fZGF0YWJhc2VEaXJlY3RvcnkgYmVm b3JlIHVzaW5nCisgICAgICAgIGl0IGZyb20gYmFja2dyb3VuZCB0aHJlYWRzLgorCisgICAgICAg ICogd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZWdpc3RyYXRpb25EYXRhYmFzZTo6b3BlblNRTGl0ZURhdGFiYXNlKToK KyAgICAgICAgKFdlYkNvcmU6OlJlZ2lzdHJhdGlvbkRhdGFiYXNlOjpjbGVhckFsbCk6CisgICAg ICAgICogd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5oOgorICAg ICAgICAoV2ViQ29yZTo6UmVnaXN0cmF0aW9uRGF0YWJhc2U6OmRhdGFiYXNlRGlyZWN0b3J5IGNv bnN0KToKKwogMjAxOS0wOC0yMSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAog ICAgICAgICBbaU9TXSBITFMgc3RyZWFtcyBkaXNhcHBlYXIgZnJvbSBOb3cgUGxheWluZyB3aGVu IHBhdXNlZCBvbiB0aGUgbG9jayBzY3JlZW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvc2VydmljZS9zZXJ2ZXIvUmVnaXN0cmF0aW9uRGF0YWJhc2UuY3BwIGIvU291cmNlL1dl YkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5jcHAKaW5k ZXggOTJjYmEwODVkM2FjZjZhMjkzZjA2YjU1ZGY0NWY0ZGZjNzkzZmJkMy4uNDY0MWMwZGFmZDll NDE4ZWM2OTY3N2Q2MDNiMDRiZWIxODM1OWU0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv d29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5j cHAKQEAgLTEzMCw3ICsxMzAsOCBAQCB2b2lkIFJlZ2lzdHJhdGlvbkRhdGFiYXNlOjpvcGVuU1FM aXRlRGF0YWJhc2UoY29uc3QgU3RyaW5nJiBmdWxsRmlsZW5hbWUpCiAgICAgQVNTRVJUKCFpc01h aW5UaHJlYWQoKSk7CiAgICAgQVNTRVJUKCFtX2RhdGFiYXNlKTsKIAotICAgIGNsZWFuT2xkRGF0 YWJhc2VzKG1fZGF0YWJhc2VEaXJlY3RvcnkpOworICAgIGF1dG8gZGF0YWJhc2VEaXJlY3Rvcnkg PSB0aGlzLT5kYXRhYmFzZURpcmVjdG9yeSgpOworICAgIGNsZWFuT2xkRGF0YWJhc2VzKGRhdGFi YXNlRGlyZWN0b3J5KTsKIAogICAgIExPRyhTZXJ2aWNlV29ya2VyLCAiU2VydmljZVdvcmtlciBS ZWdpc3RyYXRpb25EYXRhYmFzZSBvcGVuaW5nIGZpbGUgJXMiLCBmdWxsRmlsZW5hbWUudXRmOCgp LmRhdGEoKSk7CiAKQEAgLTE1MCw3ICsxNTEsNyBAQCB2b2lkIFJlZ2lzdHJhdGlvbkRhdGFiYXNl OjpvcGVuU1FMaXRlRGF0YWJhc2UoY29uc3QgU3RyaW5nJiBmdWxsRmlsZW5hbWUpCiAgICAgICAg IH0pOwogICAgIH0pOwogCi0gICAgU1FMaXRlRmlsZVN5c3RlbTo6ZW5zdXJlRGF0YWJhc2VEaXJl Y3RvcnlFeGlzdHMobV9kYXRhYmFzZURpcmVjdG9yeSk7CisgICAgU1FMaXRlRmlsZVN5c3RlbTo6 ZW5zdXJlRGF0YWJhc2VEaXJlY3RvcnlFeGlzdHMoZGF0YWJhc2VEaXJlY3RvcnkpOwogCiAgICAg bV9kYXRhYmFzZSA9IG1ha2VVbmlxdWU8U1FMaXRlRGF0YWJhc2U+KCk7CiAgICAgaWYgKCFtX2Rh dGFiYXNlLT5vcGVuKGZ1bGxGaWxlbmFtZSkpIHsKQEAgLTMwOCw3ICszMDksNyBAQCB2b2lkIFJl Z2lzdHJhdGlvbkRhdGFiYXNlOjpjbGVhckFsbChDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYg Y29tcGxldGlvbkhhbmRsZQogICAgICAgICBtX2RhdGFiYXNlID0gbnVsbHB0cjsKIAogICAgICAg ICBTUUxpdGVGaWxlU3lzdGVtOjpkZWxldGVEYXRhYmFzZUZpbGUobV9kYXRhYmFzZUZpbGVQYXRo KTsKLSAgICAgICAgU1FMaXRlRmlsZVN5c3RlbTo6ZGVsZXRlRW1wdHlEYXRhYmFzZURpcmVjdG9y eShtX2RhdGFiYXNlRGlyZWN0b3J5KTsKKyAgICAgICAgU1FMaXRlRmlsZVN5c3RlbTo6ZGVsZXRl RW1wdHlEYXRhYmFzZURpcmVjdG9yeShkYXRhYmFzZURpcmVjdG9yeSgpKTsKIAogICAgICAgICBj YWxsT25NYWluVGhyZWFkKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICAgICB9KTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvUmVnaXN0cmF0 aW9uRGF0YWJhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvUmVn aXN0cmF0aW9uRGF0YWJhc2UuaAppbmRleCA4OTRhZDVjNGMzMTBhMmViNTM2NGIxY2Q4NjZjZTMw NmViYmUyYmMwLi4yYWI0MzhjMjI3NDE1N2M5MzNlY2U3YTYwNjBhOTQ5NTM1ZjY1NTFmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lzdHJhdGlv bkRhdGFiYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9S ZWdpc3RyYXRpb25EYXRhYmFzZS5oCkBAIC01OSw2ICs1OSw4IEBAIHB1YmxpYzoKIAogcHJpdmF0 ZToKICAgICBSZWdpc3RyYXRpb25EYXRhYmFzZShSZWdpc3RyYXRpb25TdG9yZSYsIFN0cmluZyYm IGRhdGFiYXNlRGlyZWN0b3J5KTsKKyAgICAKKyAgICBTdHJpbmcgZGF0YWJhc2VEaXJlY3Rvcnko KSBjb25zdCB7IHJldHVybiBtX2RhdGFiYXNlRGlyZWN0b3J5Lmlzb2xhdGVkQ29weSgpOyB9CiAK ICAgICB2b2lkIHBvc3RUYXNrVG9Xb3JrUXVldWUoRnVuY3Rpb248dm9pZCgpPiYmKTsKIAo=