<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>200815</bug_id>
          
          <creation_ts>2019-08-16 08:18:43 -0700</creation_ts>
          <short_desc>[GTK][WPE] Enable service workers by default</short_desc>
          <delta_ts>2019-10-22 01:51:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>203036</dependson>
          <blocked>174541</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
    
    <cc>thorton</cc>
    
    <cc>wenson_hsieh</cc>
    
    <cc>youennf</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1562037</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-08-16 08:18:43 -0700</bug_when>
    <thetext>Currently service workers is enabled only when building with -DENABLE_EXPERIMENTAL_FEATURES=ON

This feature has been in development since 2 years ago and Safari TP is already shipping it.


Anyone knows about any blocker before enabling this by default?


I will check the test pass-rates on WPT related tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563724</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-08-21 15:20:00 -0700</bug_when>
    <thetext>Running the JS and Ref tests for /service-workers on https://w3c-test.org/tools/runner/index.html gives the following result for the GTK MiniBrowser:

Passed: 1192
Failed:  198
Timeouts: 63
Errors:    2
Not run:  70

So, around 82% of pass-rate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1582036</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-10-21 14:21:25 -0700</bug_when>
    <thetext>Here is another manual test for SW: https://serviceworke.rs/message-relay_demo.html
it works fine</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1582038</commentid>
    <comment_count>3</comment_count>
      <attachid>381450</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2019-10-21 14:25:01 -0700</bug_when>
    <thetext>Created attachment 381450
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1582305</commentid>
    <comment_count>4</comment_count>
      <attachid>381450</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-22 01:51:46 -0700</bug_when>
    <thetext>Comment on attachment 381450
Patch

Clearing flags on attachment: 381450

Committed r251424: &lt;https://trac.webkit.org/changeset/251424&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1582306</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-22 01:51:48 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>381450</attachid>
            <date>2019-10-21 14:25:01 -0700</date>
            <delta_ts>2019-10-22 01:51:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200815-20191021232459.patch</filename>
            <type>text/plain</type>
            <size>3980</size>
            <attacher name="Carlos Alberto Lopez Perez">clopez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU0MWRlMzhjNzA1NmMzYzNh
Nzc3M2I2NzJlYWJhNGM2NmYwNGFkMDcuLjI2YTdiMjc1NTNkMGZlZWNjYjI4ZjljY2YxMjEwNTYw
YmI0ZGQ5OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTAtMjEgIENhcmxvcyBB
bGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b
V1BFXSBFbmFibGUgc2VydmljZSB3b3JrZXJzIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDgxNQorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZsaXAgdGhlIHJ1bi10aW1lIHN3aXRjaCB0
byBiZSBlbmFibGVkIGJ5IGRlZmF1bHQgYW5kIG5vdCBvbmx5CisgICAgICAgIHdoZW4gYnVpbGRp
bmcgd2l0aCBleHBlcmltZW50YWwgZmVhdHVyZXMgZW5hYmxlZC4KKworICAgICAgICAqIFNoYXJl
ZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaDoKKwogMjAxOS0xMC0yMSAgQ2hyaXMgRHVt
ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBtb3JlIHJlbGVhc2UgbG9nZ2lu
ZyBmb3IgIlVuZXhwZWN0ZWRseSByZXN1bWVkIiBhc3NlcnRpb24KZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oIGIvU291cmNlL1dl
YktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmgKaW5kZXggZTRiZDI1OGZl
Njc3OTNmMGFiN2Q5MmI5ZGU0OGEwNDE0MDVkYWM5Mi4uYTIyYzI3Nzc2NzEzMDdkNjExMjZhNTFk
MGIwYTkzZDE2NjYyYmNlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJl
ZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJl
ZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmgKQEAgLTIxMiw3ICsyMTIsNyBAQAogI2RlZmluZSBERUZB
VUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVEIGZhbHNlCiAjZW5kaWYKIAotI2lmIEVO
QUJMRShFWFBFUklNRU5UQUxfRkVBVFVSRVMpIHx8IFBMQVRGT1JNKENPQ09BKQorI2lmIEVOQUJM
RShFWFBFUklNRU5UQUxfRkVBVFVSRVMpIHx8IFBMQVRGT1JNKENPQ09BKSB8fCBQTEFURk9STShH
VEspIHx8IFBMQVRGT1JNKFdQRSkKICNkZWZpbmUgREVGQVVMVF9TRVJWSUNFX1dPUktFUlNfRU5B
QkxFRCB0cnVlCiAjZWxzZQogI2RlZmluZSBERUZBVUxUX1NFUlZJQ0VfV09SS0VSU19FTkFCTEVE
IGZhbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJj
ZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDVjOGJjYzc1YzllNWE4MjBlYWIzOTAwNzI5
ZmQzZjFjZWRiNTQ3Y2UuLjlhNDY4NDExZTRkZWIwNzY2ZjNhODQyMGE1ODAyNjdkOWUxOGQ1ZTUg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9j
bWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNTksNyArMTU5LDcgQEAgV0VCS0lUX09QVElPTl9E
RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FRElBX1NUUkVBTSBQUklWQVRFICR7RU5BQkxFX0VY
UEVSSU1FTlQKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NSFRNTCBQ
UklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01PVVNF
X0NVUlNPUl9TQ0FMRSBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFM
VUUoRU5BQkxFX05FVFdPUktfQ0FDSEVfU1BFQ1VMQVRJVkVfUkVWQUxJREFUSU9OIFBSSVZBVEUg
T04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0VSVklDRV9XT1JL
RVIgUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQorV0VCS0lUX09QVElP
Tl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NFUlZJQ0VfV09SS0VSIFBSSVZBVEUgT04pCiBX
RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0hBUkVBQkxFX1JFU09VUkNF
IFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJf
UlRDIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKIApkaWZmIC0tZ2l0
IGEvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQ
RS5jbWFrZQppbmRleCAxZGE1ZmE3NDk3MGNlMzFlMTE4NDVhMjRjMDVjMTllMzkzODgyYTUyLi4x
M2EzNmZlNjcxYTg2MmFlODNkMmYxZmViNjVmOGY0NmRlY2FjMGMxIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5j
bWFrZQpAQCAtNTMsNyArNTMsNyBAQCBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShF
TkFCTEVfTUVESUFfU1RSRUFNIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVAogV0VCS0lUX09Q
VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01IVE1MIFBSSVZBVEUgT04pCiBXRUJLSVRf
T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSBQUklW
QVRFIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9OT1RJRklD
QVRJT05TIFBSSVZBVEUgT0ZGKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B
QkxFX1NFUlZJQ0VfV09SS0VSIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVT
fSkKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TRVJWSUNFX1dPUktF
UiBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NI
QVJFQUJMRV9SRVNPVVJDRSBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W
QUxVRShFTkFCTEVfU01PT1RIX1NDUk9MTElORyBQUklWQVRFIE9GRikKIFdFQktJVF9PUFRJT05f
REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9UT1VDSF9FVkVOVFMgUFJJVkFURSBPTikKZGlmZiAt
LWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyZjI3ODhlMjVhZjkwNWQ0YWI2MDE1
YmNmZGNlZDljNTQ1MGYzYTg3Li4zZDc3YWUwYTRmODA0YjRlYWQ2ZDJhN2ZmYjE2MzkzYjAzMmI3
NmE2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg
QEAKKzIwMTktMTAtMjEgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxp
YS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBFbmFibGUgc2VydmljZSB3b3JrZXJzIGJ5IGRl
ZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw
MDgxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZs
aXAgdGhlIGJ1aWxkLXRpbWUgc3dpdGNoIHRvIGJlIGVuYWJsZWQgYnkgZGVmYXVsdCBhbmQgbm90
IG9ubHkKKyAgICAgICAgd2hlbiBidWlsZGluZyB3aXRoIGV4cGVyaW1lbnRhbCBmZWF0dXJlcyBl
bmFibGVkLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisgICAg
ICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2U6CisKIDIwMTktMTAtMjEgIEFsaWNp
YSBCb3lhIEdhcmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtNU0VdW0dTdHJl
YW1lcl0gUmV2ZXJ0IFdlYktpdE1lZGlhU3JjIHJld29yayB0ZW1wb3JhcmlseQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>