200723 2019-08-14 10:05:30 -0700 Web Inspector: support `console.screenshot` with detached <canvas> 2019-08-15 12:17:20 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 199309 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1561207 0 hi 2019-08-14 10:05:30 -0700 We already have support for detached <img> and <picture> (r247814), as well as the various canvas rendering contexts, but not <canvas> itself. 1561228 1 376277 hi 2019-08-14 10:25:13 -0700 Created attachment 376277 Patch 1561668 2 376277 joepeck 2019-08-15 12:13:06 -0700 Comment on attachment 376277 Patch r=me 1561674 3 376277 commit-queue 2019-08-15 12:16:11 -0700 Comment on attachment 376277 Patch Clearing flags on attachment: 376277 Committed r248736: <https://trac.webkit.org/changeset/248736> 1561675 4 commit-queue 2019-08-15 12:16:12 -0700 All reviewed patches have been landed. Closing bug. 1561677 5 webkit-bug-importer 2019-08-15 12:17:20 -0700 <rdar://problem/54357533> 376277 2019-08-14 10:25:13 -0700 2019-08-15 12:16:11 -0700 Patch 200723.diff text/plain 7671 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhN2E5ODlkMjk2NS4uNTZkZGQ3ZTA2NzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOS0wOC0xNCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAg V2ViIEluc3BlY3Rvcjogc3VwcG9ydCBgY29uc29sZS5zY3JlZW5zaG90YCB3aXRoIGRldGFjaGVk IDxjYW52YXM+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDA3MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtc2NyZWVuc2hvdC5odG1sOgorICAgICAgICAq IGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtc2NyZWVuc2hvdC1leHBlY3RlZC50eHQ6CisKIDIw MTktMDgtMTMgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBb aVBhZE9TXSBzbGlkZXMuZ29vZ2xlLmNvbTogQ2Fubm90IGRpc21pc3MgdGhlIGNvbnRleHQgbWVu dSBieSB0YXBwaW5nIG9uIHRoZSBjYW52YXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9jb25zb2xlL2NvbnNvbGUtc2NyZWVuc2hvdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXNjcmVlbnNob3QtZXhwZWN0ZWQudHh0CmluZGV4 IDNjMDIwZWE5MTRmLi5iNjM3MzA3YmUyZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL2NvbnNvbGUvY29uc29sZS1zY3JlZW5zaG90LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXNjcmVlbnNob3QtZXhwZWN0ZWQudHh0CkBA IC0yLDYgKzIsNyBAQCBDT05TT0xFIE1FU1NBR0U6IFtvYmplY3QgSFRNTERpdkVsZW1lbnRdCiBD T05TT0xFIE1FU1NBR0U6IFtvYmplY3QgSFRNTERpdkVsZW1lbnRdCiBDT05TT0xFIE1FU1NBR0U6 IFtvYmplY3QgSFRNTEltYWdlRWxlbWVudF0KIENPTlNPTEUgTUVTU0FHRTogW29iamVjdCBIVE1M UGljdHVyZUVsZW1lbnRdCitDT05TT0xFIE1FU1NBR0U6IFtvYmplY3QgSFRNTENhbnZhc0VsZW1l bnRdCiBDT05TT0xFIE1FU1NBR0U6IFtvYmplY3QgSFRNTERpdkVsZW1lbnRdCiBDT05TT0xFIE1F U1NBR0U6IFtvYmplY3QgSW1hZ2VEYXRhXQogQ09OU09MRSBNRVNTQUdFOiBbb2JqZWN0IEltYWdl Qml0bWFwXQpAQCAtMzYsNiArMzcsMTIgQEAgUEFTUzogVGhlIGltYWdlIHNob3VsZCBub3QgYmUg ZW1wdHkuCiBQQVNTOiBUaGUgaW1hZ2Ugd2lkdGggc2hvdWxkIGJlIDJweC4KIFBBU1M6IFRoZSBp bWFnZSBoZWlnaHQgc2hvdWxkIGJlIDJweC4KIAorLS0gUnVubmluZyB0ZXN0IGNhc2U6IGNvbnNv bGUuc2NyZWVuc2hvdC5Ob2RlLkRldGFjaGVkU2NyZWVuc2hvdGFibGUuQ2FudmFzCitQQVNTOiBU aGUgYWRkZWQgbWVzc2FnZSBzaG91bGQgYmUgYW4gaW1hZ2UuCitQQVNTOiBUaGUgaW1hZ2Ugc2hv dWxkIG5vdCBiZSBlbXB0eS4KK1BBU1M6IFRoZSBpbWFnZSB3aWR0aCBzaG91bGQgYmUgMnB4Lgor UEFTUzogVGhlIGltYWdlIGhlaWdodCBzaG91bGQgYmUgMnB4LgorCiAtLSBSdW5uaW5nIHRlc3Qg Y2FzZTogY29uc29sZS5zY3JlZW5zaG90Lk5vZGUuRGV0YWNoZWROb25TY3JlZW5zaG90YWJsZQog UEFTUzogQ291bGQgbm90IGNhcHR1cmUgc2NyZWVuc2hvdAogCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXNjcmVlbnNob3QuaHRtbCBiL0xheW91dFRl c3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtc2NyZWVuc2hvdC5odG1sCmluZGV4IGI1NmIz YzliZGM4Li41NGE3NDgzYjAyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nv bnNvbGUvY29uc29sZS1zY3JlZW5zaG90Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L2NvbnNvbGUvY29uc29sZS1zY3JlZW5zaG90Lmh0bWwKQEAgLTMxLDYgKzMxLDE4IEBAIGZ1bmN0 aW9uIHRlc3RIVE1MUGljdHVyZUVsZW1lbnQoKSB7CiAgICAgfSk7CiB9CiAKK2Z1bmN0aW9uIHRl c3RIVE1MQ2FudmFzRWxlbWVudCgpIHsKKyAgICBsZXQgY2FudmFzID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiY2FudmFzIik7CisgICAgY2FudmFzLndpZHRoID0gMjsKKyAgICBjYW52YXMuaGVp Z2h0ID0gMjsKKworICAgIGxldCBjb250ZXh0ID0gY2FudmFzLmdldENvbnRleHQoIjJkIik7Cisg ICAgY29udGV4dC5maWxsU3R5bGUgPSAicmVkIjsKKyAgICBjb250ZXh0LmZpbGxSZWN0KDAsIDAs IDIsIDIpOworCisgICAgY29uc29sZS5zY3JlZW5zaG90KGNhbnZhcyk7Cit9CisKIGZ1bmN0aW9u IHRlc3RJbWFnZUJpdG1hcCgpIHsKICAgICAvLyAyeDIgcmVkIHNxdWFyZQogICAgIGxldCBpbWFn ZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImltZyIpOwpAQCAtMTMwLDYgKzE0MiwxOCBAQCBm dW5jdGlvbiB0ZXN0KCkKICAgICAgICAgfSwKICAgICB9KTsKIAorICAgIGFkZFRlc3QoeworICAg ICAgICBuYW1lOiAiY29uc29sZS5zY3JlZW5zaG90Lk5vZGUuRGV0YWNoZWRTY3JlZW5zaG90YWJs ZS5DYW52YXMiLAorICAgICAgICBleHByZXNzaW9uOiBgdGVzdEhUTUxDYW52YXNFbGVtZW50KClg LAorICAgICAgICBhc3luYyBpbWFnZU1lc3NhZ2VBZGRlZENhbGxiYWNrKG1lc3NhZ2UpIHsKKyAg ICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0Tm90RXF1YWwobWVzc2FnZS5tZXNzYWdlVGV4 dCwgImRhdGE6IiwgIlRoZSBpbWFnZSBzaG91bGQgbm90IGJlIGVtcHR5LiIpOworCisgICAgICAg ICAgICBsZXQgaW1nID0gYXdhaXQgV0kuSW1hZ2VVdGlsaXRpZXMucHJvbWlzaWZ5TG9hZChtZXNz YWdlLm1lc3NhZ2VUZXh0KTsKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0RXF1YWwo aW1nLndpZHRoLCAyLCAiVGhlIGltYWdlIHdpZHRoIHNob3VsZCBiZSAycHguIik7CisgICAgICAg ICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEVxdWFsKGltZy5oZWlnaHQsIDIsICJUaGUgaW1hZ2Ug aGVpZ2h0IHNob3VsZCBiZSAycHguIik7CisgICAgICAgIH0sCisgICAgfSk7CisKICAgICBhZGRU ZXN0KHsKICAgICAgICAgbmFtZTogImNvbnNvbGUuc2NyZWVuc2hvdC5Ob2RlLkRldGFjaGVkTm9u U2NyZWVuc2hvdGFibGUiLAogICAgICAgICBleHByZXNzaW9uOiBgY29uc29sZS5zY3JlZW5zaG90 KGNyZWF0ZURldGFjaGVkVGVzdCgpKWAsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFkODQxNTNjZDUuLjFmMDhj NTU4ZDg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDgtMTQgIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHN1cHBv cnQgYGNvbnNvbGUuc2NyZWVuc2hvdGAgd2l0aCBkZXRhY2hlZCA8Y2FudmFzPgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzIzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL1BhZ2VDb25zb2xl Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNuYXBzaG90Q2FudmFzKTogQWRkZWQuCisg ICAgICAgIChXZWJDb3JlOjpQYWdlQ29uc29sZUNsaWVudDo6c2NyZWVuc2hvdCk6CisKIDIwMTkt MDgtMTMgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUg V1BFIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlQ29uc29sZUNs aWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VDb25zb2xlQ2xpZW50LmNwcAppbmRl eCBkMDMyZmNmNzBmOC4uN2QwYjgxYThhNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvUGFnZUNvbnNvbGVDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZUNv bnNvbGVDbGllbnQuY3BwCkBAIC0yODAsNiArMjgwLDI2IEBAIHZvaWQgUGFnZUNvbnNvbGVDbGll bnQ6OnJlY29yZEVuZChKU0M6OkV4ZWNTdGF0ZSogc3RhdGUsIFJlZjxTY3JpcHRBcmd1bWVudHM+ JiYKICAgICB9CiB9CiAKK3N0YXRpYyBPcHRpb25hbDxTdHJpbmc+IHNuYXBzaG90Q2FudmFzKEhU TUxDYW52YXNFbGVtZW50JiBjYW52YXNFbGVtZW50LCBDYW52YXNSZW5kZXJpbmdDb250ZXh0JiBj YW52YXNSZW5kZXJpbmdDb250ZXh0KQoreworI2lmIEVOQUJMRShXRUJHTCkKKyAgICBpZiAoaXM8 V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZT4oY2FudmFzUmVuZGVyaW5nQ29udGV4dCkpCisgICAg ICAgIGRvd25jYXN0PFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U+KGNhbnZhc1JlbmRlcmluZ0Nv bnRleHQpLnNldFByZXZlbnRCdWZmZXJDbGVhckZvckluc3BlY3Rvcih0cnVlKTsKKyNlbmRpZgor CisgICAgYXV0byByZXN1bHQgPSBjYW52YXNFbGVtZW50LnRvRGF0YVVSTCgiaW1hZ2UvcG5nIl9z KTsKKworI2lmIEVOQUJMRShXRUJHTCkKKyAgICBpZiAoaXM8V2ViR0xSZW5kZXJpbmdDb250ZXh0 QmFzZT4oY2FudmFzUmVuZGVyaW5nQ29udGV4dCkpCisgICAgICAgIGRvd25jYXN0PFdlYkdMUmVu ZGVyaW5nQ29udGV4dEJhc2U+KGNhbnZhc1JlbmRlcmluZ0NvbnRleHQpLnNldFByZXZlbnRCdWZm ZXJDbGVhckZvckluc3BlY3RvcihmYWxzZSk7CisjZW5kaWYKKworICAgIGlmICghcmVzdWx0Lmhh c0V4Y2VwdGlvbigpKQorICAgICAgICByZXR1cm4gcmVzdWx0LnJlbGVhc2VSZXR1cm5WYWx1ZSgp LnN0cmluZzsKKworICAgIHJldHVybiBXVEY6Om51bGxvcHQ7Cit9CisKIHZvaWQgUGFnZUNvbnNv bGVDbGllbnQ6OnNjcmVlbnNob3QoSlNDOjpFeGVjU3RhdGUqIHN0YXRlLCBSZWY8U2NyaXB0QXJn dW1lbnRzPiYmIGFyZ3VtZW50cykKIHsKICAgICBTdHJpbmcgZGF0YVVSTDsKQEAgLTMyMCwxMyAr MzQwLDIyIEBAIHZvaWQgUGFnZUNvbnNvbGVDbGllbnQ6OnNjcmVlbnNob3QoSlNDOjpFeGVjU3Rh dGUqIHN0YXRlLCBSZWY8U2NyaXB0QXJndW1lbnRzPiYmCiAgICAgICAgICAgICAgICAgICAgICAg ICB2aWRlb0VsZW1lbnQucGFpbnRDdXJyZW50RnJhbWVJbkNvbnRleHQoc25hcHNob3QtPmNvbnRl eHQoKSwgRmxvYXRSZWN0KDAsIDAsIHZpZGVvV2lkdGgsIHZpZGVvSGVpZ2h0KSk7CiAgICAgICAg ICAgICAgICAgICAgIH0KICNlbmRpZgorICAgICAgICAgICAgICAgICAgICBlbHNlIGlmIChpczxI VE1MQ2FudmFzRWxlbWVudD4obm9kZSkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGF1dG8m IGNhbnZhc0VsZW1lbnQgPSBkb3duY2FzdDxIVE1MQ2FudmFzRWxlbWVudD4oKm5vZGUpOworICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKGF1dG8qIGNhbnZhc1JlbmRlcmluZ0NvbnRleHQgPSBj YW52YXNFbGVtZW50LnJlbmRlcmluZ0NvbnRleHQoKSkgeworICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGlmIChhdXRvIHJlc3VsdCA9IHNuYXBzaG90Q2FudmFzKGNhbnZhc0VsZW1lbnQsICpj YW52YXNSZW5kZXJpbmdDb250ZXh0KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZGF0YVVSTCA9IHJlc3VsdC52YWx1ZSgpOworICAgICAgICAgICAgICAgICAgICAgICAgfQorICAg ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAg aWYgKCFzbmFwc2hvdCkKLSAgICAgICAgICAgICAgICAgICAgc25hcHNob3QgPSBXZWJDb3JlOjpz bmFwc2hvdE5vZGUobV9wYWdlLm1haW5GcmFtZSgpLCAqbm9kZSk7CisgICAgICAgICAgICAgICAg aWYgKGRhdGFVUkwuaXNFbXB0eSgpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmICghc25hcHNo b3QpCisgICAgICAgICAgICAgICAgICAgICAgICBzbmFwc2hvdCA9IFdlYkNvcmU6OnNuYXBzaG90 Tm9kZShtX3BhZ2UubWFpbkZyYW1lKCksICpub2RlKTsKIAotICAgICAgICAgICAgICAgIGlmIChz bmFwc2hvdCkKLSAgICAgICAgICAgICAgICAgICAgZGF0YVVSTCA9IHNuYXBzaG90LT50b0RhdGFV UkwoImltYWdlL3BuZyJfcywgV1RGOjpudWxsb3B0LCBQcmVzZXJ2ZVJlc29sdXRpb246Olllcyk7 CisgICAgICAgICAgICAgICAgICAgIGlmIChzbmFwc2hvdCkKKyAgICAgICAgICAgICAgICAgICAg ICAgIGRhdGFVUkwgPSBzbmFwc2hvdC0+dG9EYXRhVVJMKCJpbWFnZS9wbmciX3MsIFdURjo6bnVs bG9wdCwgUHJlc2VydmVSZXNvbHV0aW9uOjpZZXMpOworICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIH0KICAgICAgICAgfSBlbHNlIGlmIChhdXRvKiBpbWFnZURhdGEgPSBKU0ltYWdlRGF0 YTo6dG9XcmFwcGVkKHN0YXRlLT52bSgpLCBwb3NzaWJsZVRhcmdldCkpIHsKICAgICAgICAgICAg IHRhcmdldCA9IHBvc3NpYmxlVGFyZ2V0OwpAQCAtMzQ5LDIwICszNzgsOCBAQCB2b2lkIFBhZ2VD b25zb2xlQ2xpZW50OjpzY3JlZW5zaG90KEpTQzo6RXhlY1N0YXRlKiBzdGF0ZSwgUmVmPFNjcmlw dEFyZ3VtZW50cz4mJgogICAgICAgICAgICAgaWYgKGlzPEhUTUxDYW52YXNFbGVtZW50PihjYW52 YXMpKSB7CiAgICAgICAgICAgICAgICAgdGFyZ2V0ID0gcG9zc2libGVUYXJnZXQ7CiAgICAgICAg ICAgICAgICAgaWYgKFVOTElLRUxZKEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6aGFzRnJvbnRl bmRzKCkpKSB7Ci0jaWYgRU5BQkxFKFdFQkdMKQotICAgICAgICAgICAgICAgICAgICBpZiAoaXM8 V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZT4oY29udGV4dCkpCi0gICAgICAgICAgICAgICAgICAg ICAgICBkb3duY2FzdDxXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlPihjb250ZXh0KS0+c2V0UHJl dmVudEJ1ZmZlckNsZWFyRm9ySW5zcGVjdG9yKHRydWUpOwotI2VuZGlmCi0KLSAgICAgICAgICAg ICAgICAgICAgYXV0byByZXN1bHQgPSBkb3duY2FzdDxIVE1MQ2FudmFzRWxlbWVudD4oY2FudmFz KS50b0RhdGFVUkwoImltYWdlL3BuZyJfcyk7Ci0KLSNpZiBFTkFCTEUoV0VCR0wpCi0gICAgICAg ICAgICAgICAgICAgIGlmIChpczxXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlPihjb250ZXh0KSkK LSAgICAgICAgICAgICAgICAgICAgICAgIGRvd25jYXN0PFdlYkdMUmVuZGVyaW5nQ29udGV4dEJh c2U+KGNvbnRleHQpLT5zZXRQcmV2ZW50QnVmZmVyQ2xlYXJGb3JJbnNwZWN0b3IoZmFsc2UpOwot I2VuZGlmCi0KLSAgICAgICAgICAgICAgICAgICAgaWYgKCFyZXN1bHQuaGFzRXhjZXB0aW9uKCkp Ci0gICAgICAgICAgICAgICAgICAgICAgICBkYXRhVVJMID0gcmVzdWx0LnJlbGVhc2VSZXR1cm5W YWx1ZSgpLnN0cmluZzsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGF1dG8gcmVzdWx0ID0gc25h cHNob3RDYW52YXMoZG93bmNhc3Q8SFRNTENhbnZhc0VsZW1lbnQ+KGNhbnZhcyksICpjb250ZXh0 KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGRhdGFVUkwgPSByZXN1bHQudmFsdWUoKTsKICAg ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAK