200534 2019-08-08 06:16:40 -0700 [GTK] Several tests crashing after r247898 "Reorganize UIScriptController into platform-specific subclasses" 2019-12-13 02:54:41 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204112 https://bugs.webkit.org/show_bug.cgi?id=205109 https://bugs.webkit.org/show_bug.cgi?id=205159 P2 Normal --- 1 magomez webkit-unassigned alex bugs-noreply cgarcia oldest_to_newest 1559482 0 magomez 2019-08-08 06:16:40 -0700 compositing/backing/backing-store-attachment-scroll.html [ Crash ] compositing/iframes/remove-reinsert-webview-with-iframe.html [ Crash ] compositing/tiling/tile-coverage-on-scroll.html [ Crash ] compositing/tiling/tiled-mask-inwindow.html [ Crash ] compositing/tiling/tiled-reflection-inwindow.html [ Crash ] editing/input/delete-text-in-composition.html [ Crash ] editing/secure-input/password-input-changed-type.html [ Crash ] editing/secure-input/password-input-focusing.html [ Crash ] editing/secure-input/removed-password-input.html [ Crash ] editing/secure-input/reset-state-on-navigation.html [ Crash ] fast/events/autoscroll-when-input-is-offscreen.html [ Crash ] fast/events/autoscroll-with-software-keyboard.html [ Crash ] fast/media/mq-prefers-reduced-motion-matchMedia.html [ Crash ] fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html [ Crash ] fast/visual-viewport/client-rects-relative-to-layout-viewport.html [ Crash ] http/tests/inspector/network/ping-type.html [ Crash ] http/tests/navigation/ping-attribute/anchor-cookie.html [ Crash ] http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html [ Crash ] http/tests/navigation/ping-attribute/anchor-cross-origin.html [ Crash ] http/tests/navigation/ping-attribute/anchor-ping-and-follow-redirect-when-sending-ping.html [ Crash ] http/tests/navigation/ping-attribute/area-cookie.html [ Crash ] http/tests/navigation/ping-attribute/area-cross-origin-from-https.html [ Crash ] http/tests/navigation/ping-attribute/area-cross-origin.html [ Crash ] http/tests/navigation/ping-attribute/area-same-origin.html [ Crash ] pageoverlay/overlay-remove-reinsert-view.html [ Crash ] All of these tests are crashing in calls to ScriptController, with a backtrace similar to this (see all of the backtraces at https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r248403%20(11158)/results.html) #0 0x00007f7f8f135dde in WTFCrash () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #1 0x000055641999bab9 in _ZN3WTR18UIScriptController11doAsyncTaskEPK13OpaqueJSValue () #2 0x000055641999ebd5 in _ZN3WTR20JSUIScriptController25doAfterPresentationUpdateEPK15OpaqueJSContextP13OpaqueJSValueS5_mPKPKS4_PS7_ () #3 0x00007f7f8e4d7c20 in _ZN3JSC19APICallbackFunction4callINS_18JSCallbackFunctionEEElPNS_9ExecStateE () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #4 0x00007f7ee7fff027 in ?? () #5 0x00007ffffc19acd0 in ?? () #6 0x00007f7f8ec6f761 in llint_op_call () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #7 0x0000000000000000 in ?? () 1559483 1 magomez 2019-08-08 06:20:06 -0700 Reading the description of the changelog, the crash may mean that we are missing some functionality that is not implemented in the subclasses, but JSC is not my field. 1559523 2 thorton 2019-08-08 09:03:03 -0700 (In reply to Miguel Gomez from comment #1) > Reading the description of the changelog, the crash may mean that we are > missing some functionality that is not implemented in the subclasses, but > JSC is not my field. Yes, 100%. Probably there are a few low effort things to implement that get you 90% and the rest you should just skip. If you have backtraces for all the crashes I can help figure which are which. 1559525 3 thorton 2019-08-08 09:04:12 -0700 “doAsyncTask” is one low effort one for example, and that’s your example BT. See the Mac implementation for example. 1579029 4 magomez 2019-10-11 01:43:05 -0700 We have this one crashing on the WPE bot as well fast/events/focus-anchor-with-tabindex-hang.html 1597578 5 magomez 2019-12-11 05:02:43 -0800 Another test failing because of the missing doAsyncTask method: editing/pasteboard/paste-and-sanitize.html [ Crash ] 1597582 6 magomez 2019-12-11 05:17:29 -0800 Two more fast/forms/contenteditable-font-optical-size.html [ Crash ] legacy-animation-engine/compositing/transitions/add-remove-transition.html [ Crash ] 1597585 7 magomez 2019-12-11 05:26:31 -0800 There are several bugs that handle tests crashing because we lack an implementation for some UIScriptController. This one mentions doAsyncTask, but there are also copyText (bug 204112) and setContinuousSpellCheckingEnabled (bug 205109). As there are even more methods failing, I'm going to move all the bugs to this one, to keep track of the whole issue: From bug 204112 we lack copyText, and these tests crash: editing/async-clipboard/clipboard-change-data-while-getting-type.html editing/async-clipboard/clipboard-change-data-while-reading.html editing/async-clipboard/clipboard-get-type-with-old-items.html from bug 205109 we lack setContinuousSpellCheckingEnabled, and this test crashes: editing/spelling/toggle-spellchecking.html 1597589 8 magomez 2019-12-11 05:37:00 -0800 This one fails because we lack activateDataListSuggestion fast/forms/datalist/datalist-click-crash.html [ Crash ] This one because we lack simulateAccessibilitySettingsChangeNotification fast/media/mq-inverted-colors.html [ Crash ] This one crashes because we lack removeViewFromWindow media/no-fullscreen-when-hidden.html [ Crash ] 1597983 9 cgarcia 2019-12-12 06:54:48 -0800 Making this GTK only for now, because WPE doesn't even have a UIScriptController impl yet. I'll submit a new bug to add UIScriptController for WPE. 1597984 10 385492 cgarcia 2019-12-12 07:04:04 -0800 Created attachment 385492 Patch 1598295 11 385492 alex 2019-12-13 02:47:53 -0800 Comment on attachment 385492 Patch Great stuff! LGTM. Let's add the same to WPE later. 1598296 12 cgarcia 2019-12-13 02:54:41 -0800 Committed r253467: <https://trac.webkit.org/changeset/253467> 385492 2019-12-12 07:04:04 -0800 2019-12-13 02:47:53 -0800 Patch wtr-ui-script-missing-impl.diff text/plain 11395 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MGM4NDQwNDBiNS4uYTI0YTM0ZmY0YTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxOS0xMi0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gU2V2ZXJhbCB0ZXN0cyBjcmFzaGluZyBhZnRlciByMjQ3ODk4ICJSZW9y Z2FuaXplIFVJU2NyaXB0Q29udHJvbGxlciBpbnRvIHBsYXRmb3JtLXNwZWNpZmljIHN1YmNsYXNz ZXMiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA1 MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRh dGUgZXhwZWN0YXRpb25zLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlv bnM6CisKIDIwMTktMTItMTIgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZyBmb3IgV2luQ2Fpcm8KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZmI5YjUxM2Q1Y2Iu LmU0ZDNkMmMzM2VlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cwpAQCAtMTA3OSw2ICsxMDc5LDExIEBAIHdlYmtpdC5vcmcvYi8xNzc2MzMgaHR0cC90ZXN0cy9z ZWN1cml0eS9jbGlwYm9hcmQvY29weS1wYXN0ZS1odG1sLWFjcm9zcy1vcmlnaW4tCiB3ZWJraXQu b3JnL2IvMTc3NjMzIGVkaXRpbmcvcGFzdGVib2FyZC9jb3B5LXBhc3RlLWFjcm9zcy1zaGFkb3ct Ym91bmRhcmllcy13aXRoLXN0eWxlLTIuaHRtbCBbIENyYXNoIF0KIHdlYmtpdC5vcmcvYi8xNzc2 MzMgZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLXRleHQtd2l0aC1zdHlsZS5odG1sIFsgRmFpbHVy ZSBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xNzc2MzMgZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLXdp dGhvdXQtbmVzdGluZy5odG1sIFsgRmFpbHVyZSBQYXNzIF0KK3dlYmtpdC5vcmcvYi8xNzc2MzMg ZWRpdGluZy9hc3luYy1jbGlwYm9hcmQvY2xpcGJvYXJkLWNoYW5nZS1kYXRhLXdoaWxlLXdyaXRp bmcuaHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzE3NzYzMyBlZGl0aW5nL2FzeW5jLWNs aXBib2FyZC9jbGlwYm9hcmQtcmVhZC10ZXh0LWZyb20tcGxhdGZvcm0uaHRtbCBbIEZhaWx1cmUg XQord2Via2l0Lm9yZy9iLzE3NzYzMyBlZGl0aW5nL2FzeW5jLWNsaXBib2FyZC9jbGlwYm9hcmQt Y2hhbmdlLWRhdGEtd2hpbGUtZ2V0dGluZy10eXBlLmh0bWwgWyBUaW1lb3V0IF0KK3dlYmtpdC5v cmcvYi8xNzc2MzMgZWRpdGluZy9hc3luYy1jbGlwYm9hcmQvY2xpcGJvYXJkLWNoYW5nZS1kYXRh LXdoaWxlLXJlYWRpbmcuaHRtbCBbIFRpbWVvdXQgXQord2Via2l0Lm9yZy9iLzE3NzYzMyBlZGl0 aW5nL2FzeW5jLWNsaXBib2FyZC9jbGlwYm9hcmQtZ2V0LXR5cGUtd2l0aC1vbGQtaXRlbXMuaHRt bCBbIFRpbWVvdXQgXQogd2Via2l0Lm9yZy9iLzE3NzYzMyBlZGl0aW5nL2FzeW5jLWNsaXBib2Fy ZC9jbGlwYm9hcmQtcmVhZC1iYXNpYy5odG1sIFsgVGltZW91dCBdCiB3ZWJraXQub3JnL2IvMTc3 NjMzIGVkaXRpbmcvYXN5bmMtY2xpcGJvYXJkL2NsaXBib2FyZC1yZWFkLXRleHQtc2FtZS1vcmln aW4uaHRtbCBbIFRpbWVvdXQgXQogd2Via2l0Lm9yZy9iLzE3NzYzMyBlZGl0aW5nL2FzeW5jLWNs aXBib2FyZC9jbGlwYm9hcmQtd3JpdGUtYmFzaWMuaHRtbCBbIFRpbWVvdXQgXQpAQCAtMTI3MCwy NiArMTI3NSw2IEBAIHdlYmtpdC5vcmcvYi8xOTkwMTQgZmFzdC9jYW52YXMvd2ViZ2wvdGV4LWlt YWdlLWFuZC1zdWItaW1hZ2UtMmQtd2l0aC12aWRlby1yZ2JhCiAKIHdlYmtpdC5vcmcvYi8xOTk0 NDAgZmFzdC9tZWRpYXN0cmVhbS9tZWRpYXN0cmVhbXRyYWNrLXZpZGVvLWNsb25lLmh0bWwgWyBG YWlsdXJlIFRpbWVvdXQgQ3Jhc2ggXQogCi0jIFVJU2NyaXB0Q29udHJvbGxlciBtaXNzaW5nIGlt cGxlbWVudGF0aW9ucwotd2Via2l0Lm9yZy9iLzIwMDUzNCBlZGl0aW5nL2lucHV0L2RlbGV0ZS10 ZXh0LWluLWNvbXBvc2l0aW9uLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMjAwNTM0IGVk aXRpbmcvc2VjdXJlLWlucHV0L3Bhc3N3b3JkLWlucHV0LWNoYW5nZWQtdHlwZS5odG1sIFsgQ3Jh c2ggXQotd2Via2l0Lm9yZy9iLzIwMDUzNCBlZGl0aW5nL3NlY3VyZS1pbnB1dC9wYXNzd29yZC1p bnB1dC1mb2N1c2luZy5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIwMDUzNCBlZGl0aW5n L3NlY3VyZS1pbnB1dC9yZW1vdmVkLXBhc3N3b3JkLWlucHV0Lmh0bWwgWyBDcmFzaCBdCi13ZWJr aXQub3JnL2IvMjAwNTM0IGVkaXRpbmcvc2VjdXJlLWlucHV0L3Jlc2V0LXN0YXRlLW9uLW5hdmln YXRpb24uaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMDA1MzQgZmFzdC9tZWRpYS9tcS1w cmVmZXJzLXJlZHVjZWQtbW90aW9uLW1hdGNoTWVkaWEuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5v cmcvYi8yMDA1MzQgZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLWFuZC1zYW5pdGl6ZS5odG1sIFsg Q3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIwMDUzNCBmYXN0L2Zvcm1zL2NvbnRlbnRlZGl0YWJsZS1m b250LW9wdGljYWwtc2l6ZS5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIwMDUzNCBsZWdh Y3ktYW5pbWF0aW9uLWVuZ2luZS9jb21wb3NpdGluZy90cmFuc2l0aW9ucy9hZGQtcmVtb3ZlLXRy YW5zaXRpb24uaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMDA1MzQgZWRpdGluZy9hc3lu Yy1jbGlwYm9hcmQvY2xpcGJvYXJkLWNoYW5nZS1kYXRhLXdoaWxlLWdldHRpbmctdHlwZS5odG1s IFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIwMDUzNCBlZGl0aW5nL2FzeW5jLWNsaXBib2FyZC9j bGlwYm9hcmQtY2hhbmdlLWRhdGEtd2hpbGUtcmVhZGluZy5odG1sIFsgQ3Jhc2ggXQotd2Via2l0 Lm9yZy9iLzIwMDUzNCBlZGl0aW5nL2FzeW5jLWNsaXBib2FyZC9jbGlwYm9hcmQtZ2V0LXR5cGUt d2l0aC1vbGQtaXRlbXMuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMDA1MzQgZWRpdGlu Zy9hc3luYy1jbGlwYm9hcmQvY2xpcGJvYXJkLXJlYWQtdGV4dC1mcm9tLXBsYXRmb3JtLmh0bWwg WyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMjAwNTM0IGVkaXRpbmcvYXN5bmMtY2xpcGJvYXJkL2Ns aXBib2FyZC1kby1ub3QtcmVhZC10ZXh0LWZyb20tcGxhdGZvcm0taWYtdGV4dC1jaGFuZ2VzLmh0 bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMjAwNTM0IGVkaXRpbmcvYXN5bmMtY2xpcGJvYXJk L2NsaXBib2FyZC1jaGFuZ2UtZGF0YS13aGlsZS13cml0aW5nLmh0bWwgWyBDcmFzaCBdCi13ZWJr aXQub3JnL2IvMjAwNTM0IGVkaXRpbmcvc3BlbGxpbmcvdG9nZ2xlLXNwZWxsY2hlY2tpbmcuaHRt bCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMDA1MzQgZmFzdC9mb3Jtcy9kYXRhbGlzdC9kYXRh bGlzdC1jbGljay1jcmFzaC5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIwMDUzNCBmYXN0 L21lZGlhL21xLWludmVydGVkLWNvbG9ycy5odG1sIFsgQ3Jhc2ggXQotCiB3ZWJraXQub3JnL2Iv MjAxMjc1IGZhc3QvZXZlbnRzL2ZvY3VzLWFuY2hvci13aXRoLXRhYmluZGV4LWhhbmcuaHRtbCBb IENyYXNoIF0KIAogIyBLbm93biBpc3N1ZXMgdGhhdCB3ZXJlIGZpeGVkIGJ5IHRoZSBXZWJLaXRN ZWRpYVNyYyByZXdvcmsgdGhhdCBpcyBub3cgcmV2ZXJ0ZWQuCmRpZmYgLS1naXQgYS9Ub29scy9D aGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDFmNWIyZjE3NTguLjFhZjM5NWQzMzRh IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjkgQEAKKzIwMTktMTItMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFNldmVyYWwgdGVzdHMgY3Jhc2hpbmcgYWZ0ZXIg cjI0Nzg5OCAiUmVvcmdhbml6ZSBVSVNjcmlwdENvbnRyb2xsZXIgaW50byBwbGF0Zm9ybS1zcGVj aWZpYyBzdWJjbGFzc2VzIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAwNTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIGltcGxlbWVudGF0aW9uIG9mIHNldmVyYWwgVUlTY3JpcHRDb250cm9sbGVy IHZpcnR1YWwgbWV0aG9kcyB0byBhdm9pZCBjcmFzaGVzLgorCisgICAgICAgICogV2ViS2l0VGVz dFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcDoKKyAgICAgICAgKFdUUjo6UGxhdGZv cm1XZWJWaWV3Ojp+UGxhdGZvcm1XZWJWaWV3KToKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJW aWV3OjphZGRUb1dpbmRvdyk6CisgICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmlldzo6cmVtb3Zl RnJvbVdpbmRvdyk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9ndGsvVUlTY3JpcHRDb250 cm9sbGVyR3RrLmNwcDoKKyAgICAgICAgKFdUUjo6VUlTY3JpcHRDb250cm9sbGVyR3RrOjpkb0Fz eW5jVGFzayk6CisgICAgICAgIChXVFI6OlVJU2NyaXB0Q29udHJvbGxlckd0azo6c2V0Q29udGlu dW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKToKKyAgICAgICAgKFdUUjo6VUlTY3JpcHRDb250cm9s bGVyR3RrOjpjb3B5VGV4dCk6CisgICAgICAgIChXVFI6OlVJU2NyaXB0Q29udHJvbGxlckd0azo6 ZGlzbWlzc01lbnUpOgorICAgICAgICAoV1RSOjpVSVNjcmlwdENvbnRyb2xsZXJHdGs6OmlzU2hv d2luZ01lbnUgY29uc3QpOgorICAgICAgICAoV1RSOjpVSVNjcmlwdENvbnRyb2xsZXJHdGs6OmFj dGl2YXRlQXRQb2ludCk6CisgICAgICAgIChXVFI6OlVJU2NyaXB0Q29udHJvbGxlckd0azo6YWN0 aXZhdGVEYXRhTGlzdFN1Z2dlc3Rpb24pOgorICAgICAgICAoV1RSOjpVSVNjcmlwdENvbnRyb2xs ZXJHdGs6OnNpbXVsYXRlQWNjZXNzaWJpbGl0eVNldHRpbmdzQ2hhbmdlTm90aWZpY2F0aW9uKToK KyAgICAgICAgKFdUUjo6VUlTY3JpcHRDb250cm9sbGVyR3RrOjpyZW1vdmVWaWV3RnJvbVdpbmRv dyk6CisgICAgICAgIChXVFI6OlVJU2NyaXB0Q29udHJvbGxlckd0azo6YWRkVmlld1RvV2luZG93 KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2d0ay9VSVNjcmlwdENvbnRyb2xsZXJHdGsu aDoKKwogMjAxOS0xMi0xMSAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAK ICAgICAgICAgUHl0aG9uIDM6IFN1cHBvcnQgc2VyaWFsIFNlcnZlclByb2Nlc3MgdGVzdHMKZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5j cHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9QbGF0Zm9ybVdlYlZpZXdHdGsuY3BwCmlu ZGV4IGQ0YTI2MjkxOGYyLi41YWVjMTExYThhNCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL2d0ay9QbGF0Zm9ybVdlYlZpZXdHdGsuY3BwCkBAIC01Niw2ICs1Niw5IEBAIFBsYXRm b3JtV2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KFdLUGFnZUNvbmZpZ3VyYXRpb25SZWYgY29uZmln dXJhdGlvbiwgY29uc3QgVGVzCiAKIFBsYXRmb3JtV2ViVmlldzo6flBsYXRmb3JtV2ViVmlldygp CiB7CisgICAgaWYgKGd0a19iaW5fZ2V0X2NoaWxkKEdUS19CSU4obV93aW5kb3cpKSAhPSBHVEtf V0lER0VUKG1fdmlldykpCisgICAgICAgIGdfb2JqZWN0X3VucmVmKEdUS19XSURHRVQobV92aWV3 KSk7CisKICAgICBndGtfd2lkZ2V0X2Rlc3Ryb3kobV93aW5kb3cpOwogICAgIGlmIChtX290aGVy V2luZG93KQogICAgICAgICBndGtfd2lkZ2V0X2Rlc3Ryb3kobV9vdGhlcldpbmRvdyk7CkBAIC0x MzksMTAgKzE0MiwxOSBAQCB2b2lkIFBsYXRmb3JtV2ViVmlldzo6cmVtb3ZlQ2hyb21lSW5wdXRG aWVsZCgpCiAKIHZvaWQgUGxhdGZvcm1XZWJWaWV3OjphZGRUb1dpbmRvdygpCiB7CisgICAgaWYg KGd0a19iaW5fZ2V0X2NoaWxkKEdUS19CSU4obV93aW5kb3cpKSA9PSBHVEtfV0lER0VUKG1fdmll dykpCisgICAgICAgIHJldHVybjsKKworICAgIGd0a19jb250YWluZXJfYWRkKEdUS19DT05UQUlO RVIobV93aW5kb3cpLCBHVEtfV0lER0VUKG1fdmlldykpOworICAgIGdfb2JqZWN0X3VucmVmKEdU S19XSURHRVQobV92aWV3KSk7CiB9CiAKIHZvaWQgUGxhdGZvcm1XZWJWaWV3OjpyZW1vdmVGcm9t V2luZG93KCkKIHsKKyAgICBpZiAoZ3RrX2Jpbl9nZXRfY2hpbGQoR1RLX0JJTihtX3dpbmRvdykp ID09IEdUS19XSURHRVQobV92aWV3KSkgeworICAgICAgICBnX29iamVjdF9yZWYoR1RLX1dJREdF VChtX3ZpZXcpKTsKKyAgICAgICAgZ3RrX2NvbnRhaW5lcl9yZW1vdmUoR1RLX0NPTlRBSU5FUiht X3dpbmRvdyksIEdUS19XSURHRVQobV92aWV3KSk7CisgICAgfQogfQogCiB2b2lkIFBsYXRmb3Jt V2ViVmlldzo6bWFrZVdlYlZpZXdGaXJzdFJlc3BvbmRlcigpCmRpZmYgLS1naXQgYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL2d0ay9VSVNjcmlwdENvbnRyb2xsZXJHdGsuY3BwIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9ndGsvVUlTY3JpcHRDb250cm9sbGVyR3RrLmNwcAppbmRleCA4OTg0NGUw ODYxZi4uZWU0NmZkOTdiMTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3Rr L1VJU2NyaXB0Q29udHJvbGxlckd0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9n dGsvVUlTY3JpcHRDb250cm9sbGVyR3RrLmNwcApAQCAtMjYsMTAgKzI2LDE1IEBACiAjaW5jbHVk ZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiVUlTY3JpcHRDb250cm9sbGVyR3RrLmgiCiAKKyNpbmNs dWRlICJFdmVudFNlbmRlclByb3h5LmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1XZWJWaWV3LmgiCiAj aW5jbHVkZSAiVGVzdENvbnRyb2xsZXIuaCIKKyNpbmNsdWRlICJUZXh0Q2hlY2tlci5oIgorI2lu Y2x1ZGUgIlVJU2NyaXB0Q29udGV4dC5oIgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL09wYXF1 ZUpTU3RyaW5nLmg+CiAjaW5jbHVkZSA8V2ViS2l0L1dLVmlld1ByaXZhdGUuaD4KICNpbmNsdWRl IDxndGsvZ3RrLmg+CisjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KIAogbmFtZXNwYWNlIFdUUiB7 CiAKQEAgLTYwLDQgKzY1LDk3IEBAIGJvb2wgVUlTY3JpcHRDb250cm9sbGVyR3RrOjppc1Nob3dp bmdEYXRhTGlzdFN1Z2dlc3Rpb25zKCkgY29uc3QKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKK3Zv aWQgVUlTY3JpcHRDb250cm9sbGVyR3RrOjpkb0FzeW5jVGFzayhKU1ZhbHVlUmVmIGNhbGxiYWNr KQoreworICAgIHVuc2lnbmVkIGNhbGxiYWNrSUQgPSBtX2NvbnRleHQtPnByZXBhcmVGb3JBc3lu Y1Rhc2soY2FsbGJhY2ssIENhbGxiYWNrVHlwZU5vblBlcnNpc3RlbnQpOworICAgIFJ1bkxvb3A6 Om1haW4oKS5kaXNwYXRjaChbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBj YWxsYmFja0lEXSB7CisgICAgICAgIGlmICghbV9jb250ZXh0KQorICAgICAgICAgICAgcmV0dXJu OworICAgICAgICBtX2NvbnRleHQtPmFzeW5jVGFza0NvbXBsZXRlKGNhbGxiYWNrSUQpOworICAg IH0pOworfQorCit2b2lkIFVJU2NyaXB0Q29udHJvbGxlckd0azo6c2V0Q29udGludW91c1NwZWxs Q2hlY2tpbmdFbmFibGVkKGJvb2wgZW5hYmxlZCkKK3sKKyAgICBXZWJLaXQ6OlRleHRDaGVja2Vy OjpzZXRDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQoZW5hYmxlZCk7Cit9CisKK3ZvaWQg VUlTY3JpcHRDb250cm9sbGVyR3RrOjpjb3B5VGV4dChKU1N0cmluZ1JlZiB0ZXh0KQoreworICAg IGF1dG8gc3RyaW5nID0gdGV4dC0+c3RyaW5nKCkudXRmOCgpOworICAgIGd0a19jbGlwYm9hcmRf c2V0X3RleHQoZ3RrX2NsaXBib2FyZF9nZXQoR0RLX1NFTEVDVElPTl9DTElQQk9BUkQpLCBzdHJp bmcuZGF0YSgpLCBzdHJpbmcubGVuZ3RoKCkpOworfQorCit2b2lkIFVJU2NyaXB0Q29udHJvbGxl ckd0azo6ZGlzbWlzc01lbnUoKQoreworICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQuCit9CisKK2Jv b2wgVUlTY3JpcHRDb250cm9sbGVyR3RrOjppc1Nob3dpbmdNZW51KCkgY29uc3QKK3sKKyAgICAv LyBGSVhNRTogaW1wbGVtZW50LgorICAgIHJldHVybiBmYWxzZTsKK30KKwordm9pZCBVSVNjcmlw dENvbnRyb2xsZXJHdGs6OmFjdGl2YXRlQXRQb2ludChsb25nIHgsIGxvbmcgeSwgSlNWYWx1ZVJl ZiBjYWxsYmFjaykKK3sKKyAgICBhdXRvKiBldmVudFNlbmRlciA9IFRlc3RDb250cm9sbGVyOjpz aW5nbGV0b24oKS5ldmVudFNlbmRlclByb3h5KCk7CisgICAgaWYgKCFldmVudFNlbmRlcikgewor ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwor ICAgIHVuc2lnbmVkIGNhbGxiYWNrSUQgPSBtX2NvbnRleHQtPnByZXBhcmVGb3JBc3luY1Rhc2so Y2FsbGJhY2ssIENhbGxiYWNrVHlwZU5vblBlcnNpc3RlbnQpOworCisgICAgZXZlbnRTZW5kZXIt Pm1vdXNlTW92ZVRvKHgsIHkpOworICAgIGV2ZW50U2VuZGVyLT5tb3VzZURvd24oMCwgMCk7Cisg ICAgZXZlbnRTZW5kZXItPm1vdXNlVXAoMCwgMCk7CisKKyAgICBSdW5Mb29wOjptYWluKCkuZGlz cGF0Y2goW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgY2FsbGJhY2tJRF0g eworICAgICAgICBpZiAoIW1fY29udGV4dCkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg bV9jb250ZXh0LT5hc3luY1Rhc2tDb21wbGV0ZShjYWxsYmFja0lEKTsKKyAgICB9KTsKK30KKwor dm9pZCBVSVNjcmlwdENvbnRyb2xsZXJHdGs6OmFjdGl2YXRlRGF0YUxpc3RTdWdnZXN0aW9uKHVu c2lnbmVkIGluZGV4LCBKU1ZhbHVlUmVmIGNhbGxiYWNrKQoreworICAgIC8vIEZJWE1FOiBpbXBs ZW1lbnQuCisgICAgVU5VU0VEX1BBUkFNKGluZGV4KTsKKworICAgIGRvQXN5bmNUYXNrKGNhbGxi YWNrKTsKK30KKwordm9pZCBVSVNjcmlwdENvbnRyb2xsZXJHdGs6OnNpbXVsYXRlQWNjZXNzaWJp bGl0eVNldHRpbmdzQ2hhbmdlTm90aWZpY2F0aW9uKEpTVmFsdWVSZWYgY2FsbGJhY2spCit7Cisg ICAgLy8gRklYTUU6IGltcGxlbWVudC4KKyAgICBkb0FzeW5jVGFzayhjYWxsYmFjayk7Cit9CisK K3ZvaWQgVUlTY3JpcHRDb250cm9sbGVyR3RrOjpyZW1vdmVWaWV3RnJvbVdpbmRvdyhKU1ZhbHVl UmVmIGNhbGxiYWNrKQoreworICAgIHVuc2lnbmVkIGNhbGxiYWNrSUQgPSBtX2NvbnRleHQtPnBy ZXBhcmVGb3JBc3luY1Rhc2soY2FsbGJhY2ssIENhbGxiYWNrVHlwZU5vblBlcnNpc3RlbnQpOwor ICAgIGF1dG8qIG1haW5XZWJWaWV3ID0gVGVzdENvbnRyb2xsZXI6OnNpbmdsZXRvbigpLm1haW5X ZWJWaWV3KCk7CisgICAgbWFpbldlYlZpZXctPnJlbW92ZUZyb21XaW5kb3coKTsKKworICAgIFJ1 bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRo aXMpLCBjYWxsYmFja0lEXSB7CisgICAgICAgIGlmICghbV9jb250ZXh0KQorICAgICAgICAgICAg cmV0dXJuOworICAgICAgICBtX2NvbnRleHQtPmFzeW5jVGFza0NvbXBsZXRlKGNhbGxiYWNrSUQp OworICAgIH0pOworfQorCit2b2lkIFVJU2NyaXB0Q29udHJvbGxlckd0azo6YWRkVmlld1RvV2lu ZG93KEpTVmFsdWVSZWYgY2FsbGJhY2spCit7CisgICAgdW5zaWduZWQgY2FsbGJhY2tJRCA9IG1f Y29udGV4dC0+cHJlcGFyZUZvckFzeW5jVGFzayhjYWxsYmFjaywgQ2FsbGJhY2tUeXBlTm9uUGVy c2lzdGVudCk7CisgICAgYXV0byogbWFpbldlYlZpZXcgPSBUZXN0Q29udHJvbGxlcjo6c2luZ2xl dG9uKCkubWFpbldlYlZpZXcoKTsKKyAgICBtYWluV2ViVmlldy0+YWRkVG9XaW5kb3coKTsKKwor ICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VS ZWYoKnRoaXMpLCBjYWxsYmFja0lEXSB7CisgICAgICAgIGlmICghbV9jb250ZXh0KQorICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICBtX2NvbnRleHQtPmFzeW5jVGFza0NvbXBsZXRlKGNhbGxi YWNrSUQpOworICAgIH0pOworfQorCiB9IC8vIG5hbWVzcGFjZSBXVFIKZGlmZiAtLWdpdCBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1VJU2NyaXB0Q29udHJvbGxlckd0ay5oIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9ndGsvVUlTY3JpcHRDb250cm9sbGVyR3RrLmgKaW5kZXggMzMzMThk YzVkNDguLjMyYWZiYjljY2FlIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0 ay9VSVNjcmlwdENvbnRyb2xsZXJHdGsuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0 ay9VSVNjcmlwdENvbnRyb2xsZXJHdGsuaApAQCAtNDIsNiArNDIsMTYgQEAgcHVibGljOgogICAg IHZvaWQgYmVnaW5CYWNrU3dpcGUoSlNWYWx1ZVJlZikgb3ZlcnJpZGU7CiAgICAgdm9pZCBjb21w bGV0ZUJhY2tTd2lwZShKU1ZhbHVlUmVmKSBvdmVycmlkZTsKICAgICBib29sIGlzU2hvd2luZ0Rh dGFMaXN0U3VnZ2VzdGlvbnMoKSBjb25zdCBvdmVycmlkZTsKKyAgICB2b2lkIGRvQXN5bmNUYXNr KEpTVmFsdWVSZWYpIG92ZXJyaWRlOworICAgIHZvaWQgc2V0Q29udGludW91c1NwZWxsQ2hlY2tp bmdFbmFibGVkKGJvb2wpIG92ZXJyaWRlOworICAgIHZvaWQgY29weVRleHQoSlNTdHJpbmdSZWYp IG92ZXJyaWRlOworICAgIHZvaWQgZGlzbWlzc01lbnUoKSBvdmVycmlkZTsKKyAgICBib29sIGlz U2hvd2luZ01lbnUoKSBjb25zdCBvdmVycmlkZTsKKyAgICB2b2lkIGFjdGl2YXRlQXRQb2ludChs b25nIHgsIGxvbmcgeSwgSlNWYWx1ZVJlZiBjYWxsYmFjaykgb3ZlcnJpZGU7CisgICAgdm9pZCBh Y3RpdmF0ZURhdGFMaXN0U3VnZ2VzdGlvbih1bnNpZ25lZCBpbmRleCwgSlNWYWx1ZVJlZiBjYWxs YmFjaykgb3ZlcnJpZGU7CisgICAgdm9pZCBzaW11bGF0ZUFjY2Vzc2liaWxpdHlTZXR0aW5nc0No YW5nZU5vdGlmaWNhdGlvbihKU1ZhbHVlUmVmKSBvdmVycmlkZTsKKyAgICB2b2lkIHJlbW92ZVZp ZXdGcm9tV2luZG93KEpTVmFsdWVSZWYpIG92ZXJyaWRlOworICAgIHZvaWQgYWRkVmlld1RvV2lu ZG93KEpTVmFsdWVSZWYpIG92ZXJyaWRlOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV1RSCg==