200244 2019-07-29 14:31:23 -0700 Legacy decimal literals should not permit separators after dot or exponent indicator 2021-02-09 14:18:46 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=199984 P2 Normal --- 1 ross.kirsling ross.kirsling darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo oldest_to_newest 1556714 0 ross.kirsling 2019-07-29 14:31:23 -0700 Legacy decimal literals should not permit separators after dot or exponent indicator 1556717 1 375104 ross.kirsling 2019-07-29 14:32:54 -0700 Created attachment 375104 Patch 1556723 2 ross.kirsling 2019-07-29 14:35:37 -0700 Follow-up to bug 199984 -- we're prohibiting separators in the integral part but we shouldn't permit them anywhere. (I'd forgotten that legacy decimal literals could even have fractional / exponent parts, haha.) 1559384 3 ross.kirsling 2019-08-07 16:53:38 -0700 Thanks for the review! Turns out I misunderstood the status quo and this is still an open question on the spec side -- I will either land this or resolve it as invalid based on the outcome of https://github.com/tc39/proposal-numeric-separator/issues/49. 1727253 4 ross.kirsling 2021-02-09 14:18:46 -0800 Closing; ultimately, the existing behavior was confirmed to be spec-correct. 375104 2019-07-29 14:32:54 -0700 2019-08-07 16:45:50 -0700 Patch bug-200244-20190729143253.patch text/plain 6992 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NDM4ZGU4ZDNlYmYzMGQyZDllNDViN2Y0MmI0ZGYzNmYwYTk3YTc2Li43NTliYmVjYjEzNTI2Y2Ew Y2Y5YmEwYTU2ZmI3YjMzNDg5NmZkMGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wNy0yOSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgTGVnYWN5IGRlY2ltYWwgbGl0ZXJhbHMgc2hvdWxkIG5vdCBwZXJt aXQgc2VwYXJhdG9ycyBhZnRlciBkb3Qgb3IgZXhwb25lbnQgaW5kaWNhdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAyNDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhcnNlci9MZXhlci5jcHA6 CisgICAgICAgIChKU0M6OkxleGVyPFQ+OjpwYXJzZURlY2ltYWwpOgorICAgICAgICAoSlNDOjpM ZXhlcjxUPjo6cGFyc2VOdW1iZXJBZnRlckRlY2ltYWxQb2ludCk6CisgICAgICAgIChKU0M6Okxl eGVyPFQ+OjpwYXJzZU51bWJlckFmdGVyRXhwb25lbnRJbmRpY2F0b3IpOgorICAgICAgICAoSlND OjpMZXhlcjxUPjo6bGV4V2l0aG91dENsZWFyaW5nTGluZVRlcm1pbmF0b3IpOgorICAgICAgICAq IHBhcnNlci9MZXhlci5oOgorCiAyMDE5LTA3LTI4ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVl dWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQ3ODg2 LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAppbmRleCBlOThjZGI1ZTU5ZTIz MDcyYzE5MDE4Zjg3ZDEwYzJkNDUyZDljZDM5Li5lN2VlOGNkMTNkOTkzNDk5MjhlMDY1MzcxZjI4 ZDk5MzcxZDBjZTgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xl eGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcApAQCAt MTY3OCwxMCArMTY3OCw5IEBAIEFMV0FZU19JTkxJTkUgYXV0byBMZXhlcjxUPjo6cGFyc2VPY3Rh bCgpIC0+IE9wdGlvbmFsPE51bWJlclBhcnNlUmVzdWx0PgogfQogCiB0ZW1wbGF0ZSA8dHlwZW5h bWUgVD4KLUFMV0FZU19JTkxJTkUgYXV0byBMZXhlcjxUPjo6cGFyc2VEZWNpbWFsKCkgLT4gT3B0 aW9uYWw8TnVtYmVyUGFyc2VSZXN1bHQ+CitBTFdBWVNfSU5MSU5FIGF1dG8gTGV4ZXI8VD46OnBh cnNlRGVjaW1hbChib29sIGlzTGVnYWN5TGl0ZXJhbCkgLT4gT3B0aW9uYWw8TnVtYmVyUGFyc2VS ZXN1bHQ+CiB7CiAgICAgQVNTRVJUKGlzQVNDSUlEaWdpdChtX2N1cnJlbnQpIHx8IG1fYnVmZmVy OC5zaXplKCkpOwotICAgIGJvb2wgaXNMZWdhY3lMaXRlcmFsID0gbV9idWZmZXI4LnNpemUoKSAm JiBpc0FTQ0lJRGlnaXRPclNlcGFyYXRvcihtX2N1cnJlbnQpOwogCiAgICAgLy8gT3B0aW1pemF0 aW9uOiBtb3N0IGRlY2ltYWwgdmFsdWVzIGZpdCBpbnRvIDQgYnl0ZXMuCiAgICAgdWludDMyX3Qg ZGVjaW1hbFZhbHVlID0gMDsKQEAgLTE3MzUsMTQgKzE3MzQsMTQgQEAgQUxXQVlTX0lOTElORSBh dXRvIExleGVyPFQ+OjpwYXJzZURlY2ltYWwoKSAtPiBPcHRpb25hbDxOdW1iZXJQYXJzZVJlc3Vs dD4KIH0KIAogdGVtcGxhdGUgPHR5cGVuYW1lIFQ+Ci1BTFdBWVNfSU5MSU5FIGJvb2wgTGV4ZXI8 VD46OnBhcnNlTnVtYmVyQWZ0ZXJEZWNpbWFsUG9pbnQoKQorQUxXQVlTX0lOTElORSBib29sIExl eGVyPFQ+OjpwYXJzZU51bWJlckFmdGVyRGVjaW1hbFBvaW50KGJvb2wgaXNMZWdhY3lMaXRlcmFs KQogewogICAgIEFTU0VSVChpc0FTQ0lJRGlnaXQobV9jdXJyZW50KSk7CiAgICAgcmVjb3JkOCgn LicpOwogCiAgICAgZG8gewogICAgICAgICBpZiAobV9jdXJyZW50ID09ICdfJykgewotICAgICAg ICAgICAgaWYgKFVOTElLRUxZKCFpc0FTQ0lJRGlnaXQocGVlaygxKSkpKQorICAgICAgICAgICAg aWYgKFVOTElLRUxZKCFpc0FTQ0lJRGlnaXQocGVlaygxKSkgfHwgaXNMZWdhY3lMaXRlcmFsKSkK ICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAgICAgIHNoaWZ0KCk7CkBA IC0xNzU2LDcgKzE3NTUsNyBAQCBBTFdBWVNfSU5MSU5FIGJvb2wgTGV4ZXI8VD46OnBhcnNlTnVt YmVyQWZ0ZXJEZWNpbWFsUG9pbnQoKQogfQogCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KLUFMV0FZ U19JTkxJTkUgYm9vbCBMZXhlcjxUPjo6cGFyc2VOdW1iZXJBZnRlckV4cG9uZW50SW5kaWNhdG9y KCkKK0FMV0FZU19JTkxJTkUgYm9vbCBMZXhlcjxUPjo6cGFyc2VOdW1iZXJBZnRlckV4cG9uZW50 SW5kaWNhdG9yKGJvb2wgaXNMZWdhY3lMaXRlcmFsKQogewogICAgIHJlY29yZDgoJ2UnKTsKICAg ICBzaGlmdCgpOwpAQCAtMTc3MCw3ICsxNzY5LDcgQEAgQUxXQVlTX0lOTElORSBib29sIExleGVy PFQ+OjpwYXJzZU51bWJlckFmdGVyRXhwb25lbnRJbmRpY2F0b3IoKQogCiAgICAgZG8gewogICAg ICAgICBpZiAobV9jdXJyZW50ID09ICdfJykgewotICAgICAgICAgICAgaWYgKFVOTElLRUxZKCFp c0FTQ0lJRGlnaXQocGVlaygxKSkpKQorICAgICAgICAgICAgaWYgKFVOTElLRUxZKCFpc0FTQ0lJ RGlnaXQocGVlaygxKSkgfHwgaXNMZWdhY3lMaXRlcmFsKSkKICAgICAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CiAKICAgICAgICAgICAgIHNoaWZ0KCk7CkBAIC0yMzQ5LDcgKzIzNDgsOCBAQCBz dGFydDoKICAgICAgICAgRkFMTFRIUk9VR0g7CiAgICAgY2FzZSBDaGFyYWN0ZXJOdW1iZXI6CiAg ICAgICAgIGlmIChMSUtFTFkodG9rZW4gIT0gSU5URUdFUiAmJiB0b2tlbiAhPSBET1VCTEUpKSB7 Ci0gICAgICAgICAgICBhdXRvIHBhcnNlTnVtYmVyUmVzdWx0ID0gcGFyc2VEZWNpbWFsKCk7Cisg ICAgICAgICAgICBib29sIGlzTGVnYWN5TGl0ZXJhbCA9IG1fYnVmZmVyOC5zaXplKCkgJiYgaXNB U0NJSURpZ2l0T3JTZXBhcmF0b3IobV9jdXJyZW50KTsKKyAgICAgICAgICAgIGF1dG8gcGFyc2VO dW1iZXJSZXN1bHQgPSBwYXJzZURlY2ltYWwoaXNMZWdhY3lMaXRlcmFsKTsKICAgICAgICAgICAg IGlmIChwYXJzZU51bWJlclJlc3VsdCkgewogICAgICAgICAgICAgICAgIGlmIChXVEY6OmhvbGRz X2FsdGVybmF0aXZlPGRvdWJsZT4oKnBhcnNlTnVtYmVyUmVzdWx0KSkgewogICAgICAgICAgICAg ICAgICAgICB0b2tlbkRhdGEtPmRvdWJsZVZhbHVlID0gV1RGOjpnZXQ8ZG91YmxlPigqcGFyc2VO dW1iZXJSZXN1bHQpOwpAQCAtMjM2NCwxNCArMjM2NCwxNCBAQCBzdGFydDoKICAgICAgICAgICAg ICAgICB0b2tlbiA9IElOVEVHRVI7CiAgICAgICAgICAgICAgICAgaWYgKG1fY3VycmVudCA9PSAn LicpIHsKICAgICAgICAgICAgICAgICAgICAgc2hpZnQoKTsKLSAgICAgICAgICAgICAgICAgICAg aWYgKFVOTElLRUxZKGlzQVNDSUlEaWdpdChtX2N1cnJlbnQpICYmICFwYXJzZU51bWJlckFmdGVy RGVjaW1hbFBvaW50KCkpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChVTkxJS0VMWShpc0FT Q0lJRGlnaXQobV9jdXJyZW50KSAmJiAhcGFyc2VOdW1iZXJBZnRlckRlY2ltYWxQb2ludChpc0xl Z2FjeUxpdGVyYWwpKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgbV9sZXhFcnJvck1lc3Nh Z2UgPSAiTm9uLW51bWJlciBmb3VuZCBhZnRlciBkZWNpbWFsIHBvaW50Il9zOwogICAgICAgICAg ICAgICAgICAgICAgICAgdG9rZW4gPSBhdEVuZCgpID8gVU5URVJNSU5BVEVEX05VTUVSSUNfTElU RVJBTF9FUlJPUlRPSyA6IElOVkFMSURfTlVNRVJJQ19MSVRFUkFMX0VSUk9SVE9LOwogICAgICAg ICAgICAgICAgICAgICAgICAgZ290byByZXR1cm5FcnJvcjsKICAgICAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgICAgICB0b2tlbiA9IERPVUJMRTsKICAgICAgICAgICAgICAgICB9 Ci0gICAgICAgICAgICAgICAgaWYgKFVOTElLRUxZKGlzQVNDSUlBbHBoYUNhc2VsZXNzRXF1YWwo bV9jdXJyZW50LCAnZScpICYmICFwYXJzZU51bWJlckFmdGVyRXhwb25lbnRJbmRpY2F0b3IoKSkp IHsKKyAgICAgICAgICAgICAgICBpZiAoVU5MSUtFTFkoaXNBU0NJSUFscGhhQ2FzZWxlc3NFcXVh bChtX2N1cnJlbnQsICdlJykgJiYgIXBhcnNlTnVtYmVyQWZ0ZXJFeHBvbmVudEluZGljYXRvcihp c0xlZ2FjeUxpdGVyYWwpKSkgewogICAgICAgICAgICAgICAgICAgICBtX2xleEVycm9yTWVzc2Fn ZSA9ICJOb24tbnVtYmVyIGZvdW5kIGFmdGVyIGV4cG9uZW50IGluZGljYXRvciJfczsKICAgICAg ICAgICAgICAgICAgICAgdG9rZW4gPSBhdEVuZCgpID8gVU5URVJNSU5BVEVEX05VTUVSSUNfTElU RVJBTF9FUlJPUlRPSyA6IElOVkFMSURfTlVNRVJJQ19MSVRFUkFMX0VSUk9SVE9LOwogICAgICAg ICAgICAgICAgICAgICBnb3RvIHJldHVybkVycm9yOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9MZXhlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9M ZXhlci5oCmluZGV4IGNmMzc4MGJiYzQ2YmU1NjRlZjg5YjMwYTYzMjUzMDA1MWZkODQ2YzUuLjk5 NTM0NWQ1NDhhZmQyOWIzOGYxZTJhZjFiYjNmMGE1MTk5NmZiYzEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL0xleGVyLmgKQEAgLTE4Miw5ICsxODIsOSBAQCBwcml2YXRlOgogICAgIEFMV0FZ U19JTkxJTkUgT3B0aW9uYWw8TnVtYmVyUGFyc2VSZXN1bHQ+IHBhcnNlSGV4KCk7CiAgICAgQUxX QVlTX0lOTElORSBPcHRpb25hbDxOdW1iZXJQYXJzZVJlc3VsdD4gcGFyc2VCaW5hcnkoKTsKICAg ICBBTFdBWVNfSU5MSU5FIE9wdGlvbmFsPE51bWJlclBhcnNlUmVzdWx0PiBwYXJzZU9jdGFsKCk7 Ci0gICAgQUxXQVlTX0lOTElORSBPcHRpb25hbDxOdW1iZXJQYXJzZVJlc3VsdD4gcGFyc2VEZWNp bWFsKCk7Ci0gICAgQUxXQVlTX0lOTElORSBib29sIHBhcnNlTnVtYmVyQWZ0ZXJEZWNpbWFsUG9p bnQoKTsKLSAgICBBTFdBWVNfSU5MSU5FIGJvb2wgcGFyc2VOdW1iZXJBZnRlckV4cG9uZW50SW5k aWNhdG9yKCk7CisgICAgQUxXQVlTX0lOTElORSBPcHRpb25hbDxOdW1iZXJQYXJzZVJlc3VsdD4g cGFyc2VEZWNpbWFsKGJvb2wgaXNMZWdhY3lMaXRlcmFsKTsKKyAgICBBTFdBWVNfSU5MSU5FIGJv b2wgcGFyc2VOdW1iZXJBZnRlckRlY2ltYWxQb2ludChib29sIGlzTGVnYWN5TGl0ZXJhbCA9IGZh bHNlKTsKKyAgICBBTFdBWVNfSU5MSU5FIGJvb2wgcGFyc2VOdW1iZXJBZnRlckV4cG9uZW50SW5k aWNhdG9yKGJvb2wgaXNMZWdhY3lMaXRlcmFsID0gZmFsc2UpOwogICAgIEFMV0FZU19JTkxJTkUg Ym9vbCBwYXJzZU11bHRpbGluZUNvbW1lbnQoKTsKIAogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBw YXJzZUNvbW1lbnREaXJlY3RpdmUoKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIv SlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTU0YjYzN2NiNmQ5ZTU3ODY0YzIxNDJhNTljOTA4MWMz MGJiYWJjYi4uY2UxOTQwNzA1MGYwZGY5ZTJkZGQyNzM5MDIxMzg2ZDRkZmUyMmNhNSAxMDA2NDQK LS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxOS0wNy0yOSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5j b20+CisKKyAgICAgICAgTGVnYWN5IGRlY2ltYWwgbGl0ZXJhbHMgc2hvdWxkIG5vdCBwZXJtaXQg c2VwYXJhdG9ycyBhZnRlciBkb3Qgb3IgZXhwb25lbnQgaW5kaWNhdG9yCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAyNDQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9udW1lcmljLWxpdGVy YWwtc2VwYXJhdG9ycy5qczoKKwogMjAxOS0wNy0yNyAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5f bWljaGF1ZEBhcHBsZS5jb20+CiAKICAgICAgICAgW1g4Nl0gRW1pdCBCVCBpbnN0cnVjdGlvbiBm b3Igc2hpZnQgKyBtYXNrIGluIEIzCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9udW1lcmlj LWxpdGVyYWwtc2VwYXJhdG9ycy5qcyBiL0pTVGVzdHMvc3RyZXNzL251bWVyaWMtbGl0ZXJhbC1z ZXBhcmF0b3JzLmpzCmluZGV4IGQ4OWQxMWQ2ZGM0N2NhMjlhOTNmMjYzODA2NTVjMzk2ZmZhYjQz YzkuLjZiNmZkYTM5Yjk3YzMxMDdlZjRlNTUyZTE4YzI0YTBkY2U4NDhmOWMgMTAwNjQ0Ci0tLSBh L0pTVGVzdHMvc3RyZXNzL251bWVyaWMtbGl0ZXJhbC1zZXBhcmF0b3JzLmpzCisrKyBiL0pTVGVz dHMvc3RyZXNzL251bWVyaWMtbGl0ZXJhbC1zZXBhcmF0b3JzLmpzCkBAIC0xMDQsMyArMTA0LDEw IEBAIHNob3VsZFRocm93KCcwOTAwXzAwMScsIFN5bnRheEVycm9yKTsKIHNob3VsZFRocm93KCcw MTAwMDAwMDAwMDBfMScsIFN5bnRheEVycm9yKTsKIHNob3VsZFRocm93KCcwMTAwMDAwMDAwMDBf OScsIFN5bnRheEVycm9yKTsKIHNob3VsZFRocm93KCcwOTAwMDAwMDAwMDBfMScsIFN5bnRheEVy cm9yKTsKKworc2hvdWxkVGhyb3coJzA5LjFfMScsIFN5bnRheEVycm9yKTsKK3Nob3VsZFRocm93 KCcwOWUyXzInLCBTeW50YXhFcnJvcik7CitzaG91bGRUaHJvdygnMDkuMTFlMl8yJywgU3ludGF4 RXJyb3IpOworc2hvdWxkVGhyb3coJzA5MDAwMDAwMDAwMC4xXzEnLCBTeW50YXhFcnJvcik7Citz aG91bGRUaHJvdygnMDkwMDAwMDAwMDAwZTJfMicsIFN5bnRheEVycm9yKTsKK3Nob3VsZFRocm93 KCcwOTAwMDAwMDAwMDAuMTFlMl8yJywgU3ludGF4RXJyb3IpOwo=