200086 2019-07-24 10:05:20 -0700 REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends 2019-07-31 10:37:59 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198450 https://bugs.webkit.org/show_bug.cgi?id=200254 InRadar P2 Normal --- 1 aakash_jain cdumez aakash_jain achristensen ap beidson cdumez commit-queue ggaren ryanhaddad sihui_liu webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1555383 0 aakash_jain 2019-07-24 10:05:20 -0700 TestWebKitAPI.WKWebView.LocalStorageProcessSuspends seems flaky. In https://ews-build.webkit.org/#/builders/9/builds/4903, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed. Same thing happened in https://ews-build.webkit.org/#/builders/9/builds/4901 In https://ews-build.webkit.org/#/builders/9/builds/4784, it just failed consistently. 1555384 1 ryanhaddad 2019-07-24 10:09:10 -0700 It can also be seen failing on a trunk bot here: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/3730/steps/run-api-tests/logs/stdio 1555385 2 webkit-bug-importer 2019-07-24 10:09:26 -0700 <rdar://problem/53501721> 1556700 3 ryanhaddad 2019-07-29 14:14:38 -0700 This is indeed quite flaky. The bots are often red because of this failure. TestWebKitAPI.WKWebView.LocalStorageProcessSuspends /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:156 Expected equality of these values: @"value" Which is: "value" result Which is: "newValue" 1556775 4 aakash_jain 2019-07-29 16:01:21 -0700 This test is creating issue in EWS infrastrucutre. It is extremely flaky and various times flakes in a manner that misleads EWS into blaming the patch being tested (this test failed consistently twice with the patch, and pass without the patch). e.g.: https://ews-build.webkit.org/#/builders/9/builds/5177 https://ews-build.webkit.org/#/builders/9/builds/5145 https://ews-build.webkit.org/#/builders/9/builds/5140 https://ews-build.webkit.org/#/builders/9/builds/5109 1556814 5 sihui_liu 2019-07-29 16:51:28 -0700 (In reply to Aakash Jain from comment #4) > This test is creating issue in EWS infrastrucutre. It is extremely flaky and > various times flakes in a manner that misleads EWS into blaming the patch > being tested (this test failed consistently twice with the patch, and pass > without the patch). > > e.g.: > https://ews-build.webkit.org/#/builders/9/builds/5177 > https://ews-build.webkit.org/#/builders/9/builds/5145 > https://ews-build.webkit.org/#/builders/9/builds/5140 > https://ews-build.webkit.org/#/builders/9/builds/5109 Do you mean this API test always passes without those patches being tested but fails with them? It sounds like some states are kept between test runs.. Does this happen since last week? If this starts to happen recently, it may help narrow down the blamed changes. 1556821 6 ryanhaddad 2019-07-29 16:56:39 -0700 FWIW this isn't specific to iOS. Based on history, this may have started after: Speed up StorageManager::getValues() https://trac.webkit.org/changeset/247486/webkit 1556824 7 cdumez 2019-07-29 17:03:15 -0700 (In reply to Ryan Haddad from comment #6) > FWIW this isn't specific to iOS. > > Based on history, this may have started after: > > Speed up StorageManager::getValues() > https://trac.webkit.org/changeset/247486/webkit Ok, so probably making it a WorkQueueMessageReceiver again. 1556826 8 aakash_jain 2019-07-29 17:05:43 -0700 > Do you mean this API test always passes without those patches being tested > but fails with them? Not always. It flakes in various different manners. This particular manner is particularly bad for EWS (as it incorrectly blames a patch). In following examples, the test is clearly flaky; it failed in first run (run-api-tests step), but in immediate retry step (in re-run-api-tests) this test passed: https://ews-build.webkit.org/#/builders/9/builds/5199 https://ews-build.webkit.org/#/builders/9/builds/5183 https://ews-build.webkit.org/#/builders/9/builds/5179 https://ews-build.webkit.org/#/builders/9/builds/5176 https://ews-build.webkit.org/#/builders/9/builds/5170 https://ews-build.webkit.org/#/builders/9/builds/5163 https://ews-build.webkit.org/#/builders/9/builds/5157 https://ews-build.webkit.org/#/builders/9/builds/5151 https://ews-build.webkit.org/#/builders/9/builds/5123 https://ews-build.webkit.org/#/builders/9/builds/5120 https://ews-build.webkit.org/#/builders/9/builds/5119 https://ews-build.webkit.org/#/builders/9/builds/5114 https://ews-build.webkit.org/#/builders/9/builds/5103 https://ews-build.webkit.org/#/builders/9/builds/5102 > > Does this happen since last week? If this starts to happen recently, it may > help narrow down the blamed changes. Seems to be happening atleast since July 16: https://ews-build.webkit.org/#/builders/9/builds/4550 https://ews-build.webkit.org/#/builders/9/builds/4547 https://ews-build.webkit.org/#/builders/9/builds/4545 1557285 9 375227 cdumez 2019-07-31 09:14:22 -0700 Created attachment 375227 Patch 1557305 10 375227 commit-queue 2019-07-31 10:37:57 -0700 Comment on attachment 375227 Patch Clearing flags on attachment: 375227 Committed r248047: <https://trac.webkit.org/changeset/248047> 1557306 11 commit-queue 2019-07-31 10:37:59 -0700 All reviewed patches have been landed. Closing bug. 375227 2019-07-31 09:14:22 -0700 2019-07-31 10:37:57 -0700 Patch bug-200086-20190731091422.patch text/plain 9491 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY0Mjc2ODFjMTc4MjJhNGZk Zjg3OTQ0MjE1MDFmNDYzMTg1ZmU4MjUuLjUzYmRhMTgwYjBhMTg2ZjZiNTdkZTkzYzkzMzA5YzZk ZDJjMjkxMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzYgQEAKKzIwMTktMDctMzEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjQ3NDg2Pyk6 IEZsYWt5IEFQSSBUZXN0IFRlc3RXZWJLaXRBUEkuV0tXZWJWaWV3LkxvY2FsU3RvcmFnZVByb2Nl c3NTdXNwZW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAwMDg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MzUwMTcyMT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCB3b3VsZCBmaXJz dCBzZW5kIGEgUHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRseSBJUEMgdG8gdGhlIE5ldHdvcmtQ cm9jZXNzIGFuZCB0aGVuCisgICAgICAgIHJ1biBKUyBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNz LCB3aGljaCB3b3VsZCBpbiB0dXJuIHNlbmQgSVBDIHRvIHRoZSBOZXR3b3JrUHJvY2Vzcy4gVGhl CisgICAgICAgIHRlc3Qgd2FzIGZsYWt5IGJlY2F1c2UgaXQgZXhwZWN0ZWQgdGhlIG5ldHdvcmsg cHJvY2VzcyB0byByZWNlaXZlIHRoZSBJUEMgZnJvbSB0aGUgVUlQcm9jZXNzCisgICAgICAgICpi ZWZvcmUqIHRoZSBvbmUgZnJvbSB0aGUgV2ViQ29udGVudCBwcm9jZXNzLiBIb3dldmVyLCB0aGVy ZSBpcyBubyBndWFyYW50ZWUgYWJvdXQgb3JkZXJpbmcKKyAgICAgICAgZnJvbSBJUEMgbWVzc2Fn ZXMgY29taW5nIGZyb20gZGlmZmVyZW50IGNvbm5lY3Rpb25zLgorCisgICAgICAgIFRvIGFkZHJl c3MgdGhlIGZsYWtpbmVzcywgdGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGEgbmV3IFByb2Nlc3NXaWxs U3VzcGVuZEltbWluZW50bHlGb3JUZXN0aW5nCisgICAgICAgIHN5bmNocm9ub3VzIElQQyBhbmQg dXNlcyB0aGlzIGluc3RlYWQuIEFzIGEgcmVzdWx0LCBpdCBpcyBub3cgZ3VhcmFudGVlZCB0aGF0 IHRoZSBuZXR3b3JrCisgICAgICAgIHByb2Nlc3MgcHJvY2Vzc2VzIHRoaXMgSVBDICpiZWZvcmUq IHJlY2VpdmluZyBhbnkgSVBDIGZyb20gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyB0aGF0IGlzCisg ICAgICAgIHRoZSByZXN1bHQgb2YgSVBDIGZyb20gdGhlIFVJUHJvY2Vzcy4KKworICAgICAgICAq IE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0 d29ya1Byb2Nlc3M6OnByb2Nlc3NXaWxsU3VzcGVuZEltbWluZW50bHlGb3JUZXN0aW5nU3luYyk6 CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaDoKKyAgICAgICAgKiBO ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5tZXNzYWdlcy5pbjoKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wubW06CisgICAgICAgICgtW1dLUHJvY2Vzc1Bv b2wgX3NlbmROZXR3b3JrUHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRseV0pOgorICAgICAgICAq IFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2Vi S2l0OjpOZXR3b3JrUHJvY2Vzc1Byb3h5OjpzZW5kUHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRs eUZvclRlc3RpbmcpOgorICAgICAgICAqIFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNz UHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6c2VuZE5ldHdvcmtQcm9jZXNzV2lsbFN1c3BlbmRJ bW1pbmVudGx5Rm9yVGVzdGluZyk6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpz ZW5kTmV0d29ya1Byb2Nlc3NXaWxsU3VzcGVuZEltbWluZW50bHkpOiBEZWxldGVkLgorICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oOgorCiAyMDE5LTA3LTMwICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IG5vbi10aHJlYWQgc2FmZSB1c2Ug b2YgV2Vha1B0ciB1bmRlciBzZW5kU2VjSXRlbVJlcXVlc3QoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAppbmRleCAwODAzM2Q2YzNmNTVkZTA0 Y2VhYWQ1Y2IxNjI2OTc0NzRlOTEyMWVmLi40YTZjOThkNWUwMDNiOTlmYTdmYmFmZTRhZjdmYWUx OWQzNzViOGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdv cmtQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQ cm9jZXNzLmNwcApAQCAtMjExMCw2ICsyMTEwLDEyIEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnBy b2Nlc3NXaWxsU3VzcGVuZEltbWluZW50bHkoKQogICAgIFJFTEVBU0VfTE9HKFByb2Nlc3NTdXNw ZW5zaW9uLCAiJXAgLSBOZXR3b3JrUHJvY2Vzczo6cHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRs eSgpIEVORCIsIHRoaXMpOwogfQogCit2b2lkIE5ldHdvcmtQcm9jZXNzOjpwcm9jZXNzV2lsbFN1 c3BlbmRJbW1pbmVudGx5Rm9yVGVzdGluZ1N5bmMoQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgpPiYm IGNvbXBsZXRpb25IYW5kbGVyKQoreworICAgIHByb2Nlc3NXaWxsU3VzcGVuZEltbWluZW50bHko KTsKKyAgICBjb21wbGV0aW9uSGFuZGxlcigpOworfQorCiB2b2lkIE5ldHdvcmtQcm9jZXNzOjpw cmVwYXJlVG9TdXNwZW5kKCkKIHsKICAgICBSRUxFQVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwg IiVwIC0gTmV0d29ya1Byb2Nlc3M6OnByZXBhcmVUb1N1c3BlbmQoKSIsIHRoaXMpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oIGIvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oCmluZGV4IDI4NjY4NTcw ZDM0M2ZkOGYwMmJhZDAxNDVmNWMyYTFkZGEwZjU2NWIuLmQ3Y2I3YzYzY2VhZWY1MTUyNDJhYzUw ZmMyNDE5YTkyOThjODZhMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Byb2Nlc3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05l dHdvcmtQcm9jZXNzLmgKQEAgLTE4MSw2ICsxODEsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBjYW5I YW5kbGVIVFRQU1NlcnZlclRydXN0RXZhbHVhdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fY2FuSGFu ZGxlSFRUUFNTZXJ2ZXJUcnVzdEV2YWx1YXRpb247IH0KIAogICAgIHZvaWQgcHJvY2Vzc1dpbGxT dXNwZW5kSW1taW5lbnRseSgpOworICAgIHZvaWQgcHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRs eUZvclRlc3RpbmdTeW5jKENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJik7CiAgICAgdm9pZCBw cmVwYXJlVG9TdXNwZW5kKCk7CiAgICAgdm9pZCBjYW5jZWxQcmVwYXJlVG9TdXNwZW5kKCk7CiAg ICAgdm9pZCBwcm9jZXNzRGlkUmVzdW1lKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLm1lc3NhZ2VzLmluIGIvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5tZXNzYWdlcy5pbgppbmRleCA5YmUxNmQ4Y2Rm NmYxZTk5ZGRhMThiZWZkNWVlNmRlZWNmZGQ1OGFmLi5mNGRlNDA4YzIxYTk4YTU5ZWY3NjE2N2Q3 ZDYzYjU3ZGNkOTk3N2Q5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L05ldHdvcmtQcm9jZXNzLm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvTmV0d29ya1Byb2Nlc3MubWVzc2FnZXMuaW4KQEAgLTc5LDYgKzc5LDcgQEAgbWVzc2Fn ZXMgLT4gTmV0d29ya1Byb2Nlc3MgTGVnYWN5UmVjZWl2ZXIgewogICAgIFByb2Nlc3NEaWRUcmFu c2l0aW9uVG9Gb3JlZ3JvdW5kKCkKIAogICAgIFByb2Nlc3NXaWxsU3VzcGVuZEltbWluZW50bHko KQorICAgIFByb2Nlc3NXaWxsU3VzcGVuZEltbWluZW50bHlGb3JUZXN0aW5nU3luYygpIC0+ICgp IFN5bmNocm9ub3VzCiAgICAgUHJlcGFyZVRvU3VzcGVuZCgpCiAgICAgQ2FuY2VsUHJlcGFyZVRv U3VzcGVuZCgpCiAgICAgUHJvY2Vzc0RpZFJlc3VtZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbC5tbSBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NQb29sLm1tCmluZGV4IDcyYWVmOWNjMDFmOTk3 Y2U5YWRiNjQwZmFiMjM2ZWJlNzdlMTUyMGMuLjliNWY3YjVlMDhlZmMzMWE5ZTdlODc1OTc0YzAw YWYwNmE1YTU2ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1Byb2Nlc3NQb29sLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1Byb2Nlc3NQb29sLm1tCkBAIC00MzksNyArNDM5LDcgQEAgLSAodm9pZClfdGVybWluYXRl TmV0d29ya1Byb2Nlc3MKIAogLSAodm9pZClfc2VuZE5ldHdvcmtQcm9jZXNzV2lsbFN1c3BlbmRJ bW1pbmVudGx5CiB7Ci0gICAgX3Byb2Nlc3NQb29sLT5zZW5kTmV0d29ya1Byb2Nlc3NXaWxsU3Vz cGVuZEltbWluZW50bHkoKTsKKyAgICBfcHJvY2Vzc1Bvb2wtPnNlbmROZXR3b3JrUHJvY2Vzc1dp bGxTdXNwZW5kSW1taW5lbnRseUZvclRlc3RpbmcoKTsKIH0KIAogLSAodm9pZClfc2VuZE5ldHdv cmtQcm9jZXNzRGlkUmVzdW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9O ZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv TmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmNwcAppbmRleCA2ZDY2NmM5YjY1NmQyY2NlY2M2 Y2Q4MGE3ZmQ3ZDljYTk2ZDQxZjYxLi4wZDNkMDNjZWVkODMxM2JjYTI3YjM5MTVhYzM3Y2U2ZTNl ZDczMDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdv cmtQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsv TmV0d29ya1Byb2Nlc3NQcm94eS5jcHAKQEAgLTk4MSw2ICs5ODEsMTIgQEAgdm9pZCBOZXR3b3Jr UHJvY2Vzc1Byb3h5OjpzZW5kUHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRseSgpCiAgICAgaWYg KGNhblNlbmRNZXNzYWdlKCkpCiAgICAgICAgIHNlbmQoTWVzc2FnZXM6Ok5ldHdvcmtQcm9jZXNz OjpQcm9jZXNzV2lsbFN1c3BlbmRJbW1pbmVudGx5KCksIDApOwogfQorCit2b2lkIE5ldHdvcmtQ cm9jZXNzUHJveHk6OnNlbmRQcm9jZXNzV2lsbFN1c3BlbmRJbW1pbmVudGx5Rm9yVGVzdGluZygp Cit7CisgICAgaWYgKGNhblNlbmRNZXNzYWdlKCkpCisgICAgICAgIHNlbmRTeW5jKE1lc3NhZ2Vz OjpOZXR3b3JrUHJvY2Vzczo6UHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRseUZvclRlc3RpbmdT eW5jKCksIE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6UHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5l bnRseUZvclRlc3RpbmdTeW5jOjpSZXBseSgpLCAwKTsKK30KICAgICAKIHZvaWQgTmV0d29ya1By b2Nlc3NQcm94eTo6c2VuZFByZXBhcmVUb1N1c3BlbmQoKQogewpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmggYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuaAppbmRleCAyZDBi ZTUxYTE4ZmE3Y2EyMjJjYTI1ODUwYTczZDQxODQ3Y2E0MWRhLi4zNWI4MjEzYzI4ZmNiNmI5NDBh MTA5OWJlMTQwOGY5MDZhM2I5MmJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuaApAQCAtMTg1LDYgKzE4NSw4IEBAIHB1 YmxpYzoKICAgICAvLyBQcm9jZXNzVGhyb3R0bGVyQ2xpZW50CiAgICAgdm9pZCBzZW5kUHJvY2Vz c1dpbGxTdXNwZW5kSW1taW5lbnRseSgpIGZpbmFsOwogICAgIHZvaWQgc2VuZFByb2Nlc3NEaWRS ZXN1bWUoKSBmaW5hbDsKKyAgICAKKyAgICB2b2lkIHNlbmRQcm9jZXNzV2lsbFN1c3BlbmRJbW1p bmVudGx5Rm9yVGVzdGluZygpOwogCiBwcml2YXRlOgogICAgIC8vIEF1eGlsaWFyeVByb2Nlc3NQ cm94eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wu Y3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCmluZGV4IDdj YjRmMTE0YmZhODI1N2FkYzJjNDRiOGM3MmY5MmZmZjRkNGEwMWEuLmFmYWIzZmQ2ZTg2MWZkZmE2 MWNhMGRiMWEzZDAxZGQyOWQ3ZDVhN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQb29sLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ cm9jZXNzUG9vbC5jcHAKQEAgLTE3NzYsMTAgKzE3NzYsMTAgQEAgdm9pZCBXZWJQcm9jZXNzUG9v bDo6dGVybWluYXRlTmV0d29ya1Byb2Nlc3MoKQogICAgIG1fZGlkTmV0d29ya1Byb2Nlc3NDcmFz aCA9IHRydWU7CiB9CiAKLXZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnNlbmROZXR3b3JrUHJvY2Vzc1dp bGxTdXNwZW5kSW1taW5lbnRseSgpCit2b2lkIFdlYlByb2Nlc3NQb29sOjpzZW5kTmV0d29ya1By b2Nlc3NXaWxsU3VzcGVuZEltbWluZW50bHlGb3JUZXN0aW5nKCkKIHsKICAgICBpZiAobV9uZXR3 b3JrUHJvY2VzcykKLSAgICAgICAgbV9uZXR3b3JrUHJvY2Vzcy0+c2VuZFByb2Nlc3NXaWxsU3Vz cGVuZEltbWluZW50bHkoKTsKKyAgICAgICAgbV9uZXR3b3JrUHJvY2Vzcy0+c2VuZFByb2Nlc3NX aWxsU3VzcGVuZEltbWluZW50bHlGb3JUZXN0aW5nKCk7CiB9CiAKIHZvaWQgV2ViUHJvY2Vzc1Bv b2w6OnNlbmROZXR3b3JrUHJvY2Vzc0RpZFJlc3VtZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUHJvY2Vzc1Bvb2wuaAppbmRleCBkYWUyNTkxMDdlMTk3NTdmZGVjNDEwNTAzYTE1NDZjY2Q1 ODNjZjc5Li4yMjZjZjM2NjE1MWZmNjI4M2E2MmRlYzM1OTcxMjkxYjM2NmNlMTA1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmgKQEAgLTMxMiw3ICszMTIsNyBAQCBw dWJsaWM6CiAgICAgdm9pZCBjbGVhckNhY2hlZENyZWRlbnRpYWxzKCk7CiAgICAgdm9pZCBjbGVh clBlcm1hbmVudENyZWRlbnRpYWxzRm9yUHJvdGVjdGlvblNwYWNlKFdlYkNvcmU6OlByb3RlY3Rp b25TcGFjZSYmLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYpOwogICAgIHZvaWQgdGVybWlu YXRlTmV0d29ya1Byb2Nlc3MoKTsKLSAgICB2b2lkIHNlbmROZXR3b3JrUHJvY2Vzc1dpbGxTdXNw ZW5kSW1taW5lbnRseSgpOworICAgIHZvaWQgc2VuZE5ldHdvcmtQcm9jZXNzV2lsbFN1c3BlbmRJ bW1pbmVudGx5Rm9yVGVzdGluZygpOwogICAgIHZvaWQgc2VuZE5ldHdvcmtQcm9jZXNzRGlkUmVz dW1lKCk7CiAgICAgdm9pZCB0ZXJtaW5hdGVTZXJ2aWNlV29ya2VyUHJvY2Vzc2VzKCk7CiAgICAg dm9pZCBkaXNhYmxlU2VydmljZVdvcmtlclByb2Nlc3NUZXJtaW5hdGlvbkRlbGF5KCk7CmRpZmYg LS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWQ2Yjk3NTYx MWZjY2ZlMTE2ZDBmZjgyYjhjNDZmMWEzZDc5NDYzOC4uOGI1MWYxMmQ5ZDg4YzQ3ODE0YzFlOWQy MWFiZjFiNWRhZDJiYzIwOCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA3LTMxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI0NzQ4Nj8pOiBGbGFreSBB UEkgVGVzdCBUZXN0V2ViS2l0QVBJLldLV2ViVmlldy5Mb2NhbFN0b3JhZ2VQcm9jZXNzU3VzcGVu ZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDA4 NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM1MDE3MjE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcmUtZW5hYmxlIHRoZSBBUEkgdGVzdC4KKwor ICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTG9jYWxTdG9yYWdlUGVy c2lzdGVuY2UubW06CisgICAgICAgIChURVNUKToKKwogMjAxOS0wNy0zMCAgSm9uYXRoYW4gQmVk YXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgRHVtcFJlbmRlclRyZWUuYXBwOiBB ZGQgQ0ZCdW5kbGVTaG9ydFZlcnNpb25TdHJpbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTG9jYWxTdG9yYWdlUGVyc2lzdGVuY2UubW0gYi9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0xvY2FsU3RvcmFnZVBlcnNpc3RlbmNl Lm1tCmluZGV4IDJiMmJmNzRmZDg0ZDlhZWNmYTg3Y2NkNGIwM2EwNzgxMmYyYWI1ZWQuLjExNTYy YmI1NjkzNGY1NGQ2M2Y5NzdhN2JkZTA5ZDk0MzU0OWFiMjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTG9jYWxTdG9yYWdlUGVyc2lzdGVuY2UubW0K KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Mb2NhbFN0b3JhZ2VQ ZXJzaXN0ZW5jZS5tbQpAQCAtMTEyLDcgKzExMiw3IEBAIFRFU1QoV0tXZWJWaWV3LCBMb2NhbFN0 b3JhZ2VQcm9jZXNzQ3Jhc2hlcykKICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJnJlYWR5 VG9Db250aW51ZSk7CiB9CiAKLVRFU1QoV0tXZWJWaWV3LCBESVNBQkxFRF9Mb2NhbFN0b3JhZ2VQ cm9jZXNzU3VzcGVuZHMpCitURVNUKFdLV2ViVmlldywgTG9jYWxTdG9yYWdlUHJvY2Vzc1N1c3Bl bmRzKQogewogICAgIHJlYWR5VG9Db250aW51ZSA9IGZhbHNlOwogICAgIFtbV0tXZWJzaXRlRGF0 YVN0b3JlIGRlZmF1bHREYXRhU3RvcmVdIHJlbW92ZURhdGFPZlR5cGVzOltXS1dlYnNpdGVEYXRh U3RvcmUgYWxsV2Vic2l0ZURhdGFUeXBlc10gbW9kaWZpZWRTaW5jZTpbTlNEYXRlIGRpc3RhbnRQ YXN0XSBjb21wbGV0aW9uSGFuZGxlcjpeKCkgewo=