<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199984</bug_id>
          
          <creation_ts>2019-07-20 18:42:55 -0700</creation_ts>
          <short_desc>Legacy numeric literals should not permit separators or BigInt</short_desc>
          <delta_ts>2019-07-29 14:35:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=196351</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=179000</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=200244</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ross Kirsling">ross.kirsling</reporter>
          <assigned_to name="Ross Kirsling">ross.kirsling</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>leo</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1554554</commentid>
    <comment_count>0</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2019-07-20 18:42:55 -0700</bug_when>
    <thetext>Legacy numeric literals should not permit separators or BigInt</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554555</commentid>
    <comment_count>1</comment_count>
      <attachid>374564</attachid>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2019-07-20 18:43:30 -0700</bug_when>
    <thetext>Created attachment 374564
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554556</commentid>
    <comment_count>2</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2019-07-20 18:47:21 -0700</bug_when>
    <thetext>An easily-overlooked piece of the spec -- Test262 cases were added for separators yesterday (https://github.com/tc39/test262/pull/2245) but I think they&apos;re still needed for BigInt.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1554820</commentid>
    <comment_count>3</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2019-07-22 13:27:00 -0700</bug_when>
    <thetext>(In reply to Ross Kirsling from comment #2)
&gt; An easily-overlooked piece of the spec -- Test262 cases were added for
&gt; separators yesterday (https://github.com/tc39/test262/pull/2245) but I think
&gt; they&apos;re still needed for BigInt.

The rest of the test cases are in https://github.com/tc39/test262/pull/2253 (with additional BigInt + separator ones in https://github.com/tc39/test262/pull/2252).

One way or another, the key is that neither proposal is meant to add to Annex B.1.1&apos;s LegacyOctalIntegerLiteral and NonOctalDecimalIntegerLiteral.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555145</commentid>
    <comment_count>4</comment_count>
      <attachid>374564</attachid>
    <who name="Caio Lima">ticaiolima</who>
    <bug_when>2019-07-23 14:25:14 -0700</bug_when>
    <thetext>Comment on attachment 374564
Patch

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555831</commentid>
    <comment_count>5</comment_count>
      <attachid>374564</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-07-25 10:37:40 -0700</bug_when>
    <thetext>Comment on attachment 374564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374564&amp;action=review

r=me.

&gt; Source/JavaScriptCore/parser/Lexer.cpp:1628
&gt; +    bool isLegacyLiteral = m_buffer8.size();

For clarity can you add:

ASSERT(!m_buffer8.size() || (m_buffer8.size() == 1 &amp;&amp; m_buffer[0] == &apos;0&apos;));</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555832</commentid>
    <comment_count>6</comment_count>
      <attachid>374564</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-07-25 10:38:52 -0700</bug_when>
    <thetext>Comment on attachment 374564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374564&amp;action=review

&gt; JSTests/stress/numeric-literal-separators.js:75
&gt; +shouldThrow(&apos;010000000000_1&apos;, SyntaxError);
&gt; +shouldThrow(&apos;010000000000_9&apos;, SyntaxError);
&gt; +shouldThrow(&apos;090000000000_1&apos;, SyntaxError);

Can you add tests for 0100_004 and 0_000 etc?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555878</commentid>
    <comment_count>7</comment_count>
      <attachid>374900</attachid>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2019-07-25 13:19:59 -0700</bug_when>
    <thetext>Created attachment 374900
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555968</commentid>
    <comment_count>8</comment_count>
      <attachid>374900</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-25 16:55:51 -0700</bug_when>
    <thetext>Comment on attachment 374900
Patch for landing

Clearing flags on attachment: 374900

Committed r247845: &lt;https://trac.webkit.org/changeset/247845&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555969</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-25 16:55:53 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1555972</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-07-25 16:58:30 -0700</bug_when>
    <thetext>&lt;rdar://problem/53566528&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>374564</attachid>
            <date>2019-07-20 18:43:30 -0700</date>
            <delta_ts>2019-07-25 13:19:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199984-20190720184329.patch</filename>
            <type>text/plain</type>
            <size>6374</size>
            <attacher name="Ross Kirsling">ross.kirsling</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1
ZTc5MDIxODcxYWIzZmM5Yzg5MTkyNTEwYmZmYTY0N2Q4ZjE3ZjMyLi4yMmZhOTAxM2U0Y2JjNjQw
OWQ2OWM2NjMxZGIxYjM2ZWY1MTdlODhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOS0wNy0yMCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u
eS5jb20+CisKKyAgICAgICAgTGVnYWN5IG51bWVyaWMgbGl0ZXJhbHMgc2hvdWxkIG5vdCBwZXJt
aXQgc2VwYXJhdG9ycyBvciBCaWdJbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTE5OTk4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogcGFyc2VyL0xleGVyLmNwcDoKKyAgICAgICAgKEpTQzo6TGV4ZXI8
VD46OnBhcnNlT2N0YWwpOgorICAgICAgICAoSlNDOjpMZXhlcjxUPjo6cGFyc2VEZWNpbWFsKToK
KwogMjAxOS0wNy0xNyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAg
ICAgIERpc2FibGUgUG9pbnRlciBFdmVudHMgcHJpb3IgdG8gd2F0Y2hPUyA2CmRpZmYgLS1naXQg
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcCBiL1NvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCmluZGV4IDQ2NjJjNTRmMmEwNTM2NDYyYWU3MmUwZGQ3
NzMwMWUwY2VlOTlkNDQuLmU4Y2Q0NzU1ZmE1NGQzZDE2YTgxNTE2MzUwNGEyZGI0YzkzZjA0N2Eg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCisrKyBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCkBAIC0xNjI1LDYgKzE2MjUs
NyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KIEFMV0FZU19JTkxJTkUgYXV0byBMZXhlcjxUPjo6
cGFyc2VPY3RhbCgpIC0+IE9wdGlvbmFsPE51bWJlclBhcnNlUmVzdWx0PgogewogICAgIEFTU0VS
VChpc0FTQ0lJT2N0YWxEaWdpdChtX2N1cnJlbnQpKTsKKyAgICBib29sIGlzTGVnYWN5TGl0ZXJh
bCA9IG1fYnVmZmVyOC5zaXplKCk7CiAKICAgICAvLyBPcHRpbWl6YXRpb246IG1vc3Qgb2N0YWwg
dmFsdWVzIGZpdCBpbnRvIDQgYnl0ZXMuCiAgICAgdWludDMyX3Qgb2N0YWxWYWx1ZSA9IDA7CkBA
IC0xNjM2LDcgKzE2MzcsNyBAQCBBTFdBWVNfSU5MSU5FIGF1dG8gTGV4ZXI8VD46OnBhcnNlT2N0
YWwoKSAtPiBPcHRpb25hbDxOdW1iZXJQYXJzZVJlc3VsdD4KIAogICAgIGRvIHsKICAgICAgICAg
aWYgKG1fY3VycmVudCA9PSAnXycpIHsKLSAgICAgICAgICAgIGlmIChVTkxJS0VMWSghaXNBU0NJ
SU9jdGFsRGlnaXQocGVlaygxKSkpKQorICAgICAgICAgICAgaWYgKFVOTElLRUxZKCFpc0FTQ0lJ
T2N0YWxEaWdpdChwZWVrKDEpKSB8fCBpc0xlZ2FjeUxpdGVyYWwpKQogICAgICAgICAgICAgICAg
IHJldHVybiBXVEY6Om51bGxvcHQ7CiAKICAgICAgICAgICAgIHNoaWZ0KCk7CkBAIC0xNjU2LDcg
KzE2NTcsNyBAQCBBTFdBWVNfSU5MSU5FIGF1dG8gTGV4ZXI8VD46OnBhcnNlT2N0YWwoKSAtPiBP
cHRpb25hbDxOdW1iZXJQYXJzZVJlc3VsdD4KIAogICAgIHdoaWxlIChpc0FTQ0lJT2N0YWxEaWdp
dE9yU2VwYXJhdG9yKG1fY3VycmVudCkpIHsKICAgICAgICAgaWYgKG1fY3VycmVudCA9PSAnXycp
IHsKLSAgICAgICAgICAgIGlmIChVTkxJS0VMWSghaXNBU0NJSU9jdGFsRGlnaXQocGVlaygxKSkp
KQorICAgICAgICAgICAgaWYgKFVOTElLRUxZKCFpc0FTQ0lJT2N0YWxEaWdpdChwZWVrKDEpKSB8
fCBpc0xlZ2FjeUxpdGVyYWwpKQogICAgICAgICAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7
CiAKICAgICAgICAgICAgIHNoaWZ0KCk7CkBAIC0xNjY2LDcgKzE2NjcsNyBAQCBBTFdBWVNfSU5M
SU5FIGF1dG8gTGV4ZXI8VD46OnBhcnNlT2N0YWwoKSAtPiBPcHRpb25hbDxOdW1iZXJQYXJzZVJl
c3VsdD4KICAgICAgICAgc2hpZnQoKTsKICAgICB9CiAKLSAgICBpZiAoVU5MSUtFTFkoT3B0aW9u
czo6dXNlQmlnSW50KCkgJiYgbV9jdXJyZW50ID09ICduJykpCisgICAgaWYgKFVOTElLRUxZKE9w
dGlvbnM6OnVzZUJpZ0ludCgpICYmIG1fY3VycmVudCA9PSAnbicpICYmICFpc0xlZ2FjeUxpdGVy
YWwpCiAgICAgICAgIHJldHVybiBOdW1iZXJQYXJzZVJlc3VsdCB7IG1ha2VJZGVudGlmaWVyKG1f
YnVmZmVyOC5kYXRhKCksIG1fYnVmZmVyOC5zaXplKCkpIH07CiAKICAgICBpZiAoaXNBU0NJSURp
Z2l0KG1fY3VycmVudCkpCkBAIC0xNjc5LDYgKzE2ODAsNyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUg
VD4KIEFMV0FZU19JTkxJTkUgYXV0byBMZXhlcjxUPjo6cGFyc2VEZWNpbWFsKCkgLT4gT3B0aW9u
YWw8TnVtYmVyUGFyc2VSZXN1bHQ+CiB7CiAgICAgQVNTRVJUKGlzQVNDSUlEaWdpdChtX2N1cnJl
bnQpIHx8IG1fYnVmZmVyOC5zaXplKCkpOworICAgIGJvb2wgaXNMZWdhY3lMaXRlcmFsID0gbV9i
dWZmZXI4LnNpemUoKSAmJiBpc0FTQ0lJRGlnaXRPclNlcGFyYXRvcihtX2N1cnJlbnQpOwogCiAg
ICAgLy8gT3B0aW1pemF0aW9uOiBtb3N0IGRlY2ltYWwgdmFsdWVzIGZpdCBpbnRvIDQgYnl0ZXMu
CiAgICAgdWludDMyX3QgZGVjaW1hbFZhbHVlID0gMDsKQEAgLTE2OTQsNyArMTY5Niw3IEBAIEFM
V0FZU19JTkxJTkUgYXV0byBMZXhlcjxUPjo6cGFyc2VEZWNpbWFsKCkgLT4gT3B0aW9uYWw8TnVt
YmVyUGFyc2VSZXN1bHQ+CiAKICAgICAgICAgZG8gewogICAgICAgICAgICAgaWYgKG1fY3VycmVu
dCA9PSAnXycpIHsKLSAgICAgICAgICAgICAgICBpZiAoVU5MSUtFTFkoIWlzQVNDSUlEaWdpdChw
ZWVrKDEpKSkpCisgICAgICAgICAgICAgICAgaWYgKFVOTElLRUxZKCFpc0FTQ0lJRGlnaXQocGVl
aygxKSkgfHwgaXNMZWdhY3lMaXRlcmFsKSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFdU
Rjo6bnVsbG9wdDsKIAogICAgICAgICAgICAgICAgIHNoaWZ0KCk7CkBAIC0xNzE1LDcgKzE3MTcs
NyBAQCBBTFdBWVNfSU5MSU5FIGF1dG8gTGV4ZXI8VD46OnBhcnNlRGVjaW1hbCgpIC0+IE9wdGlv
bmFsPE51bWJlclBhcnNlUmVzdWx0PgogCiAgICAgd2hpbGUgKGlzQVNDSUlEaWdpdE9yU2VwYXJh
dG9yKG1fY3VycmVudCkpIHsKICAgICAgICAgaWYgKG1fY3VycmVudCA9PSAnXycpIHsKLSAgICAg
ICAgICAgIGlmIChVTkxJS0VMWSghaXNBU0NJSURpZ2l0KHBlZWsoMSkpKSkKKyAgICAgICAgICAg
IGlmIChVTkxJS0VMWSghaXNBU0NJSURpZ2l0KHBlZWsoMSkpIHx8IGlzTGVnYWN5TGl0ZXJhbCkp
CiAgICAgICAgICAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKIAogICAgICAgICAgICAgc2hp
ZnQoKTsKQEAgLTE3MjUsNyArMTcyNyw3IEBAIEFMV0FZU19JTkxJTkUgYXV0byBMZXhlcjxUPjo6
cGFyc2VEZWNpbWFsKCkgLT4gT3B0aW9uYWw8TnVtYmVyUGFyc2VSZXN1bHQ+CiAgICAgICAgIHNo
aWZ0KCk7CiAgICAgfQogICAgIAotICAgIGlmIChVTkxJS0VMWShPcHRpb25zOjp1c2VCaWdJbnQo
KSAmJiBtX2N1cnJlbnQgPT0gJ24nKSkKKyAgICBpZiAoVU5MSUtFTFkoT3B0aW9uczo6dXNlQmln
SW50KCkgJiYgbV9jdXJyZW50ID09ICduJyAmJiAhaXNMZWdhY3lMaXRlcmFsKSkKICAgICAgICAg
cmV0dXJuIE51bWJlclBhcnNlUmVzdWx0IHsgbWFrZUlkZW50aWZpZXIobV9idWZmZXI4LmRhdGEo
KSwgbV9idWZmZXI4LnNpemUoKSkgfTsKIAogICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CmRpZmYg
LS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJmM2Rl
OWMwMDg1NmUyYzdiZDg0NGEzZjE0MjYxNDJkNzJjN2MwZTQuLjcyZjFlNTBjMTRjZDY5NGEzNTdi
MjQyZTkzNDU0ZmUxN2NhNDE3YjQgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBi
L0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDctMjAgIFJvc3MgS2ly
c2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgorCisgICAgICAgIExlZ2FjeSBudW1lcmlj
IGxpdGVyYWxzIHNob3VsZCBub3QgcGVybWl0IHNlcGFyYXRvcnMgb3IgQmlnSW50CisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk5ODQKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9iaWctaW50
LWxpdGVyYWxzLmpzOgorICAgICAgICAqIHN0cmVzcy9udW1lcmljLWxpdGVyYWwtc2VwYXJhdG9y
cy5qczoKKwogMjAxOS0wNy0xNiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAg
ICAgICAgQXJndW1lbnRzRWxpbWluYXRpb25QaGFzZSBzaG91bGQgaW5zZXJ0IEtpbGxTdGFjayBu
b2RlcyBiZWZvcmUgUHV0U3RhY2sgbm9kZXMgdGhhdCBpdCBhZGRzLgpkaWZmIC0tZ2l0IGEvSlNU
ZXN0cy9zdHJlc3MvYmlnLWludC1saXRlcmFscy5qcyBiL0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQt
bGl0ZXJhbHMuanMKaW5kZXggNTQ5NTdlOGY5ODg5YzNkMDA2NDdmZTg3ZTMyMWJhMWNjNjE5Yzhl
Yy4uMmMyMzI3YzhmYWJmYmFhYjIzOTA1YTQ3Y2UzZmI1YWZkMzBlMDVmNCAxMDA2NDQKLS0tIGEv
SlNUZXN0cy9zdHJlc3MvYmlnLWludC1saXRlcmFscy5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9i
aWctaW50LWxpdGVyYWxzLmpzCkBAIC0xOCw5ICsxOCw2IEBAIGZ1bmN0aW9uIGFzc2VydFRocm93
U3ludGF4RXJyb3IoaW5wdXQpIHsKIGxldCBuID0gMG47CiBhc3NlcnQobiA9PT0gMG4pOwogCi1u
ID0gMDBuOwotYXNzZXJ0KG4gPT09IDBuKTsKLQogLy8gQmluYXJ5IHJlcHJlc2VudGF0aW9uCiAK
IG4gPSAwYjExMTFuOwpAQCAtMTA1LDMgKzEwMiw2IEBAIGFzc2VydFRocm93U3ludGF4RXJyb3Io
IjEwMG5uIik7CiBhc3NlcnRUaHJvd1N5bnRheEVycm9yKCIxYTBubiIpOwogYXNzZXJ0VGhyb3dT
eW50YXhFcnJvcigiMTBFMjBuIik7CiBhc3NlcnRUaHJvd1N5bnRheEVycm9yKCItLTEwbiIpOwor
YXNzZXJ0VGhyb3dTeW50YXhFcnJvcigiMDBuIik7Cithc3NlcnRUaHJvd1N5bnRheEVycm9yKCIw
MW4iKTsKK2Fzc2VydFRocm93U3ludGF4RXJyb3IoIjA5biIpOwpkaWZmIC0tZ2l0IGEvSlNUZXN0
cy9zdHJlc3MvbnVtZXJpYy1saXRlcmFsLXNlcGFyYXRvcnMuanMgYi9KU1Rlc3RzL3N0cmVzcy9u
dW1lcmljLWxpdGVyYWwtc2VwYXJhdG9ycy5qcwppbmRleCA1MWI0MDYzODlkNTRiMDczYzQyMGJh
M2E0OWFlZmNkNjNlYjg5YzM3Li5lMWE4NDZlMzVjNmIwOGQ1ZTNiMjk1ZTA5ZWJlY2I2MjE3YWMz
NTkyIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9udW1lcmljLWxpdGVyYWwtc2VwYXJhdG9y
cy5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9udW1lcmljLWxpdGVyYWwtc2VwYXJhdG9ycy5qcwpA
QCAtNTksNiArNTksOSBAQCBzaG91bGRUaHJvdygnMG9fMScsIFN5bnRheEVycm9yKTsKIHNob3Vs
ZFRocm93KCcwbzFfJywgU3ludGF4RXJyb3IpOwogc2hvdWxkVGhyb3coJzBvMV9fMScsIFN5bnRh
eEVycm9yKTsKIHNob3VsZFRocm93KCcwXzEnLCBTeW50YXhFcnJvcik7CitzaG91bGRUaHJvdygn
MDFfMScsIFN5bnRheEVycm9yKTsKK3Nob3VsZFRocm93KCcwMV85JywgU3ludGF4RXJyb3IpOwor
c2hvdWxkVGhyb3coJzA5XzEnLCBTeW50YXhFcnJvcik7CiBzaG91bGRUaHJvdygnMTAwMDAwMDAw
MDBfJywgU3ludGF4RXJyb3IpOwogc2hvdWxkVGhyb3coJzEwMDAwMDAwMDAwX18wJywgU3ludGF4
RXJyb3IpOwogc2hvdWxkVGhyb3coJzB4MTAwMDAwMDAwXycsIFN5bnRheEVycm9yKTsKQEAgLTY3
LDYgKzcwLDkgQEAgc2hvdWxkVGhyb3coJzBiMTAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwXycsIFN5bnRheEVycm9yKTsKIHNob3VsZFRocm93KCcwYjEwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMF9fMCcsIFN5bnRheEVycm9yKTsKIHNob3VsZFRocm93KCcwbzEwMDAwMDAw
MDAwXycsIFN5bnRheEVycm9yKTsKIHNob3VsZFRocm93KCcwbzEwMDAwMDAwMDAwX18wJywgU3lu
dGF4RXJyb3IpOworc2hvdWxkVGhyb3coJzAxMDAwMDAwMDAwMF8xJywgU3ludGF4RXJyb3IpOwor
c2hvdWxkVGhyb3coJzAxMDAwMDAwMDAwMF85JywgU3ludGF4RXJyb3IpOworc2hvdWxkVGhyb3co
JzA5MDAwMDAwMDAwMF8xJywgU3ludGF4RXJyb3IpOwogCiBzaG91bGRUaHJvdygnMV9uJywgU3lu
dGF4RXJyb3IpOwogc2hvdWxkVGhyb3coJzB4MV9uJywgU3ludGF4RXJyb3IpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>374900</attachid>
            <date>2019-07-25 13:19:59 -0700</date>
            <delta_ts>2019-07-25 16:55:51 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-199984-20190725131956.patch</filename>
            <type>text/plain</type>
            <size>6087</size>
            <attacher name="Ross Kirsling">ross.kirsling</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw
MGQ4ZWE5NDVmNzhmZTEwZDllYTNjOTZkNDFjYWJhZjZjMjYyY2YzLi5mM2IyMTBiYjA4NTcwYzQy
NjQzMDE4NTMyZWQ5OTFmMzJkNzVkMWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOS0wNy0yNSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u
eS5jb20+CisKKyAgICAgICAgTGVnYWN5IG51bWVyaWMgbGl0ZXJhbHMgc2hvdWxkIG5vdCBwZXJt
aXQgc2VwYXJhdG9ycyBvciBCaWdJbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTE5OTk4NAorCisgICAgICAgIFJldmlld2VkIGJ5IEtlaXRoIE1pbGxl
ci4KKworICAgICAgICAqIHBhcnNlci9MZXhlci5jcHA6CisgICAgICAgIChKU0M6OkxleGVyPFQ+
OjpwYXJzZU9jdGFsKToKKyAgICAgICAgKEpTQzo6TGV4ZXI8VD46OnBhcnNlRGVjaW1hbCk6CisK
IDIwMTktMDctMjUgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAg
ICAgICAgIFtFU05leHRdIEltcGxlbWVudCBudWxsaXNoIGNvYWxlc2NpbmcKZGlmZiAtLWdpdCBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwIGIvU291cmNlL0phdmFTY3Jp
cHRDb3JlL3BhcnNlci9MZXhlci5jcHAKaW5kZXggMTZiZmE4YTI0N2IzZjBiYjQ2NWE1NzYzZDg3
NWYyNmUxNGFjMjZlNy4uZTk4Y2RiNWU1OWUyMzA3MmMxOTAxOGY4N2QxMGMyZDQ1MmQ5Y2QzOSAx
MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAKKysrIGIv
U291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAKQEAgLTE2MjUsNiArMTYyNSw4
IEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBUPgogQUxXQVlTX0lOTElORSBhdXRvIExleGVyPFQ+Ojpw
YXJzZU9jdGFsKCkgLT4gT3B0aW9uYWw8TnVtYmVyUGFyc2VSZXN1bHQ+CiB7CiAgICAgQVNTRVJU
KGlzQVNDSUlPY3RhbERpZ2l0KG1fY3VycmVudCkpOworICAgIEFTU0VSVCghbV9idWZmZXI4LnNp
emUoKSB8fCAobV9idWZmZXI4LnNpemUoKSA9PSAxICYmIG1fYnVmZmVyOFswXSA9PSAnMCcpKTsK
KyAgICBib29sIGlzTGVnYWN5TGl0ZXJhbCA9IG1fYnVmZmVyOC5zaXplKCk7CiAKICAgICAvLyBP
cHRpbWl6YXRpb246IG1vc3Qgb2N0YWwgdmFsdWVzIGZpdCBpbnRvIDQgYnl0ZXMuCiAgICAgdWlu
dDMyX3Qgb2N0YWxWYWx1ZSA9IDA7CkBAIC0xNjM2LDcgKzE2MzgsNyBAQCBBTFdBWVNfSU5MSU5F
IGF1dG8gTGV4ZXI8VD46OnBhcnNlT2N0YWwoKSAtPiBPcHRpb25hbDxOdW1iZXJQYXJzZVJlc3Vs
dD4KIAogICAgIGRvIHsKICAgICAgICAgaWYgKG1fY3VycmVudCA9PSAnXycpIHsKLSAgICAgICAg
ICAgIGlmIChVTkxJS0VMWSghaXNBU0NJSU9jdGFsRGlnaXQocGVlaygxKSkpKQorICAgICAgICAg
ICAgaWYgKFVOTElLRUxZKCFpc0FTQ0lJT2N0YWxEaWdpdChwZWVrKDEpKSB8fCBpc0xlZ2FjeUxp
dGVyYWwpKQogICAgICAgICAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAKICAgICAgICAg
ICAgIHNoaWZ0KCk7CkBAIC0xNjU2LDcgKzE2NTgsNyBAQCBBTFdBWVNfSU5MSU5FIGF1dG8gTGV4
ZXI8VD46OnBhcnNlT2N0YWwoKSAtPiBPcHRpb25hbDxOdW1iZXJQYXJzZVJlc3VsdD4KIAogICAg
IHdoaWxlIChpc0FTQ0lJT2N0YWxEaWdpdE9yU2VwYXJhdG9yKG1fY3VycmVudCkpIHsKICAgICAg
ICAgaWYgKG1fY3VycmVudCA9PSAnXycpIHsKLSAgICAgICAgICAgIGlmIChVTkxJS0VMWSghaXNB
U0NJSU9jdGFsRGlnaXQocGVlaygxKSkpKQorICAgICAgICAgICAgaWYgKFVOTElLRUxZKCFpc0FT
Q0lJT2N0YWxEaWdpdChwZWVrKDEpKSB8fCBpc0xlZ2FjeUxpdGVyYWwpKQogICAgICAgICAgICAg
ICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAKICAgICAgICAgICAgIHNoaWZ0KCk7CkBAIC0xNjY2
LDcgKzE2NjgsNyBAQCBBTFdBWVNfSU5MSU5FIGF1dG8gTGV4ZXI8VD46OnBhcnNlT2N0YWwoKSAt
PiBPcHRpb25hbDxOdW1iZXJQYXJzZVJlc3VsdD4KICAgICAgICAgc2hpZnQoKTsKICAgICB9CiAK
LSAgICBpZiAoVU5MSUtFTFkoT3B0aW9uczo6dXNlQmlnSW50KCkgJiYgbV9jdXJyZW50ID09ICdu
JykpCisgICAgaWYgKFVOTElLRUxZKE9wdGlvbnM6OnVzZUJpZ0ludCgpICYmIG1fY3VycmVudCA9
PSAnbicpICYmICFpc0xlZ2FjeUxpdGVyYWwpCiAgICAgICAgIHJldHVybiBOdW1iZXJQYXJzZVJl
c3VsdCB7IG1ha2VJZGVudGlmaWVyKG1fYnVmZmVyOC5kYXRhKCksIG1fYnVmZmVyOC5zaXplKCkp
IH07CiAKICAgICBpZiAoaXNBU0NJSURpZ2l0KG1fY3VycmVudCkpCkBAIC0xNjc5LDYgKzE2ODEs
NyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KIEFMV0FZU19JTkxJTkUgYXV0byBMZXhlcjxUPjo6
cGFyc2VEZWNpbWFsKCkgLT4gT3B0aW9uYWw8TnVtYmVyUGFyc2VSZXN1bHQ+CiB7CiAgICAgQVNT
RVJUKGlzQVNDSUlEaWdpdChtX2N1cnJlbnQpIHx8IG1fYnVmZmVyOC5zaXplKCkpOworICAgIGJv
b2wgaXNMZWdhY3lMaXRlcmFsID0gbV9idWZmZXI4LnNpemUoKSAmJiBpc0FTQ0lJRGlnaXRPclNl
cGFyYXRvcihtX2N1cnJlbnQpOwogCiAgICAgLy8gT3B0aW1pemF0aW9uOiBtb3N0IGRlY2ltYWwg
dmFsdWVzIGZpdCBpbnRvIDQgYnl0ZXMuCiAgICAgdWludDMyX3QgZGVjaW1hbFZhbHVlID0gMDsK
QEAgLTE2OTQsNyArMTY5Nyw3IEBAIEFMV0FZU19JTkxJTkUgYXV0byBMZXhlcjxUPjo6cGFyc2VE
ZWNpbWFsKCkgLT4gT3B0aW9uYWw8TnVtYmVyUGFyc2VSZXN1bHQ+CiAKICAgICAgICAgZG8gewog
ICAgICAgICAgICAgaWYgKG1fY3VycmVudCA9PSAnXycpIHsKLSAgICAgICAgICAgICAgICBpZiAo
VU5MSUtFTFkoIWlzQVNDSUlEaWdpdChwZWVrKDEpKSkpCisgICAgICAgICAgICAgICAgaWYgKFVO
TElLRUxZKCFpc0FTQ0lJRGlnaXQocGVlaygxKSkgfHwgaXNMZWdhY3lMaXRlcmFsKSkKICAgICAg
ICAgICAgICAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKIAogICAgICAgICAgICAgICAgIHNo
aWZ0KCk7CkBAIC0xNzE1LDcgKzE3MTgsNyBAQCBBTFdBWVNfSU5MSU5FIGF1dG8gTGV4ZXI8VD46
OnBhcnNlRGVjaW1hbCgpIC0+IE9wdGlvbmFsPE51bWJlclBhcnNlUmVzdWx0PgogCiAgICAgd2hp
bGUgKGlzQVNDSUlEaWdpdE9yU2VwYXJhdG9yKG1fY3VycmVudCkpIHsKICAgICAgICAgaWYgKG1f
Y3VycmVudCA9PSAnXycpIHsKLSAgICAgICAgICAgIGlmIChVTkxJS0VMWSghaXNBU0NJSURpZ2l0
KHBlZWsoMSkpKSkKKyAgICAgICAgICAgIGlmIChVTkxJS0VMWSghaXNBU0NJSURpZ2l0KHBlZWso
MSkpIHx8IGlzTGVnYWN5TGl0ZXJhbCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIFdURjo6bnVs
bG9wdDsKIAogICAgICAgICAgICAgc2hpZnQoKTsKQEAgLTE3MjUsNyArMTcyOCw3IEBAIEFMV0FZ
U19JTkxJTkUgYXV0byBMZXhlcjxUPjo6cGFyc2VEZWNpbWFsKCkgLT4gT3B0aW9uYWw8TnVtYmVy
UGFyc2VSZXN1bHQ+CiAgICAgICAgIHNoaWZ0KCk7CiAgICAgfQogICAgIAotICAgIGlmIChVTkxJ
S0VMWShPcHRpb25zOjp1c2VCaWdJbnQoKSAmJiBtX2N1cnJlbnQgPT0gJ24nKSkKKyAgICBpZiAo
VU5MSUtFTFkoT3B0aW9uczo6dXNlQmlnSW50KCkgJiYgbV9jdXJyZW50ID09ICduJyAmJiAhaXNM
ZWdhY3lMaXRlcmFsKSkKICAgICAgICAgcmV0dXJuIE51bWJlclBhcnNlUmVzdWx0IHsgbWFrZUlk
ZW50aWZpZXIobV9idWZmZXI4LmRhdGEoKSwgbV9idWZmZXI4LnNpemUoKSkgfTsKIAogICAgIHJl
dHVybiBXVEY6Om51bGxvcHQ7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVz
dHMvQ2hhbmdlTG9nCmluZGV4IGQ4ODcyMWUxNjg3YjYxMTVlZjcwOTk3MWJiNTlkZWMwN2E5NTIx
YzQuLjA0ZDAxMWFkODFiMmI5YWU5NTQwYjdjMzAxMTY2NzFhY2QzMmJkYWMgMTAwNjQ0Ci0tLSBh
L0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMTktMDctMjUgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgor
CisgICAgICAgIExlZ2FjeSBudW1lcmljIGxpdGVyYWxzIHNob3VsZCBub3QgcGVybWl0IHNlcGFy
YXRvcnMgb3IgQmlnSW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xOTk5ODQKKworICAgICAgICBSZXZpZXdlZCBieSBLZWl0aCBNaWxsZXIuCisKKyAg
ICAgICAgKiBzdHJlc3MvYmlnLWludC1saXRlcmFscy5qczoKKyAgICAgICAgKiBzdHJlc3MvbnVt
ZXJpYy1saXRlcmFsLXNlcGFyYXRvcnMuanM6CisKIDIwMTktMDctMjUgIFJvc3MgS2lyc2xpbmcg
IDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFtFU05leHRdIEltcGxlbWVudCBu
dWxsaXNoIGNvYWxlc2NpbmcKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQtbGl0
ZXJhbHMuanMgYi9KU1Rlc3RzL3N0cmVzcy9iaWctaW50LWxpdGVyYWxzLmpzCmluZGV4IDU0OTU3
ZThmOTg4OWMzZDAwNjQ3ZmU4N2UzMjFiYTFjYzYxOWM4ZWMuLjJjMjMyN2M4ZmFiZmJhYWIyMzkw
NWE0N2NlM2ZiNWFmZDMwZTA1ZjQgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQt
bGl0ZXJhbHMuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvYmlnLWludC1saXRlcmFscy5qcwpAQCAt
MTgsOSArMTgsNiBAQCBmdW5jdGlvbiBhc3NlcnRUaHJvd1N5bnRheEVycm9yKGlucHV0KSB7CiBs
ZXQgbiA9IDBuOwogYXNzZXJ0KG4gPT09IDBuKTsKIAotbiA9IDAwbjsKLWFzc2VydChuID09PSAw
bik7Ci0KIC8vIEJpbmFyeSByZXByZXNlbnRhdGlvbgogCiBuID0gMGIxMTExbjsKQEAgLTEwNSwz
ICsxMDIsNiBAQCBhc3NlcnRUaHJvd1N5bnRheEVycm9yKCIxMDBubiIpOwogYXNzZXJ0VGhyb3dT
eW50YXhFcnJvcigiMWEwbm4iKTsKIGFzc2VydFRocm93U3ludGF4RXJyb3IoIjEwRTIwbiIpOwog
YXNzZXJ0VGhyb3dTeW50YXhFcnJvcigiLS0xMG4iKTsKK2Fzc2VydFRocm93U3ludGF4RXJyb3Io
IjAwbiIpOworYXNzZXJ0VGhyb3dTeW50YXhFcnJvcigiMDFuIik7Cithc3NlcnRUaHJvd1N5bnRh
eEVycm9yKCIwOW4iKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL251bWVyaWMtbGl0ZXJh
bC1zZXBhcmF0b3JzLmpzIGIvSlNUZXN0cy9zdHJlc3MvbnVtZXJpYy1saXRlcmFsLXNlcGFyYXRv
cnMuanMKaW5kZXggNTFiNDA2Mzg5ZDU0YjA3M2M0MjBiYTNhNDlhZWZjZDYzZWI4OWMzNy4uZDg5
ZDExZDZkYzQ3Y2EyOWE5M2YyNjM4MDY1NWMzOTZmZmFiNDNjOSAxMDA2NDQKLS0tIGEvSlNUZXN0
cy9zdHJlc3MvbnVtZXJpYy1saXRlcmFsLXNlcGFyYXRvcnMuanMKKysrIGIvSlNUZXN0cy9zdHJl
c3MvbnVtZXJpYy1saXRlcmFsLXNlcGFyYXRvcnMuanMKQEAgLTk0LDMgKzk0LDEzIEBAIHNob3Vs
ZFRocm93KCcxZSsyX18yJywgU3ludGF4RXJyb3IpOwogc2hvdWxkVGhyb3coJzFlLV8yJywgU3lu
dGF4RXJyb3IpOwogc2hvdWxkVGhyb3coJzFlLTJfJywgU3ludGF4RXJyb3IpOwogc2hvdWxkVGhy
b3coJzFlLTJfXzInLCBTeW50YXhFcnJvcik7CisKK3Nob3VsZFRocm93KCcwMV8xJywgU3ludGF4
RXJyb3IpOworc2hvdWxkVGhyb3coJzAxXzknLCBTeW50YXhFcnJvcik7CitzaG91bGRUaHJvdygn
MDlfMScsIFN5bnRheEVycm9yKTsKK3Nob3VsZFRocm93KCcwMTAwXzAwMScsIFN5bnRheEVycm9y
KTsKK3Nob3VsZFRocm93KCcwMTAwXzAwOScsIFN5bnRheEVycm9yKTsKK3Nob3VsZFRocm93KCcw
OTAwXzAwMScsIFN5bnRheEVycm9yKTsKK3Nob3VsZFRocm93KCcwMTAwMDAwMDAwMDBfMScsIFN5
bnRheEVycm9yKTsKK3Nob3VsZFRocm93KCcwMTAwMDAwMDAwMDBfOScsIFN5bnRheEVycm9yKTsK
K3Nob3VsZFRocm93KCcwOTAwMDAwMDAwMDBfMScsIFN5bnRheEVycm9yKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>