199907 2019-07-18 08:00:52 -0700 Crash under WebPage::boundaryEventOccurred 2019-07-18 14:56:34 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham cdumez cfleizach commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1553903 0 pvollan 2019-07-18 08:00:52 -0700 A nullptr check is needed in this method. 1553904 1 374384 pvollan 2019-07-18 08:02:19 -0700 Created attachment 374384 Patch 1553905 2 pvollan 2019-07-18 08:06:41 -0700 rdar://problem/53189800 1553906 3 374384 ggaren 2019-07-18 08:20:44 -0700 Comment on attachment 374384 Patch Under what conditions can corePage() be null? I don't see anything that would ever clear it (except for the WebPage destructor). If the error here is use after free of WebPage, I think we need a different fix. 1553910 4 374386 pvollan 2019-07-18 08:40:50 -0700 Created attachment 374386 Patch 1553911 5 374384 cdumez 2019-07-18 08:40:58 -0700 Comment on attachment 374384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374384&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:6600 > + if (!corePage() || !corePage()->speechSynthesisClient()) I agree with Geoff, I do not see how corePage() can be null unless we're in the WebPage destructor. Can you also clarify how Page::speechSynthesisClient() can return null here? It never seems to get nulled out inside Page, and it seems to get initialized unconditionally (as long as ENABLED(SPEECH_SYNTHESIS)): #if ENABLE(SPEECH_SYNTHESIS) pageConfiguration.speechSynthesisClient = std::make_unique<WebSpeechSynthesisClient>(*this); #endif 1553912 6 374386 cdumez 2019-07-18 08:41:12 -0700 Comment on attachment 374386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374386&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:6600 > + if (!corePage()->speechSynthesisClient()) Please see my comment on the previous patch. 1553919 7 pvollan 2019-07-18 08:53:44 -0700 (In reply to Chris Dumez from comment #6) > Comment on attachment 374386 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374386&action=review > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:6600 > > + if (!corePage()->speechSynthesisClient()) > > Please see my comment on the previous patch. Yes, I believe you are right. The reason for the crash is probably that m_currentSpeechUtterance in SpeechSynthesis is null. I will update the patch. Thanks for reviewing, everybody! 1553920 8 cdumez 2019-07-18 08:54:48 -0700 (In reply to Per Arne Vollan from comment #7) > (In reply to Chris Dumez from comment #6) > > Comment on attachment 374386 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=374386&action=review > > > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:6600 > > > + if (!corePage()->speechSynthesisClient()) > > > > Please see my comment on the previous patch. > > Yes, I believe you are right. The reason for the crash is probably that > m_currentSpeechUtterance in SpeechSynthesis is null. I will update the patch. This is what I said on the radar yesterday :) > > Thanks for reviewing, everybody! 1553932 9 374386 bfulgham 2019-07-18 09:48:38 -0700 Comment on attachment 374386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374386&action=review >>>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6600 >>>> + if (!corePage()->speechSynthesisClient()) >>> >>> Please see my comment on the previous patch. >> >> Yes, I believe you are right. The reason for the crash is probably that m_currentSpeechUtterance in SpeechSynthesis is null. I will update the patch. >> >> Thanks for reviewing, everybody! > > This is what I said on the radar yesterday :) We do seem to have other cases where corePage() is nullptr checked, but perhaps those checks should not be present. Does the IPC layer not protect against return messages being sent to a WebContent process that is closing down? Maybe we are hitting the crash when something racy happens between the start of an async speech call, and the return message comes back when the process has terminated... 1554012 10 374411 pvollan 2019-07-18 13:45:24 -0700 Created attachment 374411 Patch 1554014 11 374411 pvollan 2019-07-18 13:47:42 -0700 Comment on attachment 374411 Patch Thanks for reviewing! 1554030 12 374411 bfulgham 2019-07-18 14:24:21 -0700 Comment on attachment 374411 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374411&action=review > Source/WebCore/Modules/speech/SpeechSynthesis.cpp:255 > { I wonder if we hit this code when SpeechSynthesis::handleSpeakingCompleted() calls fireEvent with an error state? 1554033 13 commit-queue 2019-07-18 14:41:34 -0700 The commit-queue encountered the following flaky tests while processing attachment 374411: storage/indexeddb/dont-wedge.html bug 199883 (authors: beidson@apple.com, commit-queue@webkit.org, dgrogan@chromium.org, and mark.lam@apple.com) The commit-queue is continuing to process your patch. 1554034 14 374411 commit-queue 2019-07-18 14:42:20 -0700 Comment on attachment 374411 Patch Clearing flags on attachment: 374411 Committed r247620: <https://trac.webkit.org/changeset/247620> 1554035 15 commit-queue 2019-07-18 14:42:22 -0700 All reviewed patches have been landed. Closing bug. 1554039 16 cfleizach 2019-07-18 14:56:34 -0700 I'll add even with these changes, I'm hitting a lot of asserts and and debug asserts. working through it with rdar://53235469 374384 2019-07-18 08:02:19 -0700 2019-07-18 13:45:22 -0700 Patch bug-199907-20190718080218.patch text/plain 1881 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDc1NjMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA3LTE4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJQYWdl Ojpib3VuZGFyeUV2ZW50T2NjdXJyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5OTkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBudWxscHRyIGNoZWNrcy4KKworICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c3BlYWtp bmdFcnJvck9jY3VycmVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Ym91bmRhcnlFdmVu dE9jY3VycmVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6dm9pY2VzRGlkQ2hhbmdlKToK KwogMjAxOS0wNy0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gQ3Jhc2ggaW4gd2Via2l0V2ViVmlld0Jhc2VSZW5kZXJIb3N0Rmls ZURlc2NyaXB0b3IKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCShyZXZpc2lvbiAyNDc1NjMpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjU5NywxOCArNjU5NywyNyBA QCB2b2lkIFdlYlBhZ2U6OnNpbXVsYXRlRGV2aWNlT3JpZW50YXRpb25DCiAjaWYgRU5BQkxFKFNQ RUVDSF9TWU5USEVTSVMpCiB2b2lkIFdlYlBhZ2U6OnNwZWFraW5nRXJyb3JPY2N1cnJlZCgpCiB7 CisgICAgaWYgKCFjb3JlUGFnZSgpIHx8ICFjb3JlUGFnZSgpLT5zcGVlY2hTeW50aGVzaXNDbGll bnQoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKGF1dG8gb2JzZXJ2ZXIgPSBjb3JlUGFn ZSgpLT5zcGVlY2hTeW50aGVzaXNDbGllbnQoKS0+b2JzZXJ2ZXIoKSkKICAgICAgICAgb2JzZXJ2 ZXItPnNwZWFraW5nRXJyb3JPY2N1cnJlZCgpOwogfQogCiB2b2lkIFdlYlBhZ2U6OmJvdW5kYXJ5 RXZlbnRPY2N1cnJlZChib29sIHdvcmRCb3VuZGFyeSwgdW5zaWduZWQgY2hhckluZGV4KQogewor ICAgIGlmICghY29yZVBhZ2UoKSB8fCAhY29yZVBhZ2UoKS0+c3BlZWNoU3ludGhlc2lzQ2xpZW50 KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIGlmIChhdXRvIG9ic2VydmVyID0gY29yZVBhZ2Uo KS0+c3BlZWNoU3ludGhlc2lzQ2xpZW50KCktPm9ic2VydmVyKCkpCiAgICAgICAgIG9ic2VydmVy LT5ib3VuZGFyeUV2ZW50T2NjdXJyZWQod29yZEJvdW5kYXJ5LCBjaGFySW5kZXgpOwogfQogCiB2 b2lkIFdlYlBhZ2U6OnZvaWNlc0RpZENoYW5nZSgpCiB7CisgICAgaWYgKCFjb3JlUGFnZSgpIHx8 ICFjb3JlUGFnZSgpLT5zcGVlY2hTeW50aGVzaXNDbGllbnQoKSkKKyAgICAgICAgcmV0dXJuOwor CiAgICAgaWYgKGF1dG8gb2JzZXJ2ZXIgPSBjb3JlUGFnZSgpLT5zcGVlY2hTeW50aGVzaXNDbGll bnQoKS0+b2JzZXJ2ZXIoKSkKICAgICAgICAgb2JzZXJ2ZXItPnZvaWNlc0NoYW5nZWQoKTsKIH0K 374386 2019-07-18 08:40:50 -0700 2019-07-18 13:45:23 -0700 Patch bug-199907-20190718084050.patch text/plain 1836 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDc1NjMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA3LTE4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJQYWdl Ojpib3VuZGFyeUV2ZW50T2NjdXJyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5OTkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBudWxscHRyIGNoZWNrcy4KKworICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c3BlYWtp bmdFcnJvck9jY3VycmVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Ym91bmRhcnlFdmVu dE9jY3VycmVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6dm9pY2VzRGlkQ2hhbmdlKToK KwogMjAxOS0wNy0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gQ3Jhc2ggaW4gd2Via2l0V2ViVmlld0Jhc2VSZW5kZXJIb3N0Rmls ZURlc2NyaXB0b3IKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCShyZXZpc2lvbiAyNDc1NjMpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjU5NywxOCArNjU5NywyNyBA QCB2b2lkIFdlYlBhZ2U6OnNpbXVsYXRlRGV2aWNlT3JpZW50YXRpb25DCiAjaWYgRU5BQkxFKFNQ RUVDSF9TWU5USEVTSVMpCiB2b2lkIFdlYlBhZ2U6OnNwZWFraW5nRXJyb3JPY2N1cnJlZCgpCiB7 CisgICAgaWYgKCFjb3JlUGFnZSgpLT5zcGVlY2hTeW50aGVzaXNDbGllbnQoKSkKKyAgICAgICAg cmV0dXJuOworCiAgICAgaWYgKGF1dG8gb2JzZXJ2ZXIgPSBjb3JlUGFnZSgpLT5zcGVlY2hTeW50 aGVzaXNDbGllbnQoKS0+b2JzZXJ2ZXIoKSkKICAgICAgICAgb2JzZXJ2ZXItPnNwZWFraW5nRXJy b3JPY2N1cnJlZCgpOwogfQogCiB2b2lkIFdlYlBhZ2U6OmJvdW5kYXJ5RXZlbnRPY2N1cnJlZChi b29sIHdvcmRCb3VuZGFyeSwgdW5zaWduZWQgY2hhckluZGV4KQogeworICAgIGlmICghY29yZVBh Z2UoKS0+c3BlZWNoU3ludGhlc2lzQ2xpZW50KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIGlm IChhdXRvIG9ic2VydmVyID0gY29yZVBhZ2UoKS0+c3BlZWNoU3ludGhlc2lzQ2xpZW50KCktPm9i c2VydmVyKCkpCiAgICAgICAgIG9ic2VydmVyLT5ib3VuZGFyeUV2ZW50T2NjdXJyZWQod29yZEJv dW5kYXJ5LCBjaGFySW5kZXgpOwogfQogCiB2b2lkIFdlYlBhZ2U6OnZvaWNlc0RpZENoYW5nZSgp CiB7CisgICAgaWYgKCFjb3JlUGFnZSgpLT5zcGVlY2hTeW50aGVzaXNDbGllbnQoKSkKKyAgICAg ICAgcmV0dXJuOworCiAgICAgaWYgKGF1dG8gb2JzZXJ2ZXIgPSBjb3JlUGFnZSgpLT5zcGVlY2hT eW50aGVzaXNDbGllbnQoKS0+b2JzZXJ2ZXIoKSkKICAgICAgICAgb2JzZXJ2ZXItPnZvaWNlc0No YW5nZWQoKTsKIH0K 374411 2019-07-18 13:45:24 -0700 2019-07-18 14:42:20 -0700 Patch bug-199907-20190718134524.patch text/plain 2587 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NzYxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA3LTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJQ YWdlOjpib3VuZGFyeUV2ZW50T2NjdXJyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5OTkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBudWxsIHBvaW50ZXIgY2hlY2tzLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgc2luY2UgSSBoYXZlIG5vdCBiZWVuIGFibGUgdG8gcmVwcm9kdWNlIHRoaXMg aW4gYSB0ZXN0LgorCisgICAgICAgICogTW9kdWxlcy9zcGVlY2gvU3BlZWNoU3ludGhlc2lzLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNwZWVjaFN5bnRoZXNpczo6ZGlkU3RhcnRTcGVha2luZyk6 CisgICAgICAgIChXZWJDb3JlOjpTcGVlY2hTeW50aGVzaXM6OmRpZEZpbmlzaFNwZWFraW5nKToK KyAgICAgICAgKFdlYkNvcmU6OlNwZWVjaFN5bnRoZXNpczo6ZGlkUGF1c2VTcGVha2luZyk6Cisg ICAgICAgIChXZWJDb3JlOjpTcGVlY2hTeW50aGVzaXM6OmRpZFJlc3VtZVNwZWFraW5nKToKKyAg ICAgICAgKFdlYkNvcmU6OlNwZWVjaFN5bnRoZXNpczo6c3BlYWtpbmdFcnJvck9jY3VycmVkKToK KyAgICAgICAgKFdlYkNvcmU6OlNwZWVjaFN5bnRoZXNpczo6Ym91bmRhcnlFdmVudE9jY3VycmVk KToKKwogMjAxOS0wNy0xOCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAg ICAgICAgIFtQb2ludGVyIEV2ZW50c10gVGhlIGJ1dHRvbiBhbmQgYnV0dG9ucyBwcm9wZXJ0aWVz IGFyZSBpbmNvcnJlY3Qgb24gaU9TCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVj aC9TcGVlY2hTeW50aGVzaXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvc3BlZWNoL1NwZWVjaFN5bnRoZXNpcy5jcHAJKHJldmlzaW9uIDI0NzU0MykKKysrIFNvdXJj ZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFN5bnRoZXNpcy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIyNSwzMSArMjI1LDQzIEBAIHZvaWQgU3BlZWNoU3ludGhlc2lzOjpib3VuZGFyeUV2 ZW50T2NjdXIKIAogdm9pZCBTcGVlY2hTeW50aGVzaXM6OmRpZFN0YXJ0U3BlYWtpbmcoKQogewor ICAgIGlmICghbV9jdXJyZW50U3BlZWNoVXR0ZXJhbmNlKQorICAgICAgICByZXR1cm47CiAgICAg ZGlkU3RhcnRTcGVha2luZygqbV9jdXJyZW50U3BlZWNoVXR0ZXJhbmNlLT5wbGF0Zm9ybVV0dGVy YW5jZSgpKTsKIH0KIAogdm9pZCBTcGVlY2hTeW50aGVzaXM6OmRpZEZpbmlzaFNwZWFraW5nKCkK IHsKKyAgICBpZiAoIW1fY3VycmVudFNwZWVjaFV0dGVyYW5jZSkKKyAgICAgICAgcmV0dXJuOwog ICAgIGRpZEZpbmlzaFNwZWFraW5nKCptX2N1cnJlbnRTcGVlY2hVdHRlcmFuY2UtPnBsYXRmb3Jt VXR0ZXJhbmNlKCkpOwogfQogCiB2b2lkIFNwZWVjaFN5bnRoZXNpczo6ZGlkUGF1c2VTcGVha2lu ZygpCiB7CisgICAgaWYgKCFtX2N1cnJlbnRTcGVlY2hVdHRlcmFuY2UpCisgICAgICAgIHJldHVy bjsKICAgICBkaWRQYXVzZVNwZWFraW5nKCptX2N1cnJlbnRTcGVlY2hVdHRlcmFuY2UtPnBsYXRm b3JtVXR0ZXJhbmNlKCkpOwogfQogCiB2b2lkIFNwZWVjaFN5bnRoZXNpczo6ZGlkUmVzdW1lU3Bl YWtpbmcoKQogeworICAgIGlmICghbV9jdXJyZW50U3BlZWNoVXR0ZXJhbmNlKQorICAgICAgICBy ZXR1cm47CiAgICAgZGlkUmVzdW1lU3BlYWtpbmcoKm1fY3VycmVudFNwZWVjaFV0dGVyYW5jZS0+ cGxhdGZvcm1VdHRlcmFuY2UoKSk7CiB9CiAKIHZvaWQgU3BlZWNoU3ludGhlc2lzOjpzcGVha2lu Z0Vycm9yT2NjdXJyZWQoKQogeworICAgIGlmICghbV9jdXJyZW50U3BlZWNoVXR0ZXJhbmNlKQor ICAgICAgICByZXR1cm47CiAgICAgc3BlYWtpbmdFcnJvck9jY3VycmVkKCptX2N1cnJlbnRTcGVl Y2hVdHRlcmFuY2UtPnBsYXRmb3JtVXR0ZXJhbmNlKCkpOwogfQogCiB2b2lkIFNwZWVjaFN5bnRo ZXNpczo6Ym91bmRhcnlFdmVudE9jY3VycmVkKGJvb2wgd29yZEJvdW5kYXJ5LCB1bnNpZ25lZCBj aGFySW5kZXgpCiB7CisgICAgaWYgKCFtX2N1cnJlbnRTcGVlY2hVdHRlcmFuY2UpCisgICAgICAg IHJldHVybjsKICAgICBib3VuZGFyeUV2ZW50T2NjdXJyZWQoKm1fY3VycmVudFNwZWVjaFV0dGVy YW5jZS0+cGxhdGZvcm1VdHRlcmFuY2UoKSwgd29yZEJvdW5kYXJ5ID8gU3BlZWNoQm91bmRhcnk6 OlNwZWVjaFdvcmRCb3VuZGFyeSA6IFNwZWVjaEJvdW5kYXJ5OjpTcGVlY2hTZW50ZW5jZUJvdW5k YXJ5LCBjaGFySW5kZXgpOwogfQogCg==