199904 2019-07-18 05:51:50 -0700 Ensure Quirks::shouldDispatchSimulatedMouseEvents() works for all Google Maps and Amazon domains 2024-09-06 01:24:47 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198657 InRadar P2 Normal --- 279250 1 graouts graouts dino mcatanzaro webkit-bug-importer oldest_to_newest 1553886 0 graouts 2019-07-18 05:51:50 -0700 A comment made on https://bugs.webkit.org/show_bug.cgi?id=198657 indicates that the quirk added to dispatch simulated mouse events to the Street View icon on Google Maps only works on the google.com domain but Google Maps could also be served via a google.co.jp or google.fr domain for which the quirk doesn't work! Likewise, Quirks::shouldDispatchSimulatedMouseEvents() uses amazon.com to check whether we are on an Amazon property, but this is bad since Amazon also uses amazon.fr and other local domains. 1553887 1 webkit-bug-importer 2019-07-18 05:52:12 -0700 <rdar://problem/53250104> 1553951 2 mcatanzaro 2019-07-18 10:53:33 -0700 The solution we use for Google user agent quirks is: String baseDomain = topPrivatelyControlledDomain(url.host().toString()); if (baseDomain.startsWith("google.")) // do something We also have quirks for gstatic.com, googleapis.com, and googleusercontent.com, but none of those are likely relevant to your Maps problem. 1553952 3 graouts 2019-07-18 10:55:25 -0700 Thanks Michael, this is really helpful! I'll use a similar approach to detect a Google and Amazon property. 1554007 4 374408 graouts 2019-07-18 13:33:46 -0700 Created attachment 374408 Patch 1554040 5 graouts 2019-07-18 14:56:43 -0700 Committed r247621: <https://trac.webkit.org/changeset/247621> 374408 2019-07-18 13:33:46 -0700 2019-07-18 13:40:09 -0700 Patch bug-199904-20190718223344.patch text/plain 4188 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDNjOWI3OGM4YTQ5MGE0 OWYyMDY1OTUwODc2MjVjYzk0ZTRmNmZiNS4uYzFiMGU1YjRlNjU2Y2JhOGQzZmRjMWM5MmM3NTg0 ODk2OWZlZjU4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA3LTE4ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgRW5zdXJlIFF1aXJrczo6 c2hvdWxkRGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50cygpIHdvcmtzIGZvciBhbGwgR29vZ2xl IE1hcHMgYW5kIEFtYXpvbiBkb21haW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTk5MDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzMjUwMTA0 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0 b3BQcml2YXRlbHlDb250cm9sbGVkRG9tYWluKCkgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgdGhlIFVS TCBpcyBhIEdvb2dsZSBvciBBbWF6b24gZG9tYWluIHNvIGFzIHRvIGFwcGx5CisgICAgICAgIEdv b2dsZSBNYXBzIGFuZCBBbWF6b24gcXVpcmtzIHRvIGFsbCB0aGUgdmFyaW91cyBkb21haW4gbmFt ZXMgdXNlZC4KKworICAgICAgICAqIHBhZ2UvUXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlF1aXJrczo6aXNBbWF6b24gY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6UXVpcmtzOjppc0dv b2dsZU1hcHMgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6UXVpcmtzOjpzaG91bGREaXNwYXRj aFNpbXVsYXRlZE1vdXNlRXZlbnRzIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OlF1aXJrczo6 c2ltdWxhdGVkTW91c2VFdmVudFR5cGVGb3JUYXJnZXQgY29uc3QpOgorICAgICAgICAqIHBhZ2Uv UXVpcmtzLmg6CisKIDIwMTktMDctMTggIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNv bT4KIAogICAgICAgICBbUG9pbnRlciBFdmVudHNdIFRoZSBidXR0b24gYW5kIGJ1dHRvbnMgcHJv cGVydGllcyBhcmUgaW5jb3JyZWN0IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9RdWlya3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCmluZGV4IDk4 MDQ2YjQ2YzZhZDhkMTg2OTZhYzY2NmU0N2EyZWJkNTU2OTJkNTYuLjI1ZDA5MzRiM2Q3MGI5M2Qz NTc4Yzc1MWU1ZGU2ZTU0NGYwYzI4YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv UXVpcmtzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKQEAgLTIyOSwx MCArMjI5LDE0IEBAIGJvb2wgUXVpcmtzOjpzaG91bGRTdXBwcmVzc0F1dG9jb3JyZWN0aW9uQW5k QXV0b2NhcHRpYWxpemF0aW9uSW5IaWRkZW5FZGl0YWJsZUFyCiAKICNpZiBFTkFCTEUoVE9VQ0hf RVZFTlRTKQogYm9vbCBRdWlya3M6OmlzQW1hem9uKCkgY29uc3QKK3sKKyAgICByZXR1cm4gdG9w UHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbihtX2RvY3VtZW50LT50b3BEb2N1bWVudCgpLnVybCgp Lmhvc3QoKS50b1N0cmluZygpKS5zdGFydHNXaXRoKCJhbWF6b24uIik7Cit9CisKK2Jvb2wgUXVp cmtzOjppc0dvb2dsZU1hcHMoKSBjb25zdAogewogICAgIGF1dG8mIHVybCA9IG1fZG9jdW1lbnQt PnRvcERvY3VtZW50KCkudXJsKCk7Ci0gICAgYXV0byBob3N0ID0gdXJsLmhvc3QoKTsKLSAgICBy ZXR1cm4gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgImFtYXpvbi5jb20iKSB8 fCBob3N0LmVuZHNXaXRoSWdub3JpbmdBU0NJSUNhc2UoIi5hbWF6b24uY29tIik7CisgICAgcmV0 dXJuIHRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4odXJsLmhvc3QoKS50b1N0cmluZygpKS5z dGFydHNXaXRoKCJnb29nbGUuIikgJiYgdXJsLnBhdGgoKS5zdGFydHNXaXRoSWdub3JpbmdBU0NJ SUNhc2UoIi9tYXBzLyIpOwogfQogCiBib29sIFF1aXJrczo6c2hvdWxkRGlzcGF0Y2hTaW11bGF0 ZWRNb3VzZUV2ZW50cygpIGNvbnN0CkBAIC0yNDksNiArMjUzLDggQEAgYm9vbCBRdWlya3M6OnNo b3VsZERpc3BhdGNoU2ltdWxhdGVkTW91c2VFdmVudHMoKSBjb25zdAogCiAgICAgaWYgKGlzQW1h em9uKCkpCiAgICAgICAgIHJldHVybiB0cnVlOworICAgIGlmIChpc0dvb2dsZU1hcHMoKSkKKyAg ICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBhdXRvJiB1cmwgPSBtX2RvY3VtZW50LT50b3BEb2N1 bWVudCgpLnVybCgpOwogICAgIGF1dG8gaG9zdCA9IHVybC5ob3N0KCk7CkBAIC0yNjcsOCArMjcz LDYgQEAgYm9vbCBRdWlya3M6OnNob3VsZERpc3BhdGNoU2ltdWxhdGVkTW91c2VFdmVudHMoKSBj b25zdAogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdB U0NJSUNhc2UoaG9zdCwgImZsaXBrYXJ0LmNvbSIpIHx8IGhvc3QuZW5kc1dpdGhJZ25vcmluZ0FT Q0lJQ2FzZSgiLmZsaXBrYXJ0LmNvbSIpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAo ZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgInd3dy5nb29nbGUuY29tIikgJiYg dXJsLnBhdGgoKS5zdGFydHNXaXRoSWdub3JpbmdBU0NJSUNhc2UoIi9tYXBzLyIpKQotICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9z dCwgInRyYWlsZXJzLmFwcGxlLmNvbSIpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAo ZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgIm5hdmVyLmNvbSIpKQpAQCAtMzAz LDE0ICszMDcsMTMgQEAgT3B0aW9uYWw8RXZlbnQ6OklzQ2FuY2VsYWJsZT4gUXVpcmtzOjpzaW11 bGF0ZWRNb3VzZUV2ZW50VHlwZUZvclRhcmdldChFdmVudFRhcmcKICAgICAgICAgcmV0dXJuIHsg fTsKIAogICAgIC8vIE9uIEdvb2dsZSBNYXBzLCB3ZSB3YW50IHRvIGxpbWl0IHNpbXVsYXRlZCBt b3VzZSBldmVudHMgdG8gZHJhZ2dpbmcgdGhlIGxpdHRsZSBtYW4gdGhhdCBhbGxvd3MgZW50ZXJp bmcgaW50byBTdHJlZXQgVmlldy4KLSAgICBhdXRvJiB1cmwgPSBtX2RvY3VtZW50LT50b3BEb2N1 bWVudCgpLnVybCgpOwotICAgIGF1dG8gaG9zdCA9IHVybC5ob3N0KCk7Ci0gICAgaWYgKGVxdWFs TGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJ3d3cuZ29vZ2xlLmNvbSIpICYmIHVybC5w YXRoKCkuc3RhcnRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCIvbWFwcy8iKSkgeworICAgIGlmIChp c0dvb2dsZU1hcHMoKSkgewogICAgICAgICBpZiAoaXM8RWxlbWVudD4odGFyZ2V0KSAmJiBkb3du Y2FzdDxFbGVtZW50Pih0YXJnZXQpLT5nZXRBdHRyaWJ1dGUoImNsYXNzIikgPT0gIndpZGdldC1l eHBhbmQtYnV0dG9uLXBlZ21hbi1pY29uIikKICAgICAgICAgICAgIHJldHVybiBFdmVudDo6SXND YW5jZWxhYmxlOjpZZXM7CiAgICAgICAgIHJldHVybiB7IH07CiAgICAgfQogCisgICAgYXV0byBo b3N0ID0gbV9kb2N1bWVudC0+dG9wRG9jdW1lbnQoKS51cmwoKS5ob3N0KCk7CiAgICAgaWYgKGVx dWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJkZXNtb3MuY29tIikgfHwgaG9zdC5l bmRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCIuZGVzbW9zLmNvbSIpKQogICAgICAgICByZXR1cm4g RXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm87CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvUXVpcmtzLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5oCmluZGV4IDRjMjAwNzBh YzBiNWUzNWFlZjRkZWJlMTJiODgxZTJjMTA0N2I3ZDYuLjJkNTBhMTg4YThlMGMyOWY1YjBkNWRm YzdlM2U0NzUxZjFjN2VhYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtz LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuaApAQCAtNzMsNiArNzMsNyBAQCBw cml2YXRlOgogCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKICAgICBib29sIGlzQW1hem9uKCkg Y29uc3Q7CisgICAgYm9vbCBpc0dvb2dsZU1hcHMoKSBjb25zdDsKICNlbmRpZgogCiAgICAgV2Vh a1B0cjxEb2N1bWVudD4gbV9kb2N1bWVudDsK