199852 2019-07-17 03:17:43 -0700 run-safari --ios-simulator is no longer working with Xcode 11 2019-09-26 14:54:39 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177595 https://bugs.webkit.org/show_bug.cgi?id=178203 InRadar P2 Normal --- 202263 1 fred.wang fred.wang commit-queue dbates ews-watchlist jbedard thorton webkit-bug-importer oldest_to_newest 1553472 0 fred.wang 2019-07-17 03:17:43 -0700 XCode relase and beta use different paths for MobileSafari.app: $ find Xcode.app -name MobileSafari.app Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/Applications/MobileSafari.app $ find Xcode-beta.app -name MobileSafari.app Xcode-beta.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/Applications/MobileSafari.app (note that "Developer" and "Library" have been switched) A trivial patch to make things work again is: diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm index 1374b4b3f2..c011655669 100755 --- a/Tools/Scripts/webkitdirs.pm +++ b/Tools/Scripts/webkitdirs.pm @@ -2503,7 +2503,7 @@ sub setupIOSWebKitEnvironment($) sub iosSimulatorApplicationsPath() { # FIXME: We should ask simctl for this information, instead of guessing from available runtimes. - my $runtimePath = File::Spec->catdir(sdkPlatformDirectory("iphoneos"), "Developer", "Library", "CoreSimulator", "Profiles", "Runtimes"); + my $runtimePath = File::Spec->catdir(sdkPlatformDirectory("iphoneos"), "Library", "Developer", "CoreSimulator", "Profiles", "Runtimes"); opendir(RUNTIMES, $runtimePath); my @runtimes = grep {/.*\.simruntime/} readdir(RUNTIMES); close(RUNTIMES); but of course that will break backward compatibility... 1574413 1 webkit-bug-importer 2019-09-26 03:26:17 -0700 <rdar://problem/55738122> 1574424 2 fred.wang 2019-09-26 05:27:03 -0700 This bug now happens on Mojave with the recent XCode 11 release. 1574436 3 jbedard 2019-09-26 07:22:13 -0700 We can totally break iOS 12 at this point, so the 'trivial patch' is probably the way to go. 1574615 4 379676 fred.wang 2019-09-26 13:54:22 -0700 Created attachment 379676 Patch OK let's do that. 1574642 5 379676 commit-queue 2019-09-26 14:54:37 -0700 Comment on attachment 379676 Patch Clearing flags on attachment: 379676 Committed r250400: <https://trac.webkit.org/changeset/250400> 1574643 6 commit-queue 2019-09-26 14:54:39 -0700 All reviewed patches have been landed. Closing bug. 379676 2019-09-26 13:54:22 -0700 2019-09-26 14:54:37 -0700 Patch 199852.patch text/plain 1648 fred.wang ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzMjM0 ODU2NDExNi4uMTdlMjllNjM1YzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOS0wOS0yNiAgRnJlZGVyaWMgV2Fu ZyAgPGZ3YW5nQGlnYWxpYS5jb20+CisKKyAgICAgICAgcnVuLXNhZmFyaSAtLWlvcy1zaW11bGF0 b3IgaXMgbm8gbG9uZ2VyIHdvcmtpbmcgd2l0aCBYY29kZSAxMQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5ODUyCisKKyAgICAgICAgUGF0aCBvZiBN b2JpbGVTYWZhcmkuYXBwIGhhcyBjaGFuZ2VkIGluIFhjb2RlIDExLiBUaGlzIHBhdGNoIHVwZGF0 ZXMKKyAgICAgICAgdGhlIHJ1bi1zYWZhcmkgc2NyaXB0IHRvIHVzZSB0aGUgbmV3IHBhdGguIFRo aXMgcmVtb3ZlcyBzdXBwb3J0IGZvcgorICAgICAgICBydW5uaW5nIFNhZmFyaSBvbiBpT1MgPCAx Mywgc2VlIGRpc2N1c3Npb25zIG9uIGJ1ZyAxNzc1OTUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAg ICAgIChpb3NTaW11bGF0b3JBcHBsaWNhdGlvbnNQYXRoKToKKwogMjAxOS0wOS0yNSAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCByZXBs YWNlbWVudCBTUEkgb24gX1dLV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24gZm9yIGVuYWJs aW5nIHNwZWN1bGF0aXZlIGNhY2hlIHZhbGlkYXRpb24gYW5kIElQQy1mcmVlIHNlcnZlciB0cnVz dCBldmFsdWF0aW9uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9U b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggMDI3MDRjMzFkNjMuLmFlNzk0MmU5YjYw IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yNTI2LDcgKzI1MjYsNyBAQCBzdWIgc2V0dXBJT1NXZWJL aXRFbnZpcm9ubWVudCgkKQogc3ViIGlvc1NpbXVsYXRvckFwcGxpY2F0aW9uc1BhdGgoKQogewog ICAgICMgRklYTUU6IFdlIHNob3VsZCBhc2sgc2ltY3RsIGZvciB0aGlzIGluZm9ybWF0aW9uLCBp bnN0ZWFkIG9mIGd1ZXNzaW5nIGZyb20gYXZhaWxhYmxlIHJ1bnRpbWVzLgotICAgIG15ICRydW50 aW1lUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGRpcihzZGtQbGF0Zm9ybURpcmVjdG9yeSgiaXBob25l b3MiKSwgIkRldmVsb3BlciIsICJMaWJyYXJ5IiwgIkNvcmVTaW11bGF0b3IiLCAiUHJvZmlsZXMi LCAiUnVudGltZXMiKTsKKyAgICBteSAkcnVudGltZVBhdGggPSBGaWxlOjpTcGVjLT5jYXRkaXIo c2RrUGxhdGZvcm1EaXJlY3RvcnkoImlwaG9uZW9zIiksICJMaWJyYXJ5IiwgIkRldmVsb3BlciIs ICJDb3JlU2ltdWxhdG9yIiwgIlByb2ZpbGVzIiwgIlJ1bnRpbWVzIik7CiAgICAgb3BlbmRpcihS VU5USU1FUywgJHJ1bnRpbWVQYXRoKTsKICAgICBteSBAcnVudGltZXMgPSBncmVwIHsvLipcLnNp bXJ1bnRpbWUvfSByZWFkZGlyKFJVTlRJTUVTKTsKICAgICBjbG9zZShSVU5USU1FUyk7Cg==