199849 2019-07-16 20:54:17 -0700 Fix includes and make a constructor explicit to avoid unified-sources-triggered test failures 2019-07-16 21:57:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199587 InRadar P2 Normal --- 1 simon.fraser simon.fraser cmarcelo commit-queue dbates ews-watchlist fred.wang jamesr luiz simon.fraser tonikitoo webkit-bug-importer wenson_hsieh oldest_to_newest 1553431 0 simon.fraser 2019-07-16 20:54:17 -0700 Fix includes and make a constructor explicit to avoid unified-sources-triggered test failures 1553433 1 374274 simon.fraser 2019-07-16 20:56:09 -0700 Created attachment 374274 Patch 1553440 2 dbates 2019-07-16 21:09:19 -0700 Wow this bug (NOT YOUR PATCH) really makes me 😡. It makes me 😡 because of the fear of the unknown. How many yet undiscovered correctness issues are unified source causing? When you spend so much time fixing bugs only for weird bugs to be introduced by the build system that's next level bull.... 1553449 3 374274 commit-queue 2019-07-16 21:56:42 -0700 Comment on attachment 374274 Patch Clearing flags on attachment: 374274 Committed r247504: <https://trac.webkit.org/changeset/247504> 1553450 4 commit-queue 2019-07-16 21:56:43 -0700 All reviewed patches have been landed. Closing bug. 1553451 5 webkit-bug-importer 2019-07-16 21:57:22 -0700 <rdar://problem/53187799> 374274 2019-07-16 20:56:09 -0700 2019-07-16 21:56:42 -0700 Patch bug-199849-20190716205608.patch text/plain 2442 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDNmMzZkZDZlZGYwMWZk N2QxMTVkMjQ5ZmE5NjQ0MTgzZDE0YjQ1ZC4uZWEyMzNiZmVhMTQ1NDg2YWMyYWVlZTc4NmU4YzRh M2MxN2FiZTIwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA3LTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBpbmNsdWRl cyBhbmQgbWFrZSBhIGNvbnN0cnVjdG9yIGV4cGxpY2l0IHRvIGF2b2lkIHVuaWZpZWQtc291cmNl cy10cmlnZ2VyZWQgdGVzdCBmYWlsdXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk5ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICB3ZWJraXQub3JnL2IvMTk5NTg3IHRyaWdnZXJlZCBz b21lIHVuZXhwZWN0ZWQgdGVzdCBmYWlsdXJlcyBiZWNhdXNlIG9mIHVuaWZpZWQgc291cmNlcyBp bmNsdWRlCisgICAgICAgIG9yZGVyLiBUaGUgVGV4dFN0cmVhbSBvcGVyYXRvciBpbiBTY3JvbGxp bmdUcmVlT3ZlcmZsb3dTY3JvbGxpbmdOb2RlOjpkdW1wUHJvcGVydGllcygpIHdhcyBpbnZva2lu ZworICAgICAgICB0aGUgaW1wbGljaXQgY29uc3RydWN0b3Igb2YgVHJhbnNmb3JtT3BlcmF0aW9u cy4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVPdmVyZmxvd1Njcm9s bGluZ05vZGUuY3BwOiBJbmNsdWRlIFRleHRTdHJlYW0uaAorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtT3BlcmF0aW9ucy5oOiBNYWtlIGN0b3IgZXhwbGlj aXQuCisKIDIwMTktMDctMTYgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OOiBmYXN0L2V2ZW50cy93YXRjaG9zL2RvdWJsZS10YXAtdG8tem9v bSogdGVzdHMgY3Jhc2hpbmcgaW4gY29tLmFwcGxlLldlYktpdDogLVtXS0NvbnRlbnRWaWV3KFdL SW50ZXJhY3Rpb24pIF9zaW5nbGVUYXBEaWRSZXNldDpdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlT3ZlcmZsb3dTY3JvbGxpbmdOb2RlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVPdmVyZmxvd1Nj cm9sbGluZ05vZGUuY3BwCmluZGV4IDkyMzc2NjkxZDc0ODQzZWU0YTY3ZTUxMzY1YjBmOWM2ZWM3 MjBkNTcuLmI1MGZlZDcxMjQ2OTY4YjVmOTI1Nzk2NGJkOTE3NjA3YmZlYThhZDIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVPdmVyZmxvd1Nj cm9sbGluZ05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9s bGluZ1RyZWVPdmVyZmxvd1Njcm9sbGluZ05vZGUuY3BwCkBAIC0zMCw2ICszMCw3IEBACiAKICNp bmNsdWRlICJTY3JvbGxpbmdTdGF0ZVRyZWUuaCIKICNpbmNsdWRlICJTY3JvbGxpbmdUcmVlLmgi CisjaW5jbHVkZSA8d3RmL3RleHQvVGV4dFN0cmVhbS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9y bXMvVHJhbnNmb3JtT3BlcmF0aW9ucy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1PcGVyYXRpb25zLmgKaW5kZXggMWY4OGQ4MTcxYzE3ZmY4 MjA1YTFhZmUwZjQyYThmOWM1MjRkZWQ4MC4uZjgyNTZhN2Y0ZDVhYjdiYjE4ZTZhZjQ0NjAzMDM3 OTM2OTgyMWQxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dHJhbnNmb3Jtcy9UcmFuc2Zvcm1PcGVyYXRpb25zLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1PcGVyYXRpb25zLmgKQEAgLTM0LDcg KzM0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgVHJhbnNmb3JtT3BlcmF0aW9ucyB7 CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6Ci0gICAgVHJhbnNmb3JtT3Bl cmF0aW9ucyhib29sIG1ha2VJZGVudGl0eSA9IGZhbHNlKTsKKyAgICBleHBsaWNpdCBUcmFuc2Zv cm1PcGVyYXRpb25zKGJvb2wgbWFrZUlkZW50aXR5ID0gZmFsc2UpOwogICAgIAogICAgIGJvb2wg b3BlcmF0b3I9PShjb25zdCBUcmFuc2Zvcm1PcGVyYXRpb25zJiBvKSBjb25zdDsKICAgICBib29s IG9wZXJhdG9yIT0oY29uc3QgVHJhbnNmb3JtT3BlcmF0aW9ucyYgbykgY29uc3QK