<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>19975</bug_id>
          
          <creation_ts>2008-07-10 13:37:11 -0700</creation_ts>
          <short_desc>[OpenBSD] Patches to enable build of WebKit</short_desc>
          <delta_ts>2008-07-18 08:33:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Landry Breuil">landry</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ddkilzer</cc>
    
    <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>85633</commentid>
    <comment_count>0</comment_count>
    <who name="Landry Breuil">landry</who>
    <bug_when>2008-07-10 13:37:11 -0700</bug_when>
    <thetext>The following patches enable support for OpenBSD, adapted from the first diff shown here : https://bugs.webkit.org/show_bug.cgi?id=19775
- One patch against JavaScriptCore/wtf/Platform.h to add PLATFORM support, both for OpenBSD and SPARC64.
- One against JavaScriptCore/kjs/config.h to define USE_PTHREAD_NP.
- One against JavaScriptCore/wtf/Threading.h to avoir using functions from libestdc++ 4.2, because otherwise makefiles have to be patched to link agaisnt -lestdc++ instead of -lstdc++ (which is libstdc++ 3.3 on OpenBSD)
- One against JavaScriptCore/kjs/collector.cpp to be sure we include pthread.h besides pthread_np.h, and also an #elif fragment to get the stack base.

There are other patches i&apos;m not submitting for review because they #define isfinite to finite and implement signbit(), because these functions are in the process of beign added to OpenBSD&apos;s libm and will be soon here (maybe the incoming 4.4)
With this patches webkit/gtklauncher/midori works fine on i386/amd64/macppc.

Patches from bug #19775 are also needed to try to support sparc64, although i haven&apos;t been able to make webkit run without SIGBUS.

Last question, our default gcc/g++ is 3.3.5, are there plans to make webkit build with those compilers or gcc 4.x is _required_ ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>85635</commentid>
    <comment_count>1</comment_count>
      <attachid>22203</attachid>
    <who name="Landry Breuil">landry</who>
    <bug_when>2008-07-10 13:38:54 -0700</bug_when>
    <thetext>Created attachment 22203
patches for OpenBSD

This patches are in the progress of beign tested _again_, but the previous diff linked on #19775 was tested several times.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>85667</commentid>
    <comment_count>2</comment_count>
      <attachid>22203</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-07-10 15:06:33 -0700</bug_when>
    <thetext>Comment on attachment 22203
patches for OpenBSD

Great!  r=me

I forgot to mention in the original review (Bug 19775 Comment #14) that you also need a ChangeLog entry.

http://webkit.org/coding/contributing.html

I&apos;ll write one up unless you&apos;d like to do it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>85769</commentid>
    <comment_count>3</comment_count>
      <attachid>22246</attachid>
    <who name="Landry Breuil">landry</who>
    <bug_when>2008-07-11 02:54:40 -0700</bug_when>
    <thetext>Created attachment 22246
new patch to correctly include pthread.h

We don&apos;t have thread.h like solaris, so patch it this way. This was my mistake, rebuilding to make sure it&apos;s ok now.

For the changelog entry, go ahead :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>85770</commentid>
    <comment_count>4</comment_count>
      <attachid>22203</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-07-11 03:35:00 -0700</bug_when>
    <thetext>Comment on attachment 22203
patches for OpenBSD

Oops.  Didn&apos;t realize the second patch was additive.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>85771</commentid>
    <comment_count>5</comment_count>
      <attachid>22246</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-07-11 03:40:10 -0700</bug_when>
    <thetext>Comment on attachment 22246
new patch to correctly include pthread.h

&gt;--- JavaScriptCore/kjs/collector.cpp.orig	Mon Jun 16 01:40:06 2008
&gt;+++ JavaScriptCore/kjs/collector.cpp	Fri Jul 11 11:46:16 2008
&gt;@@ -61,6 +61,10 @@
&gt; #include &lt;thread.h&gt;
&gt; #endif
&gt; 
&gt;+#if PLATFORM(OPENBSD)
&gt;+#include &lt;pthread.h&gt;
&gt;+#endif
&gt;+
&gt; #if HAVE(PTHREAD_NP_H)
&gt; #include &lt;pthread_np.h&gt;
&gt; #else

Looks good.

&gt;@@ -331,6 +335,11 @@ static inline void* currentThreadStackBase()
&gt;     stack_t s;
&gt;     thr_stksegment(&amp;s);
&gt;     return s.ss_sp;
&gt;+#elif PLATFORM(OPENBSD)
&gt;+    pthread_t thread = pthread_self();
&gt;+    stack_t stack;
&gt;+    pthread_stackseg_np(thread, &amp;stack);
&gt;+    return stack.ss_sp;
&gt; #elif PLATFORM(UNIX)
&gt;     static void* stackBase = 0;
&gt;     static size_t stackSize = 0;

This is already in the first patch.  There&apos;s no need to include it here.

The ChangeLog for the first patch is &quot;free&quot;.  Please create one using the prepare-ChangeLog script.  Thanks!

r- for above issues.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86203</commentid>
    <comment_count>6</comment_count>
      <attachid>22335</attachid>
    <who name="Landry Breuil">landry</who>
    <bug_when>2008-07-17 04:59:29 -0700</bug_when>
    <thetext>Created attachment 22335
patch against svn

And here&apos;s a cleaner, simpler patchset against svn, works fine with midori &amp; webkit-r35203.
ChangeLogs entries are included.
- i finally added a temporary signbit/isfinite implemetation in MathExtras.h, similar to what is done for Solaris. Once we&apos;ll have them in libm it shouldn&apos;t conflict.
- finally, Thread.h patching is not necessary, we have to link with libstdc++-4.2 anyway (that&apos;ll be our only local patch against GNUMakefile.am, because on openbsd libstdc++ in /usr/lib is 3.3 version, libstdc++ 4.2 is installed in /usr/local/lib/libestdc++)
- a non-intrusive patch for WebKitTools/DumpRenderTree/DumpRenderTree.h has been added to conditionally declare the method. I think there&apos;s a better way to handle it, but it compiles and runs fine this way. Having a HAVE_WCHAR detection could help maybe.
- while here i kept the PLATFORM(SPARC64) definition, needed for the upcoming fix for alignment problem on sparc64.

I hope this patchset is correct, and am just waiting for a new nightly build including it to import my port of webkit &amp; midori in OpenBSD&apos;s ports-tree. The fix for sparc64 will be worked on afterwards.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86205</commentid>
    <comment_count>7</comment_count>
      <attachid>22203</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-07-17 05:09:01 -0700</bug_when>
    <thetext>Comment on attachment 22203
patches for OpenBSD

Clearing review flag for obsolete patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86206</commentid>
    <comment_count>8</comment_count>
      <attachid>22335</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-07-17 05:20:45 -0700</bug_when>
    <thetext>Comment on attachment 22335
patch against svn

r=me!

Please include reference to the bug in future changelog entries.  Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86336</commentid>
    <comment_count>9</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-07-18 08:33:26 -0700</bug_when>
    <thetext>Committed r35234

Note that I tweaked the whitespace in MathExtras.h to match the formatting of the PLATFORM(SOLARIS) section above it.

Please file new bugs for additional or follow-up issues, and feel free to copy me on them.  Thanks!

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22203</attachid>
            <date>2008-07-10 13:38:54 -0700</date>
            <delta_ts>2008-07-17 05:09:01 -0700</delta_ts>
            <desc>patches for OpenBSD</desc>
            <filename>patches-openbsd.diff</filename>
            <type>text/plain</type>
            <size>2379</size>
            <attacher name="Landry Breuil">landry</attacher>
            
              <data encoding="base64">JE9wZW5CU0QkCi0tLSBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaC5vcmlnCU1vbiBKdW4g
MTYgMDE6NDA6MDYgMjAwOAorKysgSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJVGh1IEp1
bCAxMCAyMjoxMToyOCAyMDA4CkBAIC01Nyw2ICs1NywxMyBAQAogI2RlZmluZSBXVEZfUExBVEZP
Uk1fRlJFRUJTRCAxCiAjZW5kaWYKIAorLyogUExBVEZPUk0oT1BFTkJTRCkgKi8KKy8qIE9wZXJh
dGluZyBzeXN0ZW0gbGV2ZWwgZGVwZW5kZW5jaWVzIGZvciBPcGVuQlNEIHN5c3RlbXMgdGhhdCAq
LworLyogc2hvdWxkIGJlIHVzZWQgcmVnYXJkbGVzcyBvZiBvcGVyYXRpbmcgZW52aXJvbm1lbnQg
Ki8KKyNpZmRlZiBfX09wZW5CU0RfXworI2RlZmluZSBXVEZfUExBVEZPUk1fT1BFTkJTRCAxCisj
ZW5kaWYKKwogLyogUExBVEZPUk0oU09MQVJJUykgKi8KIC8qIE9wZXJhdGluZyBzeXN0ZW0gbGV2
ZWwgZGVwZW5kZW5jaWVzIGZvciBTb2xhcmlzIHRoYXQgc2hvdWxkIGJlIHVzZWQgKi8KIC8qIHJl
Z2FyZGxlc3Mgb2Ygb3BlcmF0aW5nIGVudmlyb25tZW50ICovCkBAIC0xNzAsNiArMTc3LDEyIEBA
CiAgICB8fCBkZWZpbmVkKF9faWE2NF9fKSBcCiAgICB8fCBkZWZpbmVkKF9NX1g2NCkKICNkZWZp
bmUgV1RGX1BMQVRGT1JNX1g4Nl82NCAxCisjZW5kaWYKKworLyogUExBVEZPUk0oU1BBUkM2NCkg
Ki8KKyNpZiBkZWZpbmVkKF9fc3BhcmM2NF9fKQorI2RlZmluZSBXVEZfUExBVEZPUk1fU1BBUkM2
NCAxCisjZGVmaW5lIFdURl9QTEFURk9STV9CSUdfRU5ESUFOIDEKICNlbmRpZgogCiAvKiBDb21w
aWxlciAqLwokT3BlbkJTRCQKLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmcuaC5vcmln
CU1vbiBKdW4gMTYgMDE6NDA6MDYgMjAwOAorKysgSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGlu
Zy5oCVRodSBKdWwgMTAgMjE6NTc6NTggMjAwOApAQCAtMTgwLDcgKzE4MCw3IEBAIGlubGluZSBp
bnQgYXRvbWljRGVjcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldAogaW5saW5lIHZv
aWQgYXRvbWljSW5jcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7IE9TQXRvbWljSW5jcmVt
ZW50MzJCYXJyaWVyKGNvbnN0X2Nhc3Q8aW50Kj4oYWRkZW5kKSk7IH0KIGlubGluZSBpbnQgYXRv
bWljRGVjcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBPU0F0b21pY0RlY3Jl
bWVudDMyQmFycmllcihjb25zdF9jYXN0PGludCo+KGFkZGVuZCkpOyB9CiAKLSNlbGlmIENPTVBJ
TEVSKEdDQykKKyNlbGlmIENPTVBJTEVSKEdDQykgJiYgIVBMQVRGT1JNKE9QRU5CU0QpCiAjZGVm
aW5lIFdURl9VU0VfTE9DS0ZSRUVfVEhSRUFEU0FGRVNIQVJFRCAxCiAKIGlubGluZSB2b2lkIGF0
b21pY0luY3JlbWVudChpbnQgdm9sYXRpbGUqIGFkZGVuZCkgeyBfX2dudV9jeHg6Ol9fYXRvbWlj
X2FkZChhZGRlbmQsIDEpOyB9CiRPcGVuQlNEJAotLS0gSmF2YVNjcmlwdENvcmUva2pzL2NvbGxl
Y3Rvci5jcHAub3JpZwlNb24gSnVuIDE2IDAxOjQwOjA2IDIwMDgKKysrIEphdmFTY3JpcHRDb3Jl
L2tqcy9jb2xsZWN0b3IuY3BwCVRodSBKdWwgMTAgMjI6MDY6MTYgMjAwOApAQCAtNTcsNyArNTcs
NyBAQAogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAjaW5jbHVkZSA8dW5pc3RkLmg+CiAKLSNpZiBQ
TEFURk9STShTT0xBUklTKQorI2lmIFBMQVRGT1JNKFNPTEFSSVMpIHx8IFBMQVRGT1JNKE9QRU5C
U0QpCiAjaW5jbHVkZSA8dGhyZWFkLmg+CiAjZW5kaWYKIApAQCAtMzMxLDYgKzMzMSwxMSBAQCBz
dGF0aWMgaW5saW5lIHZvaWQqIGN1cnJlbnRUaHJlYWRTdGFja0Jhc2UoKQogICAgIHN0YWNrX3Qg
czsKICAgICB0aHJfc3Rrc2VnbWVudCgmcyk7CiAgICAgcmV0dXJuIHMuc3Nfc3A7CisjZWxpZiBQ
TEFURk9STShPUEVOQlNEKQorICAgIHB0aHJlYWRfdCB0aHJlYWQgPSBwdGhyZWFkX3NlbGYoKTsK
KyAgICBzdGFja190IHN0YWNrOworICAgIHB0aHJlYWRfc3RhY2tzZWdfbnAodGhyZWFkLCAmc3Rh
Y2spOworICAgIHJldHVybiBzdGFjay5zc19zcDsKICNlbGlmIFBMQVRGT1JNKFVOSVgpCiAgICAg
c3RhdGljIHZvaWQqIHN0YWNrQmFzZSA9IDA7CiAgICAgc3RhdGljIHNpemVfdCBzdGFja1NpemUg
PSAwOwokT3BlbkJTRCQKLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9jb25maWcuaC5vcmlnCVRodSBK
dWwgMTAgMjI6MzA6MDAgMjAwOAorKysgSmF2YVNjcmlwdENvcmUva2pzL2NvbmZpZy5oCVRodSBK
dWwgMTAgMjI6MzA6MjAgMjAwOApAQCAtNjQsNyArNjQsNyBAQAogCiAjZW5kaWYKIAotI2lmIFBM
QVRGT1JNKEZSRUVCU0QpCisjaWYgUExBVEZPUk0oRlJFRUJTRCkgfHwgUExBVEZPUk0oT1BFTkJT
RCkKICNkZWZpbmUgSEFWRV9QVEhSRUFEX05QX0ggMQogI2VuZGlmCiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22246</attachid>
            <date>2008-07-11 02:54:40 -0700</date>
            <delta_ts>2008-07-17 04:59:29 -0700</delta_ts>
            <desc>new patch to correctly include pthread.h</desc>
            <filename>patch-JavaScriptCore_kjs_collector_cpp</filename>
            <type>text/plain</type>
            <size>669</size>
            <attacher name="Landry Breuil">landry</attacher>
            
              <data encoding="base64">JE9wZW5CU0QkCi0tLSBKYXZhU2NyaXB0Q29yZS9ranMvY29sbGVjdG9yLmNwcC5vcmlnCU1vbiBK
dW4gMTYgMDE6NDA6MDYgMjAwOAorKysgSmF2YVNjcmlwdENvcmUva2pzL2NvbGxlY3Rvci5jcHAJ
RnJpIEp1bCAxMSAxMTo0NjoxNiAyMDA4CkBAIC02MSw2ICs2MSwxMCBAQAogI2luY2x1ZGUgPHRo
cmVhZC5oPgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShPUEVOQlNEKQorI2luY2x1ZGUgPHB0aHJl
YWQuaD4KKyNlbmRpZgorCiAjaWYgSEFWRShQVEhSRUFEX05QX0gpCiAjaW5jbHVkZSA8cHRocmVh
ZF9ucC5oPgogI2Vsc2UKQEAgLTMzMSw2ICszMzUsMTEgQEAgc3RhdGljIGlubGluZSB2b2lkKiBj
dXJyZW50VGhyZWFkU3RhY2tCYXNlKCkKICAgICBzdGFja190IHM7CiAgICAgdGhyX3N0a3NlZ21l
bnQoJnMpOwogICAgIHJldHVybiBzLnNzX3NwOworI2VsaWYgUExBVEZPUk0oT1BFTkJTRCkKKyAg
ICBwdGhyZWFkX3QgdGhyZWFkID0gcHRocmVhZF9zZWxmKCk7CisgICAgc3RhY2tfdCBzdGFjazsK
KyAgICBwdGhyZWFkX3N0YWNrc2VnX25wKHRocmVhZCwgJnN0YWNrKTsKKyAgICByZXR1cm4gc3Rh
Y2suc3Nfc3A7CiAjZWxpZiBQTEFURk9STShVTklYKQogICAgIHN0YXRpYyB2b2lkKiBzdGFja0Jh
c2UgPSAwOwogICAgIHN0YXRpYyBzaXplX3Qgc3RhY2tTaXplID0gMDsK
</data>
<flag name="review"
          id="9784"
          type_id="1"
          status="-"
          setter="ddkilzer"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22335</attachid>
            <date>2008-07-17 04:59:29 -0700</date>
            <delta_ts>2008-07-17 05:20:45 -0700</delta_ts>
            <desc>patch against svn</desc>
            <filename>patch-openbsd-svn2.diff</filename>
            <type>text/plain</type>
            <size>4657</size>
            <attacher name="Landry Breuil">landry</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM1MjE2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMDctMTcgIExhbmRyeSBC
cmV1aWwgIDxsYW5kcnlAb3BlbmJzZC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgU3VwcG9ydCBmb3IgT3BlbkJTRCwgbW9zdGx5IHRocmVhZGlu
ZyBhbmQgbGlibSB0d2Vha3MuCisKKyAgICAgICAgKiBranMvY29sbGVjdG9yLmNwcDogI2luY2x1
ZGUgPHB0aHJlYWQuaD4KKyAgICAgICAgKEtKUzo6Y3VycmVudFRocmVhZFN0YWNrQmFzZSk6IHVz
ZSBwdGhyZWFkX3N0YWNrc2VnX25wKCkgdG8gZ2V0IHN0YWNrIGJhc2UKKyAgICAgICAgKiBranMv
Y29uZmlnLmg6IE9wZW5CU0QgYWxzbyBwcm92aWRlcyA8cHRocmVhZF9ucC5oPgorICAgICAgICAq
IHd0Zi9NYXRoRXh0cmFzLmg6ICNpbmNsdWRlIDxzeXMvdHlwZXMuaD4gYW5kIDxtYWNoaW5lL2ll
ZWUuaD4KKyAgICAgICAgKGlzZmluaXRlKSwgKHNpZ25iaXQpOiBhcyBsb25nIGFzIHdlIGRvbid0
IGhhdmUgdGhvc2UgZnVuY3Rpb25zIHByb3ZpZGUgZmFsbGJhY2sgaW1wbGVtZW50YXRpb25zCisg
ICAgICAgICogd3RmL1BsYXRmb3JtLmg6IEFkZCBzdXBwb3J0IGZvciBQTEFURk9STShPUEVOQlNE
KSBhbmQgUExBVEZPUk0oU1BBUkM2NCkgbWFjcm8KKwogMjAwOC0wNy0xNiAgTWFyayBSb3dlICA8
bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEdlb2ZmIEdhcmVu
LgpJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL2NvbGxlY3Rvci5jcHAKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
SmF2YVNjcmlwdENvcmUva2pzL2NvbGxlY3Rvci5jcHAJKHJldmlzaW9uIDM1MjE2KQorKysgSmF2
YVNjcmlwdENvcmUva2pzL2NvbGxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzLDYgKzYz
LDEwIEBACiAjaW5jbHVkZSA8dGhyZWFkLmg+CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKE9QRU5C
U0QpCisjaW5jbHVkZSA8cHRocmVhZC5oPgorI2VuZGlmCisKICNpZiBIQVZFKFBUSFJFQURfTlBf
SCkKICNpbmNsdWRlIDxwdGhyZWFkX25wLmg+CiAjZWxzZQpAQCAtMzY5LDYgKzM3MywxMSBAQCBz
dGF0aWMgaW5saW5lIHZvaWQqIGN1cnJlbnRUaHJlYWRTdGFja0Jhc2UoKQogICAgIHN0YWNrX3Qg
czsKICAgICB0aHJfc3Rrc2VnbWVudCgmcyk7CiAgICAgcmV0dXJuIHMuc3Nfc3A7CisjZWxpZiBQ
TEFURk9STShPUEVOQlNEKQorICAgIHB0aHJlYWRfdCB0aHJlYWQgPSBwdGhyZWFkX3NlbGYoKTsK
KyAgICBzdGFja190IHN0YWNrOworICAgIHB0aHJlYWRfc3RhY2tzZWdfbnAodGhyZWFkLCAmc3Rh
Y2spOworICAgIHJldHVybiBzdGFjay5zc19zcDsKICNlbGlmIFBMQVRGT1JNKFVOSVgpCiAgICAg
c3RhdGljIHZvaWQqIHN0YWNrQmFzZSA9IDA7CiAgICAgc3RhdGljIHNpemVfdCBzdGFja1NpemUg
PSAwOwpJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL2NvbmZpZy5oCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEph
dmFTY3JpcHRDb3JlL2tqcy9jb25maWcuaAkocmV2aXNpb24gMzUyMTYpCisrKyBKYXZhU2NyaXB0
Q29yZS9ranMvY29uZmlnLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3LDcgQEAKIAogI2Vu
ZGlmCiAKLSNpZiBQTEFURk9STShGUkVFQlNEKQorI2lmIFBMQVRGT1JNKEZSRUVCU0QpIHx8IFBM
QVRGT1JNKE9QRU5CU0QpCiAjZGVmaW5lIEhBVkVfUFRIUkVBRF9OUF9IIDEKICNlbmRpZgogCklu
ZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT
Y3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgJKHJldmlzaW9uIDM1MjE2KQorKysgSmF2YVNjcmlw
dENvcmUvd3RmL01hdGhFeHRyYXMuaAkod29ya2luZyBjb3B5KQpAQCAtMzQsNiArMzQsMTEgQEAK
ICNpbmNsdWRlIDxpZWVlZnAuaD4KICNlbmRpZgogCisjaWYgUExBVEZPUk0oT1BFTkJTRCkKKyNp
bmNsdWRlIDxzeXMvdHlwZXMuaD4KKyNpbmNsdWRlIDxtYWNoaW5lL2llZWUuaD4KKyNlbmRpZgor
CiAjaWYgQ09NUElMRVIoTVNWQykKIAogI2luY2x1ZGUgPHhtYXRoLmg+CkBAIC03MSw2ICs3Niwx
NyBAQCBpbmxpbmUgYm9vbCBpc2luZihkb3VibGUgeCkgeyByZXR1cm4gIWZpbml0ZSh4KSAmJiAh
aXMKICNlbmRpZgogI2lmbmRlZiBzaWduYml0CiBpbmxpbmUgYm9vbCBzaWduYml0KGRvdWJsZSB4
KSB7IHJldHVybiB4IDwgMC4wOyB9IC8vIEZJWE1FOiBXcm9uZyBmb3IgbmVnYXRpdmUgMC4KKyNl
bmRpZgorCisjZW5kaWYKKworI2lmIFBMQVRGT1JNKE9QRU5CU0QpCisjaWZuZGVmIGlzZmluaXRl
CitpbmxpbmUgYm9vbCBpc2Zpbml0ZShkb3VibGUgeCkgeyByZXR1cm4gZmluaXRlKHgpOyB9Cisj
ZW5kaWYKKworI2lmbmRlZiBzaWduYml0CitpbmxpbmUgYm9vbCBzaWduYml0KGRvdWJsZSB4KSB7
IHN0cnVjdCBpZWVlX2RvdWJsZSAqcCA9IChzdHJ1Y3QgaWVlZV9kb3VibGUgKikmeDsgcmV0dXJu
IHAtPmRibF9zaWduOyB9CiAjZW5kaWYKIAogI2VuZGlmCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93
dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0u
aAkocmV2aXNpb24gMzUyMTYpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29y
a2luZyBjb3B5KQpAQCAtNTcsNiArNTcsMTMgQEAKICNkZWZpbmUgV1RGX1BMQVRGT1JNX0ZSRUVC
U0QgMQogI2VuZGlmCiAKKy8qIFBMQVRGT1JNKE9QRU5CU0QpICovCisvKiBPcGVyYXRpbmcgc3lz
dGVtIGxldmVsIGRlcGVuZGVuY2llcyBmb3IgT3BlbkJTRCBzeXN0ZW1zIHRoYXQgKi8KKy8qIHNo
b3VsZCBiZSB1c2VkIHJlZ2FyZGxlc3Mgb2Ygb3BlcmF0aW5nIGVudmlyb25tZW50ICovCisjaWZk
ZWYgX19PcGVuQlNEX18KKyNkZWZpbmUgV1RGX1BMQVRGT1JNX09QRU5CU0QgMQorI2VuZGlmCisK
IC8qIFBMQVRGT1JNKFNPTEFSSVMpICovCiAvKiBPcGVyYXRpbmcgc3lzdGVtIGxldmVsIGRlcGVu
ZGVuY2llcyBmb3IgU29sYXJpcyB0aGF0IHNob3VsZCBiZSB1c2VkICovCiAvKiByZWdhcmRsZXNz
IG9mIG9wZXJhdGluZyBlbnZpcm9ubWVudCAqLwpAQCAtMTcwLDYgKzE3NywxMiBAQAogICAgfHwg
ZGVmaW5lZChfX2lhNjRfXykgXAogICAgfHwgZGVmaW5lZChfTV9YNjQpCiAjZGVmaW5lIFdURl9Q
TEFURk9STV9YODZfNjQgMQorI2VuZGlmCisKKy8qIFBMQVRGT1JNKFNQQVJDNjQpICovCisjaWYg
ZGVmaW5lZChfX3NwYXJjNjRfXykKKyNkZWZpbmUgV1RGX1BMQVRGT1JNX1NQQVJDNjQgMQorI2Rl
ZmluZSBXVEZfUExBVEZPUk1fQklHX0VORElBTiAxCiAjZW5kaWYKIAogLyogQ29tcGlsZXIgKi8K
SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDM1MjE2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwOC0wNy0xNiAgTGFuZHJ5IEJyZXVpbCAgPGxh
bmRyeUBvcGVuYnNkLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmg6IE9wZW5CU0QgZG9l
c24ndCBzdXBwb3J0IHdpZGUgY2hhcmFjdGVycy4KKwogMjAwOC0wNy0xNiAgSm9uIEhvbmV5Y3V0
dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIEN5Z3dpbkRvd25sb2FkZXIgZmFp
bHMgdG8gaW5zdGFsbCBuZWNlc3NhcnkgcGFja2FnZXMKSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBS
ZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVt
cFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuaAkocmV2aXNpb24gMzUyMTYpCisrKyBXZWJLaXRU
b29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00
Niw3ICs0Niw5IEBAIGV4dGVybiBDRlJ1bkxvb3BUaW1lclJlZiB3YWl0VG9EdW1wV2F0Y2hkb2c7
CiAKICNpbmNsdWRlIDxzdHJpbmc+CiAKKyNpZiAhUExBVEZPUk0oT1BFTkJTRCkKIHN0ZDo6d3N0
cmluZyB1cmxTdWl0YWJsZUZvclRlc3RSZXN1bHQoY29uc3Qgc3RkOjp3c3RyaW5nJiB1cmwpOwor
I2VuZGlmCiAKIGNsYXNzIExheW91dFRlc3RDb250cm9sbGVyOwogCg==
</data>
<flag name="review"
          id="9840"
          type_id="1"
          status="+"
          setter="ddkilzer"
    />
          </attachment>
      

    </bug>

</bugzilla>