199598 2019-07-08 16:02:30 -0700 UserData::decode should return false when decoding an unrecognized type 2019-07-09 11:28:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen rniwa webkit-bug-importer oldest_to_newest 1551012 0 achristensen 2019-07-08 16:02:30 -0700 UserData::decode should return false when decoding an unrecognized type 1551013 1 373677 achristensen 2019-07-08 16:02:53 -0700 Created attachment 373677 Patch 1551122 2 373677 rniwa 2019-07-08 19:50:28 -0700 Comment on attachment 373677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373677&action=review > Source/WebKit/Shared/UserData.cpp:601 > ASSERT_NOT_REACHED(); > + return false; I'm a bit surprised that we're not already getting a compiler warning / error about this... 1551310 3 achristensen 2019-07-09 11:27:35 -0700 http://trac.webkit.org/r247263 1551311 4 webkit-bug-importer 2019-07-09 11:28:23 -0700 <rdar://problem/52843696> 373677 2019-07-08 16:02:53 -0700 2019-07-08 19:50:28 -0700 Patch bug-199598-20190708160252.patch text/plain 1026 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDcyMzEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA3LTA4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVXNlckRhdGE6OmRl Y29kZSBzaG91bGQgcmV0dXJuIGZhbHNlIHdoZW4gZGVjb2RpbmcgYW4gdW5yZWNvZ25pemVkIHR5 cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTU5 OAorICAgICAgICA8cmRhcjovLzUyNzM1MTM4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL1VzZXJEYXRhLmNwcDoKKyAgICAgICAgKFdl YktpdDo6VXNlckRhdGE6OmRlY29kZSk6CisKIDIwMTktMDctMDggIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbnVwIHVzZXMgb2YgTmV0d29ya1Byb2Nlc3M6 Om1fc2Vzc2lvbkJ5Q29ubmVjdGlvbgpJbmRleDogU291cmNlL1dlYktpdC9TaGFyZWQvVXNlckRh dGEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvU2hhcmVkL1VzZXJEYXRhLmNwcAko cmV2aXNpb24gMjQ3MDkyKQorKysgU291cmNlL1dlYktpdC9TaGFyZWQvVXNlckRhdGEuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC01OTgsNiArNTk4LDcgQEAgYm9vbCBVc2VyRGF0YTo6ZGVjb2RlKElQ Qzo6RGVjb2RlciYgZGVjbwogCiAgICAgZGVmYXVsdDoKICAgICAgICAgQVNTRVJUX05PVF9SRUFD SEVEKCk7CisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKICAgICByZXR1cm4gdHJ1ZTsK