199596 2019-07-08 15:53:33 -0700 Null check HistoryItems given to loadDifferentDocumentItem 2019-07-09 11:56:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen beidson cdumez dbates ews-watchlist ggaren japhet rniwa webkit-bug-importer oldest_to_newest 1551005 0 achristensen 2019-07-08 15:53:33 -0700 Null check HistoryItems given to loadDifferentDocumentItem 1551008 1 373675 achristensen 2019-07-08 15:54:50 -0700 Created attachment 373675 Patch 1551009 2 achristensen 2019-07-08 15:54:52 -0700 <rdar://problem/49884391> 1551123 3 373675 rniwa 2019-07-08 19:55:46 -0700 Comment on attachment 373675 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373675&action=review > Source/WebCore/loader/FrameLoader.cpp:3874 > + if (item) Should we add a debug assertion / release logging when item is null? 1551323 4 achristensen 2019-07-09 11:56:01 -0700 http://trac.webkit.org/r247266 373675 2019-07-08 15:54:50 -0700 2019-07-08 19:55:46 -0700 Patch bug-199596-20190708155448.patch text/plain 1804 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NzIzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA3LTA4ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBjaGVj ayBIaXN0b3J5SXRlbXMgZ2l2ZW4gdG8gbG9hZERpZmZlcmVudERvY3VtZW50SXRlbQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NTk2CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80OTg4NDM5MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZUxvYWRlcjo6cmV0cnlBZnRlckZhaWxlZENhY2hlT25seU1haW5SZXNvdXJj ZUxvYWQpOgorICAgICAgICBVbmRlciBzb21lIHJhcmUgYW5kIG15c3RlcmlvdXMgY29uZGl0aW9u cyB3ZSBjYW4gaGF2ZSBhIG51bGwgcHJvdmlzaW9uYWxJdGVtIHdoZW4gbG9hZGluZyBmcm9tIHRo ZSBjYWNoZS4KKwogMjAxOS0wNy0wOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxl LmNvbT4KIAogICAgICAgICBVbmFibGUgdG8gcGFzdGUgZnJvbSBOb3RlcyBpbnRvIEV4Y2VsIDM2 NSBzcHJlYWRzaGVldApJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShy ZXZpc2lvbiAyNDcwOTIpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zODY4LDEwICszODY4LDExIEBAIHZvaWQgRnJhbWVMb2FkZXI6 OnJldHJ5QWZ0ZXJGYWlsZWRDYWNoZU8KICAgICBBU1NFUlQoaGlzdG9yeSgpLnByb3Zpc2lvbmFs SXRlbSgpID09IG1fcmVxdWVzdGVkSGlzdG9yeUl0ZW0uZ2V0KCkpOwogCiAgICAgRnJhbWVMb2Fk VHlwZSBsb2FkVHlwZSA9IG1fbG9hZFR5cGU7Ci0gICAgSGlzdG9yeUl0ZW0mIGl0ZW0gPSAqaGlz dG9yeSgpLnByb3Zpc2lvbmFsSXRlbSgpOworICAgIEhpc3RvcnlJdGVtKiBpdGVtID0gaGlzdG9y eSgpLnByb3Zpc2lvbmFsSXRlbSgpOwogCiAgICAgc3RvcEFsbExvYWRlcnMoU2hvdWxkTm90Q2xl YXJQcm92aXNpb25hbEl0ZW0pOwotICAgIGxvYWREaWZmZXJlbnREb2N1bWVudEl0ZW0oaXRlbSwg aGlzdG9yeSgpLmN1cnJlbnRJdGVtKCksIGxvYWRUeXBlLCBNYXlOb3RBdHRlbXB0Q2FjaGVPbmx5 TG9hZEZvckZvcm1TdWJtaXNzaW9uSXRlbSwgU2hvdWxkVHJlYXRBc0NvbnRpbnVpbmdMb2FkOjpO byk7CisgICAgaWYgKGl0ZW0pCisgICAgICAgIGxvYWREaWZmZXJlbnREb2N1bWVudEl0ZW0oKml0 ZW0sIGhpc3RvcnkoKS5jdXJyZW50SXRlbSgpLCBsb2FkVHlwZSwgTWF5Tm90QXR0ZW1wdENhY2hl T25seUxvYWRGb3JGb3JtU3VibWlzc2lvbkl0ZW0sIFNob3VsZFRyZWF0QXNDb250aW51aW5nTG9h ZDo6Tm8pOwogfQogCiBSZXNvdXJjZUVycm9yIEZyYW1lTG9hZGVyOjpjYW5jZWxsZWRFcnJvcihj b25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpIGNvbnN0Cg==