199588 2019-07-08 14:10:27 -0700 Web Inspector: REGRESSION: Elements: pasting in the Styles sidebar adds a text node to the DOM tree 2019-07-08 17:28:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1550955 0 hi 2019-07-08 14:10:27 -0700 # STEPS TO REPRODUCE: 1. copy "foo" 2. inspect any page 3. select the inline style of any node in the Elements tab 4. start adding a new property in the inline style 5. paste => "foo" added as a sibling of the currently selected node in the DOM tree 1550958 1 hi 2019-07-08 14:13:20 -0700 (In reply to Devin Rousso from comment #0) > 1. copy "foo" Actually, you need to copy something that would instead be rendered as a CSS property (or multiple): "foo:". 1550964 2 373664 hi 2019-07-08 14:19:21 -0700 Created attachment 373664 Patch 1550969 3 373664 joepeck 2019-07-08 14:33:47 -0700 Comment on attachment 373664 Patch rs=me Should this be the case for other events then? WI._copy? 1550972 4 373664 hi 2019-07-08 14:35:28 -0700 Comment on attachment 373664 Patch (In reply to Joseph Pecoraro from comment #3) > Should this be the case for other events then? WI._copy? I'd say yes, but in the interest of avoiding regressions, I'd rather not. Also, the default functionality of a "copy" won't modify the DOM like "paste" would, so there's less "risk" there of multiple things acting on the same "copy". 1551057 5 373664 commit-queue 2019-07-08 17:27:12 -0700 Comment on attachment 373664 Patch Clearing flags on attachment: 373664 Committed r247241: <https://trac.webkit.org/changeset/247241> 1551058 6 commit-queue 2019-07-08 17:27:14 -0700 All reviewed patches have been landed. Closing bug. 1551060 7 webkit-bug-importer 2019-07-08 17:28:17 -0700 <rdar://problem/52806667> 373664 2019-07-08 14:19:21 -0700 2019-07-08 17:27:12 -0700 Patch bug-199588-20190708141920.patch text/plain 1500 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFkZjM5NTQwMzA4YzQ3NGE2NTdmZDRkOTE4Yzg5 NjgxODliMWYxYzguLjg1YTU4MjkxN2RlNWVhZDc4YWJhOTc4MjEzZGU2ZDY3ODNlZTE1ZTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA3LTA4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiBFbGVtZW50czogcGFzdGluZyBpbiB0aGUgU3R5bGVzIHNpZGViYXIgYWRkcyBh IHRleHQgbm9kZSB0byB0aGUgRE9NIHRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5OTU4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAg IChXSS5fcGFzdGUpOgorICAgICAgICBCYWlsIGlmIGBldmVudC5kZWZhdWx0UHJldmVudGVkYCwg YXMgdGhhdCBtZWFucyB0aGF0IHNvbWV0aGluZyBlbHNlIGhhcyBoYW5kbGVkIChhbmQgbGlrZWx5 CisgICAgICAgIG92ZXJyb2RlKSB0aGlzIGV2ZW50LgorCiAyMDE5LTA3LTA2ICBOaWtpdGEgVmFz aWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0 eWxlczogdW5iYWxhbmNlZCBxdW90ZXMgYW5kIHBhcmVudGhlc2lzIGFyZW4ndCBkaXNwbGF5ZWQg YXMgcHJvcGVydHkgY2xvc2VkIGFmdGVyIGVkaXRpbmcgdmFsdWVzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggZTllNmFjZGNhZWUy NmI0ODZlZGEwYThiZGIzYmRlZDJhZWNlNjA1My4uZDZkODA3MzAzYWM1ZmZiMDcyOGYyZTU0YzM0 MzYxYzllNGZiNWYwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvTWFpbi5qcwpAQCAtMjYyMyw2ICsyNjIzLDkgQEAgV0kuX2NvcHkgPSBmdW5jdGlv bihldmVudCkKIAogV0kuX3Bhc3RlID0gZnVuY3Rpb24oZXZlbnQpCiB7CisgICAgaWYgKGV2ZW50 LmRlZmF1bHRQcmV2ZW50ZWQpCisgICAgICAgIHJldHVybjsKKwogICAgIGxldCBzZWxlY3Rpb24g PSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CiAKICAgICAvLyBJZiB0aGVyZSBpcyBubyBzZWxlY3Rp b24sIHBhc3MgdGhlIHBhc3RlIGV2ZW50IG9uIHRvIHRoZSBmb2N1c2VkIGVsZW1lbnQgb3IgZm9j dXNlZCBDb250ZW50Vmlldy4K