199578 2019-07-08 10:57:01 -0700 test-webkitpy: Explicitly use Python 2.7 lldb library 2019-07-08 12:57:35 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue dbates dean_johnson ews-watchlist glenn webkit-bug-importer oldest_to_newest 1550871 0 jbedard 2019-07-08 10:57:01 -0700 In newer versions of Xcode, the default lldb Python library is the Python 3 library, explicitly use the Python 2.7 library. 1550872 1 jbedard 2019-07-08 10:57:19 -0700 <rdar://problem/51853557> 1550874 2 373643 jbedard 2019-07-08 11:03:42 -0700 Created attachment 373643 Patch 1550875 3 jbedard 2019-07-08 11:04:55 -0700 Might get tripped up by TCC prompts on Catalina, but I think our bots should be fine because they have password-less sudo. 1550922 4 373643 aakash_jain 2019-07-08 12:09:59 -0700 Comment on attachment 373643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373643&action=review > Tools/Scripts/webkitpy/test/main.py:107 > build_version = _host.platform.build_version() Do we need this method (_supports_building_and_running_lldb_tests) at all after this change? Seems like it was added in https://trac.webkit.org/changeset/246662/webkit 1550932 5 373643 jbedard 2019-07-08 12:23:46 -0700 Comment on attachment 373643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373643&action=review >> Tools/Scripts/webkitpy/test/main.py:107 >> build_version = _host.platform.build_version() > > Do we need this method (_supports_building_and_running_lldb_tests) at all after this change? > > Seems like it was added in https://trac.webkit.org/changeset/246662/webkit I'd like to keep it until the FIX-ME is resolved. I think there is a non-zero chance we need to do this again (because of TCC prompts), and after r247139, this is also acting as a platform check for lldb tests, since they aren't supported on Linux at the moment. 1550939 6 373643 commit-queue 2019-07-08 12:57:33 -0700 Comment on attachment 373643 Patch Clearing flags on attachment: 373643 Committed r247228: <https://trac.webkit.org/changeset/247228> 1550940 7 commit-queue 2019-07-08 12:57:35 -0700 All reviewed patches have been landed. Closing bug. 373643 2019-07-08 11:03:42 -0700 2019-07-08 12:57:33 -0700 Patch bug-199578-20190708110342.patch text/plain 2182 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NzIxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA3LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB0ZXN0LXdlYmtpdHB5OiBFeHBsaWNpdGx5IHVzZSBQeXRob24gMi43IGxs ZGIgbGlicmFyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk5NTc4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTg1MzU1Nz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS9zeXN0ZW1ob3N0LnB5OgorICAgICAgICAoU3lzdGVtSG9zdC5wYXRoX3Rv X2xsZGJfcHl0aG9uX2RpcmVjdG9yeSk6IEV4cGxpY2l0bHkgdXNlIFB5dGhvbiAyLjcgbGxkYiBs aWJhcnkuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHk6CisgICAgICAg IChfc3VwcG9ydHNfYnVpbGRpbmdfYW5kX3J1bm5pbmdfbGxkYl90ZXN0cyk6IFJ1biBsbGRiIHRl c3RzIG9uIENhdGFsaW5hIGFnYWluLgorCiAyMDE5LTA3LTA4ICBBbnRvaW5lIFF1aW50ICA8Z3Jh b3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgW1BvaW50ZXIgRXZlbnRzXSBFbmFibGUgb25seSBv biB0aGUgbW9zdCByZWNlbnQgdmVyc2lvbiBvZiB0aGUgc3VwcG9ydGVkIGlPUyBmYW1pbHkKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9zeXN0ZW1ob3N0LnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9zeXN0ZW1o b3N0LnB5CShyZXZpc2lvbiAyNDcyMTApCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9zeXN0ZW0vc3lzdGVtaG9zdC5weQkod29ya2luZyBjb3B5KQpAQCAtNTQsNyArNTQsOSBAQCBj bGFzcyBTeXN0ZW1Ib3N0KG9iamVjdCk6CiAgICAgZGVmIHBhdGhfdG9fbGxkYl9weXRob25fZGly ZWN0b3J5KHNlbGYpOgogICAgICAgICBpZiBub3Qgc2VsZi5wbGF0Zm9ybS5pc19tYWMoKToKICAg ICAgICAgICAgIHJldHVybiAnJwotICAgICAgICByZXR1cm4gc2VsZi5leGVjdXRpdmUucnVuX2Nv bW1hbmQoWyd4Y3J1bicsICdsbGRiJywgJy0tcHl0aG9uLXBhdGgnXSwgcmV0dXJuX3N0ZGVycj1G YWxzZSkucnN0cmlwKCkKKyAgICAgICAgIyBFeHBsaWNpdGx5IHVzZSBQeXRob24gMi43CisgICAg ICAgIHBhdGggPSBzZWxmLmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3hjcnVuJywgJ2xsZGInLCAn LS1weXRob24tcGF0aCddLCByZXR1cm5fc3RkZXJyPUZhbHNlKS5yc3RyaXAoKQorICAgICAgICBy ZXR1cm4gc2VsZi5maWxlc3lzdGVtLmpvaW4oc2VsZi5maWxlc3lzdGVtLmRpcm5hbWUocGF0aCks ICdQeXRob24nKQogCiAgICAgQHByb3BlcnR5CiAgICAgZGVmIGRldmljZV90eXBlKHNlbGYpOgpJ bmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkJKHJldmlzaW9uIDI0NzIxMCkKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0x MDcsNyArMTA3LDcgQEAgZGVmIF9zdXBwb3J0c19idWlsZGluZ19hbmRfcnVubmluZ19sbGRiXwog ICAgIGJ1aWxkX3ZlcnNpb24gPSBfaG9zdC5wbGF0Zm9ybS5idWlsZF92ZXJzaW9uKCkKICAgICBp ZiBidWlsZF92ZXJzaW9uIGlzIE5vbmU6CiAgICAgICAgIHJldHVybiBGYWxzZQotICAgIHJldHVy biBub3QgYnVpbGRfdmVyc2lvbi5zdGFydHN3aXRoKCcxOUEnKQorICAgIHJldHVybiBUcnVlCiAK IAogZGVmIF9wcmludF9yZXN1bHRzX2FzX2pzb24oc3RyZWFtLCBhbGxfdGVzdF9uYW1lcywgZmFp bHVyZXMsIGVycm9ycyk6Cg==