199549 2019-07-06 11:01:13 -0700 Enabling the Layers tab hides the paint flashing button 2019-07-08 19:20:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser hi commit-queue hi inspector-bugzilla-changes joepeck ross.kirsling simon.fraser webkit-bug-importer oldest_to_newest 1550635 0 simon.fraser 2019-07-06 11:01:13 -0700 If you enable the Layers tab, the paint flashing button (the little paintbrush) disappears from the Elements tab. 1550639 1 hi 2019-07-06 11:22:38 -0700 The toggles for Paint Flashing and Compositing Borders are moved to the Layers tab when its enabled. Personally, I think that the Layers details sidebar (which is still shown in the Elements tab) should also move to the Layers tab, but there's been back and forth on that in the past. 1550642 2 simon.fraser 2019-07-06 11:26:30 -0700 It's _very_ confusing when enabling a tab moves buttons around. Can we just leave the old UI alone? 1550643 3 simon.fraser 2019-07-06 11:26:46 -0700 Also what does paint flashing have to do with layers. 1550666 4 373580 hi 2019-07-06 13:18:32 -0700 Created attachment 373580 Patch 1550982 5 373580 joepeck 2019-07-08 14:50:01 -0700 Comment on attachment 373580 Patch r=me 1550984 6 ross.kirsling 2019-07-08 14:57:21 -0700 The original idea was that the Layers sidebar would be *replaced* by the Layers tab, and so these buttons were going to be migrated over as well. We went back on this idea in bug 190158, so it seems that this part was just missed from that patch. 1551104 7 373580 commit-queue 2019-07-08 19:19:32 -0700 Comment on attachment 373580 Patch Clearing flags on attachment: 373580 Committed r247248: <https://trac.webkit.org/changeset/247248> 1551105 8 commit-queue 2019-07-08 19:19:34 -0700 All reviewed patches have been landed. Closing bug. 1551107 9 webkit-bug-importer 2019-07-08 19:20:25 -0700 <rdar://problem/52810669> 373580 2019-07-06 13:18:32 -0700 2019-07-08 19:19:32 -0700 Patch bug-199549-20190706131831.patch text/plain 2615 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDgxYjViZTNlNjg5ZTY4ZDhkZDZlMmZkOTZhNmJk ZWNjMDY0NjBkMTIuLmQyNzJkNDRkMWYyZDcxYmYyZGJhNzIyYjRkOWRlODVmNzQyODM2MzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA3LTA2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBFbmFibGluZyB0aGUgTGF5 ZXJzIHRhYiBoaWRlcyB0aGUgcGFpbnQgZmxhc2hpbmcgYnV0dG9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk1NDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdGlsbCBzaG93IHRoZSBDb21wb3NpdGlu ZyBCb3JkZXJzIGFuZCBQYWludCBGbGFzaGluZyBuYXZpZ2F0aW9uIGl0ZW1zIGluIHRoZSBFbGVt ZW50cyB0YWIKKyAgICAgICAgZXZlbiB3aGVuIHRoZSBMYXllcnMgdGFiIGlzIGVuYWJsZWQgKGp1 c3QgbGlrZSB0aGUgTGF5ZXJzIGRldGFpbHMgc2lkZWJhcikuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkRPTVRyZWVD b250ZW50Vmlldy5wcm90b3R5cGUuZ2V0IG5hdmlnYXRpb25JdGVtcyk6CisgICAgICAgIChXSS5E T01UcmVlQ29udGVudFZpZXcucHJvdG90eXBlLl91cGRhdGVDb21wb3NpdGluZ0JvcmRlcnNCdXR0 b25Ub01hdGNoUGFnZVNldHRpbmdzKToKKwogMjAxOS0wNy0wNSAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY3VycmVudCBjYWxsIGZy YW1lIGluZGljYXRvciBub3QgdmlzaWJsZSBpbiBkYXJrIG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50Vmlldy5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250 ZW50Vmlldy5qcwppbmRleCA1ZGIxOWI4MWZjYWI3MDEzN2I0ZmE2NTU5ZGFkZGIwMDI2OTVmNThj Li44NTBjOTM0ZDJjZTY0NzUxMzMxZjQxZTk2MTcxODk0YzY0ZmU0ZTE5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZp ZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9N VHJlZUNvbnRlbnRWaWV3LmpzCkBAIC0xMjgsMTMgKzEyOCwxMSBAQCBXSS5ET01UcmVlQ29udGVu dFZpZXcgPSBjbGFzcyBET01UcmVlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50Vmlldwog ICAgICAgICBpZiAodGhpcy5fc2hvd1J1bGVyc0J1dHRvbk5hdmlnYXRpb25JdGVtKQogICAgICAg ICAgICBpdGVtcy51bnNoaWZ0KHRoaXMuX3Nob3dSdWxlcnNCdXR0b25OYXZpZ2F0aW9uSXRlbSk7 CiAKLSAgICAgICAgaWYgKCFXSS5zZXR0aW5ncy5leHBlcmltZW50YWxFbmFibGVMYXllcnNUYWIu dmFsdWUpIHsKLSAgICAgICAgICAgIGlmICh0aGlzLl9jb21wb3NpdGluZ0JvcmRlcnNCdXR0b25O YXZpZ2F0aW9uSXRlbSkKLSAgICAgICAgICAgICAgICBpdGVtcy5wdXNoKHRoaXMuX2NvbXBvc2l0 aW5nQm9yZGVyc0J1dHRvbk5hdmlnYXRpb25JdGVtKTsKKyAgICAgICAgaWYgKHRoaXMuX2NvbXBv c2l0aW5nQm9yZGVyc0J1dHRvbk5hdmlnYXRpb25JdGVtKQorICAgICAgICAgICAgaXRlbXMucHVz aCh0aGlzLl9jb21wb3NpdGluZ0JvcmRlcnNCdXR0b25OYXZpZ2F0aW9uSXRlbSk7CiAKLSAgICAg ICAgICAgIGlmICh0aGlzLl9wYWludEZsYXNoaW5nQnV0dG9uTmF2aWdhdGlvbkl0ZW0pCi0gICAg ICAgICAgICAgICAgaXRlbXMucHVzaCh0aGlzLl9wYWludEZsYXNoaW5nQnV0dG9uTmF2aWdhdGlv bkl0ZW0pOwotICAgICAgIH0KKyAgICAgICAgaWYgKHRoaXMuX3BhaW50Rmxhc2hpbmdCdXR0b25O YXZpZ2F0aW9uSXRlbSkKKyAgICAgICAgICAgIGl0ZW1zLnB1c2godGhpcy5fcGFpbnRGbGFzaGlu Z0J1dHRvbk5hdmlnYXRpb25JdGVtKTsKIAogICAgICAgICByZXR1cm4gaXRlbXM7CiAgICAgfQpA QCAtNjA2LDkgKzYwNCw2IEBAIFdJLkRPTVRyZWVDb250ZW50VmlldyA9IGNsYXNzIERPTVRyZWVD b250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWV3CiAKICAgICBfdXBkYXRlQ29tcG9zaXRp bmdCb3JkZXJzQnV0dG9uVG9NYXRjaFBhZ2VTZXR0aW5ncygpCiAgICAgewotICAgICAgICBpZiAo V0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlTGF5ZXJzVGFiLnZhbHVlKQotICAgICAgICAg ICAgcmV0dXJuOwotCiAgICAgICAgIHZhciBidXR0b24gPSB0aGlzLl9jb21wb3NpdGluZ0JvcmRl cnNCdXR0b25OYXZpZ2F0aW9uSXRlbTsKIAogICAgICAgICAvLyBXZSBuZWVkIHRvIHN5bmMgd2l0 aCB0aGUgcGFnZSBzZXR0aW5ncyBzaW5jZSB0aGVzZSBjYW4gYmUgY29udHJvbGxlZAo=