199540 2019-07-05 19:21:41 -0700 Carvana.com needs the fetch AbortSignal quirk 2019-07-05 22:37:44 -0700 1 1 1 Unclassified WebKit WebCore JavaScript Safari Technology Preview All All RESOLVED FIXED InRadar P2 Normal --- 1 zhifei_fang youennf achristensen cdumez commit-queue webkit-bug-importer youennf zhifei_fang oldest_to_newest 1550600 0 zhifei_fang 2019-07-05 19:21:41 -0700 In this website: https://www.carvana.com/vehicle/1251874 They use a polyfill for abort signal, I guess the reason is here: https://bugs.webkit.org/show_bug.cgi?id=174980 Though we already fix this, I guess for a compatible reason, they just do a polyfill for safari everywhere without checking safari's version. here is the code: ``` a = function(e) { function a() { t(this, a); var e = n(this, (a.__proto__ || Object.getPrototypeOf(a)).call(this)); return e.aborted = !1, e.onabort = null, e } return function(e, t) { if ("function" !== typeof t && null !== t) throw new TypeError("Super expression must either be null or a function, not " + typeof t); e.prototype = Object.create(t && t.prototype, { constructor: { value: e, enumerable: !1, writable: !0, configurable: !0 } }), t && (Object.setPrototypeOf ? Object.setPrototypeOf(e, t) : e.__proto__ = t) }(a, i), r(a, [{ key: "toString", value: function() { return "[object AbortSignal]" } }, { key: "dispatchEvent", value: function(e) { "abort" === e.type && (this.aborted = !0, "function" === typeof this.onabort && this.onabort.call(this, e)), function e(t, r, n) { null === t && (t = Function.prototype); var i = Object.getOwnPropertyDescriptor(t, r); if (void 0 === i) { var a = Object.getPrototypeOf(t); return null === a ? void 0 : e(a, r, n) } if ("value" in i) return i.value; var o = i.get; return void 0 !== o ? o.call(n) : void 0 }(a.prototype.__proto__ || Object.getPrototypeOf(a.prototype), "dispatchEvent", this).call(this, e) } }]), a }(), o = function() { function e() { t(this, e), this.signal = new a } return r(e, [{ key: "abort", value: function() { var e = void 0; try { e = new Event("abort") } catch (t) { "undefined" !== typeof document ? (e = document.createEvent("Event")).initEvent("abort", !1, !1) : e = { type: "abort", bubbles: !1, cancelable: !1 } } this.signal.dispatchEvent(e) } }, { key: "toString", value: function() { return "[object AbortController]" } }]), e }(); "undefined" !== typeof Symbol && Symbol.toStringTag && (o.prototype[Symbol.toStringTag] = "AbortController", a.prototype[Symbol.toStringTag] = "AbortSignal"), function(e) { if (!e.AbortController || function(e) { return e.navigator && (e.navigator.vendor && e.navigator.vendor.startsWith("Apple Computer") || e.navigator.userAgent && e.navigator.userAgent.match(/ (crios|gsa|fxios)\//i)) }(e)) if (e.AbortController = o, e.AbortSignal = a, e.fetch) { ``` in here, e is the window, they are using a self defined object (a, o) to replace webkit's AbortContorller and AbortSignal And in FetchRequest::initialWith if (init.signal) { if (auto* signal = JSAbortSignal::toWrapped(scriptExecutionContext()->vm(), init.signal)) m_signal->follow(*signal); else if (!init.signal.isUndefinedOrNull()) { if (auto exception = processInvalidSignal(*scriptExecutionContext())) return WTFMove(*exception); } } We do a JSAbortSignal::toWrapped, this will do a jscDynamicCast, since here it has been replaced by the polyfill, we cannot do that. In result, we have an exception here. I guess to allow this polyfill, we should call the AbortSignal's interface in js, rather than dynamic cast it here 1550601 1 youennf 2019-07-05 19:56:00 -0700 The website might be using https://github.com/mo/abortcontroller-polyfill. The website would probably need to update their polyfill. I guess a quirk is the way to go here. 1550602 2 373559 youennf 2019-07-05 20:02:18 -0700 Created attachment 373559 Patch 1550603 3 webkit-bug-importer 2019-07-05 20:02:45 -0700 <rdar://problem/52712158> 1550614 4 373559 commit-queue 2019-07-05 22:37:42 -0700 Comment on attachment 373559 Patch Clearing flags on attachment: 373559 Committed r247191: <https://trac.webkit.org/changeset/247191> 1550615 5 commit-queue 2019-07-05 22:37:44 -0700 All reviewed patches have been landed. Closing bug. 373559 2019-07-05 20:02:18 -0700 2019-07-05 22:37:42 -0700 Patch bug-199540-20190705200218.patch text/plain 1553 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRiNTY3M2IxZDgxOGIw ZGNjNDllZDlhMTZhZGIxZmMwMWYwNTgwNS4uODQ4Yzg5YTQwMTFjM2QyMDE2MjJkYWNjZjUwM2Fk OWJlN2FkZTNmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA3LTA1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBDYXJ2YW5hLmNvbSBuZWVk cyB0aGUgZmV0Y2ggQWJvcnRTaWduYWwgcXVpcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTU0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1hbnVhbGx5IHRlc3RlZC4KKworICAgICAgICAqIHBhZ2Uv UXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF1aXJrczo6c2hvdWxkSWdub3JlSW52YWxp ZFNpZ25hbCBjb25zdCk6CisKIDIwMTktMDctMDUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPiBhbmQgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBUcmlnZ2VyIGEgY29tcG9zaXRpbmcgdXBkYXRlIHdoZW4gdmlkZW8gZWxlbWVudCBpcyBj aGFuZ2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCmluZGV4IDFlMjhlYjZmM2RkMjIyMzM4MTM5NWZi MWRiNDdhN2NiNGQ5MTZlOTAuLjRhYzI2ZTQwNTA1NDVkMWU1NjRhMzZkZDY5ZjJlYmYzY2IyNDI2 ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKQEAgLTk0LDcgKzk0LDkgQEAgYm9vbCBRdWlya3M6 OnNob3VsZElnbm9yZUludmFsaWRTaWduYWwoKSBjb25zdAogICAgICAgICByZXR1cm4gZmFsc2U7 CiAKICAgICBhdXRvIGhvc3QgPSBtX2RvY3VtZW50LT50b3BEb2N1bWVudCgpLnVybCgpLmhvc3Qo KTsKLSAgICByZXR1cm4gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgInd3dy50 aHJpdmVwYXRpZW50cG9ydGFsLmNvbSIpIHx8IGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNl KGhvc3QsICJ3d3cuYm56LmNvLm56Iik7CisgICAgcmV0dXJuIGVxdWFsTGV0dGVyc0lnbm9yaW5n QVNDSUlDYXNlKGhvc3QsICJ3d3cudGhyaXZlcGF0aWVudHBvcnRhbC5jb20iKQorICAgICAgICB8 fCBlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAid3d3LmJuei5jby5ueiIpCisg ICAgICAgIHx8IGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJ3d3cuY2FydmFu YS5jb20iKTsKIH0KIAogYm9vbCBRdWlya3M6Om5lZWRzRm9ybUNvbnRyb2xUb0JlTW91c2VGb2N1 c2FibGUoKSBjb25zdAo=