199535 2019-07-05 15:04:28 -0700 WebBackForwardListItem::setPageState should receive pageState by reference 2019-07-12 13:59:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Trivial --- 104114 1 mcatanzaro mcatanzaro achristensen clopez commit-queue mcatanzaro webkit-bug-importer youennf oldest_to_newest 1550538 0 mcatanzaro 2019-07-05 15:04:28 -0700 Coverity is complaining here about copying PageState by value in the parameter list. It's sort of a false positive, in that the PageState really does need to be copied here, so this is the best we can do. But pass by value and then WTFMove() is a pretty strange way to write it. Just passing by reference would be better. Then it will be copied into m_itemState.pageState. 1550539 1 373542 mcatanzaro 2019-07-05 15:05:38 -0700 Created attachment 373542 Patch 1552034 2 373542 clopez 2019-07-11 05:58:13 -0700 Comment on attachment 373542 Patch Looks good to me. I think you need to CC some reviewers or this will be unnoticed 1552087 3 373542 youennf 2019-07-11 09:48:29 -0700 Comment on attachment 373542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373542&action=review > Source/WebKit/ChangeLog:12 > + m_itemState.pageState.. I would tend to go with setPageState(PageState&&), except if it requires too much explicit PageState { } at call sites. Doing setPageState(PageState) is somehow better than setPageState(const&) since it probably accepts both const& and && as parameters. 1552270 4 373971 mcatanzaro 2019-07-11 16:07:45 -0700 Created attachment 373971 Patch 1552271 5 mcatanzaro 2019-07-11 16:08:33 -0700 (In reply to youenn fablet from comment #3) > > Source/WebKit/ChangeLog:12 > > + m_itemState.pageState.. > > I would tend to go with setPageState(PageState&&), except if it requires too > much explicit PageState { } at call sites. Sure. There's only one callsite. 1552511 6 373971 commit-queue 2019-07-12 13:58:49 -0700 Comment on attachment 373971 Patch Clearing flags on attachment: 373971 Committed r247396: <https://trac.webkit.org/changeset/247396> 1552512 7 commit-queue 2019-07-12 13:58:50 -0700 All reviewed patches have been landed. Closing bug. 1552513 8 webkit-bug-importer 2019-07-12 13:59:19 -0700 <rdar://problem/53025386> 373542 2019-07-05 15:05:38 -0700 2019-07-11 16:07:43 -0700 Patch bug-199535-20190705170537.patch text/plain 2120 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFjMmVjZWRmZDE1NWMzMmMx NTg5NGYzNzliNGU0ZTE1YjJkYWEwMGIuLjliOTBmNTNlZGQ3MmVjYmNjNTY4NTgxN2JjMWZiYWJj NjY0M2EzY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDctMDUgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYkJhY2tGb3J3 YXJkTGlzdEl0ZW06OnNldFBhZ2VTdGF0ZSBzaG91bGQgcmVjZWl2ZSBwYWdlU3RhdGUgYnkgcmVm ZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTk1MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIENv dmVyaXR5IGlzIGNvbXBsYWluaW5nIGhlcmUgYWJvdXQgY29weWluZyBQYWdlU3RhdGUgYnkgdmFs dWUgaW4gdGhlIHBhcmFtZXRlciBsaXN0LiBJdCdzCisgICAgICAgIHNvcnQgb2YgYSBmYWxzZSBw b3NpdGl2ZSwgaW4gdGhhdCB0aGUgUGFnZVN0YXRlIHJlYWxseSBkb2VzIG5lZWQgdG8gYmUgY29w aWVkIGhlcmUsIHNvIHRoaXMKKyAgICAgICAgaXMgdGhlIGJlc3Qgd2UgY2FuIGRvLiBCdXQgcGFz cyBieSB2YWx1ZSBhbmQgdGhlbiBXVEZNb3ZlKCkgaXMgYSBwcmV0dHkgc3RyYW5nZSB3YXkgdG8g d3JpdGUKKyAgICAgICAgaXQuIEp1c3QgcGFzc2luZyBieSByZWZlcmVuY2Ugd291bGQgYmUgYmV0 dGVyLiBUaGVuIGl0IHdpbGwgYmUgY29waWVkIGludG8KKyAgICAgICAgbV9pdGVtU3RhdGUucGFn ZVN0YXRlLi4KKworICAgICAgICAqIFNoYXJlZC9XZWJCYWNrRm9yd2FyZExpc3RJdGVtLmg6Cisg ICAgICAgIChXZWJLaXQ6OldlYkJhY2tGb3J3YXJkTGlzdEl0ZW06OnNldFBhZ2VTdGF0ZSk6CisK IDIwMTktMDctMDUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb Q29udGVudENoYW5nZU9ic2VydmVyXSBSRUdSRVNTSU9OIChyMjQ3MDE1KTogZmFjZWJvb2sgcGhv dG8vdmlkZW8gdXBsb2FkIGJ1dHRvbiBpcyB1bnJlc3BvbnNpdmUgdG8gdXNlciBpbnRlcmFjdGlv bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkJhY2tGb3J3YXJkTGlzdEl0 ZW0uaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkJhY2tGb3J3YXJkTGlzdEl0ZW0uaAppbmRl eCAzYjliMGJmZDliMWU0OGI3NTYzMjljNTVjNmE0NDJkYTlkZTE5OTY5Li41MzY5YzcxY2QyYWVj M2VmNTg2NTU0MzdhZDc5NzJlNGYyODc4MDkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1No YXJlZC9XZWJCYWNrRm9yd2FyZExpc3RJdGVtLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQv V2ViQmFja0ZvcndhcmRMaXN0SXRlbS5oCkBAIC02MCw3ICs2MCw3IEBAIHB1YmxpYzoKICAgICBX ZWJDb3JlOjpQcm9jZXNzSWRlbnRpZmllciBsYXN0UHJvY2Vzc0lkZW50aWZpZXIoKSBjb25zdCB7 IHJldHVybiBtX2xhc3RQcm9jZXNzSWRlbnRpZmllcjsgfQogICAgIHZvaWQgc2V0TGFzdFByb2Nl c3NJZGVudGlmaWVyKGNvbnN0IFdlYkNvcmU6OlByb2Nlc3NJZGVudGlmaWVyJiBpZGVudGlmaWVy KSB7IG1fbGFzdFByb2Nlc3NJZGVudGlmaWVyID0gaWRlbnRpZmllcjsgfQogCi0gICAgdm9pZCBz ZXRQYWdlU3RhdGUoUGFnZVN0YXRlIHBhZ2VTdGF0ZSkgeyBtX2l0ZW1TdGF0ZS5wYWdlU3RhdGUg PSBXVEZNb3ZlKHBhZ2VTdGF0ZSk7IH0KKyAgICB2b2lkIHNldFBhZ2VTdGF0ZShjb25zdCBQYWdl U3RhdGUmIHBhZ2VTdGF0ZSkgeyBtX2l0ZW1TdGF0ZS5wYWdlU3RhdGUgPSBwYWdlU3RhdGU7IH0K ICAgICBjb25zdCBQYWdlU3RhdGUmIHBhZ2VTdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1faXRlbVN0 YXRlLnBhZ2VTdGF0ZTsgfQogCiAgICAgY29uc3QgU3RyaW5nJiBvcmlnaW5hbFVSTCgpIGNvbnN0 IHsgcmV0dXJuIG1faXRlbVN0YXRlLnBhZ2VTdGF0ZS5tYWluRnJhbWVTdGF0ZS5vcmlnaW5hbFVS TFN0cmluZzsgfQo= 373971 2019-07-11 16:07:45 -0700 2019-07-12 13:58:49 -0700 Patch bug-199535-20190711180744.patch text/plain 2751 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlNjEwNTY1NzkyOTY0NDE4 YWVkMzI2ZGQzYjdhN2RkZDNkYjhlZGUuLjI2ZTYwZmIwNzU4NzlkOTdiZDdjZjQwNmY5OTAxMjli MWE5YmFkY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDctMTEgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYkJhY2tGb3J3 YXJkTGlzdEl0ZW06OnNldFBhZ2VTdGF0ZSBzaG91bGQgcmVjZWl2ZSBwYWdlU3RhdGUgYnkgcnZh bHVlIHJlZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk5NTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKworICAg ICAgICBDb3Zlcml0eSBpcyBjb21wbGFpbmluZyBoZXJlIGFib3V0IGNvcHlpbmcgUGFnZVN0YXRl IGJ5IHZhbHVlIGluIHRoZSBwYXJhbWV0ZXIgbGlzdC4gSXQncworICAgICAgICBzb3J0IG9mIGEg ZmFsc2UgcG9zaXRpdmUsIGluIHRoYXQgdGhlIFBhZ2VTdGF0ZSByZWFsbHkgZG9lcyBuZWVkIHRv IGJlIGNvcGllZCBoZXJlLCBzbyB0aGlzCisgICAgICAgIGlzIHRoZSBiZXN0IHdlIGNhbiBkby4g QnV0IHBhc3MgYnkgdmFsdWUgYW5kIHRoZW4gV1RGTW92ZSgpIGlzIGEgcHJldHR5IHN0cmFuZ2Ug d2F5IHRvIHdyaXRlCisgICAgICAgIGl0LiBQYXNzaW5nIGJ5IHJ2YWx1ZSByZWZlcmVuY2Ugd291 bGQgYmUgYmV0dGVyLiBUaGlzIG1ha2VzIHRoZSBjb3B5IG1vcmUgY2xlYXIuCisKKyAgICAgICAg KiBTaGFyZWQvV2ViQmFja0ZvcndhcmRMaXN0SXRlbS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJC YWNrRm9yd2FyZExpc3RJdGVtOjpzZXRQYWdlU3RhdGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OnVw ZGF0ZUJhY2tGb3J3YXJkSXRlbSk6CisKIDIwMTktMDctMTEgIENvbW1pdCBRdWV1ZSAgPGNvbW1p dC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIy NDczMTQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJCYWNrRm9yd2FyZExp c3RJdGVtLmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJCYWNrRm9yd2FyZExpc3RJdGVtLmgK aW5kZXggM2I5YjBiZmQ5YjFlNDhiNzU2MzI5YzU1YzZhNDQyZGE5ZGUxOTk2OS4uM2E0NWUxY2I3 YTc5MjU4OWY4OTA0NDAwZWEzNTlkYWJiYjc1MjAzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViQmFja0ZvcndhcmRMaXN0SXRlbS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hh cmVkL1dlYkJhY2tGb3J3YXJkTGlzdEl0ZW0uaApAQCAtNjAsNyArNjAsNyBAQCBwdWJsaWM6CiAg ICAgV2ViQ29yZTo6UHJvY2Vzc0lkZW50aWZpZXIgbGFzdFByb2Nlc3NJZGVudGlmaWVyKCkgY29u c3QgeyByZXR1cm4gbV9sYXN0UHJvY2Vzc0lkZW50aWZpZXI7IH0KICAgICB2b2lkIHNldExhc3RQ cm9jZXNzSWRlbnRpZmllcihjb25zdCBXZWJDb3JlOjpQcm9jZXNzSWRlbnRpZmllciYgaWRlbnRp ZmllcikgeyBtX2xhc3RQcm9jZXNzSWRlbnRpZmllciA9IGlkZW50aWZpZXI7IH0KIAotICAgIHZv aWQgc2V0UGFnZVN0YXRlKFBhZ2VTdGF0ZSBwYWdlU3RhdGUpIHsgbV9pdGVtU3RhdGUucGFnZVN0 YXRlID0gV1RGTW92ZShwYWdlU3RhdGUpOyB9CisgICAgdm9pZCBzZXRQYWdlU3RhdGUoUGFnZVN0 YXRlJiYgcGFnZVN0YXRlKSB7IG1faXRlbVN0YXRlLnBhZ2VTdGF0ZSA9IFdURk1vdmUocGFnZVN0 YXRlKTsgfQogICAgIGNvbnN0IFBhZ2VTdGF0ZSYgcGFnZVN0YXRlKCkgY29uc3QgeyByZXR1cm4g bV9pdGVtU3RhdGUucGFnZVN0YXRlOyB9CiAKICAgICBjb25zdCBTdHJpbmcmIG9yaWdpbmFsVVJM KCkgY29uc3QgeyByZXR1cm4gbV9pdGVtU3RhdGUucGFnZVN0YXRlLm1haW5GcmFtZVN0YXRlLm9y aWdpbmFsVVJMU3RyaW5nOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1By b3h5LmNwcAppbmRleCA0MDRiNDM4OTc1YjUyMThiOTFhYWE2NWQwNmQ5YjA3MmE2ZDljYTkwLi5l YTQyZjBjYjJjZWYxNmNhYmQyNTg2ODI0MWU3ZjlhYTU3MDE5YjA3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKQEAgLTU5Miw3ICs1OTIsNyBAQCB2b2lk IFdlYlByb2Nlc3NQcm94eTo6dXBkYXRlQmFja0ZvcndhcmRJdGVtKGNvbnN0IEJhY2tGb3J3YXJk TGlzdEl0ZW1TdGF0ZSYgaXRlbQogICAgIGlmICghaXRlbSB8fCAhaXNBbGxvd2VkVG9VcGRhdGVC YWNrRm9yd2FyZEl0ZW0oKml0ZW0pKQogICAgICAgICByZXR1cm47CiAKLSAgICBpdGVtLT5zZXRQ YWdlU3RhdGUoaXRlbVN0YXRlLnBhZ2VTdGF0ZSk7CisgICAgaXRlbS0+c2V0UGFnZVN0YXRlKFBh Z2VTdGF0ZSB7IGl0ZW1TdGF0ZS5wYWdlU3RhdGUgfSk7CiB9CiAKICNpZiBFTkFCTEUoTkVUU0NB UEVfUExVR0lOX0FQSSkK