199534 2019-07-05 15:03:43 -0700 Mail's use of punchOutWhiteBackgroundsInDarkMode not working on iOS 2019-07-05 16:19:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bdakin bfulgham commit-queue dino simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1550537 0 timothy 2019-07-05 15:03:43 -0700 Some Mail with white backgrounds are showing black instead of the system background color. <rdar://problem/52586836> 1550542 1 373544 timothy 2019-07-05 15:11:21 -0700 Created attachment 373544 Patch 1550553 2 373544 simon.fraser 2019-07-05 15:49:39 -0700 Comment on attachment 373544 Patch Would be nice to test this. 1550562 3 373544 commit-queue 2019-07-05 16:19:40 -0700 Comment on attachment 373544 Patch Clearing flags on attachment: 373544 Committed r247184: <https://trac.webkit.org/changeset/247184> 1550563 4 commit-queue 2019-07-05 16:19:42 -0700 All reviewed patches have been landed. Closing bug. 373544 2019-07-05 15:11:21 -0700 2019-07-05 16:19:40 -0700 Patch bug-199534-20190705151121.patch text/plain 7444 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmRjMGIzMmM0YjY3MmRj NmI0NTVmNjgyZWIyZDU2NTNkODg1OGY2NS4uZmM0ODgwZjJhYjM0ZTQyOGEyM2U1ZmRiY2Q3ZDdk YmI4NTAyZmU2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTA3LTA1ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBNYWlsJ3MgdXNlIG9m IHB1bmNoT3V0V2hpdGVCYWNrZ3JvdW5kc0luRGFya01vZGUgbm90IHdvcmtpbmcgb24gaU9TLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NTM0Cisg ICAgICAgIHJkYXI6Ly9wcm9ibGVtLzUyNTg2ODM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHM6IGNzczMvY29sb3ItZmlsdGVycy9wdW5jaC1v dXQtd2hpdGUtYmFja2dyb3VuZHMuaHRtbAorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpjb21wb3NpdGVPcGVyYXRvckZvckJhY2tncm91 bmRDb2xvciBjb25zdCk6IEFkZGVkLgorICAgICAgICBVc2UgQ29tcG9zaXRlRGVzdGluYXRpb25P dXQgZm9yIHRyYW5zcGFyZW50IGZyYW1lcywgb3RoZXJ3aXNlIENvbXBvc2l0ZURlc3RpbmF0aW9u SW4uCisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisgICAgICAgICogcmVuZGVyaW5nL0lubGlu ZUZsb3dCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5saW5lRmxvd0JveDo6cGFpbnRCb3hE ZWNvcmF0aW9ucyk6IFVzZSBjb21wb3NpdGVPcGVyYXRvckZvckJhY2tncm91bmRDb2xvci4KKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJveDo6cGFpbnRSb290Qm94RmlsbExheWVycyk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyQm94OjpwYWludEJhY2tncm91bmQpOiBEaXR0by4KKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyVGFibGVDZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ2VsbDo6 cGFpbnRCYWNrZ3JvdW5kc0JlaGluZENlbGwpOiBEaXR0by4KKwogMjAxOS0wNy0wNSAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBbaU9TXSBDcmFzaCBpbiBXZWJL aXQ6OldlYlBhZ2U6OnBvc2l0aW9uSW5mb3JtYXRpb24gdmlhIFJhbmdlOjpzdGFydFBvc2l0aW9u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCA3OGU1OTEyNzUwOGQ5OGY5NzUzOTg1ODc2MWI0 ZGQzNjQ5ZTJhYWQyLi41Y2ZkYWFmYmVkNGUyY2ZjMDlhYjliZmQ4OGE2ZDJjZTdiOTVkNDMwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTY5NzcsNiArNjk3NywyMCBAQCBPcHRpb25TZXQ8 U3R5bGVDb2xvcjo6T3B0aW9ucz4gRG9jdW1lbnQ6OnN0eWxlQ29sb3JPcHRpb25zKGNvbnN0IFJl bmRlclN0eWxlKiBzdAogICAgIHJldHVybiBvcHRpb25zOwogfQogCitDb21wb3NpdGVPcGVyYXRv ciBEb2N1bWVudDo6Y29tcG9zaXRlT3BlcmF0b3JGb3JCYWNrZ3JvdW5kQ29sb3IoY29uc3QgQ29s b3ImIGNvbG9yLCBjb25zdCBSZW5kZXJPYmplY3QmIHJlbmRlcmVyKSBjb25zdAoreworICAgIGlm IChMSUtFTFkoIXNldHRpbmdzKCkucHVuY2hPdXRXaGl0ZUJhY2tncm91bmRzSW5EYXJrTW9kZSgp IHx8ICFDb2xvcjo6aXNXaGl0ZUNvbG9yKGNvbG9yKSB8fCAhcmVuZGVyZXIudXNlRGFya0FwcGVh cmFuY2UoKSkpCisgICAgICAgIHJldHVybiBDb21wb3NpdGVTb3VyY2VPdmVyOworCisgICAgYXV0 byogZnJhbWVWaWV3ID0gdmlldygpOworICAgIGlmICghZnJhbWVWaWV3KQorICAgICAgICByZXR1 cm4gQ29tcG9zaXRlU291cmNlT3ZlcjsKKworICAgIC8vIE1haWwgb24gbWFjT1MgdXNlcyBhIHRy YW5zcGFyZW50IHZpZXcsIGFuZCBvbiBpT1MgaXQgaXMgYW4gb3BhcXVlIHZpZXcuIFdlIG5lZWQg dG8KKyAgICAvLyB1c2UgZGlmZmVyZW50IGNvbXBvc2l0ZSBtb2RlcyB0byBnZXQgdGhlIHJpZ2h0 IHJlc3VsdHMgaW4gdGhpcyBjYXNlLgorICAgIHJldHVybiBmcmFtZVZpZXctPmlzVHJhbnNwYXJl bnQoKSA/IENvbXBvc2l0ZURlc3RpbmF0aW9uT3V0IDogQ29tcG9zaXRlRGVzdGluYXRpb25JbjsK K30KKwogdm9pZCBEb2N1bWVudDo6ZGlkQXNzb2NpYXRlRm9ybUNvbnRyb2woRWxlbWVudCYgZWxl bWVudCkKIHsKICAgICBhdXRvKiBwYWdlID0gdGhpcy0+cGFnZSgpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQu aAppbmRleCBhMWM4YjE0Y2E5NjA1NTU5YTEyNTM4YWJhYzRjOGNmMGM3NWExYTM5Li43ODkzMjQ4 ZDliYzVlZGZhYTNhNjM1NjE0OTQwZGM4MzQ4Y2IwNTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaApA QCAtMzksNiArMzksNyBAQAogI2luY2x1ZGUgIkZvbnRTZWxlY3RvckNsaWVudC5oIgogI2luY2x1 ZGUgIkZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZlci5oIgogI2luY2x1ZGUgIkdlbmVyaWNUYXNrUXVl dWUuaCIKKyNpbmNsdWRlICJHcmFwaGljc1R5cGVzLmgiCiAjaW5jbHVkZSAiTWVkaWFQcm9kdWNl ci5oIgogI2luY2x1ZGUgIk11dGF0aW9uT2JzZXJ2ZXIuaCIKICNpbmNsdWRlICJPcmllbnRhdGlv bk5vdGlmaWVyLmgiCkBAIC01NjgsNiArNTY5LDcgQEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQ T1JUIGJvb2wgdXNlRGFya0FwcGVhcmFuY2UoY29uc3QgUmVuZGVyU3R5bGUqKSBjb25zdDsKIAog ICAgIE9wdGlvblNldDxTdHlsZUNvbG9yOjpPcHRpb25zPiBzdHlsZUNvbG9yT3B0aW9ucyhjb25z dCBSZW5kZXJTdHlsZSopIGNvbnN0OworICAgIENvbXBvc2l0ZU9wZXJhdG9yIGNvbXBvc2l0ZU9w ZXJhdG9yRm9yQmFja2dyb3VuZENvbG9yKGNvbnN0IENvbG9yJiwgY29uc3QgUmVuZGVyT2JqZWN0 JikgY29uc3Q7CiAKICAgICBXRUJDT1JFX0VYUE9SVCBSZWY8UmFuZ2U+IGNyZWF0ZVJhbmdlKCk7 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcAppbmRleCA0ZmU3 OTMxMTdiYjQxYzZlNzEzNTEwOGQwMDE2NTQ4ODhiYTYyNDNhLi4yYTFiYzI4OWI0M2MyNWQ3NTFi YWMwYTc3MDMyNzEzZTBjNjA5NzMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvSW5saW5lRmxvd0JveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGlu ZUZsb3dCb3guY3BwCkBAIC0xMzY5LDExICsxMzY5LDggQEAgdm9pZCBJbmxpbmVGbG93Qm94Ojpw YWludEJveERlY29yYXRpb25zKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQb2lu dCYKICAgICBpZiAoIXJlbmRlcmVyKCkuYm94U2hhZG93U2hvdWxkQmVBcHBsaWVkVG9CYWNrZ3Jv dW5kKGFkanVzdGVkUGFpbnRvZmZzZXQsIEJhY2tncm91bmRCbGVlZE5vbmUsIHRoaXMpKQogICAg ICAgICBwYWludEJveFNoYWRvdyhwYWludEluZm8sIGxpbmVTdHlsZSwgTm9ybWFsLCBwYWludFJl Y3QpOwogCi0gICAgQ29sb3IgY29sb3IgPSBsaW5lU3R5bGUudmlzaXRlZERlcGVuZGVudENvbG9y KENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKTsKLQotICAgIENvbXBvc2l0ZU9wZXJhdG9yIGNv bXBvc2l0ZU9wID0gQ29tcG9zaXRlU291cmNlT3ZlcjsKLSAgICBpZiAocmVuZGVyZXIoKS5kb2N1 bWVudCgpLnNldHRpbmdzKCkucHVuY2hPdXRXaGl0ZUJhY2tncm91bmRzSW5EYXJrTW9kZSgpICYm IENvbG9yOjppc1doaXRlQ29sb3IoY29sb3IpICYmIHJlbmRlcmVyKCkudXNlRGFya0FwcGVhcmFu Y2UoKSkKLSAgICAgICAgY29tcG9zaXRlT3AgPSBDb21wb3NpdGVEZXN0aW5hdGlvbk91dDsKKyAg ICBhdXRvIGNvbG9yID0gbGluZVN0eWxlLnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0 eUJhY2tncm91bmRDb2xvcik7CisgICAgYXV0byBjb21wb3NpdGVPcCA9IHJlbmRlcmVyKCkuZG9j dW1lbnQoKS5jb21wb3NpdGVPcGVyYXRvckZvckJhY2tncm91bmRDb2xvcihjb2xvciwgcmVuZGVy ZXIoKSk7CiAKICAgICBjb2xvciA9IGxpbmVTdHlsZS5jb2xvckJ5QXBwbHlpbmdDb2xvckZpbHRl cihjb2xvcik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC b3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggYzdl ZDIyMzU4YjAxZDJiOTRmNTI2YTk1MDkwYTg1N2FlMjZmOGZiNy4uMjFkZWI4OGViMWE5NDI5N2Q3 NjZjY2QzMTIwZjcyZDc3N2JlMzNmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJv eC5jcHAKQEAgLTEyNTcsMTIgKzEyNTcsOCBAQCB2b2lkIFJlbmRlckJveDo6cGFpbnRSb290Qm94 RmlsbExheWVycyhjb25zdCBQYWludEluZm8mIHBhaW50SW5mbykKICAgICAgICAgcmV0dXJuOwog CiAgICAgYXV0byYgc3R5bGUgPSByb290QmFja2dyb3VuZFJlbmRlcmVyLT5zdHlsZSgpOwotCiAg ICAgYXV0byBjb2xvciA9IHN0eWxlLnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUJh Y2tncm91bmRDb2xvcik7Ci0KLSAgICBDb21wb3NpdGVPcGVyYXRvciBjb21wb3NpdGVPcCA9IENv bXBvc2l0ZVNvdXJjZU92ZXI7Ci0gICAgaWYgKGRvY3VtZW50KCkuc2V0dGluZ3MoKS5wdW5jaE91 dFdoaXRlQmFja2dyb3VuZHNJbkRhcmtNb2RlKCkgJiYgQ29sb3I6OmlzV2hpdGVDb2xvcihjb2xv cikgJiYgdXNlRGFya0FwcGVhcmFuY2UoKSkKLSAgICAgICAgY29tcG9zaXRlT3AgPSBDb21wb3Np dGVEZXN0aW5hdGlvbk91dDsKKyAgICBhdXRvIGNvbXBvc2l0ZU9wID0gZG9jdW1lbnQoKS5jb21w b3NpdGVPcGVyYXRvckZvckJhY2tncm91bmRDb2xvcihjb2xvciwgKnRoaXMpOwogCiAgICAgcGFp bnRGaWxsTGF5ZXJzKHBhaW50SW5mbywgc3R5bGUuY29sb3JCeUFwcGx5aW5nQ29sb3JGaWx0ZXIo Y29sb3IpLCBzdHlsZS5iYWNrZ3JvdW5kTGF5ZXJzKCksIHZpZXcoKS5iYWNrZ3JvdW5kUmVjdCgp LCBCYWNrZ3JvdW5kQmxlZWROb25lLCBjb21wb3NpdGVPcCwgcm9vdEJhY2tncm91bmRSZW5kZXJl cik7CiB9CkBAIC0xMzkzLDExICsxMzg5LDggQEAgdm9pZCBSZW5kZXJCb3g6OnBhaW50QmFja2dy b3VuZChjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UmVjdCYgcGEKICAg ICBpZiAoYmFja2dyb3VuZElzS25vd25Ub0JlT2JzY3VyZWQocGFpbnRSZWN0LmxvY2F0aW9uKCkp ICYmICFib3hTaGFkb3dTaG91bGRCZUFwcGxpZWRUb0JhY2tncm91bmQocGFpbnRSZWN0LmxvY2F0 aW9uKCksIGJsZWVkQXZvaWRhbmNlKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgQ29sb3IgYmFj a2dyb3VuZENvbG9yID0gc3R5bGUoKS52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlC YWNrZ3JvdW5kQ29sb3IpOwotCi0gICAgQ29tcG9zaXRlT3BlcmF0b3IgY29tcG9zaXRlT3AgPSBD b21wb3NpdGVTb3VyY2VPdmVyOwotICAgIGlmIChkb2N1bWVudCgpLnNldHRpbmdzKCkucHVuY2hP dXRXaGl0ZUJhY2tncm91bmRzSW5EYXJrTW9kZSgpICYmIENvbG9yOjppc1doaXRlQ29sb3IoYmFj a2dyb3VuZENvbG9yKSAmJiB1c2VEYXJrQXBwZWFyYW5jZSgpKQotICAgICAgICBjb21wb3NpdGVP cCA9IENvbXBvc2l0ZURlc3RpbmF0aW9uT3V0OworICAgIGF1dG8gYmFja2dyb3VuZENvbG9yID0g c3R5bGUoKS52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3Ip OworICAgIGF1dG8gY29tcG9zaXRlT3AgPSBkb2N1bWVudCgpLmNvbXBvc2l0ZU9wZXJhdG9yRm9y QmFja2dyb3VuZENvbG9yKGJhY2tncm91bmRDb2xvciwgKnRoaXMpOwogCiAgICAgcGFpbnRGaWxs TGF5ZXJzKHBhaW50SW5mbywgc3R5bGUoKS5jb2xvckJ5QXBwbHlpbmdDb2xvckZpbHRlcihiYWNr Z3JvdW5kQ29sb3IpLCBzdHlsZSgpLmJhY2tncm91bmRMYXllcnMoKSwgcGFpbnRSZWN0LCBibGVl ZEF2b2lkYW5jZSwgY29tcG9zaXRlT3ApOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGFibGVDZWxsLmNwcAppbmRleCA3ZmMyMzBjMzEzODQwZTM5ZjJjOWIwMTlmNWQzODY5 MGNkNTRhNzVjLi41MWExMTAzZmUyMmJiZTU4N2U0OGFhZDQ5YmZkNTA5NmY4NjczYWM5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcApAQCAtMTI4Nywx MCArMTI4Nyw4IEBAIHZvaWQgUmVuZGVyVGFibGVDZWxsOjpwYWludEJhY2tncm91bmRzQmVoaW5k Q2VsbChQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5CiAgICAgY29uc3QgYXV0byYgc3R5 bGUgPSBiYWNrZ3JvdW5kT2JqZWN0LT5zdHlsZSgpOwogICAgIGF1dG8mIGJnTGF5ZXIgPSBzdHls ZS5iYWNrZ3JvdW5kTGF5ZXJzKCk7CiAKLSAgICBDb21wb3NpdGVPcGVyYXRvciBjb21wb3NpdGVP cCA9IENvbXBvc2l0ZVNvdXJjZU92ZXI7Ci0gICAgQ29sb3IgY29sb3IgPSBzdHlsZS52aXNpdGVk RGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3IpOwotICAgIGlmIChkb2N1 bWVudCgpLnNldHRpbmdzKCkucHVuY2hPdXRXaGl0ZUJhY2tncm91bmRzSW5EYXJrTW9kZSgpICYm IENvbG9yOjppc1doaXRlQ29sb3IoY29sb3IpICYmIHVzZURhcmtBcHBlYXJhbmNlKCkpCi0gICAg ICAgIGNvbXBvc2l0ZU9wID0gQ29tcG9zaXRlRGVzdGluYXRpb25PdXQ7CisgICAgYXV0byBjb2xv ciA9IHN0eWxlLnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xv cik7CisgICAgYXV0byBjb21wb3NpdGVPcCA9IGRvY3VtZW50KCkuY29tcG9zaXRlT3BlcmF0b3JG b3JCYWNrZ3JvdW5kQ29sb3IoY29sb3IsICp0aGlzKTsKIAogICAgIGNvbG9yID0gc3R5bGUuY29s b3JCeUFwcGx5aW5nQ29sb3JGaWx0ZXIoY29sb3IpOwogCg==