199532 2019-07-05 14:54:36 -0700 [GTK] ViewGestureController constructor leaves m_direction uninitialized 2019-07-08 01:17:31 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 104114 1 mcatanzaro mcatanzaro alicem bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1550530 0 mcatanzaro 2019-07-05 14:54:36 -0700 ViewGestureController constructor leaves m_direction uninitialized This is harmless because it should never be read until after it's initialized, but still not robust. 1550531 1 373541 mcatanzaro 2019-07-05 14:55:59 -0700 Created attachment 373541 Patch 1550536 2 mcatanzaro 2019-07-05 15:01:38 -0700 P.S. Exalm, you should add yourself to Tools/Scripts/webkitpy/common/config/contributors.json so you'll be easier to CC ;) 1550555 3 alicem 2019-07-05 15:56:51 -0700 Oops. :) But yeah, it's always initialized before it's used. 1550769 4 373541 commit-queue 2019-07-08 01:17:30 -0700 Comment on attachment 373541 Patch Clearing flags on attachment: 373541 Committed r247203: <https://trac.webkit.org/changeset/247203> 1550770 5 commit-queue 2019-07-08 01:17:31 -0700 All reviewed patches have been landed. Closing bug. 373541 2019-07-05 14:55:59 -0700 2019-07-08 01:17:30 -0700 Patch bug-199532-20190705165558.patch text/plain 1504 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFjMmVjZWRmZDE1NWMzMmMx NTg5NGYzNzliNGU0ZTE1YjJkYWEwMGIuLjkwYThhZTJjNTc1N2UyMGU4NjhiNDE1YjEyODEyMjVj NGZkMmRmYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDctMDUgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFZpZXdH ZXN0dXJlQ29udHJvbGxlciBjb25zdHJ1Y3RvciBsZWF2ZXMgbV9kaXJlY3Rpb24gdW5pbml0aWFs aXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5 NTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBpcyBoYXJtbGVzcyBiZWNhdXNlIGl0IHNob3VsZCBuZXZlciBiZSByZWFkIHVudGlsIGFmdGVy IGl0J3MgaW5pdGlhbGl6ZWQsIGJ1dCBzdGlsbCBub3QKKyAgICAgICAgcm9idXN0LiBGaXggaXQg YnkgYXNzdW1pbmcgQmFjayBhcyB0aGUgZGVmYXVsdCB2YWx1ZSB1bnRpbCB0aGUgZmlyc3Qgc3dp cGUgYmVnaW5zLgorCisgICAgICAgICogVUlQcm9jZXNzL1ZpZXdHZXN0dXJlQ29udHJvbGxlci5o OgorCiAyMDE5LTA3LTA1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgW0NvbnRlbnRDaGFuZ2VPYnNlcnZlcl0gUkVHUkVTU0lPTiAocjI0NzAxNSk6IGZhY2Vib29r IHBob3RvL3ZpZGVvIHVwbG9hZCBidXR0b24gaXMgdW5yZXNwb25zaXZlIHRvIHVzZXIgaW50ZXJh Y3Rpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9WaWV3R2VzdHVyZUNv bnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1ZpZXdHZXN0dXJlQ29udHJvbGxl ci5oCmluZGV4IDdiMDIwZWY1ZjA2MzFmMDhhODcxMTUwMDVjYjhhZmNiODhjYWQyYTQuLjdjZDZl OGZlMDkxMjRiOWI0ZWQ4ZGYwNjAyM2Y1NjczMzIyNmVjNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1ZpZXdHZXN0dXJlQ29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1ZpZXdHZXN0dXJlQ29udHJvbGxlci5oCkBAIC0zODgsNyArMzg4LDcgQEAg cHJpdmF0ZToKIAogICAgICAgICBTdGF0ZSBtX3N0YXRlIHsgU3RhdGU6Ok5vbmUgfTsKIAotICAg ICAgICBTd2lwZURpcmVjdGlvbiBtX2RpcmVjdGlvbjsKKyAgICAgICAgU3dpcGVEaXJlY3Rpb24g bV9kaXJlY3Rpb24geyBTd2lwZURpcmVjdGlvbjo6QmFjayB9OwogICAgICAgICBSZWZQdHI8V2Vi QmFja0ZvcndhcmRMaXN0SXRlbT4gbV90YXJnZXRJdGVtOwogICAgICAgICB1bnNpZ25lZCBtX3Rp Y2tDYWxsYmFja0lEIHsgMCB9OwogCg==