199498 2019-07-04 07:46:20 -0700 Scribble Heap::m_worldState on destructor 2019-07-05 11:58:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff rmorisset saam sam webkit-bug-importer ysuzuki oldest_to_newest 1550237 0 tzagallo 2019-07-04 07:46:20 -0700 ... 1550238 1 373465 tzagallo 2019-07-04 07:49:50 -0700 Created attachment 373465 Patch 1550273 2 373465 sam 2019-07-04 15:24:32 -0700 Comment on attachment 373465 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review > Source/JavaScriptCore/heap/Heap.cpp:342 > + m_worldState.store(0xbadbeef0u); I think a comment here clarifying why this store is being made would be instructive. 1550309 3 373465 tzagallo 2019-07-05 01:08:01 -0700 Comment on attachment 373465 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review Thanks for the review! >> Source/JavaScriptCore/heap/Heap.cpp:342 >> + m_worldState.store(0xbadbeef0u); > > I think a comment here clarifying why this store is being made would be instructive. That makes sense, I'll add it. 1550310 4 373483 tzagallo 2019-07-05 01:10:22 -0700 Created attachment 373483 Patch for landing 1550403 5 373483 commit-queue 2019-07-05 09:38:47 -0700 Comment on attachment 373483 Patch for landing Clearing flags on attachment: 373483 Committed r247160: <https://trac.webkit.org/changeset/247160> 1550404 6 commit-queue 2019-07-05 09:38:48 -0700 All reviewed patches have been landed. Closing bug. 1550405 7 webkit-bug-importer 2019-07-05 09:39:15 -0700 <rdar://problem/52690607> 1550449 8 tzagallo 2019-07-05 11:37:40 -0700 I just realized this value won't work... it will clear the conn bit. I'll land a follow-up patch to change it to 0xbadbeeff. 1550456 9 tzagallo 2019-07-05 11:58:07 -0700 Committed r247166: <https://trac.webkit.org/changeset/247166> 373465 2019-07-04 07:49:50 -0700 2019-07-05 01:10:18 -0700 Patch bug-199498-20190704164949.patch text/plain 1297 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NTk1OWFmYzAxOWY0NjkxNGY2MmExMjZhYmJjN2MzMmYzMTY3ZDIyLi5hYWQ5NmMwNjI2OTBhM2Jh YWNmOGRkMzhlYWNjNTIwMmJkNzU4ODY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNy0wNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBTY3JpYmJsZSBIZWFwOjptX3dvcmxkU3RhdGUgb24gZGVzdHJ1Y3Rvcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NDk4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHdvcmxk U3RhdGUgaXMgZHVtcGVkIHdoZW4gd2UgY3Jhc2ggZHVlIHRvIGEgZmFpbGVkIGNoZWNrQ29ubiwg YW5kCisgICAgICAgIHRoaXMgd2lsbCBtYWtlIGl0IGNsZWFyIGlmIHRoZSBoZWFwIGhhcyBhbHJl YWR5IGJlZW4gZGVzdHJveWVkLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAg KEpTQzo6SGVhcDo6fkhlYXApOgorCiAyMDE5LTA3LTAzICBTYW0gV2VpbmlnICA8d2VpbmlnQGFw cGxlLmNvbT4KIAogICAgICAgICBBZG9wdCBzaW1wbGUgc3RydWN0dXJlZCBiaW5kaW5ncyBpbiBt b3JlIHBsYWNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAppbmRleCBiN2U0MzAxYTRh OTk1ZDVjNTZkOGIyNmJjZDUzYjBmOGU0MzZiNjY0Li5hYzhkYmM0NGUyZDI4ZTU1MDczOTYzYTFh YTcxYzcwOWZlMDVhYWU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9I ZWFwLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcApAQCAtMzM5 LDYgKzMzOSw4IEBAIEhlYXA6OkhlYXAoVk0qIHZtLCBIZWFwVHlwZSBoZWFwVHlwZSkKIAogSGVh cDo6fkhlYXAoKQogeworICAgIG1fd29ybGRTdGF0ZS5zdG9yZSgweGJhZGJlZWYwdSk7CisKICAg ICBmb3JFYWNoU2xvdFZpc2l0b3IoCiAgICAgICAgIFsmXSAoU2xvdFZpc2l0b3ImIHZpc2l0b3Ip IHsKICAgICAgICAgICAgIHZpc2l0b3IuY2xlYXJNYXJrU3RhY2tzKCk7Cg== 373483 2019-07-05 01:10:22 -0700 2019-07-05 09:38:47 -0700 Patch for landing bug-199498-20190705101021.patch text/plain 1406 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NTk1OWFmYzAxOWY0NjkxNGY2MmExMjZhYmJjN2MzMmYzMTY3ZDIyLi5kNTAyNGVmZjcwOTMxOGVh MjQwYTMzMzNjMmZiMTcwYTFkZDYwOWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNy0wNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBTY3JpYmJsZSBIZWFwOjptX3dvcmxkU3RhdGUgb24gZGVzdHJ1Y3Rvcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5NDk4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KKworICAgICAgICBUaGUgd29ybGRTdGF0 ZSBpcyBkdW1wZWQgd2hlbiB3ZSBjcmFzaCBkdWUgdG8gYSBmYWlsZWQgY2hlY2tDb25uLCBhbmQK KyAgICAgICAgdGhpcyB3aWxsIG1ha2UgaXQgY2xlYXIgaWYgdGhlIGhlYXAgaGFzIGFscmVhZHkg YmVlbiBkZXN0cm95ZWQuCisKKyAgICAgICAgKiBoZWFwL0hlYXAuY3BwOgorICAgICAgICAoSlND OjpIZWFwOjp+SGVhcCk6CisKIDIwMTktMDctMDMgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkb3B0IHNpbXBsZSBzdHJ1Y3R1cmVkIGJpbmRpbmdzIGluIG1vcmUg cGxhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCmluZGV4IGI3ZTQzMDFhNGE5OTVk NWM1NmQ4YjI2YmNkNTNiMGY4ZTQzNmI2NjQuLmRiZDljYmY4MGEwM2JjNDVkMDlmNjc3MDA3Zjcx ODhkYTRmYmI1M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCkBAIC0zMzksNiAr MzM5LDkgQEAgSGVhcDo6SGVhcChWTSogdm0sIEhlYXBUeXBlIGhlYXBUeXBlKQogCiBIZWFwOjp+ SGVhcCgpCiB7CisgICAgLy8gU2NyaWJibGUgbV93b3JsZFN0YXRlIHRvIG1ha2UgaXQgY2xlYXIg dGhhdCB0aGUgaGVhcCBoYXMgYWxyZWFkeSBiZWVuIGRlc3Ryb3llZCBpZiB3ZSBjcmFzaCBpbiBj aGVja0Nvbm4KKyAgICBtX3dvcmxkU3RhdGUuc3RvcmUoMHhiYWRiZWVmMHUpOworCiAgICAgZm9y RWFjaFNsb3RWaXNpdG9yKAogICAgICAgICBbJl0gKFNsb3RWaXNpdG9yJiB2aXNpdG9yKSB7CiAg ICAgICAgICAgICB2aXNpdG9yLmNsZWFyTWFya1N0YWNrcygpOwo=