199488 2019-07-03 19:17:41 -0700 WKWebView fails to render when another view uses CoreImage filters 2019-07-08 12:54:58 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Mac macOS 10.14 RESOLVED FIXED InRadar P2 Normal --- 1 dasau thorton cdumez commit-queue dino simon.fraser thorton webkit-bug-importer oldest_to_newest 1550159 0 dasau 2019-07-03 19:17:41 -0700 In 10.15 we noticed a regression where WKWebView was not rendering in our application and just shows a blank view. In 10.14.5 WKWebView is rendering with the same code. The issue is that when any subview in your window uses CoreImage filters, it breaks future WKWebView that are added to the window from rendering. I am not sure what change in WebKit caused this to stop working, but I can repro by running the latest WebKit code on my 10.14.5 machine. This does not repro when you change the order and first call -[WKWebView loadRequest:] before adding the web view to the window. NSView *ciLayerView = [[NSView alloc] initWithFrame:NSMakeRect(0, 0, 1, 1)]; ciLayerView.wantsLayer = YES; ciLayerView.layerUsesCoreImageFilters = YES; [[self view] addSubview:ciLayerView]; dispatch_async(dispatch_get_main_queue(), ^{ WKWebView *webView = [[WKWebView alloc] initWithFrame:NSMakeRect(100, 100, 400, 400)]; [self.view addSubview:webView]; [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"https://www.bing.com"]]]; }); 1550546 1 dasau 2019-07-05 15:21:32 -0700 I have debugged this more and found the cause of the regression, it seems the issue is that m_layerHostingMode is never set to LayerHostingMode::InProcess when CI filters are used. Previously the WebKit content process is already started when you add WKWebView to the window, so WebPageProxy::viewDidEnterWindow updates the layer hosting mode. With recent changes, WebPageProxy::dispatchActivityStateChange returns early because no process is started and the layer hosting mode is not set correctly. PageClientImpl::viewLayerHostingMode can get the correct value for the window, but it is just not set correctly on the content process in this scenario. CI filter forces in-proc rendering, WebKit will need to match the layer hosting mode of the window that is hosting it. 1550547 2 webkit-bug-importer 2019-07-05 15:21:52 -0700 <rdar://problem/52705268> 1550898 3 thorton 2019-07-08 11:31:14 -0700 Maybe a regression from the delayed web process launch thing? 1550900 4 thorton 2019-07-08 11:33:18 -0700 I think WebPageProxy::layerHostingModeDidChange() should not early-return if there's no process launched. Or rather, it should, but just before the message send; it should still update m_layerHostingMode, which is sent across in WebPageCreationParameters. 1550917 5 373653 thorton 2019-07-08 12:05:26 -0700 Created attachment 373653 Patch 1550918 6 thorton 2019-07-08 12:05:36 -0700 Does fix it. 1550930 7 373653 cdumez 2019-07-08 12:21:04 -0700 Comment on attachment 373653 Patch LGTM too. 1550933 8 thorton 2019-07-08 12:49:50 -0700 I took a quick jaunt through the rest of WebPageProxy and didn't see any other similarly wrong functions. 1550935 9 373653 commit-queue 2019-07-08 12:54:56 -0700 Comment on attachment 373653 Patch Clearing flags on attachment: 373653 Committed r247227: <https://trac.webkit.org/changeset/247227> 1550936 10 commit-queue 2019-07-08 12:54:58 -0700 All reviewed patches have been landed. Closing bug. 373653 2019-07-08 12:05:26 -0700 2019-07-08 12:54:56 -0700 Patch bug-199488-20190708120525.patch text/plain 2069 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM4MWRmMWY4ODE1ODNkNjE3 YmNiZTdlNTZhN2UyZmQ4NTAyY2IzMGMuLjk5OGIwYmEwNzI5ODRkNWI0YTVmNjgwMzRiOGNjMzcy NzQ5NTgzNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDctMDggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgV0tXZWJWaWV3IGZhaWxz IHRvIHJlbmRlciB3aGVuIGFub3RoZXIgdmlldyB1c2VzIENvcmVJbWFnZSBmaWx0ZXJzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk0ODgKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzUyNjk1ODI1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6bGF5ZXJIb3N0aW5nTW9kZURpZENoYW5nZSk6Cisg ICAgICAgIFVwZGF0ZSBtX2xheWVySG9zdGluZ01vZGUgd2hlbiBpdCBjaGFuZ2VzLCBldmVuIGlm IHdlIGNhbid0IG1lc3NhZ2UKKyAgICAgICAgdGhlIFdlYiBDb250ZW50IHByb2Nlc3MuIFRoaXMg ZW5zdXJlcyB0aGF0IHRoZSBuZXh0IHRpbWUgd2UgbGF1bmNoCisgICAgICAgIGEgV2ViIENvbnRl bnQgcHJvY2VzcywgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyB3aWxsIGhhdmUgdGhlIGNvcnJl Y3QKKyAgICAgICAgbGF5ZXIgaG9zdGluZyBtb2RlLCBhbmQgaXMgdGhlIHVzdWFsIHBhdHRlcm4g Zm9yIHN1Y2ggdGhpbmdzLgorCiAyMDE5LTA3LTAzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNlcnZlcl0gUkVHUkVTU0lPTiAocjI0 NDM1Nik6IERyb3AgZG93biBtZW51cyBjb2xsYXBzZSB3aXRob3V0IHVzZXIgaW5wdXQgLSBFYmF5 LmNvbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggMDYzNWE2 ZDBiZTdlNTc5M2RhMDZlMDNhMWVmNGE2OGE1MGVjNzI2Ni4uZjc3MzY3NGIwNGMwYmVmM2M0YjMz Mzg5ZTA1MmU0ZGE0YzMxMDZkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuY3BwCkBAIC0xODU4LDE1ICsxODU4LDE0IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojp1cGRhdGVI aWRkZW5QYWdlVGhyb3R0bGluZ0F1dG9JbmNyZWFzZXMoKQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6 bGF5ZXJIb3N0aW5nTW9kZURpZENoYW5nZSgpCiB7Ci0gICAgaWYgKCFoYXNSdW5uaW5nUHJvY2Vz cygpKQotICAgICAgICByZXR1cm47Ci0KICAgICBMYXllckhvc3RpbmdNb2RlIGxheWVySG9zdGlu Z01vZGUgPSBwYWdlQ2xpZW50KCkudmlld0xheWVySG9zdGluZ01vZGUoKTsKICAgICBpZiAobV9s YXllckhvc3RpbmdNb2RlID09IGxheWVySG9zdGluZ01vZGUpCiAgICAgICAgIHJldHVybjsKIAog ICAgIG1fbGF5ZXJIb3N0aW5nTW9kZSA9IGxheWVySG9zdGluZ01vZGU7Ci0gICAgbV9wcm9jZXNz LT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpTZXRMYXllckhvc3RpbmdNb2RlKGxheWVySG9zdGlu Z01vZGUpLCBtX3BhZ2VJRCk7CisKKyAgICBpZiAoaGFzUnVubmluZ1Byb2Nlc3MoKSkKKyAgICAg ICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpTZXRMYXllckhvc3RpbmdNb2Rl KGxheWVySG9zdGluZ01vZGUpLCBtX3BhZ2VJRCk7CiB9CiAKIHZvaWQgV2ViUGFnZVByb3h5Ojp3 YWl0Rm9yRGlkVXBkYXRlQWN0aXZpdHlTdGF0ZShBY3Rpdml0eVN0YXRlQ2hhbmdlSUQgYWN0aXZp dHlTdGF0ZUNoYW5nZUlEKQo=