199469 2019-07-03 15:27:31 -0700 HyphenationLibHyphen: Include GLib-related headers only if ENABLE(DEVELOPER_MODE) is true 2019-07-04 06:55:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annulen annulen mcatanzaro webkit-bug-importer zan oldest_to_newest 1550039 0 annulen 2019-07-03 15:27:31 -0700 GLib is used only inside ENABLE(DEVELOPER_MODE) block 1550040 1 373421 annulen 2019-07-03 15:28:46 -0700 Created attachment 373421 Patch 1550116 2 373421 mcatanzaro 2019-07-03 17:44:49 -0700 Comment on attachment 373421 Patch How about #if USE(GLIB)? 1550156 3 373447 annulen 2019-07-03 18:56:36 -0700 Created attachment 373447 Patch 1550210 4 373447 mcatanzaro 2019-07-04 06:21:26 -0700 Comment on attachment 373447 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373447&action=review > Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp:43 > +#if ENABLE(DEVELOPER_MODE) && PLATFORM(GTK) Well this is even worse, now they won't work for WPE layout tests, right? If you're using USE(GLIB) then what's the problem with including these headers? 1550213 5 annulen 2019-07-04 06:24:36 -0700 (In reply to Michael Catanzaro from comment #4) > Comment on attachment 373447 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373447&action=review > > > Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp:43 > > +#if ENABLE(DEVELOPER_MODE) && PLATFORM(GTK) > > Well this is even worse, now they won't work for WPE layout tests, right? No. Code below (it's really sad that we don't have an easy way to expand context in patch view) is explicitly using PLATFORM(GTK). WPE should not be affected at all by this change >If you're using USE(GLIB) then what's the problem with including these headers? I'm just trying to match ifdefs on headers with ifdefs on code which uses them 1550214 6 373447 mcatanzaro 2019-07-04 06:26:07 -0700 Comment on attachment 373447 Patch So it is.... 1550215 7 mcatanzaro 2019-07-04 06:27:25 -0700 Maybe just use PLATFORM(GTK) guards and not ENABLE(DEVELOPER_MODE). My worry is that someone will in the future use these headers outside developer mode, and nobody will notice the build is broken until release time. In general, headers should only be behind ifdefs if really required, to avoid gratuitous build breakage down the road. 1550221 8 373463 annulen 2019-07-04 06:37:18 -0700 Created attachment 373463 Patch 1550225 9 373463 mcatanzaro 2019-07-04 06:49:38 -0700 Comment on attachment 373463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373463&action=review > Source/WebCore/ChangeLog:3 > + HyphenationLibHyphen: Include GLib-related headers only if ENABLE(DEVELOPER_MODE) is true Change the title, of course 1550226 10 annulen 2019-07-04 06:50:23 -0700 Oops 1550231 11 annulen 2019-07-04 06:54:53 -0700 Committed r247141: <https://trac.webkit.org/changeset/247141> 1550232 12 webkit-bug-importer 2019-07-04 06:55:16 -0700 <rdar://problem/52645215> 373421 2019-07-03 15:28:46 -0700 2019-07-03 18:56:33 -0700 Patch bug-199469-20190704012846.patch text/plain 1570 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg0YmEyMTQ4YzIzMGI1 YzUxNGQ5MTFiODg0ZmExYWZjMjc5ZjljNS4uYzBiM2UwNjk3Y2M3ZGM1ODUzNDM5NTZjZjMyNmI1 YzNlOTIyNDczYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA3LTAzICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBIeXBoZW5hdGlv bkxpYkh5cGhlbjogSW5jbHVkZSBHTGliLXJlbGF0ZWQgaGVhZGVycyBvbmx5IGlmIEVOQUJMRShE RVZFTE9QRVJfTU9ERSkgaXMgdHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk5NDY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5hdGlvbkxpYkh5cGhl bi5jcHA6CisKIDIwMTktMDctMDMgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAK ICAgICAgICAgRXhjZXB0aW9uIHRocm93biBmcm9tIC1bQVZTYW1wbGVCdWZmZXJSZW5kZXJTeW5j aHJvbml6ZXIgYWRkUmVuZGVyZXI6XSwgbm90IGEgdmFsaWQgcmVuZGVyZXIuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5hdGlvbkxpYkh5cGhl bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5hdGlvbkxp Ykh5cGhlbi5jcHAKaW5kZXggZmU0MGZiMjU5YjkzZjlkMzRlNTZmMjNjZDFkZDExMDNjNjVjYzlh OC4uYWI4MmMxY2JhNmJhNWI5MWEwMGRhZDUxYzM1ZDEzMWJmODFmODlhMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9oeXBoZW4vSHlwaGVuYXRpb25MaWJIeXBoZW4u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvaHlwaGVuL0h5cGhlbmF0aW9u TGliSHlwaGVuLmNwcApAQCAtMzYsMTIgKzM2LDE1IEBACiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAu aD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYvVGlueUxS VUNhY2hlLmg+Ci0jaW5jbHVkZSA8d3RmL2dsaWIvR0xpYlV0aWxpdGllcy5oPgotI2luY2x1ZGUg PHd0Zi9nbGliL0dVbmlxdWVQdHIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9BdG9tU3RyaW5nSGFz aC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9T dHJpbmdWaWV3Lmg+CiAKKyNpZiBFTkFCTEUoREVWRUxPUEVSX01PREUpCisjaW5jbHVkZSA8d3Rm L2dsaWIvR0xpYlV0aWxpdGllcy5oPgorI2luY2x1ZGUgPHd0Zi9nbGliL0dVbmlxdWVQdHIuaD4K KyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBjb25zdCBjaGFyKiBjb25z dCBnRGljdGlvbmFyeURpcmVjdG9yaWVzW10gPSB7Cg== 373447 2019-07-03 18:56:36 -0700 2019-07-04 06:37:14 -0700 Patch bug-199469-20190704045635.patch text/plain 2172 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg0YmEyMTQ4YzIzMGI1 YzUxNGQ5MTFiODg0ZmExYWZjMjc5ZjljNS4uYzBiM2UwNjk3Y2M3ZGM1ODUzNDM5NTZjZjMyNmI1 YzNlOTIyNDczYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA3LTAzICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBIeXBoZW5hdGlv bkxpYkh5cGhlbjogSW5jbHVkZSBHTGliLXJlbGF0ZWQgaGVhZGVycyBvbmx5IGlmIEVOQUJMRShE RVZFTE9QRVJfTU9ERSkgaXMgdHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk5NDY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5hdGlvbkxpYkh5cGhl bi5jcHA6CisKIDIwMTktMDctMDMgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAK ICAgICAgICAgRXhjZXB0aW9uIHRocm93biBmcm9tIC1bQVZTYW1wbGVCdWZmZXJSZW5kZXJTeW5j aHJvbml6ZXIgYWRkUmVuZGVyZXI6XSwgbm90IGEgdmFsaWQgcmVuZGVyZXIuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5hdGlvbkxpYkh5cGhl bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5hdGlvbkxp Ykh5cGhlbi5jcHAKaW5kZXggZmU0MGZiMjU5YjkzZjlkMzRlNTZmMjNjZDFkZDExMDNjNjVjYzlh OC4uMzNiMGFiOWE3MzNlOTM4NDNlMzFkZTNkNTQzNGUxMTk2YTE3NDk4NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9oeXBoZW4vSHlwaGVuYXRpb25MaWJIeXBoZW4u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvaHlwaGVuL0h5cGhlbmF0aW9u TGliSHlwaGVuLmNwcApAQCAtMzYsMTIgKzM2LDE1IEBACiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAu aD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYvVGlueUxS VUNhY2hlLmg+Ci0jaW5jbHVkZSA8d3RmL2dsaWIvR0xpYlV0aWxpdGllcy5oPgotI2luY2x1ZGUg PHd0Zi9nbGliL0dVbmlxdWVQdHIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9BdG9tU3RyaW5nSGFz aC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9T dHJpbmdWaWV3Lmg+CiAKKyNpZiBFTkFCTEUoREVWRUxPUEVSX01PREUpICYmIFBMQVRGT1JNKEdU SykKKyNpbmNsdWRlIDx3dGYvZ2xpYi9HTGliVXRpbGl0aWVzLmg+CisjaW5jbHVkZSA8d3RmL2ds aWIvR1VuaXF1ZVB0ci5oPgorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGlj IGNvbnN0IGNoYXIqIGNvbnN0IGdEaWN0aW9uYXJ5RGlyZWN0b3JpZXNbXSA9IHsKQEAgLTg1LDYg Kzg4LDggQEAgc3RhdGljIHZvaWQgc2NhbkRpcmVjdG9yeUZvckRpY3Rpb25hcmllcyhjb25zdCBj aGFyKiBkaXJlY3RvcnlQYXRoLCBIYXNoTWFwPEF0b20KIH0KIAogI2lmIEVOQUJMRShERVZFTE9Q RVJfTU9ERSkKKworI2lmIFBMQVRGT1JNKEdUSykKIHN0YXRpYyBDU3RyaW5nIHRvcExldmVsUGF0 aCgpCiB7CiAgICAgaWYgKGNvbnN0IGNoYXIqIHRvcExldmVsRGlyZWN0b3J5ID0gZ19nZXRlbnYo IldFQktJVF9UT1BfTEVWRUwiKSkKQEAgLTEwOCw2ICsxMTMsNyBAQCBzdGF0aWMgQ1N0cmluZyB3 ZWJraXRCdWlsZERpcmVjdG9yeSgpCiAgICAgR1VuaXF1ZVB0cjxjaGFyPiBvdXRwdXREaXIoZ19i dWlsZF9maWxlbmFtZSh0b3BMZXZlbFBhdGgoKS5kYXRhKCksICJXZWJLaXRCdWlsZCIsIG51bGxw dHIpKTsKICAgICByZXR1cm4gb3V0cHV0RGlyLmdldCgpOwogfQorI2VuZGlmIC8vIFBMQVRGT1JN KEdUSykKIAogc3RhdGljIHZvaWQgc2NhblRlc3REaWN0aW9uYXJpZXNEaXJlY3RvcnlJZk5lY2Vz c2FyeShIYXNoTWFwPEF0b21TdHJpbmcsIFZlY3RvcjxTdHJpbmc+PiYgYXZhaWxhYmxlTG9jYWxl cykKIHsK 373463 2019-07-04 06:37:18 -0700 2019-07-04 06:49:21 -0700 Patch bug-199469-20190704163716.patch text/plain 2100 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDdjZDZhYzVjYmViNmJk M2JjN2YzMjg5YTI3MmQ2ZGZlZDI3ZGI0OS4uZWM5YmQ0MWM3NmEyZWI4ZWRiZmQyYjRmYmQyOGRm ZDdlMGY2NDAwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA3LTA0ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBIeXBoZW5hdGlv bkxpYkh5cGhlbjogSW5jbHVkZSBHTGliLXJlbGF0ZWQgaGVhZGVycyBvbmx5IGlmIEVOQUJMRShE RVZFTE9QRVJfTU9ERSkgaXMgdHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk5NDY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWljaGFlbCBDYXRh bnphcm8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5hdGlvbkxpYkh5 cGhlbi5jcHA6CisKIDIwMTktMDctMDMgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW01TRV0gQWRkIG1vcmUgZGVidWcgYW5kIGVycm9yIGxvZ2dpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvaHlwaGVuL0h5cGhlbmF0 aW9uTGliSHlwaGVuLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvaHlwaGVuL0h5 cGhlbmF0aW9uTGliSHlwaGVuLmNwcAppbmRleCBmZTQwZmIyNTliOTNmOWQzNGU1NmYyM2NkMWRk MTEwM2M2NWNjOWE4Li4xMmJhYTRjNGQzZTllNjNmN2ZmODFjNWUyYjExOTRiOGJiOGE5YzA1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5hdGlv bkxpYkh5cGhlbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9oeXBoZW4v SHlwaGVuYXRpb25MaWJIeXBoZW4uY3BwCkBAIC0zNiwxMiArMzYsMTUgQEAKICNpbmNsdWRlIDx3 dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogI2luY2x1ZGUg PHd0Zi9UaW55TFJVQ2FjaGUuaD4KLSNpbmNsdWRlIDx3dGYvZ2xpYi9HTGliVXRpbGl0aWVzLmg+ Ci0jaW5jbHVkZSA8d3RmL2dsaWIvR1VuaXF1ZVB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0F0 b21TdHJpbmdIYXNoLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUg PHd0Zi90ZXh0L1N0cmluZ1ZpZXcuaD4KIAorI2lmIFBMQVRGT1JNKEdUSykKKyNpbmNsdWRlIDx3 dGYvZ2xpYi9HTGliVXRpbGl0aWVzLmg+CisjaW5jbHVkZSA8d3RmL2dsaWIvR1VuaXF1ZVB0ci5o PgorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGNvbnN0IGNoYXIqIGNv bnN0IGdEaWN0aW9uYXJ5RGlyZWN0b3JpZXNbXSA9IHsKQEAgLTg1LDYgKzg4LDggQEAgc3RhdGlj IHZvaWQgc2NhbkRpcmVjdG9yeUZvckRpY3Rpb25hcmllcyhjb25zdCBjaGFyKiBkaXJlY3RvcnlQ YXRoLCBIYXNoTWFwPEF0b20KIH0KIAogI2lmIEVOQUJMRShERVZFTE9QRVJfTU9ERSkKKworI2lm IFBMQVRGT1JNKEdUSykKIHN0YXRpYyBDU3RyaW5nIHRvcExldmVsUGF0aCgpCiB7CiAgICAgaWYg KGNvbnN0IGNoYXIqIHRvcExldmVsRGlyZWN0b3J5ID0gZ19nZXRlbnYoIldFQktJVF9UT1BfTEVW RUwiKSkKQEAgLTEwOCw2ICsxMTMsNyBAQCBzdGF0aWMgQ1N0cmluZyB3ZWJraXRCdWlsZERpcmVj dG9yeSgpCiAgICAgR1VuaXF1ZVB0cjxjaGFyPiBvdXRwdXREaXIoZ19idWlsZF9maWxlbmFtZSh0 b3BMZXZlbFBhdGgoKS5kYXRhKCksICJXZWJLaXRCdWlsZCIsIG51bGxwdHIpKTsKICAgICByZXR1 cm4gb3V0cHV0RGlyLmdldCgpOwogfQorI2VuZGlmIC8vIFBMQVRGT1JNKEdUSykKIAogc3RhdGlj IHZvaWQgc2NhblRlc3REaWN0aW9uYXJpZXNEaXJlY3RvcnlJZk5lY2Vzc2FyeShIYXNoTWFwPEF0 b21TdHJpbmcsIFZlY3RvcjxTdHJpbmc+PiYgYXZhaWxhYmxlTG9jYWxlcykKIHsK