199465 2019-07-03 15:03:21 -0700 REGRESSION (r246817): fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing 2019-07-03 16:22:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad Unspecified RESOLVED FIXED InRadar, PlatformOnly, Regression P2 Normal --- 199204 1 dbates dbates webkit-bug-importer wenson_hsieh oldest_to_newest 1550011 0 dbates 2019-07-03 15:03:21 -0700 Oops! In the fix for bug #199204 I was a bit too nice. It does not make sense to allow cursor key commands when there is no selection. The tests: fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing fail because try to perform cursor movements (like Control + A to move to the start of the line) even when there is no selection. Handled key commands don't dispatch DOM keypress events. 1550012 1 webkit-bug-importer 2019-07-03 15:03:36 -0700 <rdar://problem/52613496> 1550014 2 373417 dbates 2019-07-03 15:05:59 -0700 Created attachment 373417 Patch 1550071 3 373417 dbates 2019-07-03 16:22:49 -0700 Comment on attachment 373417 Patch Clearing flags on attachment: 373417 Committed r247116: <https://trac.webkit.org/changeset/247116> 1550072 4 dbates 2019-07-03 16:22:50 -0700 All reviewed patches have been landed. Closing bug. 373417 2019-07-03 15:05:59 -0700 2019-07-03 16:22:49 -0700 Patch bug-199465-20190703150559.patch text/plain 2159 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdiZTAxNzg0ZGZlNjFkZWFi ZTkwZDdiMDlhNDlkNDU1OGZiMmQwMzAuLjNjYTVkMGM5NDI4ZDc4NDQxNWM5ZWY0YThiNzMzOTNh ODk3NWNhMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDctMDMgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDY4MTcp OiBmYXN0L2V2ZW50cy9pb3Mva2V5LWV2ZW50cy1jb21wcmVoZW5zaXZlL2tleS1ldmVudHMte2Nv bnRyb2wsIGNvbnRyb2wtc2hpZnR9Lmh0bWwgYXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTQ2NQorICAgICAgICA8cmRhcjovL3By b2JsZW0vNTI2MTM0OTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG9uJ3QgYWR2ZXJ0aXNlIHRoYXQgV2ViS2l0IGNhbiBwZXJmb3JtIGN1cnNvciBt b3ZlbWVudHMgd2hlbiB0aGVyZSBpc24ndCBzb21lIGtpbmQgb2Ygc2VsZWN0aW9uLgorCisgICAg ICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgY2FuUGVyZm9ybUFjdGlvbjp3aXRoU2VuZGVyOl0pOgorCiAyMDE5 LTA3LTAyICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T XSBTdXBwb3J0IHNlbGVjdCBhbGwgaW4gbm9uLWVkaXRhYmxlIGVsZW1lbnQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0g Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CmluZGV4IDBlN2E0NzljMzA1ODE4ZGVmZmRhNTAzMWJmYjhkNDBmN2JiMmEyMDMuLmZhYjY3OWMz NTgzYTNmODUwNjAzMGM1MmExODkzZDdlMmYxZTQ3MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMjg5 NSw3ICsyODk1LDcgQEAgLSAoQk9PTCljYW5QZXJmb3JtQWN0aW9uOihTRUwpYWN0aW9uIHdpdGhT ZW5kZXI6KGlkKXNlbmRlcgogICAgICAgICB8fCBhY3Rpb24gPT0gQHNlbGVjdG9yKF9tb3ZlVG9F bmRPZkRvY3VtZW50OndpdGhIaXN0b3J5OikgfHwgYWN0aW9uID09IEBzZWxlY3RvcihfbW92ZVRv RW5kT2ZMaW5lOndpdGhIaXN0b3J5OikgfHwgYWN0aW9uID09IEBzZWxlY3RvcihfbW92ZVRvRW5k T2ZQYXJhZ3JhcGg6d2l0aEhpc3Rvcnk6KQogICAgICAgICB8fCBhY3Rpb24gPT0gQHNlbGVjdG9y KF9tb3ZlVG9FbmRPZldvcmQ6d2l0aEhpc3Rvcnk6KSB8fCBhY3Rpb24gPT0gQHNlbGVjdG9yKF9t b3ZlVG9TdGFydE9mRG9jdW1lbnQ6d2l0aEhpc3Rvcnk6KSB8fCBhY3Rpb24gPT0gQHNlbGVjdG9y KF9tb3ZlVG9TdGFydE9mTGluZTp3aXRoSGlzdG9yeTopCiAgICAgICAgIHx8IGFjdGlvbiA9PSBA c2VsZWN0b3IoX21vdmVUb1N0YXJ0T2ZQYXJhZ3JhcGg6d2l0aEhpc3Rvcnk6KSB8fCBhY3Rpb24g PT0gQHNlbGVjdG9yKF9tb3ZlVG9TdGFydE9mV29yZDp3aXRoSGlzdG9yeTopIHx8IGFjdGlvbiA9 PSBAc2VsZWN0b3IoX21vdmVVcDp3aXRoSGlzdG9yeTopKQotICAgICAgICByZXR1cm4gWUVTOwor ICAgICAgICByZXR1cm4gIWVkaXRvclN0YXRlLnNlbGVjdGlvbklzTm9uZTsKIAogICAgIGlmIChh Y3Rpb24gPT0gQHNlbGVjdG9yKF9kZWxldGVCeVdvcmQpIHx8IGFjdGlvbiA9PSBAc2VsZWN0b3Io X2RlbGV0ZUZvcndhcmRBbmROb3RpZnk6KSB8fCBhY3Rpb24gPT0gQHNlbGVjdG9yKF9kZWxldGVU b0VuZE9mUGFyYWdyYXBoKSB8fCBhY3Rpb24gPT0gQHNlbGVjdG9yKF9kZWxldGVUb1N0YXJ0T2ZM aW5lKQogICAgICAgICB8fCBhY3Rpb24gPT0gQHNlbGVjdG9yKF90cmFuc3Bvc2UpKQo=