199463 2019-07-03 14:27:08 -0700 Fix a couple of thread safety issues in ResourceLoadStatisticsStore 2019-07-03 15:17:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson bfulgham commit-queue webkit-bug-importer wilander youennf oldest_to_newest 1549996 0 cdumez 2019-07-03 14:27:08 -0700 Fix a couple of thread safety issues in ResourceLoadStatisticsStore. 1549997 1 373415 cdumez 2019-07-03 14:32:27 -0700 Created attachment 373415 Patch 1550000 2 373415 cdumez 2019-07-03 14:39:15 -0700 Comment on attachment 373415 Patch Oh, there is more... 1550001 3 373415 cdumez 2019-07-03 14:41:40 -0700 Comment on attachment 373415 Patch I'll keep this patch simple. 1550032 4 373415 commit-queue 2019-07-03 15:16:13 -0700 Comment on attachment 373415 Patch Clearing flags on attachment: 373415 Committed r247112: <https://trac.webkit.org/changeset/247112> 1550033 5 commit-queue 2019-07-03 15:16:15 -0700 All reviewed patches have been landed. Closing bug. 1550036 6 webkit-bug-importer 2019-07-03 15:17:18 -0700 <rdar://problem/52614372> 373415 2019-07-03 14:32:27 -0700 2019-07-03 15:16:13 -0700 Patch bug-199463-20190703143227.patch text/plain 4323 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg0MjkyMGJmMTVjOGZlMjYx ZTY0YTI1YjkwMzgzNmU2ZGIwYjBmOTIuLjdhMzkxOTA2MzMyY2RiMTNjMDFkY2NiMmJjYzhlYzhm Y2JiY2MyNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDctMDMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYSBjb3VwbGUgb2YgdGhyZWFk IHNhZmV0eSBpc3N1ZXMgaW4gUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk0NjMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1N0b3JlIG9iamVjdCBpcyBjb25zdHJ1Y3RlZCAvIHVzZWQgLyBkZXN0cm95ZWQgb24g YSBiYWNrZ3JvdW5kIHF1ZXVlLgorICAgICAgICBJdCBpcyB0aGVyZWZvcmUgbm90IHNhZmUgdG8g dXNlIGEgV2Vha1B0ciB0byB0aGUgUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlIG9uIHRoZSBt YWluIHRocmVhZC4KKworICAgICAgICBUaGUgc2FmZSBwYXR0ZXJuIGlzIHRvIGhhdmUgdGhlIFJl c291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSBjYXB0dXJlIGEgUmVmPD4gb2YgaXRzIG1fc3RvcmUg YmVmb3JlCisgICAgICAgIGRpc3BhdGNoaW5nIHRvIHRoZSBtYWluIHRocmVhZCBhbmQgdXNlIHRo aXMgc3RvcmUgb24gdGhlIG1haW4gdGhyZWFkIGluc3RlYWQgb2Ygd2Vha1RoaXMtPm1fc3RvcmUu CisgICAgICAgIFJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSdzIG1fc3RvcmUgaXMgY29uc3Ry dWN0ZWQgLyB1c2VkIC8gZGVzdHJveWVkIG9uIHRoZSBtYWluIHRocmVhZC4KKworICAgICAgICAq IE5ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNw cDoKKyAgICAgICAgKFdlYktpdDo6UmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpyZW1vdmVE YXRhUmVjb3Jkcyk6CisgICAgICAgIChXZWJLaXQ6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9y ZTo6cHJvY2Vzc1N0YXRpc3RpY3NBbmREYXRhUmVjb3Jkcyk6CisKIDIwMTktMDctMDMgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVc2Ugc21h cnRlciBwb2ludGVycyBpbiBXS0Rvd25sb2FkUHJvZ3Jlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3Rv cmUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNl TG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKaW5kZXggMjZlMjM3MjNmZmZjOGQ2MTIyNDg1MzZiYjM4 ODc0YzI1YTlkNDM5MS4uNzUzYzI5NDM3M2JjNGI3YjhjNjk4ODNjOGM5YzFiMDg1ZGU5MTQyNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291 cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKQEAgLTIwNSwx MyArMjA1LDggQEAgdm9pZCBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OnJlbW92ZURhdGFS ZWNvcmRzKENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJgogCiAgICAgc2V0RGF0YVJlY29yZHNC ZWluZ1JlbW92ZWQodHJ1ZSk7CiAKLSAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW2RvbWFp bnNUb1JlbW92ZVdlYnNpdGVEYXRhRm9yID0gY3Jvc3NUaHJlYWRDb3B5KGRvbWFpbnNUb1JlbW92 ZVdlYnNpdGVEYXRhRm9yKSwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25I YW5kbGVyKSwgd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhpcyksIHNob3VsZE5vdGlmeVBhZ2Vz V2hlbkRhdGFSZWNvcmRzV2VyZVNjYW5uZWQgPSBtX3BhcmFtZXRlcnMuc2hvdWxkTm90aWZ5UGFn ZXNXaGVuRGF0YVJlY29yZHNXZXJlU2Nhbm5lZCwgd29ya1F1ZXVlID0gbV93b3JrUXVldWUuY29w eVJlZigpXSAoKSBtdXRhYmxlIHsKLSAgICAgICAgaWYgKCF3ZWFrVGhpcykgewotICAgICAgICAg ICAgY29tcGxldGlvbkhhbmRsZXIoKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQot Ci0gICAgICAgIHdlYWtUaGlzLT5tX3N0b3JlLmRlbGV0ZVdlYnNpdGVEYXRhRm9yUmVnaXN0cmFi bGVEb21haW5zKFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6bW9uaXRvcmVkRGF0YVR5 cGVzKCksIFdURk1vdmUoZG9tYWluc1RvUmVtb3ZlV2Vic2l0ZURhdGFGb3IpLCBzaG91bGROb3Rp ZnlQYWdlc1doZW5EYXRhUmVjb3Jkc1dlcmVTY2FubmVkLCBbY29tcGxldGlvbkhhbmRsZXIgPSBX VEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSwgd2Vha1RoaXMgPSBXVEZNb3ZlKHdlYWtUaGlzKSwg d29ya1F1ZXVlID0gd29ya1F1ZXVlLmNvcHlSZWYoKV0oY29uc3QgSGFzaFNldDxSZWdpc3RyYWJs ZURvbWFpbj4mIGRvbWFpbnNXaXRoRGVsZXRlZFdlYnNpdGVEYXRhKSBtdXRhYmxlIHsKKyAgICBS dW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3N0b3JlID0gbWFrZVJlZihtX3N0b3JlKSwgZG9tYWlu c1RvUmVtb3ZlV2Vic2l0ZURhdGFGb3IgPSBjcm9zc1RocmVhZENvcHkoZG9tYWluc1RvUmVtb3Zl V2Vic2l0ZURhdGFGb3IpLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhh bmRsZXIpLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKSwgc2hvdWxkTm90aWZ5UGFnZXNX aGVuRGF0YVJlY29yZHNXZXJlU2Nhbm5lZCA9IG1fcGFyYW1ldGVycy5zaG91bGROb3RpZnlQYWdl c1doZW5EYXRhUmVjb3Jkc1dlcmVTY2FubmVkLCB3b3JrUXVldWUgPSBtX3dvcmtRdWV1ZS5jb3B5 UmVmKCldICgpIG11dGFibGUgeworICAgICAgICBzdG9yZS0+ZGVsZXRlV2Vic2l0ZURhdGFGb3JS ZWdpc3RyYWJsZURvbWFpbnMoV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjptb25pdG9y ZWREYXRhVHlwZXMoKSwgV1RGTW92ZShkb21haW5zVG9SZW1vdmVXZWJzaXRlRGF0YUZvciksIHNo b3VsZE5vdGlmeVBhZ2VzV2hlbkRhdGFSZWNvcmRzV2VyZVNjYW5uZWQsIFtjb21wbGV0aW9uSGFu ZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpLCB3ZWFrVGhpcyA9IFdURk1vdmUod2Vh a1RoaXMpLCB3b3JrUXVldWUgPSB3b3JrUXVldWUuY29weVJlZigpXShjb25zdCBIYXNoU2V0PFJl Z2lzdHJhYmxlRG9tYWluPiYgZG9tYWluc1dpdGhEZWxldGVkV2Vic2l0ZURhdGEpIG11dGFibGUg ewogICAgICAgICAgICAgd29ya1F1ZXVlLT5kaXNwYXRjaChbZG9tYWluc1dpdGhEZWxldGVkV2Vi c2l0ZURhdGEgPSBjcm9zc1RocmVhZENvcHkoZG9tYWluc1dpdGhEZWxldGVkV2Vic2l0ZURhdGEp LCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpLCB3ZWFrVGhp cyA9IFdURk1vdmUod2Vha1RoaXMpXSAoKSBtdXRhYmxlIHsKICAgICAgICAgICAgICAgICBpZiAo IXdlYWtUaGlzKSB7CiAgICAgICAgICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKCk7CkBA IC0yNDcsMTIgKzI0Miw4IEBAIHZvaWQgUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpwcm9j ZXNzU3RhdGlzdGljc0FuZERhdGFSZWNvcmRzKCkKICAgICAgICAgaWYgKCFtX3BhcmFtZXRlcnMu c2hvdWxkTm90aWZ5UGFnZXNXaGVuRGF0YVJlY29yZHNXZXJlU2Nhbm5lZCkKICAgICAgICAgICAg IHJldHVybjsKIAotICAgICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3RoaXMsIHdlYWtU aGlzID0gV1RGTW92ZSh3ZWFrVGhpcyldIHsKLSAgICAgICAgICAgIEFTU0VSVChSdW5Mb29wOjpp c01haW4oKSk7Ci0gICAgICAgICAgICBpZiAoIXdlYWtUaGlzKQotICAgICAgICAgICAgICAgIHJl dHVybjsKLQotICAgICAgICAgICAgbV9zdG9yZS5ub3RpZnlSZXNvdXJjZUxvYWRTdGF0aXN0aWNz UHJvY2Vzc2VkKCk7CisgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbc3RvcmUgPSBt YWtlUmVmKG1fc3RvcmUpXSB7CisgICAgICAgICAgICBzdG9yZS0+bm90aWZ5UmVzb3VyY2VMb2Fk U3RhdGlzdGljc1Byb2Nlc3NlZCgpOwogICAgICAgICB9KTsKICAgICB9KTsKIH0K