199413 2019-07-02 11:32:46 -0700 Web Inspector: Elements: DOM breakpoints context menu items inserted first when accessed via status image 2022-03-26 04:15:43 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All NEW P3 Normal --- 1 mattbaker mattbaker hi inspector-bugzilla-changes oldest_to_newest 1549648 0 mattbaker 2019-07-02 11:32:46 -0700 Summary: DOM breakpoints context menu items inserted first when accessed via status image. Steps to Reproduce: 1. Right-click the DOM node in the tree to show context menu 2. Add any DOM breakpoint (e.g.: Break on > Attribute Modified) 3. Right-click the DOM breakpoint indicator to show context menu Expected: Add Edit Copy Delete Toggle Visibility - Forced Pseudo-Classes - Break on - Disable Breakpoint Delete Breakpoint - etc. Actual: Break on - Disable Breakpoint Delete Breakpoint - Add Edit Copy Delete Toggle Visibility - Forced Pseudo-Classes - etc. 1549649 1 373342 mattbaker 2019-07-02 11:36:00 -0700 Created attachment 373342 Patch 1549652 2 373342 hi 2019-07-02 11:43:23 -0700 Comment on attachment 373342 Patch r-, I did this intentionally. If a user shows a context menu specifically for the breakpoint icon, it likely means that they want to do something with breakpoints, as it's pretty "small" and is way far over in the gutter area. As such, we should put the actions for breakpoints closer to the top. 1549665 3 mattbaker 2019-07-02 11:52:42 -0700 (In reply to Devin Rousso from comment #2) > Comment on attachment 373342 [details] > Patch > > r-, I did this intentionally. If a user shows a context menu specifically > for the breakpoint icon, it likely means that they want to do something with > breakpoints, as it's pretty "small" and is way far over in the gutter area. > As such, we should put the actions for breakpoints closer to the top. I see your reasoning, however I don't think it's a good idea to render the menu for reasons like this. We show all the other menu items for the node, so it is not as if its a "DOM breakpoint only" context menu. 373342 2019-07-02 11:36:00 -0700 2022-03-26 04:15:43 -0700 Patch bug-199413-20190702113559.patch text/plain 3457 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj NGYxOWE3OGRmN2M2ODkyMmY3ZTAxZDdiMDgxMGMxYTQ2ZmIzNzU5Li41OGZiYTllNmI2NzAyMWNi M2FiYzI2NjkwMGU1ZmEwYzhiMjZjNzIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wNy0wMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWxlbWVudHM6IERPTSBicmVha3BvaW50cyBjb250 ZXh0IG1lbnUgaXRlbXMgaW5zZXJ0ZWQgZmlyc3Qgd2hlbiBhY2Nlc3NlZCB2aWEgc3RhdHVzIGlt YWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk0 MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb250 ZXh0IG1lbnUgaGFuZGxpbmcgc2hvdWxkIGJlIGRvbmUgYXQgdGhlIERPTVRyZWVFbGVtZW50IGxl dmVsLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0TWVudVV0aWxpdGll cy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzOgor ICAgICAgICAoV0kuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl91cGRhdGVCcmVha3BvaW50U3Rh dHVzKToKKyAgICAgICAgKFdJLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5fc3RhdHVzSW1hZ2VD b250ZXh0bWVudSk6IERlbGV0ZWQuCisKIDIwMTktMDctMDIgIERldmluIFJvdXNzbyAgPGRyb3Vz c29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVsZW1lbnRzOiBhbGxvdyBu b2RlcyB0byBiZSBjb3BpZWQgYW5kIHBhc3RlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGlsaXRpZXMuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0TWVudVV0aWxpdGll cy5qcwppbmRleCA1YzI3ZTJiZWY1MTdhM2Y5ODVlZDIyMjRkNTlkNDhhMWIxNGFiMWY1Li5lMzI5 M2E5YTAzOGI4MDg1Y2JjYTliY2E2OTMwY2E4NDNlNGVmMjc2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0TWVudVV0aWxpdGllcy5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0 TWVudVV0aWxpdGllcy5qcwpAQCAtMjg2LDExICsyODYsNiBAQCBXSS5hcHBlbmRDb250ZXh0TWVu dUl0ZW1zRm9yRE9NTm9kZSA9IGZ1bmN0aW9uKGNvbnRleHRNZW51LCBkb21Ob2RlLCBvcHRpb25z ID0gewogCiBXSS5hcHBlbmRDb250ZXh0TWVudUl0ZW1zRm9yRE9NTm9kZUJyZWFrcG9pbnRzID0g ZnVuY3Rpb24oY29udGV4dE1lbnUsIGRvbU5vZGUsIG9wdGlvbnMgPSB7fSkKIHsKLSAgICBpZiAo Y29udGV4dE1lbnUuX19kb21CcmVha3BvaW50SXRlbXNBZGRlZCkKLSAgICAgICAgcmV0dXJuOwot Ci0gICAgY29udGV4dE1lbnUuX19kb21CcmVha3BvaW50SXRlbXNBZGRlZCA9IHRydWU7Ci0KICAg ICBsZXQgYnJlYWtwb2ludHMgPSBXSS5kb21EZWJ1Z2dlck1hbmFnZXIuZG9tQnJlYWtwb2ludHNG b3JOb2RlKGRvbU5vZGUpOwogCiAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01U cmVlRWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0RPTVRyZWVFbGVtZW50LmpzCmluZGV4IDVmMjBhNjhmMzBlYzIzOTNjZGFjOThmNDk5ZTRmZTRl NjdmMGNmNjcuLjgzNGNiMjcwNDQ4MjUyMGZmY2JmZDM4YzI5NjhlNDQ5NTk2ZTQ3MWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVF bGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0RPTVRyZWVFbGVtZW50LmpzCkBAIC0xOTEyLDcgKzE5MTIsNiBAQCBXSS5ET01UcmVlRWxlbWVu dCA9IGNsYXNzIERPTVRyZWVFbGVtZW50IGV4dGVuZHMgV0kuVHJlZUVsZW1lbnQKICAgICAgICAg ICAgIHRoaXMuX3N0YXR1c0ltYWdlRWxlbWVudCA9IFdJLkltYWdlVXRpbGl0aWVzLnVzZVNWR1N5 bWJvbCgiSW1hZ2VzL0RPTUJyZWFrcG9pbnQuc3ZnIiwgInN0YXR1cy1pbWFnZSIpOwogICAgICAg ICAgICAgdGhpcy5fc3RhdHVzSW1hZ2VFbGVtZW50LmNsYXNzTGlzdC5hZGQoImJyZWFrcG9pbnQi KTsKICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0ltYWdlRWxlbWVudC5hZGRFdmVudExpc3RlbmVy KCJjbGljayIsIHRoaXMuX3N0YXR1c0ltYWdlQ2xpY2tlZC5iaW5kKHRoaXMpKTsKLSAgICAgICAg ICAgIHRoaXMuX3N0YXR1c0ltYWdlRWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVu dSIsIHRoaXMuX3N0YXR1c0ltYWdlQ29udGV4dG1lbnUuYmluZCh0aGlzKSk7CiAgICAgICAgICAg ICB0aGlzLl9zdGF0dXNJbWFnZUVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vkb3duIiwg KGV2ZW50KSA9PiB7IGV2ZW50LnN0b3BQcm9wYWdhdGlvbigpOyB9KTsKICAgICAgICAgfQogCkBA IC0xOTQwLDE4ICsxOTM5LDYgQEAgV0kuRE9NVHJlZUVsZW1lbnQgPSBjbGFzcyBET01UcmVlRWxl bWVudCBleHRlbmRzIFdJLlRyZWVFbGVtZW50CiAgICAgICAgIGJyZWFrcG9pbnRzLmZvckVhY2go KGJyZWFrcG9pbnQpID0+IGJyZWFrcG9pbnQuZGlzYWJsZWQgPSAhc2hvdWxkRW5hYmxlKTsKICAg ICB9CiAKLSAgICBfc3RhdHVzSW1hZ2VDb250ZXh0bWVudShldmVudCkKLSAgICB7Ci0gICAgICAg IGlmICghdGhpcy5oYXNCcmVha3BvaW50KQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAg IGxldCBjb250ZXh0TWVudSA9IFdJLkNvbnRleHRNZW51LmNyZWF0ZUZyb21FdmVudChldmVudCk7 Ci0KLSAgICAgICAgV0kuYXBwZW5kQ29udGV4dE1lbnVJdGVtc0ZvckRPTU5vZGVCcmVha3BvaW50 cyhjb250ZXh0TWVudSwgdGhpcy5yZXByZXNlbnRlZE9iamVjdCwgewotICAgICAgICAgICAgcmV2 ZWFsRGVzY2VuZGFudEJyZWFrcG9pbnRzTWVudUl0ZW1IYW5kbGVyOiB0aGlzLmJpbmRSZXZlYWxE ZXNjZW5kYW50QnJlYWtwb2ludHNNZW51SXRlbUhhbmRsZXIoKSwKLSAgICAgICAgfSk7Ci0gICAg fQotCiAgICAgX2hpZ2hsaWdodEFuaW1hdGlvbkVuZCgpCiAgICAgewogICAgICAgICBsZXQgbGlz dEl0ZW1FbGVtZW50ID0gdGhpcy5saXN0SXRlbUVsZW1lbnQ7Cg==