199406 2019-07-02 09:13:10 -0700 [GTK][WPE] Not longer needed to build woff2 on the JHBuild 2019-07-04 03:53:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199449 InRadar P2 Normal --- 1 clopez clopez aakash_jain agomez aperez ap bugs-noreply ews-watchlist jbedard ltilve mcatanzaro webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1549591 0 clopez 2019-07-02 09:13:10 -0700 On r223042 <https://trac.webkit.org/r223042> we removed Woff2 from ThirdParty and started bundling it on the JHBuild. Now the 4 distributions we "support" for development have a recent enough version of woff2. So there is no need to keep building this, we can just use the system one. I have checked that the woff2 version shipped both on Debian 10 and Ubuntu 18.04 work fine. And I guess Fedora and Arch should work fine as well. Both the debian and ubuntu stable bots are using now the system version Until now they were building with -DUSE_WOFF2=OFF (I removed this config parameter from the bots and installed system woff2) 1549600 1 373331 clopez 2019-07-02 09:18:43 -0700 Created attachment 373331 Patch 1549686 2 aakash_jain 2019-07-02 12:52:46 -0700 This patch fails new EWS on WPE: https://ews-build.webkit-uat.org/#/builders/7/builds/429 Retry: https://ews-build.webkit-uat.org/#/builders/7/builds/438 Not sure how it passed old EWS: https://webkit-queues.webkit.org/patch/373331/wpe-ews 1549730 3 mcatanzaro 2019-07-02 15:05:21 -0700 Hey Aakash, it's failing on new EWS because the new EWS isn't running the jhbuild step yet. You just fixed that over in bug #199408. 1549731 4 373331 mcatanzaro 2019-07-02 15:06:13 -0700 Comment on attachment 373331 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373331&action=review > Tools/wpe/install-dependencies:93 > - zlib1g-dev" > + zlib1g-dev \ > + libwoff-dev" Should be alphabetized under l 1549732 5 aakash_jain 2019-07-02 15:09:37 -0700 (In reply to Michael Catanzaro from comment #3) > Hey Aakash, it's failing on new EWS because the new EWS isn't running the jhbuild step yet. You just fixed that over in bug #199408. jhbuild step was run in the build URLs I posted above. I have already applied my patches to that EWS UAT instance. 1549734 6 mcatanzaro 2019-07-02 15:25:47 -0700 (In reply to Aakash Jain from comment #5) > jhbuild step was run in the build URLs I posted above. I have already > applied my patches to that EWS UAT instance. Oh, sorry, my bad: my answer was incorrect because we were only removing libraries from the jhbuild. We just need to install libbrotli and libwoff on the new EWS. This needs to be done manually on the rare occasions when we add new dependencies (including when we remove them from the jhbuild). 1549738 7 mcatanzaro 2019-07-02 15:28:58 -0700 (It passed on the old EWS because the old EWS happen to have these libraries already installed. In the future, if we switch to using containerization software like podman/docker to run the EWS, then we could avoid instance-specific configuration differences like these.) 1549875 8 clopez 2019-07-03 07:42:27 -0700 It seems this patch will broke continuous building when it lands due to: 1) Our JHBuild tooling is smart enough to detect a change on the moduleset has happened so it does a clean build of the JHBuild 2) But our WebKit build tooling doesn't detect the JHBuild has been rebuilt so it just triggers a continous build, and this happens: -- Build files have been written to: /home/igalia/clopez/webkit/webkit/WebKitBuild/Release ninja: error: '../DependenciesGTK/Root/lib/libwoff2dec.so', needed by 'lib/libwebkit2gtk-4.0.so.37.38.1', missing and no known rule to make it The previous binaries are liked with a libwoff2dec.so that is now gone on that path, and that seems to cause a ninja error. So its needed to trigger a clean build. 1549878 9 mcatanzaro 2019-07-03 07:47:17 -0700 Ideally the bots would trigger a clean build (wipe of the build directory) every time the JHBuild is run. 1549896 10 clopez 2019-07-03 09:35:18 -0700 (In reply to Michael Catanzaro from comment #9) > Ideally the bots would trigger a clean build (wipe of the build directory) > every time the JHBuild is run. It seems cleaning the CMake cache is enough to avoid this. Will upload a patch for that in #199449 1550201 11 clopez 2019-07-04 03:52:42 -0700 Committed r247138: <https://trac.webkit.org/changeset/247138> 1550202 12 webkit-bug-importer 2019-07-04 03:53:16 -0700 <rdar://problem/52639816> 373331 2019-07-02 09:18:43 -0700 2019-07-02 15:06:13 -0700 Patch bug-199406-20190702181841.patch text/plain 5335 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTVkNTQ4Nzc4MTNhNzdjZTYxMDM3MmU1MWZmYzc3NDVh MWFjNjUxNi4uOGQzYTljZWZhYTYzZThiNjA5ODRlZWUxMDhlZmI4NDVlNjcyMmExYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE5LTA3LTAyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gTm90IGxvbmdlciBuZWVkZWQgdG8gYnVpbGQg d29mZjIgb24gdGhlIEpIQnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5OTQwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEluc3RhbGwgdGhlIFdvZmYyIGxpYnJhcmllcyBhbmQgaGVhZGVycyBmcm9t IHRoZSBzeXN0ZW0gcGFja2FnZQorICAgICAgICBhbmQgc3RvcCBidWlsZGluZyB0aGVtIG9uIHRo ZSBKSEJ1aWxkLgorCisgICAgICAgICogZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzOgorICAgICAg ICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6CisgICAgICAgICogd3BlL2luc3RhbGwtZGVwZW5kZW5j aWVzOgorICAgICAgICAqIHdwZS9qaGJ1aWxkLm1vZHVsZXM6CisKIDIwMTktMDctMDIgIEFha2Fz aCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtld3MtYnVpbGRdIE1h a2UgUHJpbnRDb25maWd1cmF0aW9uIHBsYXRmb3JtIGF3YXJlCmRpZmYgLS1naXQgYS9Ub29scy9n dGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMK aW5kZXggNDNkYjUyMTg0YTdmOTFmOWZmNWVmNjBmMDkyMzU5MWE3N2ZlYWE2OS4uM2QxODBmYzI0 MzFmNWUwY2FlYjNmZmJhZmZlOWNkZjRmYTBiOGNlYSAxMDA3NTUKLS0tIGEvVG9vbHMvZ3RrL2lu c3RhbGwtZGVwZW5kZW5jaWVzCisrKyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcwpA QCAtMTM5LDYgKzEzOSw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsK ICAgICAgICAgbGlidnB4LWRldiBcCiAgICAgICAgIGxpYnVwb3dlci1nbGliLWRldiBcCiAgICAg ICAgIGxpYndlYnAtZGV2IFwKKyAgICAgICAgbGlid29mZi1kZXYgXAogICAgICAgICBsaWJ4Y29t cG9zaXRlLWRldiBcCiAgICAgICAgIGxpYnh0LWRldiBcCiAgICAgICAgIGxpYnh0c3QtZGV2IFwK QEAgLTMxMyw3ICszMTQsOCBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aFBhY21h biB7CiAgICAgICAgIHJ1YnkgXAogICAgICAgICB1dGlsLWxpbnV4IFwKICAgICAgICAgeG9yZy1m b250LXV0aWxzIFwKLSAgICAgICAgd2F5bGFuZCIKKyAgICAgICAgd2F5bGFuZCBcCisgICAgICAg IHdvZmYyIgogCiAgICAgIyBUaGVzZSBhcmUgZGVwZW5kZW5jaWVzIG5lY2Vzc2FyeSBmb3IgcnVu bmluZyB0ZXN0cy4KICAgICAjIE5vdGU6IGFwYWNoZS1tb2RfYncsIHJ1YnktanNvbiwgYW5kIHJ1 YnktaGlnaGxpbmUgYXJlIGF2YWlsYWJsZSBpbiB0aGUgQVVSCkBAIC00NzYsNyArNDc4LDggQEAg ZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhEbmYgewogICAgICAgICByZWRoYXQtcnBt LWNvbmZpZyBcCiAgICAgICAgIHJ1YnkgXAogICAgICAgICBzcWxpdGUtZGV2ZWwgXAotICAgICAg ICB1cG93ZXItZGV2ZWwiCisgICAgICAgIHVwb3dlci1kZXZlbCBcCisgICAgICAgIHdvZmYyLWRl dmVsIgogCiAgICAgIyBUaGVzZSBhcmUgZGVwZW5kZW5jaWVzIG5lY2Vzc2FyeSBmb3IgcnVubmlu ZyB0ZXN0cy4KICAgICBwYWNrYWdlcz0iJHBhY2thZ2VzIFwKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0 ay9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCmluZGV4IGViNjA3 NDQxMjFhNmQ3ZTAwMTRmZjM1Njg0ZjQ1YTQwM2NlYmZhOTcuLjQzZDJjZGUxNTA2YzNmMzBiYjJh OWY0NDVhMjhhNTM3NjY5ODFlZDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVs ZXMKKysrIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAtNyw4ICs3LDYgQEAKIAogICA8 bWV0YW1vZHVsZSBpZD0id2Via2l0Z3RrLXRlc3RpbmctZGVwZW5kZW5jaWVzIj4KICAgICA8ZGVw ZW5kZW5jaWVzPgotICAgICAgPGRlcCBwYWNrYWdlPSJicm90bGkiLz4KLSAgICAgIDxkZXAgcGFj a2FnZT0id29mZjIiLz4KICAgICAgIDxkZXAgcGFja2FnZT0iY2Fpcm8iLz4KICAgICAgIDxkZXAg cGFja2FnZT0iZm9udHMiLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZGljdHMiLz4KQEAgLTg1LDE3 ICs4Myw2IEBACiAgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9IndwZXdlYmtpdCIK ICAgICAgIGhyZWY9Imh0dHBzOi8vd3Bld2Via2l0Lm9yZy9yZWxlYXNlcy8iLz4KIAotICA8Y21h a2UgaWQ9ImJyb3RsaSI+Ci0gICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9Imdv b2dsZS9icm90bGkuZ2l0IiBjaGVja291dGRpcj0iYnJvdGxpIiB0YWc9InYxLjAuNSIvPgotICA8 L2NtYWtlPgotCi0gIDxjbWFrZSBpZD0id29mZjIiPgotICAgIDxicmFuY2ggcmVwbz0iZ2l0aHVi LmNvbSIgbW9kdWxlPSJnb29nbGUvd29mZjIuZ2l0IiBjaGVja291dGRpcj0id29mZjIiIHRhZz0i djEuMC4yIi8+Ci0gICAgPGRlcGVuZGVuY2llcz4KLSAgICAgIDxkZXAgcGFja2FnZT0iYnJvdGxp Ii8+Ci0gICAgPC9kZXBlbmRlbmNpZXM+Ci0gIDwvY21ha2U+Ci0KICAgPGF1dG90b29scyBpZD0i Y2Fpcm8iCiAgICAgICAgICAgICAgYXV0b2dlbi1zaD0iY29uZmlndXJlIj4KICAgICA8aWYgY29u ZGl0aW9uLXNldD0ibGludXgiPgpkaWZmIC0tZ2l0IGEvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5k ZW5jaWVzIGIvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzCmluZGV4IDA4Njk0YWU4MThk MjFiNzZmYmUxZjIyM2JmOTUyMWM4OTY4OTYyN2MuLjA5NDk5NmE2YTUwNGQ5MjgwMDA5NDIwZTBl ODRmMzc0ZGM3YTUxZmYgMTAwNzU1Ci0tLSBhL1Rvb2xzL3dwZS9pbnN0YWxsLWRlcGVuZGVuY2ll cworKysgYi9Ub29scy93cGUvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAgLTg5LDcgKzg5LDggQEAg ZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewogICAgICAgICBwYXRjaCBcCiAg ICAgICAgIHBrZy1jb25maWcgXAogICAgICAgICBydWJ5IFwKLSAgICAgICAgemxpYjFnLWRldiIK KyAgICAgICAgemxpYjFnLWRldiBcCisgICAgICAgIGxpYndvZmYtZGV2IgogCiAgICAgIyBUaGVz ZSBhcmUgZGVwZW5kZW5jaWVzIG5lY2Vzc2FyeSBmb3IgcnVubmluZyB0ZXN0cy4KICAgICBwYWNr YWdlcz0iJHBhY2thZ2VzIFwKQEAgLTE4OCw3ICsxODksOCBAQCBmdW5jdGlvbiBpbnN0YWxsRGVw ZW5kZW5jaWVzV2l0aFBhY21hbiB7CiAgICAgICAgIHNxbGl0ZSBcCiAgICAgICAgIHRleGluZm8g XAogICAgICAgICB3aGljaCBcCi0gICAgICAgIHpsaWIiCisgICAgICAgIHpsaWIgXAorICAgICAg ICB3b2ZmMiIKIAogICAgICMgVGhlc2UgYXJlIGRlcGVuZGVuY2llcyBuZWNlc3NhcnkgZm9yIHJ1 bm5pbmcgdGVzdHMuCiAgICAgIyBOb3RlOiBhcGFjaGUtbW9kX2J3LCBydWJ5LWpzb24gYW5kIHJ1 YnktaGlnaGxpbmUgYXJlIGF2YWlsYWJsZSBpbiB0aGUgQVVSCkBAIC0zNDEsNiArMzQzLDcgQEAg ZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhEbmYgewogICAgICAgICBwdWxzZWF1ZGlv LWxpYnMtZGV2ZWwgXAogICAgICAgICBweXRob24zLXNldHVwdG9vbHMgXAogICAgICAgICB3YXls YW5kLWRldmVsIFwKKyAgICAgICAgd29mZjItZGV2ZWwgXAogICAgICAgICB5YXNtIgogCiAgICAg IyBUaGVzZSBhcmUgZGVwZW5kZW5jaWVzIG5lY2Vzc2FyeSBmb3IgdXNpbmcgd2Via2l0LXBhdGNo CmRpZmYgLS1naXQgYS9Ub29scy93cGUvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvd3BlL2poYnVp bGQubW9kdWxlcwppbmRleCBiZTBmZTRmY2FkOTMxM2JkMjA2MmIzMDkxZTNmYTcyNDE5MWM0MDVm Li4zZDk1M2FhYTYwM2EyZDA1ZDU3ZTFjNTE4YjlkN2YwMjdlMjAyZDU5IDEwMDY0NAotLS0gYS9U b29scy93cGUvamhidWlsZC5tb2R1bGVzCisrKyBiL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMK QEAgLTcsNyArNyw2IEBACiAKICAgPG1ldGFtb2R1bGUgaWQ9IndlYmtpdHdwZS10ZXN0aW5nLWRl cGVuZGVuY2llcyI+CiAgICAgPGRlcGVuZGVuY2llcz4KLSAgICAgIDxkZXAgcGFja2FnZT0iYnJv dGxpIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KICAgICAgIDxkZXAgcGFja2FnZT0i bGlic291cCIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJjYWlybyIvPgpAQCAtMTgsNyArMTcsNiBA QAogICAgICAgPGRlcCBwYWNrYWdlPSJoYXJmYnV6eiIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJp Y3UiLz4KICAgICAgIDxkZXAgcGFja2FnZT0id2Via2l0LWdzdHJlYW1lci10ZXN0aW5nLWRlcGVu ZGVuY2llcyIvPgotICAgICAgPGRlcCBwYWNrYWdlPSJ3b2ZmMiIvPgogICAgICAgPGRlcCBwYWNr YWdlPSJsaWJ3cGUiLz4KICAgICAgIDxkZXAgcGFja2FnZT0id3BlYmFja2VuZC1mZG8iLz4KICAg ICAgIDxkZXAgcGFja2FnZT0ibGliZ3BnLWVycm9yIi8+CkBAIC01NiwxNyArNTQsNiBAQAogICA8 cmVwb3NpdG9yeSB0eXBlPSJ0YXJiYWxsIiBuYW1lPSJ3ZWJraXRndGstamhidWlsZC1taXJyb3Ii CiAgICAgICBocmVmPSJodHRwOi8vd2Via2l0Z3RrLm9yZy9qaGJ1aWxkX21pcnJvci8iLz4KIAot ICA8Y21ha2UgaWQ9ImJyb3RsaSI+Ci0gICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1 bGU9Imdvb2dsZS9icm90bGkuZ2l0IiBjaGVja291dGRpcj0iYnJvdGxpIiB0YWc9InYxLjAuMSIv PgotICA8L2NtYWtlPgotCi0gIDxjbWFrZSBpZD0id29mZjIiPgotICAgIDxicmFuY2ggcmVwbz0i Z2l0aHViLmNvbSIgbW9kdWxlPSJnb29nbGUvd29mZjIuZ2l0IiBjaGVja291dGRpcj0id29mZjIi IHRhZz0idjEuMC4yIi8+Ci0gICAgPGRlcGVuZGVuY2llcz4KLSAgICAgIDxkZXAgcGFja2FnZT0i YnJvdGxpIi8+Ci0gICAgPC9kZXBlbmRlbmNpZXM+Ci0gIDwvY21ha2U+Ci0KICAgPGF1dG90b29s cyBpZD0ibGliZmZpIiBhdXRvZ2VuLXNoPSJjb25maWd1cmUiPgogICAgIDxicmFuY2ggbW9kdWxl PSJsaWJmZmkvbGliZmZpLTMuMC4xMC50YXIuZ3oiIHZlcnNpb249IjMuMC4xMCIKICAgICAgICAg ICAgICByZXBvPSJzb3VyY2V3YXJlLm9yZy1taXJyb3IiCg==