199401 2019-07-02 05:15:58 -0700 [GTK] Support cancelling touchscreen back/forward gesture 2019-07-02 06:55:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alicem webkit-unassigned berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro oldest_to_newest 1549528 0 alicem 2019-07-02 05:15:58 -0700 See the patch. 1549529 1 373316 alicem 2019-07-02 05:19:38 -0700 Created attachment 373316 Patch 1549530 2 ews-watchlist 2019-07-02 05:20:26 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1549548 3 373316 commit-queue 2019-07-02 06:55:04 -0700 Comment on attachment 373316 Patch Clearing flags on attachment: 373316 Committed r247048: <https://trac.webkit.org/changeset/247048> 1549549 4 commit-queue 2019-07-02 06:55:06 -0700 All reviewed patches have been landed. Closing bug. 373316 2019-07-02 05:19:38 -0700 2019-07-02 06:55:04 -0700 Patch bug-199401-20190702171936.patch text/plain 7096 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjZGIwNWIwNjdhMjk5ZmQ5 YjljZGQ0YzA2N2Y4M2VlYmE2OTAzYjQuLmExMjQyMWEyMzk2ZGU5MzZkNjllMTJjZWYwNmNiYTg4 OWY4YjQzZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTktMDctMDIgIEFsZXhhbmRl ciBNaWtoYXlsZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gU3Vw cG9ydCBjYW5jZWxsaW5nIHRvdWNoc2NyZWVuIGJhY2svZm9yd2FyZCBnZXN0dXJlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk0MDEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBzaG91bGQgYmUgcG9z c2libGUgdG8gY2FuY2VsIHRoZSBnZXN0dXJlIHdoZW4gcGVyZm9ybWluZyBpdCBvbgorICAgICAg ICB0b3VjaHNjcmVlbiwgZm9yIGV4YW1wbGUsIGJ5IG1vdmluZyBwZW4gdG9vIGZhciBmcm9tIHRo ZSBzY3JlZW4uCisgICAgICAgIEhhbmRsZSB0aGlzIGNhc2UgcHJvcGVybHkuCisKKyAgICAgICAg T25seSBEcmFnR2VzdHVyZSBpbiBHZXN0dXJlQ29udHJvbGxlciBuZWVkcyB0byBoYW5kbGUgdGhp cywKKyAgICAgICAgU3dpcGVHZXN0dXJlIHNpbXBseSB3b24ndCBlbWl0IHRoZSByZWxldmFudCBl dmVudCBpbiB0aGlzIGNhc2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL1ZpZXdHZXN0dXJlQ29udHJvbGxl ci5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvR2VzdHVyZUNvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViS2l0OjpHZXN0dXJlQ29udHJvbGxlcjo6RHJhZ0dlc3R1cmU6OmNhbmNlbERyYWcp OgorICAgICAgICAoV2ViS2l0OjpHZXN0dXJlQ29udHJvbGxlcjo6RHJhZ0dlc3R1cmU6OmNhbmNl bCk6CisgICAgICAgIChXZWJLaXQ6Okdlc3R1cmVDb250cm9sbGVyOjpEcmFnR2VzdHVyZTo6RHJh Z0dlc3R1cmUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvR2VzdHVyZUNvbnRyb2xsZXIuaDoK KyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1ZpZXdHZXN0dXJlQ29udHJvbGxlckd0ay5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6cGxhdGZvcm1UZWFyZG93bik6 CisgICAgICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6Y2FuY2VsU3dpcGUpOgor CiAyMDE5LTA3LTAxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBQZXJmb3JtIGxlc3Mgd29yayB3aGVuIGEgcHJlLXdhcm1lZCBXZWJQcm9jZXNzIGlzIHN1 c3BlbmRlZCBvciByZXN1bWVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCAwOTkyZjM2M2JlNWQ1OGI0Y2FlZjQ3 ZTkwZDNjMGU3ZDdkZmMzZDhmLi40YTMzYTU2NDg3MWVkMjliNWRjMmUxYzJlNmRlZWYwZGU0M2Mx YTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dFdlYlZpZXdCYXNlLmNwcApAQCAtMTE3Nyw2ICsxMTc3LDEyIEBAIHByaXZhdGU6CiAgICAgICAg IHdlYmtpdFdlYlZpZXdCYXNlSGFuZGxlV2hlZWxFdmVudChtX3dlYlZpZXcsIHNjcm9sbEV2ZW50 LmdldCgpLCBXZWJXaGVlbEV2ZW50OjpQaGFzZTo6UGhhc2VDaGFuZ2VkKTsKICAgICB9CiAKKyAg ICB2b2lkIGNhbmNlbERyYWcoKSBmaW5hbAorICAgIHsKKyAgICAgICAgaWYgKGF1dG8qIGNvbnRy b2xsZXIgPSB3ZWJraXRXZWJWaWV3QmFzZVZpZXdHZXN0dXJlQ29udHJvbGxlcihtX3dlYlZpZXcp KQorICAgICAgICAgICAgY29udHJvbGxlci0+Y2FuY2VsU3dpcGUoKTsKKyAgICB9CisKICAgICB2 b2lkIHN3aXBlKEdka0V2ZW50VG91Y2gqIGV2ZW50LCBjb25zdCBGbG9hdFBvaW50JiB2ZWxvY2l0 eSkgZmluYWwKICAgICB7CiAgICAgICAgIGRvdWJsZSB4LCB5OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvVmlld0dlc3R1cmVDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaAppbmRleCBmM2RmMzJmYWFiOWM0YmI5 ZTZhZjg1MzJjNzliNDZjYzBiM2QwNTczLi43YjAyMGVmNWYwNjMxZjA4YTg3MTE1MDA1Y2I4YWZj Yjg4Y2FkMmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9WaWV3R2VzdHVy ZUNvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9WaWV3R2VzdHVyZUNv bnRyb2xsZXIuaApAQCAtMTY1LDYgKzE2NSw3IEBAIHB1YmxpYzoKICAgICBib29sIGlzU3dpcGVH ZXN0dXJlRW5hYmxlZCgpIHsgcmV0dXJuIG1fc3dpcGVHZXN0dXJlRW5hYmxlZDsgfQogCiAjaWYg UExBVEZPUk0oR1RLKQorICAgIHZvaWQgY2FuY2VsU3dpcGUoKTsKICAgICB2b2lkIGRyYXcoY2Fp cm9fdCosIGNhaXJvX3BhdHRlcm5fdCopOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2d0ay9HZXN0dXJlQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9ndGsvR2VzdHVyZUNvbnRyb2xsZXIuY3BwCmluZGV4IDllOGJlMWYzNzQ3NDkx ZjQ3YjUzNjcxM2Q4MGFhMTJiNjhmZjdmMmMuLjc2NDk4YjgwMTU4NDQ4NmQ2YzdhNWJiNmUyOTI3 MjU4Yjg1Zjc4ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9HZXN0 dXJlQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL0dlc3R1 cmVDb250cm9sbGVyLmNwcApAQCAtOTUsNiArOTUsMTIgQEAgdm9pZCBHZXN0dXJlQ29udHJvbGxl cjo6RHJhZ0dlc3R1cmU6OmhhbmRsZURyYWcoR2RrRXZlbnQqIGV2ZW50LCBkb3VibGUgeCwgZG91 YmwKICAgICAgICAgRmxvYXRQb2ludDo6bmFycm93UHJlY2lzaW9uKChtX29mZnNldC54KCkgLSB4 KSAvIFNjcm9sbGJhcjo6cGl4ZWxzUGVyTGluZVN0ZXAoKSwgKG1fb2Zmc2V0LnkoKSAtIHkpIC8g U2Nyb2xsYmFyOjpwaXhlbHNQZXJMaW5lU3RlcCgpKSk7CiB9CiAKK3ZvaWQgR2VzdHVyZUNvbnRy b2xsZXI6OkRyYWdHZXN0dXJlOjpjYW5jZWxEcmFnKCkKK3sKKyAgICBBU1NFUlQobV9pbkRyYWcp OworICAgIG1fY2xpZW50LmNhbmNlbERyYWcoKTsKK30KKwogdm9pZCBHZXN0dXJlQ29udHJvbGxl cjo6RHJhZ0dlc3R1cmU6OmhhbmRsZVRhcChHZGtFdmVudCogZXZlbnQpCiB7CiAgICAgQVNTRVJU KCFtX2luRHJhZyk7CkBAIC0xNDUsNiArMTUxLDEyIEBAIHZvaWQgR2VzdHVyZUNvbnRyb2xsZXI6 OkRyYWdHZXN0dXJlOjplbmQoRHJhZ0dlc3R1cmUqIGRyYWdHZXN0dXJlLCBHZGtFdmVudFNlcXVl CiAgICAgfQogfQogCit2b2lkIEdlc3R1cmVDb250cm9sbGVyOjpEcmFnR2VzdHVyZTo6Y2FuY2Vs KERyYWdHZXN0dXJlKiBkcmFnR2VzdHVyZSwgR2RrRXZlbnRTZXF1ZW5jZSogc2VxdWVuY2UsIEd0 a0dlc3R1cmUqIGdlc3R1cmUpCit7CisgICAgZHJhZ0dlc3R1cmUtPm1fbG9uZ1ByZXNzVGltZW91 dC5zdG9wKCk7CisgICAgZHJhZ0dlc3R1cmUtPmNhbmNlbERyYWcoKTsKK30KKwogdm9pZCBHZXN0 dXJlQ29udHJvbGxlcjo6RHJhZ0dlc3R1cmU6OmxvbmdQcmVzc0ZpcmVkKCkKIHsKICAgICBtX2lu RHJhZyA9IHRydWU7CkBAIC0xNTgsNiArMTcwLDcgQEAgR2VzdHVyZUNvbnRyb2xsZXI6OkRyYWdH ZXN0dXJlOjpEcmFnR2VzdHVyZShHdGtXaWRnZXQqIHdpZGdldCwgR2VzdHVyZUNvbnRyb2xsZXIK ICAgICBnX3NpZ25hbF9jb25uZWN0X3N3YXBwZWQobV9nZXN0dXJlLmdldCgpLCAiZHJhZy1iZWdp biIsIEdfQ0FMTEJBQ0soYmVnaW4pLCB0aGlzKTsKICAgICBnX3NpZ25hbF9jb25uZWN0X3N3YXBw ZWQobV9nZXN0dXJlLmdldCgpLCAiZHJhZy11cGRhdGUiLCBHX0NBTExCQUNLKHVwZGF0ZSksIHRo aXMpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChtX2dlc3R1cmUuZ2V0KCksICJlbmQi LCBHX0NBTExCQUNLKGVuZCksIHRoaXMpOworICAgIGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZCht X2dlc3R1cmUuZ2V0KCksICJjYW5jZWwiLCBHX0NBTExCQUNLKGNhbmNlbCksIHRoaXMpOwogfQog CiB2b2lkIEdlc3R1cmVDb250cm9sbGVyOjpTd2lwZUdlc3R1cmU6OnN0YXJ0TW9tZW50dW1TY3Jv bGwoR2RrRXZlbnQqIGV2ZW50LCBkb3VibGUgdmVsb2NpdHlYLCBkb3VibGUgdmVsb2NpdHlZKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL0dlc3R1cmVDb250cm9sbGVy LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvR2VzdHVyZUNvbnRyb2xsZXIuaAppbmRl eCBjNzEwNWJmNTM0MjgxNmNlMDgzN2UwNzNlYjg1YzMzMjgwYTI2MmQ4Li4yYWRkYmNkNTljMDEz MjdmY2VmMzRlYWZkOGE4NjI5Y2EzYWYwYjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9ndGsvR2VzdHVyZUNvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9ndGsvR2VzdHVyZUNvbnRyb2xsZXIuaApAQCAtNDUsNiArNDUsNyBAQCBwdWJsaWM6CiAK ICAgICB2aXJ0dWFsIHZvaWQgc3RhcnREcmFnKEdka0V2ZW50VG91Y2gqLCBjb25zdCBXZWJDb3Jl OjpGbG9hdFBvaW50JikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBkcmFnKEdka0V2ZW50VG91Y2gq LCBjb25zdCBXZWJDb3JlOjpGbG9hdFBvaW50JiwgY29uc3QgV2ViQ29yZTo6RmxvYXRQb2ludCYp ID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgY2FuY2VsRHJhZygpID0gMDsKIAogICAgIHZpcnR1YWwg dm9pZCBzd2lwZShHZGtFdmVudFRvdWNoKiwgY29uc3QgV2ViQ29yZTo6RmxvYXRQb2ludCYpID0g MDsKIApAQCAtOTQsMTIgKzk1LDE0IEBAIHByaXZhdGU6CiAgICAgICAgIC8vIE5vdGlmeSB0aGF0 IGEgZHJhZyBzdGFydGVkLCBhbGxvd2luZyB0byBzdG9wIGtpbmV0aWMgZGVjZWxlcmF0aW9uLgog ICAgICAgICB2b2lkIHN0YXJ0RHJhZyhHZGtFdmVudCopOwogICAgICAgICB2b2lkIGhhbmRsZURy YWcoR2RrRXZlbnQqLCBkb3VibGUgeCwgZG91YmxlIHkpOworICAgICAgICB2b2lkIGNhbmNlbERy YWcoKTsKICAgICAgICAgdm9pZCBoYW5kbGVUYXAoR2RrRXZlbnQqKTsKICAgICAgICAgdm9pZCBs b25nUHJlc3NGaXJlZCgpOwogCiAgICAgICAgIHN0YXRpYyB2b2lkIGJlZ2luKERyYWdHZXN0dXJl KiwgZG91YmxlIHgsIGRvdWJsZSB5LCBHdGtHZXN0dXJlKik7CiAgICAgICAgIHN0YXRpYyB2b2lk IHVwZGF0ZShEcmFnR2VzdHVyZSosIGRvdWJsZSB4LCBkb3VibGUgeSwgR3RrR2VzdHVyZSopOwog ICAgICAgICBzdGF0aWMgdm9pZCBlbmQoRHJhZ0dlc3R1cmUqLCBHZGtFdmVudFNlcXVlbmNlKiwg R3RrR2VzdHVyZSopOworICAgICAgICBzdGF0aWMgdm9pZCBjYW5jZWwoRHJhZ0dlc3R1cmUqLCBH ZGtFdmVudFNlcXVlbmNlKiwgR3RrR2VzdHVyZSopOwogCiAgICAgICAgIFdlYkNvcmU6OkZsb2F0 UG9pbnQgbV9zdGFydDsKICAgICAgICAgV2ViQ29yZTo6RmxvYXRQb2ludCBtX29mZnNldDsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9WaWV3R2VzdHVyZUNvbnRyb2xs ZXJHdGsuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1ZpZXdHZXN0dXJlQ29udHJv bGxlckd0ay5jcHAKaW5kZXggNTI4MjVlYzQ4ZTY2YzYzZThlY2VjNDBkYjFkNGNjZDBiYWU3YWIz My4uY2VlODMwNmY3Nzk4MDkxMGQ2ZjFjYzAzZmRlNzRiMTk5ZDYxNjk5OSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1ZpZXdHZXN0dXJlQ29udHJvbGxlckd0ay5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1ZpZXdHZXN0dXJlQ29udHJvbGxlckd0 ay5jcHAKQEAgLTU5LDEwICs1OSw3IEBAIHN0YXRpYyBib29sIGlzRXZlbnRTdG9wKEdka0V2ZW50 U2Nyb2xsKiBldmVudCkKIAogdm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OnBsYXRmb3JtVGVh cmRvd24oKQogewotICAgIG1fc3dpcGVQcm9ncmVzc1RyYWNrZXIucmVzZXQoKTsKLQotICAgIGlm IChtX2FjdGl2ZUdlc3R1cmVUeXBlID09IFZpZXdHZXN0dXJlVHlwZTo6U3dpcGUpCi0gICAgICAg IHJlbW92ZVN3aXBlU25hcHNob3QoKTsKKyAgICBjYW5jZWxTd2lwZSgpOwogfQogCiBib29sIFZp ZXdHZXN0dXJlQ29udHJvbGxlcjo6UGVuZGluZ1N3aXBlVHJhY2tlcjo6c2Nyb2xsRXZlbnRDYW5T dGFydFN3aXBlKEdka0V2ZW50U2Nyb2xsKikKQEAgLTMyOCw2ICszMjUsMTYgQEAgdm9pZCBWaWV3 R2VzdHVyZUNvbnRyb2xsZXI6OmhhbmRsZVN3aXBlR2VzdHVyZShXZWJCYWNrRm9yd2FyZExpc3RJ dGVtKiwgZG91YmxlLAogICAgIGd0a193aWRnZXRfcXVldWVfZHJhdyhtX3dlYlBhZ2VQcm94eS52 aWV3V2lkZ2V0KCkpOwogfQogCit2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6Y2FuY2VsU3dp cGUoKQoreworICAgIG1fcGVuZGluZ1N3aXBlVHJhY2tlci5yZXNldCgiY2FuY2VsbGluZyBzd2lw ZSIpOworCisgICAgaWYgKG1fYWN0aXZlR2VzdHVyZVR5cGUgPT0gVmlld0dlc3R1cmVUeXBlOjpT d2lwZSkgeworICAgICAgICBtX3N3aXBlUHJvZ3Jlc3NUcmFja2VyLnJlc2V0KCk7CisgICAgICAg IHJlbW92ZVN3aXBlU25hcHNob3QoKTsKKyAgICB9Cit9CisKIHZvaWQgVmlld0dlc3R1cmVDb250 cm9sbGVyOjpkcmF3KGNhaXJvX3QqIGNyLCBjYWlyb19wYXR0ZXJuX3QqIHBhZ2VHcm91cCkKIHsK ICAgICBib29sIHN3aXBpbmdMZWZ0ID0gaXNQaHlzaWNhbGx5U3dpcGluZ0xlZnQobV9zd2lwZVBy b2dyZXNzVHJhY2tlci5kaXJlY3Rpb24oKSk7Cg==