199356 2019-07-01 04:11:58 -0700 [GStreamer] The CREATE_TRACK macro is messed up 2019-07-08 03:13:26 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris commit-queue webkit-bug-importer oldest_to_newest 1549173 0 pnormand 2019-07-01 04:11:58 -0700 The naturalSize() method was implemented in the middle ot its ifdef and the macro signature is wrong in case of VIDEO_TRACK support is disabled. 1549224 1 373237 pnormand 2019-07-01 08:25:05 -0700 Created attachment 373237 Patch 1549474 2 373237 commit-queue 2019-07-01 23:35:37 -0700 Comment on attachment 373237 Patch Rejecting attachment 373237 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 373237, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/12636566 1550776 3 pnormand 2019-07-08 03:08:39 -0700 Committed r247204: <https://trac.webkit.org/changeset/247204> 1550777 4 webkit-bug-importer 2019-07-08 03:13:26 -0700 <rdar://problem/52770671> 373237 2019-07-01 08:25:05 -0700 2019-07-01 23:35:37 -0700 Patch bug-199356-20190701162503.patch text/plain 4647 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU4OTBhN2ZhYTUzMmU0 MTg0MTFhZmZhNTA1ODc1YjljNzg3YWI0Ni4uMTU5MmFhZWFmMzRhOTRhNTAyYzMwMDVkOTRlN2Mx YjI3NjZmN2ViNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA3LTAxICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBUaGUgQ1JFQVRFX1RSQUNLIG1hY3JvIGlzIG1lc3NlZCB1cAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MzU2CisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6dXBkYXRlVHJhY2tz KTogRml4IHRoZQorICAgICAgICBDUkVBVEVfVFJBQ0sgbWFjcm8gZm9yICFWSURFT19UUkFDSyBi dWlsZHMuCisKIDIwMTktMDctMDEgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIENhbm5vdCBwbGF5IEJlcnQncyBCeXRlcyByYWRp byBzdHJlYW0gZnJvbSBodHRwOi8vcmFkaW8uZG9zLm5sLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCA5NzE3M2YzMDYxNTI0NzY3OGJhYjBl ZDNjZTIyZWU2Y2NmNzBkYjU5Li45MDg5NGQwZWM4M2FjYTU4YjgyY2Q1ODM0YTRiNDIzZDUwOTI4 NzkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw cApAQCAtNjgwLDE4ICs2ODAsNiBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6 Y2xlYXJUcmFja3MoKQogfQogI3VuZGVmIENMRUFSX1RSQUNLUwogCi0jaWYgRU5BQkxFKFZJREVP X1RSQUNLKQotI2RlZmluZSBDUkVBVEVfVFJBQ0sodHlwZSwgVHlwZSkgXAotICAgIG1faGFzIyNU eXBlID0gdHJ1ZTsgXAotICAgIGlmICghdXNlTWVkaWFTb3VyY2UpIHtcCi0gICAgICAgIFJlZlB0 cjxUeXBlIyNUcmFja1ByaXZhdGVHU3RyZWFtZXI+IHRyYWNrID0gVHlwZSMjVHJhY2tQcml2YXRl R1N0cmVhbWVyOjpjcmVhdGUobWFrZVdlYWtQdHIoKnRoaXMpLCBpLCBzdHJlYW0pOyBcCi0gICAg ICAgIG1fIyN0eXBlIyNUcmFja3MuYWRkKHRyYWNrLT5pZCgpLCB0cmFjayk7IFwKLSAgICAgICAg bV9wbGF5ZXItPmFkZCMjVHlwZSMjVHJhY2soKnRyYWNrKTtcCi0gICAgICAgIGlmIChnc3Rfc3Ry ZWFtX2dldF9zdHJlYW1fZmxhZ3Moc3RyZWFtLmdldCgpKSAmIEdTVF9TVFJFQU1fRkxBR19TRUxF Q1QpIHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgICAgICBt X2N1cnJlbnQjI1R5cGUjI1N0cmVhbUlkID0gU3RyaW5nKGdzdF9zdHJlYW1fZ2V0X3N0cmVhbV9p ZChzdHJlYW0uZ2V0KCkpKTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAg IH0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0g ICAgfQotCiBGbG9hdFNpemUgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpuYXR1cmFsU2l6 ZSgpIGNvbnN0CiB7CiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKQEAgLTcxMCw4ICs2OTgsMjIg QEAgRmxvYXRTaXplIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bmF0dXJhbFNpemUoKSBj b25zdAogCiAgICAgcmV0dXJuIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6Om5hdHVy YWxTaXplKCk7CiB9CisKKyNpZiBFTkFCTEUoVklERU9fVFJBQ0spCisjZGVmaW5lIENSRUFURV9U UkFDSyh0eXBlLCBUeXBlKSBHX1NUTVRfU1RBUlQgeyAgICAgICAgICAgICAgICAgICAgICAgICBc CisgICAgICAgIG1faGFzIyNUeXBlID0gdHJ1ZTsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBcCisgICAgICAgIGlmICghdXNlTWVkaWFTb3VyY2UpIHsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCisgICAgICAgICAgICBSZWZQdHI8 VHlwZSMjVHJhY2tQcml2YXRlR1N0cmVhbWVyPiB0cmFjayA9IFR5cGUjI1RyYWNrUHJpdmF0ZUdT dHJlYW1lcjo6Y3JlYXRlKG1ha2VXZWFrUHRyKCp0aGlzKSwgaSwgc3RyZWFtKTsgXAorICAgICAg ICAgICAgbV8jI3R5cGUjI1RyYWNrcy5hZGQodHJhY2stPmlkKCksIHRyYWNrKTsgICAgICAgICAg ICAgICAgICAgXAorICAgICAgICAgICAgbV9wbGF5ZXItPmFkZCMjVHlwZSMjVHJhY2soKnRyYWNr KTsgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICAgICAgaWYgKGdzdF9zdHJlYW1f Z2V0X3N0cmVhbV9mbGFncyhzdHJlYW0uZ2V0KCkpICYgR1NUX1NUUkVBTV9GTEFHX1NFTEVDVCkg XAorICAgICAgICAgICAgICAgIG1fY3VycmVudCMjVHlwZSMjU3RyZWFtSWQgPSBTdHJpbmcoZ3N0 X3N0cmVhbV9nZXRfc3RyZWFtX2lkKHN0cmVhbS5nZXQoKSkpOyBcCisgICAgICAgIH0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBc CisgICAgfSBHX1NUTVRfRU5ECiAjZWxzZQotI2RlZmluZSBDUkVBVEVfVFJBQ0sodHlwZSwgX2lk LCB0cmFja3MsIG1ldGhvZCwgc3RyZWFtKSBtX2hhcyMjVHlwZSMjID0gdHJ1ZTsKKyNkZWZpbmUg Q1JFQVRFX1RSQUNLKHR5cGUsIFR5cGUpIEdfU1RNVF9TVEFSVCB7IFwKKyAgICAgICAgbV9oYXMj I1R5cGUjIyA9IHRydWU7ICAgICAgICAgICAgICAgICAgIFwKKyAgICB9IEdfU1RNVF9FTkQKICNl bmRpZiAvLyBFTkFCTEUoVklERU9fVFJBQ0spCiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyOjp1cGRhdGVUcmFja3MoKQpAQCAtNzMyLDExICs3MzQsMTEgQEAgdm9pZCBNZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVRyYWNrcygpCiAgICAgICAgIEdzdFN0cmVhbVR5 cGUgdHlwZSA9IGdzdF9zdHJlYW1fZ2V0X3N0cmVhbV90eXBlKHN0cmVhbS5nZXQoKSk7CiAKICAg ICAgICAgR1NUX0RFQlVHX09CSkVDVChwaXBlbGluZSgpLCAiSW5zcGVjdGluZyAlcyB0cmFjayB3 aXRoIElEICVzIiwgZ3N0X3N0cmVhbV90eXBlX2dldF9uYW1lKHR5cGUpLCBzdHJlYW1JZC51dGY4 KCkuZGF0YSgpKTsKLSAgICAgICAgaWYgKHR5cGUgJiBHU1RfU1RSRUFNX1RZUEVfQVVESU8pIHsK LSAgICAgICAgICAgIENSRUFURV9UUkFDSyhhdWRpbywgQXVkaW8pCi0gICAgICAgIH0gZWxzZSBp ZiAodHlwZSAmIEdTVF9TVFJFQU1fVFlQRV9WSURFTykgewotICAgICAgICAgICAgQ1JFQVRFX1RS QUNLKHZpZGVvLCBWaWRlbykKLSAgICAgICAgfSBlbHNlIGlmICh0eXBlICYgR1NUX1NUUkVBTV9U WVBFX1RFWFQgJiYgIXVzZU1lZGlhU291cmNlKSB7CisgICAgICAgIGlmICh0eXBlICYgR1NUX1NU UkVBTV9UWVBFX0FVRElPKQorICAgICAgICAgICAgQ1JFQVRFX1RSQUNLKGF1ZGlvLCBBdWRpbyk7 CisgICAgICAgIGVsc2UgaWYgKHR5cGUgJiBHU1RfU1RSRUFNX1RZUEVfVklERU8pCisgICAgICAg ICAgICBDUkVBVEVfVFJBQ0sodmlkZW8sIFZpZGVvKTsKKyAgICAgICAgZWxzZSBpZiAodHlwZSAm IEdTVF9TVFJFQU1fVFlQRV9URVhUICYmICF1c2VNZWRpYVNvdXJjZSkgewogI2lmIEVOQUJMRShW SURFT19UUkFDSykKICAgICAgICAgICAgIGF1dG8gdHJhY2sgPSBJbmJhbmRUZXh0VHJhY2tQcml2 YXRlR1N0cmVhbWVyOjpjcmVhdGUodGV4dFRyYWNrSW5kZXgrKywgc3RyZWFtKTsKICAgICAgICAg ICAgIG1fdGV4dFRyYWNrcy5hZGQoc3RyZWFtSWQsIHRyYWNrLmNvcHlSZWYoKSk7CkBAIC03NTUs NiArNzU3LDggQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVRyYWNr cygpCiAgICAgbV9wbGF5ZXItPmNsaWVudCgpLm1lZGlhUGxheWVyRW5naW5lVXBkYXRlZChtX3Bs YXllcik7CiB9CiAKKyN1bmRlZiBDUkVBVEVfVFJBQ0sKKwogdm9pZCBNZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXI6OmVuYWJsZVRyYWNrKFRyYWNrUHJpdmF0ZUJhc2VHU3RyZWFtZXI6OlRyYWNr VHlwZSB0cmFja1R5cGUsIHVuc2lnbmVkIGluZGV4KQogewogICAgIC8vIEZJWE1FOiBSZW1vdmUg aXNNZWRpYVNvdXJjZSgpIHRlc3QgYmVsb3cgd2hlbiBmaXhpbmcgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MjUzMS4K