199337 2019-06-28 13:47:01 -0700 unable to build WebRTC for iOS Simulator 2019-06-28 15:50:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino eric.carlson ews-watchlist thorton webkit-bug-importer oldest_to_newest 1548932 0 dino 2019-06-28 13:47:01 -0700 unable to build WebRTC for iOS Simulator 1548933 1 dino 2019-06-28 13:47:36 -0700 <rdar://problem/52020841> 1548934 2 373147 dino 2019-06-28 13:50:30 -0700 Created attachment 373147 Patch 1548959 3 373154 dino 2019-06-28 15:20:28 -0700 Created attachment 373154 Patch 1548969 4 373154 thorton 2019-06-28 15:29:25 -0700 Comment on attachment 373154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373154&action=review > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:3384 > + script = "DYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n"; This is /such a hack/ and needs a comment and a bug tracking properly building this for the host. 1548972 5 dino 2019-06-28 15:42:37 -0700 (In reply to Tim Horton from comment #4) > Comment on attachment 373154 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373154&action=review > > > Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:3384 > > + script = "DYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm -fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I ${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I ${SRCROOT}/Source/third_party/libvpx/source/libvpx -o ${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o ${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n"; > > This is /such a hack/ and needs a comment and a bug tracking properly > building this for the host. I don't know where to put the comment. I could put it in the script field within the Xcode project, but no one will see that if they are looking at the build output. 1548973 6 dino 2019-06-28 15:50:56 -0700 Committed r246945: <https://trac.webkit.org/changeset/246945> 373147 2019-06-28 13:50:30 -0700 2019-06-28 15:20:24 -0700 Patch bug-199337-20190629065029.patch text/plain 1461 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2OTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBiMTVhODJkOTIzYmM0N2RhNzJmYjc4MDZjYjE4NjRkZGQ1NWEzMDU4Li5hOWMw YmUzNDBkYWRiY2ZkNjgxNjE1YTdkMzU4NmFjYjI5YjIxZTg5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wNi0yOCAgRGVhbiBKYWNr c29uICA8ZGlub0BhcHBsZS5jb20+CisKKyAgICAgICAgdW5hYmxlIHRvIGJ1aWxkIFdlYlJUQyBm b3IgaU9TIFNpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk5MzM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MjAyMDg0MT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IGJ1aWxkIGZv ciBtYWNPUy4KKworICAgICAgICAqIE1ha2VmaWxlOgorCiAyMDE5LTA2LTI3ICBCZXRoIERha2lu ICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBVcHN0cmVhbSB1c2Ugb2YgTUFDQ0FUQUxZ U1QKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9NYWtlZmlsZSBiL1Nv dXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9NYWtlZmlsZQppbmRleCA5NzU2NmI4MGI2OGQwNzk2 YjZhZDc2N2Q1YWM0MzI5M2FkZDNjODdiLi4yMWFiZmRiOWQxNzIxMjc2YmZhY2NjZDhjYzlkZjRj ZDkxNzhjMmI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvTWFrZWZp bGUKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL01ha2VmaWxlCkBAIC0xLDcgKzEs MTUgQEAKLWlmbmVxICgsJChTREtST09UKSkKLQlpZm5lcSAoLCQoZmluZHN0cmluZyB3YXRjaCwk KFNES1JPT1QpKSkKLQkJT1RIRVJfT1BUSU9OUyArPSAtdGFyZ2V0IGJvcmluZ3NzbAotCWVuZGlm CitpZm5lcSAoLCQoZmluZHN0cmluZyBpcGhvbmUsJChTREtST09UKSkpCisJT1ZFUlJJREVfU0RL Uk9PVCA9IGRlZmF1bHQKKwlPVkVSUklERV9BUkNIUyA9IGRlZmF1bHQKK2VuZGlmCitpZm5lcSAo LCQoZmluZHN0cmluZyB3YXRjaCwkKFNES1JPT1QpKSkKKwlPVEhFUl9PUFRJT05TICs9IC10YXJn ZXQgYm9yaW5nc3NsCisJT1ZFUlJJREVfU0RLUk9PVCA9IGRlZmF1bHQKKwlPVkVSUklERV9BUkNI UyA9IGRlZmF1bHQKK2VuZGlmCitpZm5lcSAoLCQoZmluZHN0cmluZyB0diwkKFNES1JPT1QpKSkK KwlPVkVSUklERV9TREtST09UID0gZGVmYXVsdAorCU9WRVJSSURFX0FSQ0hTID0gZGVmYXVsdAog ZW5kaWYKIAogaW5jbHVkZSAuLi9NYWtlZmlsZS5zaGFyZWQK 373154 2019-06-28 15:20:28 -0700 2019-06-28 15:29:25 -0700 Patch bug-199337-20190629082026.patch text/plain 2208 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2OTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBiMTVhODJkOTIzYmM0N2RhNzJmYjc4MDZjYjE4NjRkZGQ1NWEzMDU4Li5iNTMy YTNmNGY4ODc0MDY3MTEzYjJkYWMyMzA2ZTEzNTdkZDg2OTM5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOS0wNi0yOCAgRGVhbiBKYWNr c29uICA8ZGlub0BhcHBsZS5jb20+CisKKyAgICAgICAgdW5hYmxlIHRvIGJ1aWxkIFdlYlJUQyBm b3IgaU9TIFNpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk5MzM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MjAyMDg0MT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSdW4gdGhlIGNvbXBp bGVkIHlhc20gd2l0aCBEWUxEX1JPT1RfUEFUSD0vCisgICAgICAgIGluIG9yZGVyIHRvIGNvbnZp bmNlIGR5bGQgdGhhdCBpdCBjYW4gbG9hZAorICAgICAgICB0aGUgc2ltdWxhdG9yIGJpbmFyeSBv biBtYWNPUy4KKworICAgICAgICAqIGxpYndlYnJ0Yy54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9q OgorCiAyMDE5LTA2LTI3ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAg ICBVcHN0cmVhbSB1c2Ugb2YgTUFDQ0FUQUxZU1QKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBh cnR5L2xpYndlYnJ0Yy9saWJ3ZWJydGMueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1NvdXJj ZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9saWJ3ZWJydGMueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv agppbmRleCBiYmNmNjNkNTFmNzM1ZTE3YWE0MGQyYjUyOGE5ODllYzRhMzA2YWJmLi41ZDc3MTUx MjRlMzZlOWFhYWE3OTdhNWM2MmM3MDcwMjEyMjk5NTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhp cmRQYXJ0eS9saWJ3ZWJydGMvbGlid2VicnRjLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysr IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL2xpYndlYnJ0Yy54Y29kZXByb2ovcHJvamVj dC5wYnhwcm9qCkBAIC0zMzc1LDExICszMzc1LDEzIEBACiAJCQljb21waWxlclNwZWMgPSBjb20u YXBwbGUuY29tcGlsZXJzLnByb3h5LnNjcmlwdDsKIAkJCWZpbGVQYXR0ZXJucyA9IGFzbTsKIAkJ CWZpbGVUeXBlID0gc291cmNlY29kZS5hc20uYXNtOworCQkJaW5wdXRGaWxlcyA9ICgKKwkJCSk7 CiAJCQlpc0VkaXRhYmxlID0gMTsKIAkJCW91dHB1dEZpbGVzID0gKAogCQkJCSIke09CSkVDVF9G SUxFX0RJUl9ub3JtYWx9LyR7Q1VSUkVOVF9BUkNIfS8ke0lOUFVUX0ZJTEVfQkFTRX0ubyIsCiAJ CQkpOwotCQkJc2NyaXB0ID0gIiR7QlVJTFRfUFJPRFVDVFNfRElSfS95YXNtIC1mbWFjaG82NCAt SSAke1NSQ1JPT1R9L1NvdXJjZS90aGlyZF9wYXJ0eS9saWJ2cHgvc291cmNlL2NvbmZpZyAtSSAk e1NSQ1JPT1R9L1NvdXJjZS90aGlyZF9wYXJ0eS9saWJ2cHgvc291cmNlL2NvbmZpZy9tYWMveDY0 IC1JICR7U1JDUk9PVH0vU291cmNlL3RoaXJkX3BhcnR5L2xpYnZweC9zb3VyY2UvbGlidnB4IC1v ICR7T0JKRUNUX0ZJTEVfRElSX25vcm1hbH0vJHtDVVJSRU5UX0FSQ0h9LyR7SU5QVVRfRklMRV9C QVNFfS5vICR7SU5QVVRfRklMRV9ESVJ9LyR7SU5QVVRfRklMRV9CQVNFfS5hc21cbiI7CisJCQlz Y3JpcHQgPSAiRFlMRF9ST09UX1BBVEg9LyAke0JVSUxUX1BST0RVQ1RTX0RJUn0veWFzbSAtZm1h Y2hvNjQgLUkgJHtTUkNST09UfS9Tb3VyY2UvdGhpcmRfcGFydHkvbGlidnB4L3NvdXJjZS9jb25m aWcgLUkgJHtTUkNST09UfS9Tb3VyY2UvdGhpcmRfcGFydHkvbGlidnB4L3NvdXJjZS9jb25maWcv bWFjL3g2NCAtSSAke1NSQ1JPT1R9L1NvdXJjZS90aGlyZF9wYXJ0eS9saWJ2cHgvc291cmNlL2xp YnZweCAtbyAke09CSkVDVF9GSUxFX0RJUl9ub3JtYWx9LyR7Q1VSUkVOVF9BUkNIfS8ke0lOUFVU X0ZJTEVfQkFTRX0ubyAke0lOUFVUX0ZJTEVfRElSfS8ke0lOUFVUX0ZJTEVfQkFTRX0uYXNtXG4i OwogCQl9OwogLyogRW5kIFBCWEJ1aWxkUnVsZSBzZWN0aW9uICovCiAK