199270 2019-06-27 06:18:20 -0700 Use JSC_GLIB_API_ENABLED instead of USE(GLIB) as a compile-time check for GLib JSC API 2019-06-27 08:48:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annulen annulen cgarcia ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1548452 0 annulen 2019-06-27 06:18:20 -0700 This change allows building code with enabled USE(GLIB) but without GLib JSC API 1548453 1 373025 annulen 2019-06-27 06:22:15 -0700 Created attachment 373025 Patch 1548472 2 373025 mcatanzaro 2019-06-27 07:21:23 -0700 Comment on attachment 373025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373025&action=review > Source/JavaScriptCore/heap/Heap.cpp:99 > -#if USE(GLIB) > +#ifdef JSC_GLIB_API_ENABLED How about #if ENABLE(JSC_GLIB_API)? 1548473 3 annulen 2019-06-27 07:27:11 -0700 This macro is also used in public headers of JSC where ENABLE() is unavailable. It's possible to introduce another macro ENABLE_JSC_GLIB_API to be used inside implementation code, but I've decided not to multiply entities 1548479 4 373025 mcatanzaro 2019-06-27 08:00:03 -0700 Comment on attachment 373025 Patch OK then. I also missed that it already exists. But why no r? 1548482 5 373025 annulen 2019-06-27 08:11:18 -0700 Comment on attachment 373025 Patch Oops, I wanted to check EWS status 1548484 6 373025 ews-watchlist 2019-06-27 08:24:05 -0700 Comment on attachment 373025 Patch Attachment 373025 did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12592494 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases apiTests 1548485 7 373025 annulen 2019-06-27 08:39:00 -0700 Comment on attachment 373025 Patch Clearing flags on attachment: 373025 Committed r246881: <https://trac.webkit.org/changeset/246881> 1548486 8 annulen 2019-06-27 08:39:04 -0700 All reviewed patches have been landed. Closing bug. 1548487 9 webkit-bug-importer 2019-06-27 08:48:20 -0700 <rdar://problem/52261875> 373025 2019-06-27 06:22:15 -0700 2019-06-27 08:39:00 -0700 Patch bug-199270-20190627162214.patch text/plain 3420 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MjBiNWVhZTliZGVmOTIyNWJhZTZlMjk0ZWE3MDYwMDQyOGYyOTJlLi4wOWUxZmNmOGZiZWU0ZDJm YmJjMDRiYTQ2ZDQ4NGM1ZmJlNTdjNGQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wNi0yNyAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgVXNlIEpTQ19HTElCX0FQSV9FTkFCTEVEIGluc3RlYWQgb2YgVVNF KEdMSUIpIGFzIGEgY29tcGlsZS10aW1lIGNoZWNrIGZvciBHTGliIEpTQyBBUEkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTI3MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIGFsbG93 cyBidWlsZGluZyBjb2RlIHdpdGggZW5hYmxlZCBVU0UoR0xJQikgYnV0IHdpdGhvdXQKKyAgICAg ICAgR0xpYiBKU0MgQVBJLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpT Qzo6SGVhcDo6cmVsZWFzZURlbGF5ZWRSZWxlYXNlZE9iamVjdHMpOgorICAgICAgICAqIGhlYXAv SGVhcC5oOgorICAgICAgICAqIGhlYXAvSGVhcElubGluZXMuaDoKKwogMjAxOS0wNi0yNyAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog dGhyb3cgYW4gZXJyb3IgaWYgY29uc29sZS5jb3VudC9jb25zb2xlLmNvdW50UmVzZXQgaXMgY2Fs bGVkIHdpdGggYW4gb2JqZWN0IHRoYXQgdGhyb3dzIGFuIGVycm9yIGZyb20gdG9TdHJpbmcKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKaW5kZXggYTUzMjc1NGE5MzY1MDQ0M2JiYTEwZGQ1 MDU3ZGE4NmQ0Y2E4MmQ0Ni4uYjdlNDMwMWE0YTk5NWQ1YzU2ZDhiMjZiY2Q1M2IwZjhlNDM2YjY2 NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKQEAgLTk2LDcgKzk2LDcgQEAKICNp bmNsdWRlIDx3dGYvc3BpL2NvY29hL29iamNTUEkuaD4KICNlbmRpZgogCi0jaWYgVVNFKEdMSUIp CisjaWZkZWYgSlNDX0dMSUJfQVBJX0VOQUJMRUQKICNpbmNsdWRlICJKU0NHTGliV3JhcHBlck9i amVjdC5oIgogI2VuZGlmCiAKQEAgLTQ3Nyw3ICs0NzcsNyBAQCB2b2lkIEhlYXA6Omxhc3RDaGFu Y2VUb0ZpbmFsaXplKCkKIAogdm9pZCBIZWFwOjpyZWxlYXNlRGVsYXllZFJlbGVhc2VkT2JqZWN0 cygpCiB7Ci0jaWYgVVNFKEZPVU5EQVRJT04pIHx8IFVTRShHTElCKQorI2lmIFVTRShGT1VOREFU SU9OKSB8fCBkZWZpbmVkKEpTQ19HTElCX0FQSV9FTkFCTEVEKQogICAgIC8vIFdlIG5lZWQgdG8g Z3VhcmQgYWdhaW5zdCB0aGUgY2FzZSB0aGF0IHJlbGVhc2luZyBhbiBvYmplY3QgY2FuIGNyZWF0 ZSBtb3JlIG9iamVjdHMgZHVlIHRvIHRoZQogICAgIC8vIHJlbGVhc2UgY2FsbGluZyBpbnRvIEpT LiBXaGVuIHRob3NlIEpTIGNhbGwocykgZXhpdCBhbmQgYWxsIGxvY2tzIGFyZSBiZWluZyBkcm9w cGVkIHdlIGVuZCB1cAogICAgIC8vIGJhY2sgaGVyZSBhbmQgY291bGQgdHJ5IHRvIHJlY3Vyc2l2 ZWx5IHJlbGVhc2Ugb2JqZWN0cy4gV2UgZ3VhcmQgdGhhdCB3aXRoIGEgcmVjdXJzaXZlIGVudHJ5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmggYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgKaW5kZXggN2M3NTE3NjVhNWI5MmQ2ZTZkOWJiZGYz OTJhZmEyMmE5OWIzYmE5Mi4uMTgxY2U4Zjg3NTljMWE5NTU4Mjc4YzEyYjI2ZTA2MjM3MDg3MjMx NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaApAQCAtODYsNyArODYsNyBAQCBjbGFzcyBW TTsKIGNsYXNzIFdlYWtHQ01hcEJhc2U7CiBzdHJ1Y3QgQ3VycmVudFRocmVhZFN0YXRlOwogCi0j aWYgVVNFKEdMSUIpCisjaWZkZWYgSlNDX0dMSUJfQVBJX0VOQUJMRUQKIGNsYXNzIEpTQ0dMaWJX cmFwcGVyT2JqZWN0OwogI2VuZGlmCiAKQEAgLTI3OSw3ICsyNzksNyBAQCBwdWJsaWM6CiAjaWYg VVNFKEZPVU5EQVRJT04pCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gdm9pZCByZWxlYXNlU29v bihSZXRhaW5QdHI8VD4mJik7CiAjZW5kaWYKLSNpZiBVU0UoR0xJQikKKyNpZmRlZiBKU0NfR0xJ Ql9BUElfRU5BQkxFRAogICAgIHZvaWQgcmVsZWFzZVNvb24oc3RkOjp1bmlxdWVfcHRyPEpTQ0dM aWJXcmFwcGVyT2JqZWN0PiYmKTsKICNlbmRpZgogCkBAIC02NjQsNyArNjY0LDcgQEAgcHJpdmF0 ZToKICAgICBWZWN0b3I8UmV0YWluUHRyPENGVHlwZVJlZj4+IG1fZGVsYXllZFJlbGVhc2VPYmpl Y3RzOwogICAgIHVuc2lnbmVkIG1fZGVsYXllZFJlbGVhc2VSZWN1cnNpb25Db3VudCB7IDAgfTsK ICNlbmRpZgotI2lmIFVTRShHTElCKQorI2lmZGVmIEpTQ19HTElCX0FQSV9FTkFCTEVECiAgICAg VmVjdG9yPHN0ZDo6dW5pcXVlX3B0cjxKU0NHTGliV3JhcHBlck9iamVjdD4+IG1fZGVsYXllZFJl bGVhc2VPYmplY3RzOwogICAgIHVuc2lnbmVkIG1fZGVsYXllZFJlbGVhc2VSZWN1cnNpb25Db3Vu dCB7IDAgfTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcElubGluZXMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBJbmxpbmVzLmgK aW5kZXggODE5NzczMGMyZmM4YTBlNzRkZDA2YjU2ZGZjNWFmY2NhZjU5YTYxZC4uNWI2OWNkNWUz NWY2MmI1MDY2M2E5Y2JkYzczOTRkMWJkNjdhZDFkOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvSGVhcElubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwSW5saW5lcy5oCkBAIC0xNjQsNyArMTY0LDcgQEAgaW5saW5lIHZvaWQgSGVhcDo6 cmVsZWFzZVNvb24oUmV0YWluUHRyPFQ+JiYgb2JqZWN0KQogfQogI2VuZGlmCiAKLSNpZiBVU0Uo R0xJQikKKyNpZmRlZiBKU0NfR0xJQl9BUElfRU5BQkxFRAogaW5saW5lIHZvaWQgSGVhcDo6cmVs ZWFzZVNvb24oc3RkOjp1bmlxdWVfcHRyPEpTQ0dMaWJXcmFwcGVyT2JqZWN0PiYmIG9iamVjdCkK IHsKICAgICBtX2RlbGF5ZWRSZWxlYXNlT2JqZWN0cy5hcHBlbmQoV1RGTW92ZShvYmplY3QpKTsK