199265 2019-06-27 04:49:05 -0700 [SOUP] WebSockets: runtime critical warning when closing the connection in some cases 2019-06-28 00:47:02 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1548430 0 cgarcia 2019-06-27 04:49:05 -0700 (process:16024): libsoup-CRITICAL **: 13:46:08.280: soup_websocket_connection_close: assertion '!pv->close_sent' failed 1548431 1 373017 cgarcia 2019-06-27 04:51:38 -0700 Created attachment 373017 Patch 1548755 2 cgarcia 2019-06-28 00:47:02 -0700 Committed r246923: <https://trac.webkit.org/changeset/246923> 373017 2019-06-27 04:51:38 -0700 2019-06-27 07:58:39 -0700 Patch wk2-soup-socket-close.diff text/plain 1718 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYjFhNWFkMmQ0M2UuLjU4MjBjMDVhNDgwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE5LTA2LTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbU09VUF0gV2ViU29ja2V0czogcnVudGltZSBjcml0aWNhbCB3YXJu aW5nIHdoZW4gY2xvc2luZyB0aGUgY29ubmVjdGlvbiBpbiBzb21lIGNhc2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkyNjUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmUgdGhlIGNvbm5lY3Rp b24gaXMgc3RpbGwgb3BlbiBiZWZvcmUgY2FsbGluZyBzb3VwX3dlYnNvY2tldF9jb25uZWN0aW9u X2Nsb3NlKCkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tT b3VwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViU29ja2V0VGFzazo6Y2xvc2UpOgorCiAyMDE5 LTA2LTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBXZWJTb2NrZXRzOiBhZGQgc3VwcG9ydCBmb3Igc2VuZGluZyBibG9iIG1lc3NhZ2VzIHdo ZW4gdXNpbmcgd2ViIHNvY2tldHMgcGxhdGZvcm0gQVBJcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tTb3VwLmNwcCBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9XZWJTb2NrZXRUYXNrU291cC5jcHAKaW5kZXggYjhi MjY4ZWVjODUuLjA0NjllMjI1NTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL3NvdXAvV2ViU29ja2V0VGFza1NvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3Mvc291cC9XZWJTb2NrZXRUYXNrU291cC5jcHAKQEAgLTE1NiwxMiArMTU2LDE0 IEBAIHZvaWQgV2ViU29ja2V0VGFzazo6Y2xvc2UoaW50MzJfdCBjb2RlLCBjb25zdCBTdHJpbmcm IHJlYXNvbikKICAgICBpZiAobV9yZWNlaXZlZERpZENsb3NlKQogICAgICAgICByZXR1cm47CiAK LSAgICBpZiAobV9jb25uZWN0aW9uKQotICAgICAgICBzb3VwX3dlYnNvY2tldF9jb25uZWN0aW9u X2Nsb3NlKG1fY29ubmVjdGlvbi5nZXQoKSwgY29kZSwgcmVhc29uLnV0ZjgoKS5kYXRhKCkpOwot ICAgIGVsc2UgeworICAgIGlmICghbV9jb25uZWN0aW9uKSB7CiAgICAgICAgIGdfY2FuY2VsbGFi bGVfY2FuY2VsKG1fY2FuY2VsbGFibGUuZ2V0KCkpOwogICAgICAgICBkaWRDbG9zZShjb2RlID8g Y29kZSA6IFNPVVBfV0VCU09DS0VUX0NMT1NFX0FCTk9STUFMLCByZWFzb24pOworICAgICAgICBy ZXR1cm47CiAgICAgfQorCisgICAgaWYgKHNvdXBfd2Vic29ja2V0X2Nvbm5lY3Rpb25fZ2V0X3N0 YXRlKG1fY29ubmVjdGlvbi5nZXQoKSkgPT0gU09VUF9XRUJTT0NLRVRfU1RBVEVfT1BFTikKKyAg ICAgICAgc291cF93ZWJzb2NrZXRfY29ubmVjdGlvbl9jbG9zZShtX2Nvbm5lY3Rpb24uZ2V0KCks IGNvZGUsIHJlYXNvbi51dGY4KCkuZGF0YSgpKTsKIH0KIAogdm9pZCBXZWJTb2NrZXRUYXNrOjpj YW5jZWwoKQo=