199260 2019-06-27 00:25:29 -0700 Rotated composited elements with clipping descendants sometimes don't respecting original layering 2022-10-24 08:49:00 -0700 1 1 1 Unclassified WebKit Compositing Other All Unspecified NEW InRadar P2 Normal --- 1 iztok.oder webkit-unassigned ahmad.saleem792 mattwoodrow simon.fraser webkit-bug-importer oldest_to_newest 1548380 0 373005 iztok.oder 2019-06-27 00:25:29 -0700 Created attachment 373005 Minimal reproduction case Overview: Ele Drag-selecting any page crashes Mac builds in the NSGetFactory function. Steps to Reproduce: Minimized, easy-to-follow steps that will trigger the bug. Include any special setup steps. Steps to reproduce: 1) Open the attached html in chrome or safari. 2) Open inspector tools and select div with 'object' class. 3) Change object's transform property function 'rotate' to use various angles. 3) Observe div elements with class names 'element-1' and 'element-2'. Expected results: The layering of most inner elements should be the same regardless of the rotation angle of their parent. Actual Results: With some angles used in rotate function the innermost div elements are correctly layered while with others they are not. Hardware and browsers: Mac OS 10.13.3 Chrome Version 75.0.3770.100 (Official Build) (64-bit) Safari Version 11.0.3 (13604.5.6) Additional Builds and Platforms: Safari on Iphone 7 with iOS 12.3.1 Chrome Version 75.0.3770.100 (Official Build) (64-bit) on Windows 10 Additional Information: Experimenting with the minimal reproduction case we figured out 1548382 1 iztok.oder 2019-06-27 00:33:20 -0700 Seems I accidentally submitted this too soon. Overview: Layering of elements within rotated parent with overflow hidden is not respected when one of the elements is sent to GPU. Experimenting with the attached minimal reproduction case we figured out that the combination of overflow: hidden on element 'container' class, rotated element with class 'object' and sending one of the elements within 'container' element produces this result. Sending all elements within 'container' element will fix this issue. 1548514 2 webkit-bug-importer 2019-06-27 10:40:37 -0700 <rdar://problem/52269393> 1548515 3 ap 2019-06-27 10:42:47 -0700 The test case shows a green square on my iPhone. Does that mean that the test passes? 1548521 4 simon.fraser 2019-06-27 10:47:54 -0700 Please attach a test case that shows both "good" and "bad" states. I should not have to go messing in the inspector to reproduce the bug. 1548533 5 373037 simon.fraser 2019-06-27 11:03:27 -0700 Created attachment 373037 Better testcase 1548596 6 373049 simon.fraser 2019-06-27 13:29:21 -0700 Created attachment 373049 Correct testcase 1548597 7 simon.fraser 2019-06-27 13:30:34 -0700 In the bad case we're not detecting that the blue box needs compositing because overlap testing fails. 1548607 8 simon.fraser 2019-06-27 13:54:26 -0700 In RenderLayerCompositor::addToOverlapMap(), 'clipRect' seems wrong, and then we intersect it with clippedBounds and get a rect that is too small. 1548613 9 simon.fraser 2019-06-27 14:12:48 -0700 RenderLayer::calculateClipRects() just offsets the clip rect by renderer().localToContainerPoint(FloatPoint(), &clipRectsContext.rootLayer->renderer()), which is clearly wrong with rotations. 1548614 10 373052 simon.fraser 2019-06-27 14:15:14 -0700 Created attachment 373052 Testcase 1907672 11 ahmad.saleem792 2022-10-23 12:21:40 -0700 I am able to reproduce this bug in Safari 16, Safari Technology Preview 156 and it does not show "blue" in second "green" square. All other browsers (Chrome Canary 109 and Firefox Nightly 108) show both "blue" square within "green" squares. Just wanted to update results. Thanks! 373005 2019-06-27 00:25:29 -0700 2019-06-27 11:03:27 -0700 Minimal reproduction case transform-in-rotated-object-bug.html text/html 836 iztok.oder CjxoZWFkPgo8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgogICAgLm9iamVjdCB7CiAgICAgICAgd2lk dGg6IDIwMHB4OwogICAgICAgIGhlaWdodDogMjAwcHg7CiAgICAgICAgdHJhbnNmb3JtOiByb3Rh dGUoOTNkZWcpOwogICAgfQogICAgLmNvbnRhaW5lciB7CiAgICAgICAgcG9zaXRpb246IHJlbGF0 aXZlOwogICAgICAgIHdpZHRoOiAxMDAlOwogICAgICAgIGhlaWdodDogMTAwJTsKICAgICAgICBv dmVyZmxvdzogaGlkZGVuOwogICAgfQoKICAgIC5lbGVtZW50LTEgewogICAgICAgIHBvc2l0aW9u OiBhYnNvbHV0ZTsKICAgICAgICB0b3A6IDUwcHg7CiAgICAgICAgbGVmdDogNTBweDsKICAgICAg ICB3aWR0aDogNTBweDsKICAgICAgICBoZWlnaHQ6IDUwcHg7CiAgICAgICAgYmFja2dyb3VuZC1j b2xvcjogcmVkOwogICAgICAgIHotaW5kZXg6IDE7CiAgICB9CgogICAgLmVsZW1lbnQtMiB7CiAg ICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgIHRvcDogLTVweDsKICAgICAgICBsZWZ0 OiAtNXB4OwogICAgICAgIHdpZHRoOiAyMTBweDsKICAgICAgICBoZWlnaHQ6IDIxMHB4OwogICAg ICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOwogICAgICAgIHRyYW5zZm9ybTogdHJhbnNsYXRl WigwKTsKICAgICAgICB6LWluZGV4OiAwOwogICAgfQoKPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4K CjxkaXYgY2xhc3M9Im9iamVjdCI+CiAgICA8ZGl2IGNsYXNzPSJjb250YWluZXIiPgogICAgICAg IDxkaXYgY2xhc3M9ImVsZW1lbnQtMSI+PC9kaXY+CiAgICAgICAgPGRpdiBjbGFzcz0iZWxlbWVu dC0yIj48L2Rpdj4KICAgIDwvZGl2Pgo8L2Rpdj4KCjwvYm9keT4= 373037 2019-06-27 11:03:27 -0700 2019-06-27 13:29:21 -0700 Better testcase rotation-and-clipping.html text/html 1349 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDx0aXRsZT5odHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MjYwPC90aXRsZT4KICAgIDxzdHlsZT4KICAgICAg ICAub2JqZWN0IHsKICAgICAgICAgICAgbWFyZ2luOiAxMDBweDsKICAgICAgICAgICAgd2lkdGg6 IDIwMHB4OwogICAgICAgICAgICBoZWlnaHQ6IDIwMHB4OwogICAgICAgIH0KICAgICAgICAKICAg ICAgICAuYmFkIHsKICAgICAgICAgICAgdHJhbnNmb3JtOiByb3RhdGUoMjk3ZGVnKTsKICAgICAg ICB9CiAgICAgICAgCiAgICAgICAgLmdvb2QgewogICAgICAgICAgICB0cmFuc2Zvcm06IHJvdGF0 ZSg5N2RlZyk7CiAgICAgICAgfQogICAgICAgIC5jb250YWluZXIgewogICAgICAgICAgICBwb3Np dGlvbjogcmVsYXRpdmU7CiAgICAgICAgICAgIHdpZHRoOiAxMDAlOwogICAgICAgICAgICBoZWln aHQ6IDEwMCU7CiAgICAgICAgICAgIG92ZXJmbG93OiBoaWRkZW47CiAgICAgICAgfQoKICAgICAg ICAuZWxlbWVudC0xIHsKICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAg ICB0b3A6IDUwcHg7CiAgICAgICAgICAgIGxlZnQ6IDUwcHg7CiAgICAgICAgICAgIHdpZHRoOiA1 MHB4OwogICAgICAgICAgICBoZWlnaHQ6IDUwcHg7CiAgICAgICAgICAgIGJhY2tncm91bmQtY29s b3I6IHJlZDsKICAgICAgICAgICAgei1pbmRleDogMTsKICAgICAgICB9CgogICAgICAgIC5lbGVt ZW50LTIgewogICAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgICAgICAgIHRvcDog LTVweDsKICAgICAgICAgICAgbGVmdDogLTVweDsKICAgICAgICAgICAgd2lkdGg6IDIxMHB4Owog ICAgICAgICAgICBoZWlnaHQ6IDIxMHB4OwogICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBn cmVlbjsKICAgICAgICAgICAgdHJhbnNmb3JtOiB0cmFuc2xhdGVaKDApOwogICAgICAgICAgICB6 LWluZGV4OiAwOwogICAgICAgIH0KICAgIDwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+Cgo8aDE+QmFk PC9oMT4KPGRpdiBjbGFzcz0ib2JqZWN0IGJhZCI+CiAgICA8ZGl2IGNsYXNzPSJjb250YWluZXIi PgogICAgICAgIDxkaXYgY2xhc3M9ImVsZW1lbnQtMSI+PC9kaXY+CiAgICAgICAgPGRpdiBjbGFz cz0iZWxlbWVudC0yIj48L2Rpdj4KICAgIDwvZGl2Pgo8L2Rpdj4KCjxoMT5Hb29kPC9oMT4KPGRp diBjbGFzcz0ib2JqZWN0IGdvb2QiPgogICAgPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KICAgICAg ICA8ZGl2IGNsYXNzPSJlbGVtZW50LTEiPjwvZGl2PgogICAgICAgIDxkaXYgY2xhc3M9ImVsZW1l bnQtMiI+PC9kaXY+CiAgICA8L2Rpdj4KPC9kaXY+CjwvYm9keT4= 373049 2019-06-27 13:29:21 -0700 2019-06-27 14:15:14 -0700 Correct testcase rotation-and-clipping.html text/html 1373 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDx0aXRsZT5odHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MjYwPC90aXRsZT4KICAgIDxzdHlsZT4KICAgICAg ICAub2JqZWN0IHsKICAgICAgICAgICAgbWFyZ2luOiAxMDBweDsKICAgICAgICAgICAgd2lkdGg6 IDIwMHB4OwogICAgICAgICAgICBoZWlnaHQ6IDIwMHB4OwogICAgICAgIH0KICAgICAgICAKICAg ICAgICAuYmFkIHsKICAgICAgICAgICAgdHJhbnNmb3JtOiByb3RhdGUoMjk3ZGVnKTsKICAgICAg ICB9CiAgICAgICAgCiAgICAgICAgLmdvb2QgewogICAgICAgICAgICB0cmFuc2Zvcm06IHJvdGF0 ZSg5N2RlZyk7CiAgICAgICAgfQogICAgICAgIC5jb250YWluZXIgewogICAgICAgICAgICBwb3Np dGlvbjogcmVsYXRpdmU7CiAgICAgICAgICAgIHdpZHRoOiAxMDAlOwogICAgICAgICAgICBoZWln aHQ6IDEwMCU7CiAgICAgICAgICAgIG92ZXJmbG93OiBoaWRkZW47CiAgICAgICAgfQoKICAgICAg ICAuZWxlbWVudC0xIHsKICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAg ICB0b3A6IDUwcHg7CiAgICAgICAgICAgIGxlZnQ6IDUwcHg7CiAgICAgICAgICAgIHdpZHRoOiA1 MHB4OwogICAgICAgICAgICBoZWlnaHQ6IDUwcHg7CiAgICAgICAgICAgIGJhY2tncm91bmQtY29s b3I6IGJsdWU7CiAgICAgICAgICAgIHotaW5kZXg6IDE7CiAgICAgICAgfQoKICAgICAgICAuZWxl bWVudC0yIHsKICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAgICB0b3A6 IC01cHg7CiAgICAgICAgICAgIGxlZnQ6IC01cHg7CiAgICAgICAgICAgIHdpZHRoOiAyMTBweDsK ICAgICAgICAgICAgaGVpZ2h0OiAyMTBweDsKICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjog Z3JlZW47CiAgICAgICAgICAgIHRyYW5zZm9ybTogdHJhbnNsYXRlWigwKTsKICAgICAgICAgICAg ei1pbmRleDogMDsKICAgICAgICB9CiAgICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5PgoKPHA+VGhl cmUgc2hvdWxkIGJlIGEgYmx1ZSBib3ggaW4gZWFjaCByZWQgYm94PC9wPgo8ZGl2IGNsYXNzPSJv YmplY3QgYmFkIj4KICAgIDxkaXYgY2xhc3M9ImNvbnRhaW5lciI+CiAgICAgICAgPGRpdiBjbGFz cz0iZWxlbWVudC0xIj48L2Rpdj4KICAgICAgICA8ZGl2IGNsYXNzPSJlbGVtZW50LTIiPjwvZGl2 PgogICAgPC9kaXY+CjwvZGl2PgoKPGRpdiBjbGFzcz0ib2JqZWN0IGdvb2QiPgogICAgPGRpdiBj bGFzcz0iY29udGFpbmVyIj4KICAgICAgICA8ZGl2IGNsYXNzPSJlbGVtZW50LTEiPjwvZGl2Pgog ICAgICAgIDxkaXYgY2xhc3M9ImVsZW1lbnQtMiI+PC9kaXY+CiAgICA8L2Rpdj4KPC9kaXY+Cjwv Ym9keT4= 373052 2019-06-27 14:15:14 -0700 2019-06-27 14:15:14 -0700 Testcase rotation-and-clipping.html text/html 1346 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDx0aXRsZT5odHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MjYwPC90aXRsZT4KICAgIDxzdHlsZT4KICAgICAg ICAub2JqZWN0IHsKICAgICAgICAgICAgbWFyZ2luOiAxMDBweDsKICAgICAgICAgICAgd2lkdGg6 IDIwMHB4OwogICAgICAgICAgICBoZWlnaHQ6IDIwMHB4OwogICAgICAgIH0KICAgICAgICAKICAg ICAgICAuYmFkIHsKICAgICAgICAgICAgdHJhbnNmb3JtOiByb3RhdGUoOTdkZWcpOwogICAgICAg IH0KICAgICAgICAKICAgICAgICAuZ29vZCB7CiAgICAgICAgICAgIHRyYW5zZm9ybTogcm90YXRl KDI5N2RlZyk7CiAgICAgICAgfQogICAgICAgIC5jb250YWluZXIgewogICAgICAgICAgICBwb3Np dGlvbjogcmVsYXRpdmU7CiAgICAgICAgICAgIHdpZHRoOiAxMDAlOwogICAgICAgICAgICBoZWln aHQ6IDEwMCU7CiAgICAgICAgICAgIG92ZXJmbG93OiBoaWRkZW47CiAgICAgICAgfQoKICAgICAg ICAuZnJvbnQgewogICAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgICAgICAgIHRv cDogNTBweDsKICAgICAgICAgICAgbGVmdDogNTBweDsKICAgICAgICAgICAgd2lkdGg6IDUwcHg7 CiAgICAgICAgICAgIGhlaWdodDogNTBweDsKICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjog Ymx1ZTsKICAgICAgICAgICAgei1pbmRleDogMTsKICAgICAgICB9CgogICAgICAgIC5iYWNrIHsK ICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAgICB0b3A6IC01cHg7CiAg ICAgICAgICAgIGxlZnQ6IC01cHg7CiAgICAgICAgICAgIHdpZHRoOiAyMTBweDsKICAgICAgICAg ICAgaGVpZ2h0OiAyMTBweDsKICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CiAg ICAgICAgICAgIHRyYW5zZm9ybTogdHJhbnNsYXRlWigwKTsKICAgICAgICAgICAgei1pbmRleDog MDsKICAgICAgICB9CiAgICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5PgoKPHA+VGhlcmUgc2hvdWxk IGJlIGEgYmx1ZSBib3ggaW4gZWFjaCByZWQgYm94PC9wPgo8ZGl2IGNsYXNzPSJvYmplY3QgZ29v ZCI+CiAgICA8ZGl2IGNsYXNzPSJjb250YWluZXIiPgogICAgICAgIDxkaXYgY2xhc3M9ImZyb250 Ij48L2Rpdj4KICAgICAgICA8ZGl2IGNsYXNzPSJiYWNrIj48L2Rpdj4KICAgIDwvZGl2Pgo8L2Rp dj4KCjxkaXYgY2xhc3M9Im9iamVjdCBiYWQiPgogICAgPGRpdiBjbGFzcz0iY29udGFpbmVyIj4K ICAgICAgICA8ZGl2IGNsYXNzPSJmcm9udCI+PC9kaXY+CiAgICAgICAgPGRpdiBjbGFzcz0iYmFj ayI+PC9kaXY+CiAgICA8L2Rpdj4KPC9kaXY+CjwvYm9keT4=