199214 2019-06-25 18:02:07 -0700 CagedPtr doesn't merge PAC bits back into the resulting caged pointer. 2019-06-26 16:47:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller benjamin cdumez cmarcelo commit-queue dbates ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1547919 0 keith_miller 2019-06-25 18:02:07 -0700 CagedPtr doesn't merge PAC bits back into the resulting caged pointer. 1547920 1 372887 keith_miller 2019-06-25 18:04:00 -0700 Created attachment 372887 Patch 1547922 2 372888 keith_miller 2019-06-25 18:19:58 -0700 Created attachment 372888 Patch 1547923 3 ews-watchlist 2019-06-25 18:22:42 -0700 Attachment 372888 did not pass style-queue: ERROR: Source/WTF/wtf/CagedPtr.h:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1547936 4 372888 ysuzuki 2019-06-25 18:48:36 -0700 Comment on attachment 372888 Patch r=me 1547947 5 372888 commit-queue 2019-06-25 19:25:25 -0700 Comment on attachment 372888 Patch Clearing flags on attachment: 372888 Committed r246827: <https://trac.webkit.org/changeset/246827> 1547948 6 commit-queue 2019-06-25 19:25:26 -0700 All reviewed patches have been landed. Closing bug. 1548216 7 webkit-bug-importer 2019-06-26 16:47:59 -0700 <rdar://problem/52218882> 372887 2019-06-25 18:04:00 -0700 2019-06-25 18:19:56 -0700 Patch bug-199214-20190625180359.patch text/plain 2700 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY4NzM1N2RiZjhkMTBmOTI4ODBjNjMw MWZjMDI2ZGZiMmE2NTMzNTEuLjU0NzNlOTYwMDI2NjJjYzgyOGU1Y2M1ZTkyYTg0ZjQzMzZmZGEy NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDYtMjUgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FnZWRQdHIgZG9lc24ndCBtZXJnZSBQQUMg Yml0cyBiYWNrIGludG8gdGhlIHJlc3VsdGluZyBjYWdlZCBwb2ludGVyLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MjE0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQgY29kZSBtZWFu cyB0aGF0IGNhZ2luZyB3aWxsIGp1c3Qgc3RyaXAgdGhlIGFueSBmYWlsZWQKKyAgICAgICAgYXV0 aGVudGljYXRpb24gYml0cy4gQWRkaW5nIHRoaXMgY29kZSBkb2Vzbid0IGFwcGVhciB0byBiZSBh CisgICAgICAgIHJlZ3Jlc3Npb24gb24gaVBob25lIFhzLgorCisgICAgICAgICogd3RmL0NhZ2Vk UHRyLmg6CisgICAgICAgIChXVEY6OkNhZ2VkUHRyOjpnZXQgY29uc3QpOgorICAgICAgICAoV1RG OjpDYWdlZFB0cjo6Z2V0TWF5QmVOdWxsIGNvbnN0KToKKyAgICAgICAgKFdURjo6Q2FnZWRQdHI6 OmdldFVuc2FmZSBjb25zdCk6CisgICAgICAgIChXVEY6OkNhZ2VkUHRyOjptZXJnZVBvaW50ZXJz KToKKwogMjAxOS0wNi0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgVGlkeSB1cCB0aGUgcmVtYWluaW5nIGJpdHMgb2YgdGhlIEF0b21pY1N0cmluZyB0byBBdG9t U3RyaW5nIHJlbmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ2FnZWRQdHIuaCBiL1Nv dXJjZS9XVEYvd3RmL0NhZ2VkUHRyLmgKaW5kZXggNzFlYzUxZTI5NDdiNWIyY2EwNmVhMmM0MDU2 ZGFkY2ViOTM4ZGY2ZS4uZGFlNWNiMDA4ZmZlMmYxYjcxZjY3NmQzYmZiODJiYzRhNDczMWIxZCAx MDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ2FnZWRQdHIuaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9DYWdlZFB0ci5oCkBAIC01MiwyNCArNTIsMjEgQEAgcHVibGljOgogICAgIHsKICAgICAgICAg QVNTRVJUKG1fcHRyKTsKICAgICAgICAgVCogcHRyID0gUHRyVHJhaXRzOjp1bndyYXAobV9wdHIp OwotICAgICAgICBpZiAoc2hvdWxkVGFnKQotICAgICAgICAgICAgcHRyID0gdW50YWdBcnJheVB0 cihwdHIsIHNpemUpOwotICAgICAgICByZXR1cm4gR2lnYWNhZ2U6OmNhZ2VkKGtpbmQsIHB0cik7 CisgICAgICAgIFQqIHVudGFnZ2VkUHRyID0gc2hvdWxkVGFnID8gdW50YWdBcnJheVB0cihwdHIs IHNpemUpIDogcHRyOworICAgICAgICByZXR1cm4gbWVyZ2VQb2ludGVycyh1bnRhZ2dlZFB0ciwg R2lnYWNhZ2U6OmNhZ2VkKGtpbmQsIHB0cikpOwogICAgIH0KIAogICAgIFQqIGdldE1heUJlTnVs bCh1bnNpZ25lZCBzaXplKSBjb25zdAogICAgIHsKICAgICAgICAgVCogcHRyID0gUHRyVHJhaXRz Ojp1bndyYXAobV9wdHIpOwotICAgICAgICBpZiAoc2hvdWxkVGFnKQotICAgICAgICAgICAgcHRy ID0gdW50YWdBcnJheVB0cihwdHIsIHNpemUpOwotICAgICAgICByZXR1cm4gR2lnYWNhZ2U6OmNh Z2VkTWF5QmVOdWxsKGtpbmQsIHB0cik7CisgICAgICAgIFQqIHVudGFnZ2VkUHRyID0gc2hvdWxk VGFnID8gdW50YWdBcnJheVB0cihwdHIsIHNpemUpIDogcHRyOworICAgICAgICByZXR1cm4gbWVy Z2VQb2ludGVycyh1bnRhZ2dlZFB0ciwgR2lnYWNhZ2U6OmNhZ2VkTWF5QmVOdWxsKGtpbmQsIHB0 cikpOwogICAgIH0KIAogICAgIFQqIGdldFVuc2FmZSgpIGNvbnN0CiAgICAgewogICAgICAgICBU KiBwdHIgPSBQdHJUcmFpdHM6OnVud3JhcChtX3B0cik7Ci0gICAgICAgIGlmIChzaG91bGRUYWcp Ci0gICAgICAgICAgICBwdHIgPSByZW1vdmVBcnJheVB0clRhZyhwdHIpOworICAgICAgICBwdHIg PSBzaG91bGRUYWcgPyByZW1vdmVBcnJheVB0clRhZyhwdHIpIDogcHRyOwogICAgICAgICByZXR1 cm4gR2lnYWNhZ2U6OmNhZ2VkTWF5QmVOdWxsKGtpbmQsIHB0cik7CiAgICAgfQogCkBAIC0xMjUs NiArMTIyLDEzIEBAIHB1YmxpYzoKICAgICB9CiAgICAgCiBwcm90ZWN0ZWQ6CisgICAgc3RhdGlj IGlubGluZSBUKiBtZXJnZVBvaW50ZXJzKGNvbnN0IFQqIHVudGFnZ2VkUHRyLCBjb25zdCBUKiB1 bmNhZ2VkUHRyKQorICAgIHsKKyAgICAgICAgY29uc3RleHByIHVuc2lnbmVkIG51bWJlck9mUEFD Qml0cyA9IDI1OworICAgICAgICBjb25zdGV4cHIgdWludHB0cl90IG1hc2sgPSAoMXVsbCA8PCAo KHNpemVvZihUKikgKiBDSEFSX0JJVCkgLSBudW1iZXJPZlBBQ0JpdHMpKSAtIDE7CisgICAgICAg IHJldHVybiByZWludGVycHJldF9jYXN0PFQqPigocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+ KHVudGFnZ2VkUHRyKSAmIH5tYXNrKSB8IChyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4odW5j YWdlZFB0cikgJiBtYXNrKSk7CisgICAgfQorCiAgICAgdHlwZW5hbWUgUHRyVHJhaXRzOjpTdG9y YWdlVHlwZSBtX3B0cjsKIH07CiAK 372888 2019-06-25 18:19:58 -0700 2019-06-25 19:25:25 -0700 Patch bug-199214-20190625181957.patch text/plain 2849 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY4NzM1N2RiZjhkMTBmOTI4ODBjNjMw MWZjMDI2ZGZiMmE2NTMzNTEuLjU0NzNlOTYwMDI2NjJjYzgyOGU1Y2M1ZTkyYTg0ZjQzMzZmZGEy NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDYtMjUgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FnZWRQdHIgZG9lc24ndCBtZXJnZSBQQUMg Yml0cyBiYWNrIGludG8gdGhlIHJlc3VsdGluZyBjYWdlZCBwb2ludGVyLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MjE0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQgY29kZSBtZWFu cyB0aGF0IGNhZ2luZyB3aWxsIGp1c3Qgc3RyaXAgdGhlIGFueSBmYWlsZWQKKyAgICAgICAgYXV0 aGVudGljYXRpb24gYml0cy4gQWRkaW5nIHRoaXMgY29kZSBkb2Vzbid0IGFwcGVhciB0byBiZSBh CisgICAgICAgIHJlZ3Jlc3Npb24gb24gaVBob25lIFhzLgorCisgICAgICAgICogd3RmL0NhZ2Vk UHRyLmg6CisgICAgICAgIChXVEY6OkNhZ2VkUHRyOjpnZXQgY29uc3QpOgorICAgICAgICAoV1RG OjpDYWdlZFB0cjo6Z2V0TWF5QmVOdWxsIGNvbnN0KToKKyAgICAgICAgKFdURjo6Q2FnZWRQdHI6 OmdldFVuc2FmZSBjb25zdCk6CisgICAgICAgIChXVEY6OkNhZ2VkUHRyOjptZXJnZVBvaW50ZXJz KToKKwogMjAxOS0wNi0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgVGlkeSB1cCB0aGUgcmVtYWluaW5nIGJpdHMgb2YgdGhlIEF0b21pY1N0cmluZyB0byBBdG9t U3RyaW5nIHJlbmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ2FnZWRQdHIuaCBiL1Nv dXJjZS9XVEYvd3RmL0NhZ2VkUHRyLmgKaW5kZXggNzFlYzUxZTI5NDdiNWIyY2EwNmVhMmM0MDU2 ZGFkY2ViOTM4ZGY2ZS4uY2E0NzNjNGJhYWE5OTU1YmRlODU1NmNjZDVlYjFiOWUxMDNjYWFkYyAx MDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ2FnZWRQdHIuaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9DYWdlZFB0ci5oCkBAIC0yOSw2ICsyOSw4IEBACiAjaW5jbHVkZSA8d3RmL0dpZ2FjYWdlLmg+ CiAjaW5jbHVkZSA8d3RmL1B0clRhZy5oPgogCisjaW5jbHVkZSA8Y2xpbWl0cz4KKwogbmFtZXNw YWNlIFdURiB7CiAKIGNvbnN0ZXhwciBib29sIHRhZ0NhZ2VkUHRyID0gdHJ1ZTsKQEAgLTUyLDI0 ICs1NCwyMSBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBBU1NFUlQobV9wdHIpOwogICAgICAg ICBUKiBwdHIgPSBQdHJUcmFpdHM6OnVud3JhcChtX3B0cik7Ci0gICAgICAgIGlmIChzaG91bGRU YWcpCi0gICAgICAgICAgICBwdHIgPSB1bnRhZ0FycmF5UHRyKHB0ciwgc2l6ZSk7Ci0gICAgICAg IHJldHVybiBHaWdhY2FnZTo6Y2FnZWQoa2luZCwgcHRyKTsKKyAgICAgICAgVCogdW50YWdnZWRQ dHIgPSBzaG91bGRUYWcgPyB1bnRhZ0FycmF5UHRyKHB0ciwgc2l6ZSkgOiBwdHI7CisgICAgICAg IHJldHVybiBtZXJnZVBvaW50ZXJzKHVudGFnZ2VkUHRyLCBHaWdhY2FnZTo6Y2FnZWQoa2luZCwg cHRyKSk7CiAgICAgfQogCiAgICAgVCogZ2V0TWF5QmVOdWxsKHVuc2lnbmVkIHNpemUpIGNvbnN0 CiAgICAgewogICAgICAgICBUKiBwdHIgPSBQdHJUcmFpdHM6OnVud3JhcChtX3B0cik7Ci0gICAg ICAgIGlmIChzaG91bGRUYWcpCi0gICAgICAgICAgICBwdHIgPSB1bnRhZ0FycmF5UHRyKHB0ciwg c2l6ZSk7Ci0gICAgICAgIHJldHVybiBHaWdhY2FnZTo6Y2FnZWRNYXlCZU51bGwoa2luZCwgcHRy KTsKKyAgICAgICAgVCogdW50YWdnZWRQdHIgPSBzaG91bGRUYWcgPyB1bnRhZ0FycmF5UHRyKHB0 ciwgc2l6ZSkgOiBwdHI7CisgICAgICAgIHJldHVybiBtZXJnZVBvaW50ZXJzKHVudGFnZ2VkUHRy LCBHaWdhY2FnZTo6Y2FnZWRNYXlCZU51bGwoa2luZCwgcHRyKSk7CiAgICAgfQogCiAgICAgVCog Z2V0VW5zYWZlKCkgY29uc3QKICAgICB7CiAgICAgICAgIFQqIHB0ciA9IFB0clRyYWl0czo6dW53 cmFwKG1fcHRyKTsKLSAgICAgICAgaWYgKHNob3VsZFRhZykKLSAgICAgICAgICAgIHB0ciA9IHJl bW92ZUFycmF5UHRyVGFnKHB0cik7CisgICAgICAgIHB0ciA9IHNob3VsZFRhZyA/IHJlbW92ZUFy cmF5UHRyVGFnKHB0cikgOiBwdHI7CiAgICAgICAgIHJldHVybiBHaWdhY2FnZTo6Y2FnZWRNYXlC ZU51bGwoa2luZCwgcHRyKTsKICAgICB9CiAKQEAgLTEyNSw2ICsxMjQsMTMgQEAgcHVibGljOgog ICAgIH0KICAgICAKIHByb3RlY3RlZDoKKyAgICBzdGF0aWMgaW5saW5lIFQqIG1lcmdlUG9pbnRl cnMoY29uc3QgVCogdW50YWdnZWRQdHIsIGNvbnN0IFQqIHVuY2FnZWRQdHIpCisgICAgeworICAg ICAgICBjb25zdGV4cHIgdW5zaWduZWQgbnVtYmVyT2ZQQUNCaXRzID0gMjU7CisgICAgICAgIGNv bnN0ZXhwciB1aW50cHRyX3QgbWFzayA9ICgxdWxsIDw8ICgoc2l6ZW9mKFQqKSAqIENIQVJfQklU KSAtIG51bWJlck9mUEFDQml0cykpIC0gMTsKKyAgICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nh c3Q8VCo+KChyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4odW50YWdnZWRQdHIpICYgfm1hc2sp IHwgKHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90Pih1bmNhZ2VkUHRyKSAmIG1hc2spKTsKKyAg ICB9CisKICAgICB0eXBlbmFtZSBQdHJUcmFpdHM6OlN0b3JhZ2VUeXBlIG1fcHRyOwogfTsKIAo=