<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199195</bug_id>
          
          <creation_ts>2019-06-25 11:18:10 -0700</creation_ts>
          <short_desc>Perform less work when a pre-warmed WebProcess is suspended or resumed.</short_desc>
          <delta_ts>2019-12-17 10:14:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Per Arne Vollan">pvollan</reporter>
          <assigned_to name="Per Arne Vollan">pvollan</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dean_johnson</cc>
    
    <cc>ggaren</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1547744</commentid>
    <comment_count>0</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-25 11:18:10 -0700</bug_when>
    <thetext>This is a confirmed improvement in page load time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1547745</commentid>
    <comment_count>1</comment_count>
      <attachid>372848</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-25 11:21:34 -0700</bug_when>
    <thetext>Created attachment 372848
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1547767</commentid>
    <comment_count>2</comment_count>
      <attachid>372853</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-25 13:05:26 -0700</bug_when>
    <thetext>Created attachment 372853
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548019</commentid>
    <comment_count>3</comment_count>
      <attachid>372853</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2019-06-26 07:42:46 -0700</bug_when>
    <thetext>Comment on attachment 372853
Patch

R=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548020</commentid>
    <comment_count>4</comment_count>
      <attachid>372853</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-06-26 07:43:29 -0700</bug_when>
    <thetext>Comment on attachment 372853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372853&amp;action=review

&gt; Source/WebKit/WebProcess/WebProcess.cpp:1476
&gt; +        return;

Seems like it should do something like this before returning:
if (shouldAcknowledgeWhenReadyToSuspend == ShouldAcknowledgeWhenReadyToSuspend::Yes) {
    RELEASE_LOG(ProcessSuspension, &quot;%p - WebProcess::actualPrepareToSuspend() Sending ProcessReadyToSuspend IPC message&quot;, this);
    parentProcessConnection()-&gt;send(Messages::WebProcessProxy::ProcessReadyToSuspend(), 0);
}

&gt; Source/WebKit/WebProcess/WebProcess.cpp:1536
&gt; +    ASSERT(m_processType != ProcessType::PrewarmedWebContent);

I am not convinced this assert is correct. Why do you think it is?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548023</commentid>
    <comment_count>5</comment_count>
      <attachid>372853</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-06-26 07:45:46 -0700</bug_when>
    <thetext>Comment on attachment 372853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372853&amp;action=review

&gt; Source/WebKit/ChangeLog:8
&gt; +        Return early from WebProcess::actualPrepareToSuspend and WebProcess::processDidResume

Have you tried not doing the IPC round trip altogether?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548070</commentid>
    <comment_count>6</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-26 11:21:28 -0700</bug_when>
    <thetext>(In reply to Chris Dumez from comment #5)
&gt; Comment on attachment 372853 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=372853&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/ChangeLog:8
&gt; &gt; +        Return early from WebProcess::actualPrepareToSuspend and WebProcess::processDidResume
&gt; 
&gt; Have you tried not doing the IPC round trip altogether?

I will try that. Thanks for reviewing, everyone!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548881</commentid>
    <comment_count>7</comment_count>
      <attachid>373132</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-28 11:00:31 -0700</bug_when>
    <thetext>Created attachment 373132
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548883</commentid>
    <comment_count>8</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-28 11:03:29 -0700</bug_when>
    <thetext>(In reply to Chris Dumez from comment #5)
&gt; Comment on attachment 372853 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=372853&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/ChangeLog:8
&gt; &gt; +        Return early from WebProcess::actualPrepareToSuspend and WebProcess::processDidResume
&gt; 
&gt; Have you tried not doing the IPC round trip altogether?

I am still evaluating a patch for this, and might propose a patch later on depending on the results.

Perhaps we also could consider suspending the pre-warmed process after some timeout, instead of an immediate suspension?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548886</commentid>
    <comment_count>9</comment_count>
      <attachid>373134</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-28 11:09:51 -0700</bug_when>
    <thetext>Created attachment 373134
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548931</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-06-28 13:43:58 -0700</bug_when>
    <thetext>&lt;rdar://problem/52349969&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548990</commentid>
    <comment_count>11</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-28 16:37:58 -0700</bug_when>
    <thetext>It seems the performance benefit of not doing the IPC roundtrip is comparable to the approach in the current patch, so I think we can stick with this approach.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549026</commentid>
    <comment_count>12</comment_count>
      <attachid>373134</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2019-06-29 09:48:06 -0700</bug_when>
    <thetext>Comment on attachment 373134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373134&amp;action=review

&gt; Source/WebKit/WebProcess/WebProcess.cpp:1474
&gt; +#if PLATFORM(COCOA)

What makes this cocoa specific? Can this have a more specific conditional? #if SUPPORTS(...).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549030</commentid>
    <comment_count>13</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-29 12:53:54 -0700</bug_when>
    <thetext>(In reply to Sam Weinig from comment #12)
&gt; Comment on attachment 373134 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=373134&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/WebProcess/WebProcess.cpp:1474
&gt; &gt; +#if PLATFORM(COCOA)
&gt; 
&gt; What makes this cocoa specific? Can this have a more specific conditional?
&gt; #if SUPPORTS(...).

Currently, m_processType is only declared for cocoa platforms. Perhaps we could declare it for all platforms, and let it have the default value &apos;ProcessType::WebContent&apos; for platforms not supporting pre-warming?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549057</commentid>
    <comment_count>14</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2019-06-29 21:24:14 -0700</bug_when>
    <thetext>(In reply to Per Arne Vollan from comment #13)
&gt; (In reply to Sam Weinig from comment #12)
&gt; &gt; Comment on attachment 373134 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; https://bugs.webkit.org/attachment.cgi?id=373134&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebKit/WebProcess/WebProcess.cpp:1474
&gt; &gt; &gt; +#if PLATFORM(COCOA)
&gt; &gt; 
&gt; &gt; What makes this cocoa specific? Can this have a more specific conditional?
&gt; &gt; #if SUPPORTS(...).
&gt; 
&gt; Currently, m_processType is only declared for cocoa platforms. Perhaps we
&gt; could declare it for all platforms, and let it have the default value
&gt; &apos;ProcessType::WebContent&apos; for platforms not supporting pre-warming?

Declaring it for all platforms would be fine and/or guarding it with a more specific conditional. PLATFORM(COCOA) should only be used for conditions that are really Cocoa specific (e.g. requires NSColor).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549062</commentid>
    <comment_count>15</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-29 21:38:43 -0700</bug_when>
    <thetext>(In reply to Sam Weinig from comment #14)
&gt; (In reply to Per Arne Vollan from comment #13)
&gt; &gt; (In reply to Sam Weinig from comment #12)
&gt; &gt; &gt; Comment on attachment 373134 [details]
&gt; &gt; &gt; Patch
&gt; &gt; &gt; 
&gt; &gt; &gt; View in context:
&gt; &gt; &gt; https://bugs.webkit.org/attachment.cgi?id=373134&amp;action=review
&gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Source/WebKit/WebProcess/WebProcess.cpp:1474
&gt; &gt; &gt; &gt; +#if PLATFORM(COCOA)
&gt; &gt; &gt; 
&gt; &gt; &gt; What makes this cocoa specific? Can this have a more specific conditional?
&gt; &gt; &gt; #if SUPPORTS(...).
&gt; &gt; 
&gt; &gt; Currently, m_processType is only declared for cocoa platforms. Perhaps we
&gt; &gt; could declare it for all platforms, and let it have the default value
&gt; &gt; &apos;ProcessType::WebContent&apos; for platforms not supporting pre-warming?
&gt; 
&gt; Declaring it for all platforms would be fine and/or guarding it with a more
&gt; specific conditional. PLATFORM(COCOA) should only be used for conditions
&gt; that are really Cocoa specific (e.g. requires NSColor).

Sounds good! I will update the patch.

Thanks for reviewing!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549065</commentid>
    <comment_count>16</comment_count>
      <attachid>373186</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-06-29 21:47:13 -0700</bug_when>
    <thetext>Created attachment 373186
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549093</commentid>
    <comment_count>17</comment_count>
      <attachid>373186</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-06-30 13:14:14 -0700</bug_when>
    <thetext>Comment on attachment 373186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373186&amp;action=review

&gt; Source/WebKit/WebProcess/WebProcess.h:-552
&gt; -#if PLATFORM(COCOA)
&gt;      enum class ProcessType { Inspector, ServiceWorker, PrewarmedWebContent, CachedWebContent, WebContent };
&gt;      ProcessType m_processType { ProcessType::WebContent };
&gt; -#endif

What motivates this change? The rest of the m_processType code is inside #if PLATFORM(MAC/COCOA/IOS_FAMILY) conditionals. That includes code in WebProcess functions initializeWebProcess, setIsInProcessCache, and markIsNoLongerPrewarmed. Why the change in strategy only for this newly written code? We could have removed some of those other conditionals too if we are deciding to change our conditionals strategy.

Typically I would suggest staying with the #if PLATFORM(COCOA) or remove more of it, not leave it mixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549209</commentid>
    <comment_count>18</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-07-01 07:37:34 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #17)
&gt; Comment on attachment 373186 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=373186&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/WebProcess/WebProcess.h:-552
&gt; &gt; -#if PLATFORM(COCOA)
&gt; &gt;      enum class ProcessType { Inspector, ServiceWorker, PrewarmedWebContent, CachedWebContent, WebContent };
&gt; &gt;      ProcessType m_processType { ProcessType::WebContent };
&gt; &gt; -#endif
&gt; 
&gt; What motivates this change? The rest of the m_processType code is inside #if
&gt; PLATFORM(MAC/COCOA/IOS_FAMILY) conditionals. That includes code in
&gt; WebProcess functions initializeWebProcess, setIsInProcessCache, and
&gt; markIsNoLongerPrewarmed. Why the change in strategy only for this newly
&gt; written code? We could have removed some of those other conditionals too if
&gt; we are deciding to change our conditionals strategy.
&gt; 
&gt; Typically I would suggest staying with the #if PLATFORM(COCOA) or remove
&gt; more of it, not leave it mixed.

I will add &apos;#if PLATFORM(COCOA)&apos; back for consistency. I created https://bugs.webkit.org/show_bug.cgi?id=199362 to declare m_processType for all platforms, since I think the related code could be cross platform.

Thanks for reviewing!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549211</commentid>
    <comment_count>19</comment_count>
      <attachid>373234</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2019-07-01 07:42:12 -0700</bug_when>
    <thetext>Created attachment 373234
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549226</commentid>
    <comment_count>20</comment_count>
      <attachid>373234</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-01 08:34:22 -0700</bug_when>
    <thetext>Comment on attachment 373234
Patch

Clearing flags on attachment: 373234

Committed r247009: &lt;https://trac.webkit.org/changeset/247009&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>372848</attachid>
            <date>2019-06-25 11:21:34 -0700</date>
            <delta_ts>2019-06-25 13:05:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199195-20190625112133.patch</filename>
            <type>text/plain</type>
            <size>2035</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDY3OTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA2LTI1ICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBQZXJmb3JtIGxlc3Mgd29yayB3
aGVuIGEgcHJlLXdhcm1lZCBXZWJQcm9jZXNzIGlzIHN1c3BlbmRlZCBvciByZXN1bWVkLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTk1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5
IGZyb20gV2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCBhbmQgV2ViUHJvY2Vzczo6
cHJvY2Vzc0RpZFJlc3VtZQorICAgICAgICBpZiB0aGlzIGlzIGEgcHJlLXdhcm1lZCBwcm9jZXNz
LiBUaGlzIGlzIGEgY29uZmlybWVkIGltcHJvdmVtZW50IGluIHBhZ2UgbG9hZCB0aW1lLgorCisg
ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBy
b2Nlc3M6OmNhbmNlbFByZXBhcmVUb1N1c3BlbmQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9j
ZXNzOjpwcm9jZXNzRGlkUmVzdW1lKToKKwogMjAxOS0wNi0yNSAgWW91ZW5uIEZhYmxldCAgPHlv
dWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xvc2Ugc29ja2V0cyB3aXRoIHRvbyBoaWdoIGZp
bGUgZGVzY3JpcHRvcgpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3Mu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNw
cAkocmV2aXNpb24gMjQ2Nzk0KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nl
c3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcxLDYgKzE0NzEsOSBAQCB2b2lkIFdlYlByb2Nl
c3M6OmFjdHVhbFByZXBhcmVUb1N1c3BlbmQoCiAgICAgU2V0Rm9yU2NvcGU8Ym9vbD4gc3VzcGVu
c2lvblNjb3BlKG1faXNTdXNwZW5kaW5nLCB0cnVlKTsKICAgICBtX3Byb2Nlc3NJc1N1c3BlbmRl
ZCA9IHRydWU7CiAKKyAgICBpZiAobV9wcm9jZXNzVHlwZSA9PSBQcm9jZXNzVHlwZTo6UHJld2Fy
bWVkV2ViQ29udGVudCkKKyAgICAgICAgcmV0dXJuOworCiAjaWYgRU5BQkxFKFZJREVPKQogICAg
IHN1c3BlbmRBbGxNZWRpYUJ1ZmZlcmluZygpOwogICAgIGlmIChhdXRvKiBwbGF0Zm9ybU1lZGlh
U2Vzc2lvbk1hbmFnZXIgPSBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFn
ZXJJZkV4aXN0cygpKQpAQCAtMTUyNyw2ICsxNTMwLDggQEAgdm9pZCBXZWJQcm9jZXNzOjpjYW5j
ZWxQcmVwYXJlVG9TdXNwZW5kKAogCiAgICAgbV9wcm9jZXNzSXNTdXNwZW5kZWQgPSBmYWxzZTsK
IAorICAgIFJFTEVBU0VfQVNTRVJUKG1fcHJvY2Vzc1R5cGUgIT0gUHJvY2Vzc1R5cGU6OlByZXdh
cm1lZFdlYkNvbnRlbnQpOworCiAgICAgdW5mcmVlemVBbGxMYXllclRyZWVzKCk7CiAKICNpZiBQ
TEFURk9STShJT1NfRkFNSUxZKQpAQCAtMTYwMyw2ICsxNjA4LDkgQEAgdm9pZCBXZWJQcm9jZXNz
Ojpwcm9jZXNzRGlkUmVzdW1lKCkKIAogICAgIG1fcHJvY2Vzc0lzU3VzcGVuZGVkID0gZmFsc2U7
CiAKKyAgICBpZiAobV9wcm9jZXNzVHlwZSA9PSBQcm9jZXNzVHlwZTo6UHJld2FybWVkV2ViQ29u
dGVudCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgY2FuY2VsTWFya0FsbExheWVyc1ZvbGF0aWxl
KCk7CiAgICAgdW5mcmVlemVBbGxMYXllclRyZWVzKCk7CiAgICAgCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>372853</attachid>
            <date>2019-06-25 13:05:26 -0700</date>
            <delta_ts>2019-06-28 11:00:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199195-20190625130525.patch</filename>
            <type>text/plain</type>
            <size>2117</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDY3OTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA2LTI1ICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBQZXJmb3JtIGxlc3Mgd29yayB3
aGVuIGEgcHJlLXdhcm1lZCBXZWJQcm9jZXNzIGlzIHN1c3BlbmRlZCBvciByZXN1bWVkLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTk1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5
IGZyb20gV2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCBhbmQgV2ViUHJvY2Vzczo6
cHJvY2Vzc0RpZFJlc3VtZQorICAgICAgICBpZiB0aGlzIGlzIGEgcHJlLXdhcm1lZCBwcm9jZXNz
LiBUaGlzIGlzIGEgY29uZmlybWVkIGltcHJvdmVtZW50IGluIHBhZ2UgbG9hZCB0aW1lLgorCisg
ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBy
b2Nlc3M6OmNhbmNlbFByZXBhcmVUb1N1c3BlbmQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9j
ZXNzOjpwcm9jZXNzRGlkUmVzdW1lKToKKwogMjAxOS0wNi0yNSAgWW91ZW5uIEZhYmxldCAgPHlv
dWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xvc2Ugc29ja2V0cyB3aXRoIHRvbyBoaWdoIGZp
bGUgZGVzY3JpcHRvcgpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3Mu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNw
cAkocmV2aXNpb24gMjQ2Nzk0KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nl
c3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcxLDYgKzE0NzEsMTEgQEAgdm9pZCBXZWJQcm9j
ZXNzOjphY3R1YWxQcmVwYXJlVG9TdXNwZW5kKAogICAgIFNldEZvclNjb3BlPGJvb2w+IHN1c3Bl
bnNpb25TY29wZShtX2lzU3VzcGVuZGluZywgdHJ1ZSk7CiAgICAgbV9wcm9jZXNzSXNTdXNwZW5k
ZWQgPSB0cnVlOwogCisjaWYgUExBVEZPUk0oQ09DT0EpCisgICAgaWYgKG1fcHJvY2Vzc1R5cGUg
PT0gUHJvY2Vzc1R5cGU6OlByZXdhcm1lZFdlYkNvbnRlbnQpCisgICAgICAgIHJldHVybjsKKyNl
bmRpZgorCiAjaWYgRU5BQkxFKFZJREVPKQogICAgIHN1c3BlbmRBbGxNZWRpYUJ1ZmZlcmluZygp
OwogICAgIGlmIChhdXRvKiBwbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIgPSBQbGF0Zm9ybU1l
ZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXJJZkV4aXN0cygpKQpAQCAtMTUyNyw2ICsx
NTMyLDEwIEBAIHZvaWQgV2ViUHJvY2Vzczo6Y2FuY2VsUHJlcGFyZVRvU3VzcGVuZCgKIAogICAg
IG1fcHJvY2Vzc0lzU3VzcGVuZGVkID0gZmFsc2U7CiAKKyNpZiBQTEFURk9STShDT0NPQSkKKyAg
ICBBU1NFUlQobV9wcm9jZXNzVHlwZSAhPSBQcm9jZXNzVHlwZTo6UHJld2FybWVkV2ViQ29udGVu
dCk7CisjZW5kaWYKKwogICAgIHVuZnJlZXplQWxsTGF5ZXJUcmVlcygpOwogCiAjaWYgUExBVEZP
Uk0oSU9TX0ZBTUlMWSkKQEAgLTE2MDMsNiArMTYxMiwxMSBAQCB2b2lkIFdlYlByb2Nlc3M6OnBy
b2Nlc3NEaWRSZXN1bWUoKQogCiAgICAgbV9wcm9jZXNzSXNTdXNwZW5kZWQgPSBmYWxzZTsKIAor
I2lmIFBMQVRGT1JNKENPQ09BKQorICAgIGlmIChtX3Byb2Nlc3NUeXBlID09IFByb2Nlc3NUeXBl
OjpQcmV3YXJtZWRXZWJDb250ZW50KQorICAgICAgICByZXR1cm47CisjZW5kaWYKKwogICAgIGNh
bmNlbE1hcmtBbGxMYXllcnNWb2xhdGlsZSgpOwogICAgIHVuZnJlZXplQWxsTGF5ZXJUcmVlcygp
OwogICAgIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>373132</attachid>
            <date>2019-06-28 11:00:31 -0700</date>
            <delta_ts>2019-06-28 11:09:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199195-20190628110030.patch</filename>
            <type>text/plain</type>
            <size>2412</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDY5MjgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA2LTI4ICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBQZXJmb3JtIGxlc3Mgd29yayB3
aGVuIGEgcHJlLXdhcm1lZCBXZWJQcm9jZXNzIGlzIHN1c3BlbmRlZCBvciByZXN1bWVkLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTk1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5
IGZyb20gV2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCBhbmQgV2ViUHJvY2Vzczo6
cHJvY2Vzc0RpZFJlc3VtZQorICAgICAgICBpZiB0aGlzIGlzIGEgcHJlLXdhcm1lZCBwcm9jZXNz
LiBUaGlzIGlzIGEgY29uZmlybWVkIGltcHJvdmVtZW50IGluIHBhZ2UgbG9hZCB0aW1lLgorCisg
ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBy
b2Nlc3M6OmNhbmNlbFByZXBhcmVUb1N1c3BlbmQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9j
ZXNzOjpwcm9jZXNzRGlkUmVzdW1lKToKKwogMjAxOS0wNi0yOCAgSmVyIE5vYmxlICA8amVyLm5v
YmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbmV3IC1bV0tXZWJWaWV3IF9jbG9zZUFsbE1l
ZGlhUHJlc2VudGF0aW9uc10gU1BJCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi
UHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBy
b2Nlc3MuY3BwCShyZXZpc2lvbiAyNDY4MDkpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv
V2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NzEsNiArMTQ3MSwxNCBAQCB2b2lk
IFdlYlByb2Nlc3M6OmFjdHVhbFByZXBhcmVUb1N1c3BlbmQoCiAgICAgU2V0Rm9yU2NvcGU8Ym9v
bD4gc3VzcGVuc2lvblNjb3BlKG1faXNTdXNwZW5kaW5nLCB0cnVlKTsKICAgICBtX3Byb2Nlc3NJ
c1N1c3BlbmRlZCA9IHRydWU7CiAKKyAgICBpZiAobV9wcm9jZXNzVHlwZSA9PSBQcm9jZXNzVHlw
ZTo6UHJld2FybWVkV2ViQ29udGVudCkgeworICAgICAgICBpZiAoc2hvdWxkQWNrbm93bGVkZ2VX
aGVuUmVhZHlUb1N1c3BlbmQgPT0gU2hvdWxkQWNrbm93bGVkZ2VXaGVuUmVhZHlUb1N1c3BlbmQ6
OlllcykgeworICAgICAgICAgICAgUkVMRUFTRV9MT0coUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAt
IFdlYlByb2Nlc3M6OmFjdHVhbFByZXBhcmVUb1N1c3BlbmQoKSBTZW5kaW5nIFByb2Nlc3NSZWFk
eVRvU3VzcGVuZCBJUEMgbWVzc2FnZSIsIHRoaXMpOworICAgICAgICAgICAgcGFyZW50UHJvY2Vz
c0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViUHJvY2Vzc1Byb3h5OjpQcm9jZXNzUmVh
ZHlUb1N1c3BlbmQoKSwgMCk7CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuOworICAgIH0KKwog
I2lmIEVOQUJMRShWSURFTykKICAgICBzdXNwZW5kQWxsTWVkaWFCdWZmZXJpbmcoKTsKICAgICBp
ZiAoYXV0byogcGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyID0gUGxhdGZvcm1NZWRpYVNlc3Np
b25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VySWZFeGlzdHMoKSkKQEAgLTE1MjcsNiArMTUzNSw5IEBA
IHZvaWQgV2ViUHJvY2Vzczo6Y2FuY2VsUHJlcGFyZVRvU3VzcGVuZCgKIAogICAgIG1fcHJvY2Vz
c0lzU3VzcGVuZGVkID0gZmFsc2U7CiAKKyAgICBpZiAobV9wcm9jZXNzVHlwZSA9PSBQcm9jZXNz
VHlwZTo6UHJld2FybWVkV2ViQ29udGVudCkKKyAgICAgICAgcmV0dXJuOworICAgIAogICAgIHVu
ZnJlZXplQWxsTGF5ZXJUcmVlcygpOwogCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKQEAgLTE2
MDMsNiArMTYxNCw5IEBAIHZvaWQgV2ViUHJvY2Vzczo6cHJvY2Vzc0RpZFJlc3VtZSgpCiAKICAg
ICBtX3Byb2Nlc3NJc1N1c3BlbmRlZCA9IGZhbHNlOwogCisgICAgaWYgKG1fcHJvY2Vzc1R5cGUg
PT0gUHJvY2Vzc1R5cGU6OlByZXdhcm1lZFdlYkNvbnRlbnQpCisgICAgICAgIHJldHVybjsKKyAg
ICAKICAgICBjYW5jZWxNYXJrQWxsTGF5ZXJzVm9sYXRpbGUoKTsKICAgICB1bmZyZWV6ZUFsbExh
eWVyVHJlZXMoKTsKICAgICAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>373134</attachid>
            <date>2019-06-28 11:09:51 -0700</date>
            <delta_ts>2019-06-29 21:47:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199195-20190628110950.patch</filename>
            <type>text/plain</type>
            <size>2493</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDY5MjgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA2LTI4ICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBQZXJmb3JtIGxlc3Mgd29yayB3
aGVuIGEgcHJlLXdhcm1lZCBXZWJQcm9jZXNzIGlzIHN1c3BlbmRlZCBvciByZXN1bWVkLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTk1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5
IGZyb20gV2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCBhbmQgV2ViUHJvY2Vzczo6
cHJvY2Vzc0RpZFJlc3VtZQorICAgICAgICBpZiB0aGlzIGlzIGEgcHJlLXdhcm1lZCBwcm9jZXNz
LiBUaGlzIGlzIGEgY29uZmlybWVkIGltcHJvdmVtZW50IGluIHBhZ2UgbG9hZCB0aW1lLgorCisg
ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBy
b2Nlc3M6OmNhbmNlbFByZXBhcmVUb1N1c3BlbmQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9j
ZXNzOjpwcm9jZXNzRGlkUmVzdW1lKToKKwogMjAxOS0wNi0yOCAgSmVyIE5vYmxlICA8amVyLm5v
YmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbmV3IC1bV0tXZWJWaWV3IF9jbG9zZUFsbE1l
ZGlhUHJlc2VudGF0aW9uc10gU1BJCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi
UHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBy
b2Nlc3MuY3BwCShyZXZpc2lvbiAyNDY4MDkpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv
V2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NzEsNiArMTQ3MSwxNiBAQCB2b2lk
IFdlYlByb2Nlc3M6OmFjdHVhbFByZXBhcmVUb1N1c3BlbmQoCiAgICAgU2V0Rm9yU2NvcGU8Ym9v
bD4gc3VzcGVuc2lvblNjb3BlKG1faXNTdXNwZW5kaW5nLCB0cnVlKTsKICAgICBtX3Byb2Nlc3NJ
c1N1c3BlbmRlZCA9IHRydWU7CiAKKyNpZiBQTEFURk9STShDT0NPQSkKKyAgICBpZiAobV9wcm9j
ZXNzVHlwZSA9PSBQcm9jZXNzVHlwZTo6UHJld2FybWVkV2ViQ29udGVudCkgeworICAgICAgICBp
ZiAoc2hvdWxkQWNrbm93bGVkZ2VXaGVuUmVhZHlUb1N1c3BlbmQgPT0gU2hvdWxkQWNrbm93bGVk
Z2VXaGVuUmVhZHlUb1N1c3BlbmQ6OlllcykgeworICAgICAgICAgICAgUkVMRUFTRV9MT0coUHJv
Y2Vzc1N1c3BlbnNpb24sICIlcCAtIFdlYlByb2Nlc3M6OmFjdHVhbFByZXBhcmVUb1N1c3BlbmQo
KSBTZW5kaW5nIFByb2Nlc3NSZWFkeVRvU3VzcGVuZCBJUEMgbWVzc2FnZSIsIHRoaXMpOworICAg
ICAgICAgICAgcGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViUHJv
Y2Vzc1Byb3h5OjpQcm9jZXNzUmVhZHlUb1N1c3BlbmQoKSwgMCk7CisgICAgICAgIH0KKyAgICAg
ICAgcmV0dXJuOworICAgIH0KKyNlbmRpZgorCiAjaWYgRU5BQkxFKFZJREVPKQogICAgIHN1c3Bl
bmRBbGxNZWRpYUJ1ZmZlcmluZygpOwogICAgIGlmIChhdXRvKiBwbGF0Zm9ybU1lZGlhU2Vzc2lv
bk1hbmFnZXIgPSBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXJJZkV4
aXN0cygpKQpAQCAtMTUyNyw2ICsxNTM3LDExIEBAIHZvaWQgV2ViUHJvY2Vzczo6Y2FuY2VsUHJl
cGFyZVRvU3VzcGVuZCgKIAogICAgIG1fcHJvY2Vzc0lzU3VzcGVuZGVkID0gZmFsc2U7CiAKKyNp
ZiBQTEFURk9STShDT0NPQSkKKyAgICBpZiAobV9wcm9jZXNzVHlwZSA9PSBQcm9jZXNzVHlwZTo6
UHJld2FybWVkV2ViQ29udGVudCkKKyAgICAgICAgcmV0dXJuOworI2VuZGlmCisKICAgICB1bmZy
ZWV6ZUFsbExheWVyVHJlZXMoKTsKIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCkBAIC0xNjAz
LDYgKzE2MTgsMTEgQEAgdm9pZCBXZWJQcm9jZXNzOjpwcm9jZXNzRGlkUmVzdW1lKCkKIAogICAg
IG1fcHJvY2Vzc0lzU3VzcGVuZGVkID0gZmFsc2U7CiAKKyNpZiBQTEFURk9STShDT0NPQSkKKyAg
ICBpZiAobV9wcm9jZXNzVHlwZSA9PSBQcm9jZXNzVHlwZTo6UHJld2FybWVkV2ViQ29udGVudCkK
KyAgICAgICAgcmV0dXJuOworI2VuZGlmCisKICAgICBjYW5jZWxNYXJrQWxsTGF5ZXJzVm9sYXRp
bGUoKTsKICAgICB1bmZyZWV6ZUFsbExheWVyVHJlZXMoKTsKICAgICAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>373186</attachid>
            <date>2019-06-29 21:47:13 -0700</date>
            <delta_ts>2019-06-30 13:14:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199195-20190629214712.patch</filename>
            <type>text/plain</type>
            <size>3001</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDY5NTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA2LTI5ICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBQZXJmb3JtIGxlc3Mgd29yayB3
aGVuIGEgcHJlLXdhcm1lZCBXZWJQcm9jZXNzIGlzIHN1c3BlbmRlZCBvciByZXN1bWVkLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTk1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5
IGZyb20gV2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCBhbmQgV2ViUHJvY2Vzczo6
cHJvY2Vzc0RpZFJlc3VtZQorICAgICAgICBpZiB0aGlzIGlzIGEgcHJlLXdhcm1lZCBwcm9jZXNz
LiBUaGlzIGlzIGEgY29uZmlybWVkIGltcHJvdmVtZW50IGluIHBhZ2UgbG9hZCB0aW1lLgorCisg
ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBy
b2Nlc3M6OmNhbmNlbFByZXBhcmVUb1N1c3BlbmQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9j
ZXNzOjpwcm9jZXNzRGlkUmVzdW1lKToKKwogMjAxOS0wNi0yOCAgQnJlbnQgRnVsZ2hhbSAgPGJm
dWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpc2UgV2ViQ29udGVudCBzYW5kYm94IGJh
c2VkIG9uIHNlZWQgZmVlZGJhY2sKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ
cm9jZXNzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJv
Y2Vzcy5jcHAJKHJldmlzaW9uIDI0Njk1MikKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X
ZWJQcm9jZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ3MSw2ICsxNDcxLDE0IEBAIHZvaWQg
V2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCgKICAgICBTZXRGb3JTY29wZTxib29s
PiBzdXNwZW5zaW9uU2NvcGUobV9pc1N1c3BlbmRpbmcsIHRydWUpOwogICAgIG1fcHJvY2Vzc0lz
U3VzcGVuZGVkID0gdHJ1ZTsKIAorICAgIGlmIChtX3Byb2Nlc3NUeXBlID09IFByb2Nlc3NUeXBl
OjpQcmV3YXJtZWRXZWJDb250ZW50KSB7CisgICAgICAgIGlmIChzaG91bGRBY2tub3dsZWRnZVdo
ZW5SZWFkeVRvU3VzcGVuZCA9PSBTaG91bGRBY2tub3dsZWRnZVdoZW5SZWFkeVRvU3VzcGVuZDo6
WWVzKSB7CisgICAgICAgICAgICBSRUxFQVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0g
V2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCgpIFNlbmRpbmcgUHJvY2Vzc1JlYWR5
VG9TdXNwZW5kIElQQyBtZXNzYWdlIiwgdGhpcyk7CisgICAgICAgICAgICBwYXJlbnRQcm9jZXNz
Q29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpXZWJQcm9jZXNzUHJveHk6OlByb2Nlc3NSZWFk
eVRvU3VzcGVuZCgpLCAwKTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm47CisgICAgfQorCiAj
aWYgRU5BQkxFKFZJREVPKQogICAgIHN1c3BlbmRBbGxNZWRpYUJ1ZmZlcmluZygpOwogICAgIGlm
IChhdXRvKiBwbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIgPSBQbGF0Zm9ybU1lZGlhU2Vzc2lv
bk1hbmFnZXI6OnNoYXJlZE1hbmFnZXJJZkV4aXN0cygpKQpAQCAtMTUyNyw2ICsxNTM1LDkgQEAg
dm9pZCBXZWJQcm9jZXNzOjpjYW5jZWxQcmVwYXJlVG9TdXNwZW5kKAogCiAgICAgbV9wcm9jZXNz
SXNTdXNwZW5kZWQgPSBmYWxzZTsKIAorICAgIGlmIChtX3Byb2Nlc3NUeXBlID09IFByb2Nlc3NU
eXBlOjpQcmV3YXJtZWRXZWJDb250ZW50KQorICAgICAgICByZXR1cm47CisKICAgICB1bmZyZWV6
ZUFsbExheWVyVHJlZXMoKTsKIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCkBAIC0xNjAzLDYg
KzE2MTQsOSBAQCB2b2lkIFdlYlByb2Nlc3M6OnByb2Nlc3NEaWRSZXN1bWUoKQogCiAgICAgbV9w
cm9jZXNzSXNTdXNwZW5kZWQgPSBmYWxzZTsKIAorICAgIGlmIChtX3Byb2Nlc3NUeXBlID09IFBy
b2Nlc3NUeXBlOjpQcmV3YXJtZWRXZWJDb250ZW50KQorICAgICAgICByZXR1cm47CisKICAgICBj
YW5jZWxNYXJrQWxsTGF5ZXJzVm9sYXRpbGUoKTsKICAgICB1bmZyZWV6ZUFsbExheWVyVHJlZXMo
KTsKICAgICAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuaAkocmV2aXNp
b24gMjQ2OTUyKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuaAkod29y
a2luZyBjb3B5KQpAQCAtNTQ2LDEwICs1NDYsOCBAQCBwcml2YXRlOgogICAgIFdlYkNvcmU6OlJl
Z2lzdHJhYmxlRG9tYWluIG1fcmVnaXN0cmFibGVEb21haW47CiAjZW5kaWYKIAotI2lmIFBMQVRG
T1JNKENPQ09BKQogICAgIGVudW0gY2xhc3MgUHJvY2Vzc1R5cGUgeyBJbnNwZWN0b3IsIFNlcnZp
Y2VXb3JrZXIsIFByZXdhcm1lZFdlYkNvbnRlbnQsIENhY2hlZFdlYkNvbnRlbnQsIFdlYkNvbnRl
bnQgfTsKICAgICBQcm9jZXNzVHlwZSBtX3Byb2Nlc3NUeXBlIHsgUHJvY2Vzc1R5cGU6OldlYkNv
bnRlbnQgfTsKLSNlbmRpZgogCiAgICAgSGFzaE1hcDxXZWJDb3JlOjpVc2VyR2VzdHVyZVRva2Vu
ICosIHVpbnQ2NF90PiBtX3VzZXJHZXN0dXJlVG9rZW5zOwogCg==
</data>
<flag name="review"
          id="388951"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>373234</attachid>
            <date>2019-07-01 07:42:12 -0700</date>
            <delta_ts>2019-07-01 08:34:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199195-20190701074211.patch</filename>
            <type>text/plain</type>
            <size>2534</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDcwMDgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA2LTI5ICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBQZXJmb3JtIGxlc3Mgd29yayB3
aGVuIGEgcHJlLXdhcm1lZCBXZWJQcm9jZXNzIGlzIHN1c3BlbmRlZCBvciByZXN1bWVkLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTk1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5IGZy
b20gV2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCBhbmQgV2ViUHJvY2Vzczo6cHJv
Y2Vzc0RpZFJlc3VtZQorICAgICAgICBpZiB0aGlzIGlzIGEgcHJlLXdhcm1lZCBwcm9jZXNzLiBU
aGlzIGlzIGEgY29uZmlybWVkIGltcHJvdmVtZW50IGluIHBhZ2UgbG9hZCB0aW1lLgorCisgICAg
ICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJv
Y2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCk6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nl
c3M6OmNhbmNlbFByZXBhcmVUb1N1c3BlbmQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNz
Ojpwcm9jZXNzRGlkUmVzdW1lKToKKwogMjAxOS0wNy0wMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg
IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViU29ja2V0czogYWRkIHN1cHBvcnQg
Zm9yIHNlbmRpbmcgYmxvYiBtZXNzYWdlcyB3aGVuIHVzaW5nIHdlYiBzb2NrZXRzIHBsYXRmb3Jt
IEFQSXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHJldmlz
aW9uIDI0NzAwOCkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAko
d29ya2luZyBjb3B5KQpAQCAtMTQ3MSw2ICsxNDcxLDE2IEBAIHZvaWQgV2ViUHJvY2Vzczo6YWN0
dWFsUHJlcGFyZVRvU3VzcGVuZCgKICAgICBTZXRGb3JTY29wZTxib29sPiBzdXNwZW5zaW9uU2Nv
cGUobV9pc1N1c3BlbmRpbmcsIHRydWUpOwogICAgIG1fcHJvY2Vzc0lzU3VzcGVuZGVkID0gdHJ1
ZTsKIAorI2lmIFBMQVRGT1JNKENPQ09BKQorICAgIGlmIChtX3Byb2Nlc3NUeXBlID09IFByb2Nl
c3NUeXBlOjpQcmV3YXJtZWRXZWJDb250ZW50KSB7CisgICAgICAgIGlmIChzaG91bGRBY2tub3ds
ZWRnZVdoZW5SZWFkeVRvU3VzcGVuZCA9PSBTaG91bGRBY2tub3dsZWRnZVdoZW5SZWFkeVRvU3Vz
cGVuZDo6WWVzKSB7CisgICAgICAgICAgICBSRUxFQVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwg
IiVwIC0gV2ViUHJvY2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCgpIFNlbmRpbmcgUHJvY2Vz
c1JlYWR5VG9TdXNwZW5kIElQQyBtZXNzYWdlIiwgdGhpcyk7CisgICAgICAgICAgICBwYXJlbnRQ
cm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpXZWJQcm9jZXNzUHJveHk6OlByb2Nl
c3NSZWFkeVRvU3VzcGVuZCgpLCAwKTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm47CisgICAg
fQorI2VuZGlmCisKICNpZiBFTkFCTEUoVklERU8pCiAgICAgc3VzcGVuZEFsbE1lZGlhQnVmZmVy
aW5nKCk7CiAgICAgaWYgKGF1dG8qIHBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciA9IFBsYXRm
b3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hhcmVkTWFuYWdlcklmRXhpc3RzKCkpCkBAIC0xNTI3
LDYgKzE1MzcsMTEgQEAgdm9pZCBXZWJQcm9jZXNzOjpjYW5jZWxQcmVwYXJlVG9TdXNwZW5kKAog
CiAgICAgbV9wcm9jZXNzSXNTdXNwZW5kZWQgPSBmYWxzZTsKIAorI2lmIFBMQVRGT1JNKENPQ09B
KQorICAgIGlmIChtX3Byb2Nlc3NUeXBlID09IFByb2Nlc3NUeXBlOjpQcmV3YXJtZWRXZWJDb250
ZW50KQorICAgICAgICByZXR1cm47CisjZW5kaWYKKwogICAgIHVuZnJlZXplQWxsTGF5ZXJUcmVl
cygpOwogCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKQEAgLTE2MDMsNiArMTYxOCwxMSBAQCB2
b2lkIFdlYlByb2Nlc3M6OnByb2Nlc3NEaWRSZXN1bWUoKQogCiAgICAgbV9wcm9jZXNzSXNTdXNw
ZW5kZWQgPSBmYWxzZTsKIAorI2lmIFBMQVRGT1JNKENPQ09BKQorICAgIGlmIChtX3Byb2Nlc3NU
eXBlID09IFByb2Nlc3NUeXBlOjpQcmV3YXJtZWRXZWJDb250ZW50KQorICAgICAgICByZXR1cm47
CisjZW5kaWYKKwogICAgIGNhbmNlbE1hcmtBbGxMYXllcnNWb2xhdGlsZSgpOwogICAgIHVuZnJl
ZXplQWxsTGF5ZXJUcmVlcygpOwogICAgIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>