199178 2019-06-24 16:55:58 -0700 [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build 2019-06-25 09:18:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1547590 0 aakash_jain 2019-06-24 16:55:58 -0700 UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build. We would need to retry layout-tests in EWS. However the file name for the uploaded test results is same if there are multiple layout-tests executions. The file name includes the builder-name, patch_id and build-number, all of which are same for multiple layout-test runs in a same build. We should add an optional identifier which can be passed to these classes in order to avoid clobbering the results. 1547592 1 372810 aakash_jain 2019-06-24 16:59:03 -0700 Created attachment 372810 Patch 1547593 2 aakash_jain 2019-06-24 16:59:46 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/35/builds/11 1547595 3 ews-watchlist 2019-06-24 17:02:38 -0700 Attachment 372810 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:1104: [ExtractTestResults.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1491: [TestUploadTestResults.test_success_with_identifier] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1491: [TestUploadTestResults.test_success_with_identifier] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1535: [TestExtractTestResults.test_success_with_identifier] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1535: [TestExtractTestResults.test_success_with_identifier] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1547702 4 372810 commit-queue 2019-06-25 09:17:49 -0700 Comment on attachment 372810 Patch Clearing flags on attachment: 372810 Committed r246793: <https://trac.webkit.org/changeset/246793> 1547703 5 commit-queue 2019-06-25 09:17:50 -0700 All reviewed patches have been landed. Closing bug. 1547704 6 webkit-bug-importer 2019-06-25 09:18:18 -0700 <rdar://problem/52116313> 372810 2019-06-24 16:59:03 -0700 2019-06-25 09:17:49 -0700 Patch bug-199178-20190624195902.patch text/plain 6409 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Njc3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTA2LTI0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVcGxvYWRUZXN0UmVzdWx0cyBhbmQgRXh0cmFjdFRl c3RSZXN1bHRzIGNsb2JiZXIgcmVzdWx0cyBpbiBjYXNlIG9mIG11bHRpcGxlIGxheW91dCB0ZXN0 IHJ1bnMgaW4gYSBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk5MTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAg IChVcGxvYWRUZXN0UmVzdWx0cy5fX2luaXRfXyk6IEFkZCBhbiBvcHRpb25hbCBpZGVudGlmaWVy IGFuZCBhcHBlbmQgdGhlIGlkZW50aWZpZXIgdG8gdGhlIGZpbGUgbmFtZS4KKyAgICAgICAgKEV4 dHJhY3RUZXN0UmVzdWx0cy5fX2luaXRfXyk6IERpdHRvLgorICAgICAgICAqIEJ1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weTogQWRkZWQgdW5pdCB0ZXN0cy4KKwog MjAxOS0wNi0yNCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAK ICAgICAgICAgY29udHJpYnV0b3JzLmpzb24gbm90IGNhbm9uaWNhbGl6ZWQgc2luY2UgcjI0MzI5 NwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2 aXNpb24gMjQ2NzY5KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMDgyLDEyICsxMDgyLDEzIEBAIGNsYXNzIFVwbG9hZFRl c3RSZXN1bHRzKHRyYW5zZmVyLkZpbGVVcGwKICAgICBuYW1lID0gJ3VwbG9hZC10ZXN0LXJlc3Vs dHMnCiAgICAgZGVzY3JpcHRpb25Eb25lID0gWydVcGxvYWRlZCB0ZXN0IHJlc3VsdHMnXQogICAg IHdvcmtlcnNyYyA9ICdsYXlvdXQtdGVzdC1yZXN1bHRzLnppcCcKLSAgICBtYXN0ZXJkZXN0ID0g SW50ZXJwb2xhdGUoJ3B1YmxpY19odG1sL3Jlc3VsdHMvJShwcm9wOmJ1aWxkZXJuYW1lKXMvciUo cHJvcDpwYXRjaF9pZClzLSUocHJvcDpidWlsZG51bWJlcilzLnppcCcpCiAgICAgaGFsdE9uRmFp bHVyZSA9IFRydWUKIAotICAgIGRlZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJncyk6CisgICAgZGVm IF9faW5pdF9fKHNlbGYsIGlkZW50aWZpZXI9JycsICoqa3dhcmdzKToKKyAgICAgICAgaWYgaWRl bnRpZmllciBhbmQgbm90IGlkZW50aWZpZXIuc3RhcnRzd2l0aCgnLScpOgorICAgICAgICAgICAg aWRlbnRpZmllciA9ICcte30nLmZvcm1hdChpZGVudGlmaWVyKQogICAgICAgICBrd2FyZ3NbJ3dv cmtlcnNyYyddID0gc2VsZi53b3JrZXJzcmMKLSAgICAgICAga3dhcmdzWydtYXN0ZXJkZXN0J10g PSBzZWxmLm1hc3RlcmRlc3QKKyAgICAgICAga3dhcmdzWydtYXN0ZXJkZXN0J10gPSBJbnRlcnBv bGF0ZSgncHVibGljX2h0bWwvcmVzdWx0cy8lKHByb3A6YnVpbGRlcm5hbWUpcy9yJShwcm9wOnBh dGNoX2lkKXMtJShwcm9wOmJ1aWxkbnVtYmVyKXN7fS56aXAnLmZvcm1hdChpZGVudGlmaWVyKSkK ICAgICAgICAga3dhcmdzWydtb2RlJ10gPSAwNjQ0CiAgICAgICAgIGt3YXJnc1snYmxvY2tzaXpl J10gPSAxMDI0ICogMjU2CiAgICAgICAgIHRyYW5zZmVyLkZpbGVVcGxvYWQuX19pbml0X18oc2Vs ZiwgKiprd2FyZ3MpCkBAIC0xMDk1LDE0ICsxMDk2LDE5IEBAIGNsYXNzIFVwbG9hZFRlc3RSZXN1 bHRzKHRyYW5zZmVyLkZpbGVVcGwKIAogY2xhc3MgRXh0cmFjdFRlc3RSZXN1bHRzKG1hc3Rlci5N YXN0ZXJTaGVsbENvbW1hbmQpOgogICAgIG5hbWUgPSAnZXh0cmFjdC10ZXN0LXJlc3VsdHMnCi0g ICAgemlwRmlsZSA9IEludGVycG9sYXRlKCdwdWJsaWNfaHRtbC9yZXN1bHRzLyUocHJvcDpidWls ZGVybmFtZSlzL3IlKHByb3A6cGF0Y2hfaWQpcy0lKHByb3A6YnVpbGRudW1iZXIpcy56aXAnKQot ICAgIHJlc3VsdERpcmVjdG9yeSA9IEludGVycG9sYXRlKCdwdWJsaWNfaHRtbC9yZXN1bHRzLyUo cHJvcDpidWlsZGVybmFtZSlzL3IlKHByb3A6cGF0Y2hfaWQpcy0lKHByb3A6YnVpbGRudW1iZXIp cycpCi0KICAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ0V4dHJhY3RlZCB0ZXN0IHJlc3VsdHMnXQot ICAgIGNvbW1hbmQgPSBbJ3VuemlwJywgemlwRmlsZSwgJy1kJywgcmVzdWx0RGlyZWN0b3J5XQog ICAgIHJlbmRlcmFibGVzID0gWydyZXN1bHREaXJlY3RvcnknLCAnemlwRmlsZSddCisgICAgaGFs dE9uRmFpbHVyZSA9IEZhbHNlCisgICAgZmx1bmtPbkZhaWx1cmUgPSBGYWxzZQorCisgICAgZGVm IF9faW5pdF9fKHNlbGYsIGlkZW50aWZpZXI9JycpOgorICAgICAgICBpZiBpZGVudGlmaWVyIGFu ZCBub3QgaWRlbnRpZmllci5zdGFydHN3aXRoKCctJyk6CisgICAgICAgICAgICBpZGVudGlmaWVy ID0gJy17fScuZm9ybWF0KGlkZW50aWZpZXIpCisKKyAgICAgICAgc2VsZi56aXBGaWxlID0gSW50 ZXJwb2xhdGUoJ3B1YmxpY19odG1sL3Jlc3VsdHMvJShwcm9wOmJ1aWxkZXJuYW1lKXMvciUocHJv cDpwYXRjaF9pZClzLSUocHJvcDpidWlsZG51bWJlcilze30uemlwJy5mb3JtYXQoaWRlbnRpZmll cikpCisgICAgICAgIHNlbGYucmVzdWx0RGlyZWN0b3J5ID0gSW50ZXJwb2xhdGUoJ3B1YmxpY19o dG1sL3Jlc3VsdHMvJShwcm9wOmJ1aWxkZXJuYW1lKXMvciUocHJvcDpwYXRjaF9pZClzLSUocHJv cDpidWlsZG51bWJlcilze30nLmZvcm1hdChpZGVudGlmaWVyKSkKKyAgICAgICAgc2VsZi5jb21t YW5kID0gWyd1bnppcCcsIHNlbGYuemlwRmlsZSwgJy1kJywgc2VsZi5yZXN1bHREaXJlY3Rvcnld CiAKLSAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIHN1cGVyKEV4dHJhY3RUZXN0UmVz dWx0cywgc2VsZikuX19pbml0X18oc2VsZi5jb21tYW5kKQogCiAgICAgZGVmIHJlc3VsdERpcmVj dG9yeVVSTChzZWxmKToKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI0Njc2OSkKKysrIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5 KQpAQCAtMTQ2OSw2ICsxNDY5LDI4IEBAIGNsYXNzIFRlc3RVcGxvYWRUZXN0UmVzdWx0cyhCdWls ZFN0ZXBNaXgKICAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0 ZV9zdHJpbmc9J1VwbG9hZGVkIHRlc3QgcmVzdWx0cycpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1 blN0ZXAoKQogCisgICAgZGVmIHRlc3Rfc3VjY2Vzc193aXRoX2lkZW50aWZpZXIoc2VsZik6Cisg ICAgICAgIHNlbGYuc2V0dXBTdGVwKFVwbG9hZFRlc3RSZXN1bHRzKGlkZW50aWZpZXI9J2NsZWFu LXRyZWUnKSkKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicsICdyZWxl YXNlJykKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYXJjaGl0ZWN0dXJlJywgJ3g4Nl82NCcp CisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJzI3MTIxMScpCisgICAgICAg IHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJ2lPUy0xMi1TaW11bGF0b3ItV0syLVRl c3RzLUVXUycpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkbnVtYmVyJywgJzEyMCcp CisgICAgICAgIHNlbGYuZXhwZWN0SGlkZGVuKEZhbHNlKQorICAgICAgICBzZWxmLmV4cGVjdFJl bW90ZUNvbW1hbmRzKAorICAgICAgICAgICAgRXhwZWN0KCd1cGxvYWRGaWxlJywgZGljdCgKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3b3JrZXJzcmM9J2xheW91dC10 ZXN0LXJlc3VsdHMuemlwJywgd29ya2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGJsb2Nrc2l6ZT0xMDI0ICogMjU2LCBtYXhzaXplPU5vbmUsIGtl ZXBzdGFtcD1GYWxzZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3 cml0ZXI9RXhwZWN0UmVtb3RlUmVmKHJlbW90ZXRyYW5zZmVyLkZpbGVXcml0ZXIpLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICkpCisgICAgICAgICAgICArIEV4cGVjdC5i ZWhhdmlvcih1cGxvYWRGaWxlV2l0aENvbnRlbnRzT2ZTdHJpbmcoJ0R1bW15IHppcCBmaWxlIGNv bnRlbnQuJykpCisgICAgICAgICAgICArIDAsCisgICAgICAgICkKKyAgICAgICAgc2VsZi5leHBl Y3RVcGxvYWRlZEZpbGUoJ3B1YmxpY19odG1sL3Jlc3VsdHMvaU9TLTEyLVNpbXVsYXRvci1XSzIt VGVzdHMtRVdTL3IyNzEyMTEtMTIwLWNsZWFuLXRyZWUuemlwJykKKworICAgICAgICBzZWxmLmV4 cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nVXBsb2FkZWQgdGVzdCBy ZXN1bHRzJykKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKIAogY2xhc3MgVGVzdEV4 dHJhY3RUZXN0UmVzdWx0cyhCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENh c2UpOgogICAgIGRlZiBzZXRVcChzZWxmKToKQEAgLTE0OTYsNiArMTUxOCwyNCBAQCBjbGFzcyBU ZXN0RXh0cmFjdFRlc3RSZXN1bHRzKEJ1aWxkU3RlcE1pCiAgICAgICAgIHNlbGYuZXhwZWN0QWRk ZWRVUkxzKFtjYWxsKCd2aWV3IGxheW91dCB0ZXN0IHJlc3VsdHMnLCAnL3Jlc3VsdHMvdGVzdC9y MjQ2OF9hYjFhMjhiNGZlZWUwZDQyOTczYzdjMDUzMzViMzViY2E5MjdlOTc0ICgxKS9yZXN1bHRz Lmh0bWwnKV0pCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCisgICAgZGVmIHRlc3Rf c3VjY2Vzc193aXRoX2lkZW50aWZpZXIoc2VsZik6CisgICAgICAgIHNlbGYuc2V0dXBTdGVwKEV4 dHJhY3RUZXN0UmVzdWx0cyhpZGVudGlmaWVyPSdyZXJ1bicpKQorICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQorICAgICAgICBzZWxmLnNldFByb3Bl cnR5KCdwYXRjaF9pZCcsICcxMjM0JykKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRl cm5hbWUnLCAnaU9TLTEyLVNpbXVsYXRvci1XSzItVGVzdHMtRVdTJykKKyAgICAgICAgc2VsZi5z ZXRQcm9wZXJ0eSgnYnVpbGRudW1iZXInLCAnMTInKQorICAgICAgICBzZWxmLmV4cGVjdExvY2Fs Q29tbWFuZHMoCisgICAgICAgICAgICBFeHBlY3RNYXN0ZXJTaGVsbENvbW1hbmQoY29tbWFuZD1b J3VuemlwJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAn cHVibGljX2h0bWwvcmVzdWx0cy9pT1MtMTItU2ltdWxhdG9yLVdLMi1UZXN0cy1FV1MvcjEyMzQt MTItcmVydW4uemlwJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnLWQnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICdwdWJsaWNfaHRtbC9yZXN1bHRzL2lPUy0xMi1TaW11bGF0b3ItV0syLVRlc3RzLUVXUy9yMTIz NC0xMi1yZXJ1bicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBdKQorICAgICAgICAgICAgKyAwLAorICAgICAgICApCisgICAgICAgIHNlbGYuZXhwZWN0T3V0 Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdFeHRyYWN0ZWQgdGVzdCByZXN1bHRz JykKKyAgICAgICAgc2VsZi5leHBlY3RBZGRlZFVSTHMoW2NhbGwoJ3ZpZXcgbGF5b3V0IHRlc3Qg cmVzdWx0cycsICcvcmVzdWx0cy90ZXN0L3IyNDY4X2FiMWEyOGI0ZmVlZTBkNDI5NzNjN2MwNTMz NWIzNWJjYTkyN2U5NzQgKDEpL3Jlc3VsdHMuaHRtbCcpXSkKKyAgICAgICAgcmV0dXJuIHNlbGYu cnVuU3RlcCgpCisKICAgICBkZWYgdGVzdF9mYWlsdXJlKHNlbGYpOgogICAgICAgICBzZWxmLnNl dHVwU3RlcChFeHRyYWN0VGVzdFJlc3VsdHMoKSkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgn Y29uZmlndXJhdGlvbicsICdkZWJ1ZycpCg==