199173 2019-06-24 13:26:23 -0700 Pages using Google's anti-flicker optimization may take ~5 seconds to do initial paint 2019-07-11 02:07:26 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 199704 1 cdumez cdumez achristensen commit-queue ggaren mcatanzaro rniwa saam webkit-bug-importer zalan oldest_to_newest 1547514 0 cdumez 2019-06-24 13:26:23 -0700 Pages using Google's anti-flicker optimization [1] take ~5 seconds to do initial paint when analytics.js load is blocked by a content blocker. [1] https://developers.google.com/optimize/ 1547515 1 cdumez 2019-06-24 13:26:39 -0700 <rdar://problem/45968770> 1547519 2 372794 cdumez 2019-06-24 13:31:00 -0700 Created attachment 372794 Patch 1547551 3 372794 ggaren 2019-06-24 14:48:32 -0700 Comment on attachment 372794 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372794&action=review r=me > Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:240 > + if (currentDocument->settings().googleAntiFlickerOptimizationQuirkEnabled() && url == "https://www.google-analytics.com/analytics.js"_str) { Should we also check site-specific quirks enabled here? Would be nice to enable a developer to test a fix in this area with our quirk turned off. 1547553 4 cdumez 2019-06-24 14:49:37 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 372794 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372794&action=review > > r=me > > > Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:240 > > + if (currentDocument->settings().googleAntiFlickerOptimizationQuirkEnabled() && url == "https://www.google-analytics.com/analytics.js"_str) { > > Should we also check site-specific quirks enabled here? Would be nice to > enable a developer to test a fix in this area with our quirk turned off. Did we fix the fact that site-specific quirks are enabled on macOS or iOS (do not remember which one of the 2). This applies to both platforms, which is why I did not do that. 1547554 5 cdumez 2019-06-24 14:50:01 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 372794 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372794&action=review > > r=me > > > Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:240 > > + if (currentDocument->settings().googleAntiFlickerOptimizationQuirkEnabled() && url == "https://www.google-analytics.com/analytics.js"_str) { > > Should we also check site-specific quirks enabled here? Would be nice to > enable a developer to test a fix in this area with our quirk turned off. They can test that using the experimental feature flag. 1547555 6 ggaren 2019-06-24 14:51:24 -0700 > Did we fix the fact that site-specific quirks are enabled on macOS or iOS > (do not remember which one of the 2). This applies to both platforms, which > is why I did not do that. I *think* we did, but I didn't confirm. Anyway, you're right that the experimental feature flag is enough. 1547563 7 372794 commit-queue 2019-06-24 15:22:48 -0700 Comment on attachment 372794 Patch Clearing flags on attachment: 372794 Committed r246764: <https://trac.webkit.org/changeset/246764> 1547564 8 commit-queue 2019-06-24 15:22:50 -0700 All reviewed patches have been landed. Closing bug. 1550565 9 mcatanzaro 2019-07-05 16:32:49 -0700 I guess you wanted it inside the results.summary.blockedLoad condition: [2134/3055] Building CXX object Source/WebCore/CMakeFiles...es/WebCore/unified-sources/UnifiedSource-5037b3e8-2.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-5037b3e8-2.cpp:2: ../../Source/WebCore/contentextensions/ContentExtensionsBackend.cpp: In member function ‘WebCore::ContentRuleListResults WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad(const WTF::URL&, WTF::OptionSet<WebCore::ContentExtensions::ResourceType>, WebCore::DocumentLoader&)’: ../../Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:235:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 235 | if (results.summary.blockedLoad) | ^~ ../../Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:240:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 240 | if (currentDocument->settings().googleAntiFlickerOptimizationQuirkEnabled() && url == "https://www.google-analytics.com/analytics.js"_str) { | ^~ 1550567 10 mcatanzaro 2019-07-05 16:35:58 -0700 Committed r247186: <https://trac.webkit.org/changeset/247186> 372794 2019-06-24 13:31:00 -0700 2019-06-24 15:22:48 -0700 Patch bug-199173-20190624133059.patch text/plain 5753 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQ0NGY4ZTM5OTVlMTYy MjlmYjM2MTJmNzQzZmJlMjkxMjk3NjViMS4uOWM5NmU0MjQ1ZDE1ODQwOWVhNDBmMGJmNTM2YzJh NzEzNzNmZTgxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA2LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUGFnZXMgdXNpbmcgR29vZ2xl J3MgYW50aS1mbGlja2VyIG9wdGltaXphdGlvbiBtYXkgdGFrZSB+NSBzZWNvbmRzIHRvIGRvIGlu aXRpYWwgcGFpbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5OTE3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDU5Njg3NzA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFnZXMgdXNpbmcgR29vZ2xl J3MgYW50aS1mbGlja2VyIG9wdGltaXphdGlvbiBbMV0gdGFrZSB+NSBzZWNvbmRzIHRvIGRvIGlu aXRpYWwgcGFpbnQgd2hlbgorICAgICAgICBhbmFseXRpY3MuanMgbG9hZCBpcyBibG9ja2VkIGJ5 IGEgY29udGVudCBibG9ja2VyLgorCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCB0aGlz IHBhdGNoIGludHJvZHVjZXMgYSBxdWlyayBiZWhpbmQgYW4gZXhwZXJpbWVudGFsIGZlYXR1cmUg ZmxhZyB0aGF0CisgICAgICAgIGNhbGxzIHdpbmRvdy5kYXRhTGF5ZXIuaGlkZS5lbmQoKSBvbiB0 aGUgcGFnZSB3aGVuIHRoZSBsb2FkIG9mIGh0dHBzOi8vd3d3Lmdvb2dsZS1hbmFseXRpY3MuY29t L2FuYWx5dGljcy5qcworICAgICAgICBpcyBibG9ja2VkIGJ5IGEgY29udGVudCBibG9ja2VyLiBO b3RlIHRoYXQgdGhpcyBpcyBtb3JlIHJvYnVzdCB0aGFuIGRyb3BwaW5nIHRoZSAnYXN5bmMtaGlk ZScKKyAgICAgICAgY2xhc3MgZnJvbSBkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQgc2luY2UgdGhl IGNsYXNzIG5hbWUgaXMgY3VzdG9taXphYmxlIGJ5IHRoZSBjYWxsZXIuCisgICAgICAgIEEgbWVz c2FnZSBpcyBsb2dnZWQgaW4gdGhlIGNvbnNvbGUgd2hlbiB0aGUgcXVpcmsgY2F1c2VzIHdpbmRv dy5kYXRhTGF5ZXIuaGlkZS5lbmQoKSB0byBnZXQgY2FsbGVkCisgICAgICAgIGVhcmx5LgorCisg ICAgICAgIFsxXSBodHRwczovL2RldmVsb3BlcnMuZ29vZ2xlLmNvbS9vcHRpbWl6ZS8KKworICAg ICAgICAqIGNvbnRlbnRleHRlbnNpb25zL0NvbnRlbnRFeHRlbnNpb25zQmFja2VuZC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDb250ZW50RXh0ZW5zaW9uczo6Q29udGVudEV4dGVuc2lvbnNCYWNr ZW5kOjpwcm9jZXNzQ29udGVudFJ1bGVMaXN0c0ZvckxvYWQpOgorICAgICAgICAqIHBhZ2UvU2V0 dGluZ3MueWFtbDoKKwogMjAxOS0wNi0yNCAgR3JlZyBEb29saXR0bGUgIDxncjNnQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBWEk6IEF1ZGl0OiBpbWFnZSBsYWJlbCB0ZXN0 IGlzIHRocm93aW5nIHNwdXJpb3VzIGVycm9ycyBvbiBlbGVtZW50cyB3aXRoIGV4aXN0aW5nIGFs dCBhdHRyLCBidXQgbm8gdmFsdWU6IDxpbWcgYWx0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCBjZWVmMjlkYjdlZWE0 MTE3ZTBmNjQ1Mjk0NDIxMGM2NWMzYzVmN2U1Li5mNjdkM2U4NTE0NTRiZTY2M2U2YWIyOGRhYmYw OWQwZDI3OTZjZmIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA2LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUGFnZXMgdXNpbmcgR29vZ2xl J3MgYW50aS1mbGlja2VyIG9wdGltaXphdGlvbiBtYXkgdGFrZSB+NSBzZWNvbmRzIHRvIGRvIGlu aXRpYWwgcGFpbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5OTE3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDU5Njg3NzA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGV4cGVyaW1lbnRhbCBm ZWF0dXJlIGZvciB0aGUgcXVpcmsuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMu eWFtbDoKKwogMjAxOS0wNi0yNCAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtXUEVdW0dUS10gRml4ZXMgZm9yIGNvbXBpbGF0aW9uIHdpdGgg dW5pZmllZCBidWlsZHMgZGlzYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2NvbnRl bnRleHRlbnNpb25zL0NvbnRlbnRFeHRlbnNpb25zQmFja2VuZC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9jb250ZW50ZXh0ZW5zaW9ucy9Db250ZW50RXh0ZW5zaW9uc0JhY2tlbmQuY3BwCmluZGV4IGE3 OThiNWY3MWIzMzRhNmI3OWYxYjI4YTZhNmY2NjJiNjQxMmVjNDAuLmQ0ZDNmMzQ1MzI4YzIxZDJi Y2JhNWE3MTExMjkyNDczODNmMjk3ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2NvbnRl bnRleHRlbnNpb25zL0NvbnRlbnRFeHRlbnNpb25zQmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY29udGVudGV4dGVuc2lvbnMvQ29udGVudEV4dGVuc2lvbnNCYWNrZW5kLmNwcApAQCAt NDMsNiArNDMsOSBAQAogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50LmgiCiAjaW5jbHVkZSAi UGFnZS5oIgogI2luY2x1ZGUgIlJlc291cmNlTG9hZEluZm8uaCIKKyNpbmNsdWRlICJTY3JpcHRD b250cm9sbGVyLmgiCisjaW5jbHVkZSAiU2NyaXB0U291cmNlQ29kZS5oIgorI2luY2x1ZGUgIlNl dHRpbmdzLmgiCiAjaW5jbHVkZSA8d3RmL1VSTC5oPgogI2luY2x1ZGUgIlVzZXJDb250ZW50Q29u dHJvbGxlci5oIgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgpAQCAtMjMxLDYgKzIz NCwxMyBAQCBDb250ZW50UnVsZUxpc3RSZXN1bHRzIENvbnRlbnRFeHRlbnNpb25zQmFja2VuZDo6 cHJvY2Vzc0NvbnRlbnRSdWxlTGlzdHNGb3JMb2FkKAogICAgICAgICB9CiAgICAgICAgIGlmIChy ZXN1bHRzLnN1bW1hcnkuYmxvY2tlZExvYWQpCiAgICAgICAgICAgICBjdXJyZW50RG9jdW1lbnQt PmFkZENvbnNvbGVNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6OkNvbnRlbnRCbG9ja2VyLCBNZXNzYWdl TGV2ZWw6OkluZm8sIG1ha2VTdHJpbmcoIkNvbnRlbnQgYmxvY2tlciBwcmV2ZW50ZWQgZnJhbWUg ZGlzcGxheWluZyAiLCBtYWluRG9jdW1lbnRVUkwuc3RyaW5nKCksICIgZnJvbSBsb2FkaW5nIGEg cmVzb3VyY2UgZnJvbSAiLCB1cmwuc3RyaW5nKCkpKTsKKyAgICAgICAgCisgICAgICAgICAgICAv LyBRdWlyayBmb3IgY29udGVudC1ibG9ja2VyIGludGVyZmVyZW5jZSB3aXRoIEdvb2dsZSdzIGFu dGktZmxpY2tlciBvcHRpbWl6YXRpb24gKHJkYXI6Ly9wcm9ibGVtLzQ1OTY4NzcwKS4KKyAgICAg ICAgICAgIC8vIGh0dHBzOi8vZGV2ZWxvcGVycy5nb29nbGUuY29tL29wdGltaXplLworICAgICAg ICAgICAgaWYgKGN1cnJlbnREb2N1bWVudC0+c2V0dGluZ3MoKS5nb29nbGVBbnRpRmxpY2tlck9w dGltaXphdGlvblF1aXJrRW5hYmxlZCgpICYmIHVybCA9PSAiaHR0cHM6Ly93d3cuZ29vZ2xlLWFu YWx5dGljcy5jb20vYW5hbHl0aWNzLmpzIl9zdHIpIHsKKyAgICAgICAgICAgICAgICBpZiAoYXV0 byogZnJhbWUgPSBjdXJyZW50RG9jdW1lbnQtPmZyYW1lKCkpCisgICAgICAgICAgICAgICAgICAg IGZyYW1lLT5zY3JpcHQoKS5ldmFsdWF0ZShTY3JpcHRTb3VyY2VDb2RlIHsgInRyeSB7IHdpbmRv dy5kYXRhTGF5ZXIuaGlkZS5lbmQoKTsgY29uc29sZS5sb2coJ0NhbGxlZCB3aW5kb3cuZGF0YUxh eWVyLmhpZGUuZW5kKCkgaW4gZnJhbWUgJyArIGRvY3VtZW50LlVSTCArICcgYmVjYXVzZSB0aGUg Y29udGVudCBibG9ja2VyIGJsb2NrZWQgdGhlIGxvYWQgb2YgdGhlIGh0dHBzOi8vd3d3Lmdvb2ds ZS1hbmFseXRpY3MuY29tL2FuYWx5dGljcy5qcyBzY3JpcHQnKTsgfSBjYXRjaCAoZSkgeyB9Il9z IH0pOworICAgICAgICAgICAgfQogICAgIH0KIAogICAgIHJldHVybiByZXN1bHRzOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy55YW1sIGIvU291cmNlL1dlYkNvcmUv cGFnZS9TZXR0aW5ncy55YW1sCmluZGV4IDIwMzQ1YTMyZDU5NjYyY2JjMTZjNDk3Nzk4YTFhOTQ1 NmJkMWYxOGYuLmNiYzczYTExMGZiZDU2NDkxYzNhY2ZjNDc4MmEwZTIwMmEzN2JmYzYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MueWFtbAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1NldHRpbmdzLnlhbWwKQEAgLTE1Myw2ICsxNTMsOSBAQCByZXNvdXJjZVVzYWdl T3ZlcmxheVZpc2libGU6CiBkaXNhYmxlU2NyZWVuU2l6ZU92ZXJyaWRlOgogICBpbml0aWFsOiBm YWxzZQogCitnb29nbGVBbnRpRmxpY2tlck9wdGltaXphdGlvblF1aXJrRW5hYmxlZDoKKyAgaW5p dGlhbDogdHJ1ZQorCiAjIFRoaXMgaXMgYSBxdWlyayB3ZSBhcmUgcHJvLWFjdGl2ZWx5IGFwcGx5 aW5nIHRvIG9sZCBhcHBsaWNhdGlvbnMuIEl0IGNoYW5nZXMga2V5Ym9hcmQgZXZlbnQgZGlzcGF0 Y2hpbmcsCiAjIG1ha2luZyBrZXlJZGVudGlmaWVyIGF2YWlsYWJsZSBvbiBrZXlwcmVzcyBldmVu dHMsIG1ha2luZyBjaGFyQ29kZSBhdmFpbGFibGUgb24ga2V5ZG93bi9rZXl1cCBldmVudHMsCiAj IGFuZCBnZXR0aW5nIGtleXByZXNzIGRpc3BhdGNoZWQgaW4gbW9yZSBjYXNlcy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2UvV2Vi S2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCmluZGV4IGI5NDY1OGIxMDYzNTU2YjJiMDIz NWQwNjBiYTEyZGQzMTEyM2Q3ODAuLjg1MGU3YTJhNDE5OTM0ZmE4MzMwMmQzOGMzYmFmOGRiZGMw MGQzYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlh bWwKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApAQCAtNTUs NiArNTUsMTMgQEAgVGhpcmRQYXJ0eUlmcmFtZVJlZGlyZWN0QmxvY2tpbmdFbmFibGVkOgogICAg aHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiQmxvY2sgdG9wLWxldmVsIHJlZGlyZWN0cyBieSB0 aGlyZC1wYXJ0eSBpZnJhbWVzIgogICAgY2F0ZWdvcnk6IGV4cGVyaW1lbnRhbAogCitHb29nbGVB bnRpRmxpY2tlck9wdGltaXphdGlvblF1aXJrRW5hYmxlZDoKKyAgIHR5cGU6IGJvb2wKKyAgIGRl ZmF1bHRWYWx1ZTogdHJ1ZQorICAgaHVtYW5SZWFkYWJsZU5hbWU6ICJRdWlyayB0byBwcmV2ZW50 IGRlbGF5ZWQgaW5pdGlhbCBwYWludGluZyBvbiBzaXRlcyB1c2luZyBHb29nbGUncyBBbnRpLUZs aWNrZXIgb3B0aW1pemF0aW9uIgorICAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiUXVpcmsg dG8gcHJldmVudCBkZWxheWVkIGluaXRpYWwgcGFpbnRpbmcgb24gc2l0ZXMgdXNpbmcgR29vZ2xl J3MgQW50aS1GbGlja2VyIG9wdGltaXphdGlvbiIKKyAgIGNhdGVnb3J5OiBleHBlcmltZW50YWwK KwogSmF2YUVuYWJsZWQ6CiAgIHR5cGU6IGJvb2wKICAgZGVmYXVsdFZhbHVlOiBmYWxzZQo=