199157 2019-06-24 07:36:55 -0700 [LFC][IFC] Inline runs should be relative to the line's top/left initially 2019-07-05 07:24:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1547340 0 zalan 2019-06-24 07:36:55 -0700 so that when the line is moved (floats etc) the individual runs don't need to be moved too. 1547341 1 webkit-bug-importer 2019-06-24 07:37:39 -0700 <rdar://problem/52053415> 1547358 2 372761 zalan 2019-06-24 08:05:43 -0700 Created attachment 372761 Patch 1550344 3 372761 koivisto 2019-07-05 06:26:48 -0700 Comment on attachment 372761 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372761&action=review > Source/WebCore/layout/inlineformatting/InlineLine.cpp:139 > + // Convert runs from relative to the line top/left to the formatting root's border box top/left. > + run->logicalRect.moveVertically(this->logicalTop()); > + run->logicalRect.moveHorizontally(this->logicalLeft()); Nice 1550355 4 372761 commit-queue 2019-07-05 07:24:29 -0700 Comment on attachment 372761 Patch Clearing flags on attachment: 372761 Committed r247153: <https://trac.webkit.org/changeset/247153> 1550356 5 commit-queue 2019-07-05 07:24:30 -0700 All reviewed patches have been landed. Closing bug. 372761 2019-06-24 08:05:43 -0700 2019-07-05 07:24:29 -0700 Patch bug-199157-20190624080543.patch text/plain 4329 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWZjMGMyMzIxODBiN2My ZjBlM2E4ODM2ZjllYzUxOTI3ODY4MmY4NC4uYzFmMWE4NDY0MWQ4MDQxZGM5ZDM0NmFjYWEzZWU3 Y2Y4MzIzOTI5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA2LTI0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBJbmxpbmUg cnVucyBzaG91bGQgYmUgcmVsYXRpdmUgdG8gdGhlIGxpbmUncyB0b3AvbGVmdCBpbml0aWFsbHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTE1Nwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTIwNTM0MTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGV0J3MgY29uc3RydWN0IHRoZSBydW5zIHJlbGF0 aXZlIHRvIHRoZSBsaW5lJ3MgdG9wL2xlZnQgYW5kIGNvbnZlcnQgdGhlbSByZWxhdGl2ZSB0byB0 aGUgZm9ybWF0dGluZyByb290J3MgYm9yZGVyIGJveCB0b3AvbGVmdAorICAgICAgICB3aGVuIHRo ZSBsaW5lIGlzIGJlaW5nIGNsb3NlZC4gV2hlbiB0aGUgbGluZSBtb3ZlcyAoZmxvYXRzIGV0Yykg d2UgZG9uJ3QgaGF2ZSB0byBtb3ZlIGVhY2ggcnVucyBpbmRpdmlkdWFsbHkuCisKKyAgICAgICAg KiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkxheW91dDo6TGluZTo6Y2xvc2UpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5l Ojptb3ZlTG9naWNhbExlZnQpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lOjphcHBl bmRJbmxpbmVDb250YWluZXJTdGFydCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6 OmFwcGVuZFRleHRDb250ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZTo6YXBw ZW5kTm9uUmVwbGFjZWRJbmxpbmVCb3gpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5l OjphcHBlbmRIYXJkTGluZUJyZWFrKToKKwogMjAxOS0wNi0yMiAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gVGhlIGFub255bW91cyBJbmxpbmVC b3ggd3JhcHBlciBmb3IgdGhlIHRleHQgbm9kZSBzaG91bGQgdGFrZSB0aGUgcGFyZW50IHN0eWxl LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5s aW5lTGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9Jbmxp bmVMaW5lLmNwcAppbmRleCBiMTI4YzhkNTBjNDUzMzdhOTRlMzJmZmRlYWEzNjJlMmVkNzM0ODk2 Li4wYzNmOTUyZmJlOWNlNTI3ZjZkNWQ5MDUxOWZjY2ZhMDNmNWVjNzU1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcApA QCAtMTM0LDYgKzEzNCw5IEBAIHN0ZDo6dW5pcXVlX3B0cjxMaW5lOjpDb250ZW50PiBMaW5lOjpj bG9zZSgpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgICAg ICBydW4tPmxvZ2ljYWxSZWN0LnNldFRvcChsb2dpY2FsVG9wKTsKKyAgICAgICAgICAgIC8vIENv bnZlcnQgcnVucyBmcm9tIHJlbGF0aXZlIHRvIHRoZSBsaW5lIHRvcC9sZWZ0IHRvIHRoZSBmb3Jt YXR0aW5nIHJvb3QncyBib3JkZXIgYm94IHRvcC9sZWZ0LgorICAgICAgICAgICAgcnVuLT5sb2dp Y2FsUmVjdC5tb3ZlVmVydGljYWxseSh0aGlzLT5sb2dpY2FsVG9wKCkpOworICAgICAgICAgICAg cnVuLT5sb2dpY2FsUmVjdC5tb3ZlSG9yaXpvbnRhbGx5KHRoaXMtPmxvZ2ljYWxMZWZ0KCkpOwog ICAgICAgICB9CiAgICAgfQogICAgIG1fY29udGVudC0+c2V0TG9naWNhbFJlY3QoeyBsb2dpY2Fs VG9wKCksIGxvZ2ljYWxMZWZ0KCksIGNvbnRlbnRMb2dpY2FsV2lkdGgoKSwgbG9naWNhbEhlaWdo dCgpIH0pOwpAQCAtMTYxLDggKzE2NCw2IEBAIHZvaWQgTGluZTo6bW92ZUxvZ2ljYWxMZWZ0KExh eW91dFVuaXQgZGVsdGEpCiAgICAgLy8gU2hyaW5rIHRoZSBsaW5lIGFuZCBtb3ZlIHRoZSBpdGVt cy4KICAgICBtX2xvZ2ljYWxUb3BMZWZ0Lm1vdmUoZGVsdGEsIDApOwogICAgIG1fbGluZUxvZ2lj YWxXaWR0aCAtPSBkZWx0YTsKLSAgICBmb3IgKGF1dG8mIHJ1biA6IG1fY29udGVudC0+cnVucygp KQotICAgICAgICBydW4tPmxvZ2ljYWxSZWN0Lm1vdmVIb3Jpem9udGFsbHkoZGVsdGEpOwogfQog CiB2b2lkIExpbmU6Om1vdmVMb2dpY2FsUmlnaHQoTGF5b3V0VW5pdCBkZWx0YSkKQEAgLTIwNSw3 ICsyMDYsNyBAQCB2b2lkIExpbmU6OmFwcGVuZE5vbkJyZWFrYWJsZVNwYWNlKGNvbnN0IElubGlu ZUl0ZW0mIGlubGluZUl0ZW0sIGNvbnN0IERpc3BsYXk6Ogogdm9pZCBMaW5lOjphcHBlbmRJbmxp bmVDb250YWluZXJTdGFydChjb25zdCBJbmxpbmVJdGVtJiBpbmxpbmVJdGVtLCBMYXlvdXRVbml0 IGxvZ2ljYWxXaWR0aCkKIHsKICAgICBhdXRvIGxvZ2ljYWxSZWN0ID0gRGlzcGxheTo6UmVjdCB7 IH07Ci0gICAgbG9naWNhbFJlY3Quc2V0TGVmdChjb250ZW50TG9naWNhbFJpZ2h0KCkpOworICAg IGxvZ2ljYWxSZWN0LnNldExlZnQoY29udGVudExvZ2ljYWxXaWR0aCgpKTsKICAgICBsb2dpY2Fs UmVjdC5zZXRXaWR0aChsb2dpY2FsV2lkdGgpOwogCiAgICAgaWYgKCFtX3NraXBWZXJ0aWNhbEFs aWdtZW50KSB7CkBAIC0yNTMsNyArMjU0LDcgQEAgdm9pZCBMaW5lOjphcHBlbmRUZXh0Q29udGVu dChjb25zdCBJbmxpbmVUZXh0SXRlbSYgaW5saW5lSXRlbSwgTGF5b3V0VW5pdCBsb2dpY2EKICAg ICBhdXRvIGNhbkJlRXh0ZW5kZWQgPSAhaXNDb21wbGV0ZWx5Q29sbGFwc2VkICYmICFpbmxpbmVJ dGVtLmlzQ29sbGFwc2VkKCk7CiAgICAgCiAgICAgYXV0byBsb2dpY2FsUmVjdCA9IERpc3BsYXk6 OlJlY3QgeyB9OwotICAgIGxvZ2ljYWxSZWN0LnNldExlZnQoY29udGVudExvZ2ljYWxSaWdodCgp KTsKKyAgICBsb2dpY2FsUmVjdC5zZXRMZWZ0KGNvbnRlbnRMb2dpY2FsV2lkdGgoKSk7CiAgICAg bG9naWNhbFJlY3Quc2V0V2lkdGgobG9naWNhbFdpZHRoKTsKICAgICBpZiAoIW1fc2tpcFZlcnRp Y2FsQWxpZ21lbnQpIHsKICAgICAgICAgYXV0byBydW5IZWlnaHQgPSBpbmxpbmVJdGVtQ29udGVu dEhlaWdodChpbmxpbmVJdGVtKTsKQEAgLTI3Niw3ICsyNzcsNyBAQCB2b2lkIExpbmU6OmFwcGVu ZE5vblJlcGxhY2VkSW5saW5lQm94KGNvbnN0IElubGluZUl0ZW0mIGlubGluZUl0ZW0sIExheW91 dFVuaXQgbAogICAgIGF1dG8gaG9yaXpvbnRhbE1hcmdpbiA9IGRpc3BsYXlCb3guaG9yaXpvbnRh bE1hcmdpbigpOyAgICAKICAgICBhdXRvIGxvZ2ljYWxSZWN0ID0gRGlzcGxheTo6UmVjdCB7IH07 CiAKLSAgICBsb2dpY2FsUmVjdC5zZXRMZWZ0KGNvbnRlbnRMb2dpY2FsUmlnaHQoKSArIGhvcml6 b250YWxNYXJnaW4uc3RhcnQpOworICAgIGxvZ2ljYWxSZWN0LnNldExlZnQoY29udGVudExvZ2lj YWxXaWR0aCgpICsgaG9yaXpvbnRhbE1hcmdpbi5zdGFydCk7CiAgICAgbG9naWNhbFJlY3Quc2V0 V2lkdGgobG9naWNhbFdpZHRoKTsKICAgICBpZiAoIW1fc2tpcFZlcnRpY2FsQWxpZ21lbnQpIHsK ICAgICAgICAgYWRqdXN0QmFzZWxpbmVBbmRMaW5lSGVpZ2h0KGlubGluZUl0ZW0sIGRpc3BsYXlC b3gubWFyZ2luQm94SGVpZ2h0KCkpOwpAQCAtMjk3LDcgKzI5OCw3IEBAIHZvaWQgTGluZTo6YXBw ZW5kUmVwbGFjZWRJbmxpbmVCb3goY29uc3QgSW5saW5lSXRlbSYgaW5saW5lSXRlbSwgTGF5b3V0 VW5pdCBsb2dpCiB2b2lkIExpbmU6OmFwcGVuZEhhcmRMaW5lQnJlYWsoY29uc3QgSW5saW5lSXRl bSYgaW5saW5lSXRlbSkKIHsKICAgICBhdXRvIGxvZ2ljYWxSZWN0ID0gRGlzcGxheTo6UmVjdCB7 IH07Ci0gICAgbG9naWNhbFJlY3Quc2V0TGVmdChjb250ZW50TG9naWNhbFJpZ2h0KCkpOworICAg IGxvZ2ljYWxSZWN0LnNldExlZnQoY29udGVudExvZ2ljYWxXaWR0aCgpKTsKICAgICBsb2dpY2Fs UmVjdC5zZXRXaWR0aCh7IH0pOwogICAgIGlmICghbV9za2lwVmVydGljYWxBbGlnbWVudCkgewog ICAgICAgICBhZGp1c3RCYXNlbGluZUFuZExpbmVIZWlnaHQoaW5saW5lSXRlbSwgeyB9KTsK