199155 2019-06-24 07:07:05 -0700 [WPE][GTK] Fixes for compilation with unified builds disabled 2019-06-24 07:53:13 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez commit-queue koivisto mcatanzaro simon.fraser webkit-bug-importer oldest_to_newest 1547324 0 aperez 2019-06-24 07:07:05 -0700 As of r246731 there's a few build errors when unified builds are disabled: --- In file included from ../Source/WebCore/rendering/LayerAncestorClippingStack.cpp:27: ../Source/WebCore/rendering/LayerAncestorClippingStack.h:42:24: error: unknown type name 'RenderLayer' CompositedClipData(RenderLayer* layer, LayoutRect rect, bool isOverflowScrollEntry) ^ ../Source/WebCore/rendering/LayerAncestorClippingStack.h:61:13: error: use of undeclared identifier 'RenderLayer' WeakPtr<RenderLayer> clippingLayer; // For scroller entries, the scrolling layer. For other entries, the most-descendant layer that has a clip. ^ ../Source/WebCore/rendering/LayerAncestorClippingStack.h:85:5: error: unknown type name 'GraphicsLayer' GraphicsLayer* firstClippingLayer() const; ^ ../Source/WebCore/rendering/LayerAncestorClippingStack.h:86:5: error: unknown type name 'GraphicsLayer' GraphicsLayer* lastClippingLayer() const; ^ ../Source/WebCore/rendering/LayerAncestorClippingStack.h:94:16: error: use of undeclared identifier 'GraphicsLayer' RefPtr<GraphicsLayer> clippingLayer; ^ --- In file included from ../Source/WebKit/NetworkProcess/glib/DNSCache.cpp:27: ../Source/WebKit/NetworkProcess/glib/DNSCache.h:45:29: error: use of undeclared identifier 'GInetAddress' Optional<Vector<GRefPtr<GInetAddress>>> lookup(const CString& host, Type = Type::Default); ^ --- ../Source/WebKit/NetworkProcess/glib/DNSCache.cpp:37:32: error: use of undeclared identifier 'RunLoopSourcePriority' m_expiredTimer.setPriority(RunLoopSourcePriority::ReleaseUnusedResourcesTimer); ^ 1547326 1 372756 aperez 2019-06-24 07:10:59 -0700 Created attachment 372756 Patch 1547332 2 372756 mcatanzaro 2019-06-24 07:24:53 -0700 Comment on attachment 372756 Patch It's going to be all for naught without an EWS. 1547335 3 aperez 2019-06-24 07:32:53 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 372756 [details] > Patch > > It's going to be all for naught without an EWS. I have a crappy script locally which picks the “compile_commands.json” file and runs over the sources using “-fsyntax-only” with Clang and that is able to find out the missing includes/declarations without making the compiler do optimizations/code-generation. I want to make make some measurements once it can run Clang in parallel (right now it's serial) to know how fast such an EWS would be before proposing adding it ;-) 1547346 4 372756 commit-queue 2019-06-24 07:52:59 -0700 Comment on attachment 372756 Patch Clearing flags on attachment: 372756 Committed r246734: <https://trac.webkit.org/changeset/246734> 1547347 5 commit-queue 2019-06-24 07:53:01 -0700 All reviewed patches have been landed. Closing bug. 1547348 6 webkit-bug-importer 2019-06-24 07:53:13 -0700 <rdar://problem/52053871> 372756 2019-06-24 07:10:59 -0700 2019-06-24 07:52:59 -0700 Patch bug-199155-20190624171058.patch text/plain 2994 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRhOTZlMGJjZGM4ZDc5 ZDBkNTUyYjQ3YmEwNWU5Y2U1MDdjMjZmMS4uMzUyYWZhMmI0Y2ZjZGMwOWM3YzUwZjgwY2UzY2My NDNiMGY4NmY3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA2LTI0ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV1b R1RLXSBGaXhlcyBmb3IgY29tcGlsYXRpb24gd2l0aCB1bmlmaWVkIGJ1aWxkcyBkaXNhYmxlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTU1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIG5lZWRlZC4KKworICAgICAgICAqIHJlbmRlcmluZy9MYXllckFuY2VzdG9yQ2xpcHBpbmdT dGFjay5oOiBBZGQgbWlzc2luZyBpbmNsdXNpb24gb2YgUmVuZGVyTGF5ZXIuaAorCiAyMDE5LTA2 LTI0ICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0 cmVhbWVyXVtNU0VdIFBhdXNpbmcgdmlkZW8gc29tZXRpbWVzIGNhdXNlcyBza2lwIHRvIGZpbmlz aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZwppbmRleCA1NmQxOTZlYjQxMDVjZmZkYjM5OWQ0Nzc5OGUyOTkwY2ZiM2M0YWE3Li5i NzUzMWQwNmYxNjg5NDExNmFkMmEwNWFhZDAyNDNiZmFlMTgzNTRiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA2LTI0ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGln YWxpYS5jb20+CisKKyAgICAgICAgW1dQRV1bR1RLXSBGaXhlcyBmb3IgY29tcGlsYXRpb24gd2l0 aCB1bmlmaWVkIGJ1aWxkcyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9nbGliL0ROU0NhY2hlLmNwcDogQWRk IG1pc3NpbmcgaW5jbHVzaW9uIG9mIHd0Zi9nbGliL1J1bkxvb3BTb3VyY2VQcmlvcml0eS5oCisg ICAgICAgICogTmV0d29ya1Byb2Nlc3MvZ2xpYi9ETlNDYWNoZS5oOiBBZGQgbWlzc2luZyBmb3J3 YXJkIGRlY2xhcmF0aW9uIGZvciBHSW5ldEFkZHJlc3MKKwogMjAxOS0wNi0yMyAgRGFuIEJlcm5z dGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFBsYXRmb3JtIGZvbnQgY2xhc3MgZ2V0 cyBuZWVkbGVzc2x5IGluaXRpYWxpemVkIGluIHRoZSBOZXR3b3JraW5nIHByb2Nlc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MYXllckFuY2VzdG9yQ2xpcHBpbmdTdGFj ay5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xheWVyQW5jZXN0b3JDbGlwcGluZ1N0YWNr LmgKaW5kZXggNGNmNDIxNWJjZGJlMWI2OWY0NWEwNGFjMTRiY2Q0YTM2MDhjN2IyZi4uNGY5Mjlm YTIzY2IwYmEyOWE1MjMyNTI2ZGViMmE4OTZhYjc4OTdiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0xheWVyQW5jZXN0b3JDbGlwcGluZ1N0YWNrLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0xheWVyQW5jZXN0b3JDbGlwcGluZ1N0YWNrLmgKQEAgLTI2LDYg KzI2LDcgQEAKICNwcmFnbWEgb25jZQogCiAjaW5jbHVkZSAiTGF5b3V0UmVjdC5oIgorI2luY2x1 ZGUgIlJlbmRlckxheWVyLmgiCiAjaW5jbHVkZSAiU2Nyb2xsVHlwZXMuaCIKICNpbmNsdWRlIDx3 dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL1dlYWtQdHIuaD4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvZ2xpYi9ETlNDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL2dsaWIvRE5TQ2FjaGUuY3BwCmluZGV4IDEyYjlhOTVjZDlmZjE3ZmI5 NTNlZjljZDE4MDYxMWE2MmExOWI2OWEuLmQ4ZWEzMzY4NWVhMmI4ZWI2Y2NlYjQzYWQzOGUwNjBj NDNhODk1OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvZ2xpYi9E TlNDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9nbGliL0ROU0Nh Y2hlLmNwcApAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg IkROU0NhY2hlLmgiCiAKKyNpbmNsdWRlIDx3dGYvZ2xpYi9SdW5Mb29wU291cmNlUHJpb3JpdHku aD4KKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIHN0YXRpYyBjb25zdCBTZWNvbmRzIGV4cGlyZUlu dGVydmFsID0gNjBfczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Z2xpYi9ETlNDYWNoZS5oIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9nbGliL0ROU0Nh Y2hlLmgKaW5kZXggZDQyMGVkZDViMTRlNjk5OTMwODZiM2Y0Y2JmN2I1ZGQ0NDRjN2ViZi4uMmI3 OGYzOGMxZmU3YTdmOGZmMmUzOTQxNGQwNjUyZmEzOGZjODNjYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9nbGliL0ROU0NhY2hlLmgKKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9nbGliL0ROU0NhY2hlLmgKQEAgLTM0LDYgKzM0LDggQEAKICNpbmNs dWRlIDx3dGYvZ2xpYi9HUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgog Cit0eXBlZGVmIHN0cnVjdCBfR0luZXRBZGRyZXNzIEdJbmV0QWRkcmVzczsKKwogbmFtZXNwYWNl IFdlYktpdCB7CiAKIGNsYXNzIEROU0NhY2hlIHsK