199128 2019-06-22 13:24:38 -0700 Web Inspector: Elements: show shadow DOM by default 2019-06-25 17:06:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P4 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes rniwa timothy webkit-bug-importer oldest_to_newest 1547123 0 mattbaker 2019-06-22 13:24:38 -0700 The toggle for this setting has a prominent spot in the Elements tab, but if overlooked, empty Shadow DOM host nodes in the tree could give the impression that something is wrong or missing. Shadow DOM host nodes will initially be collapsed in the DOM tree, so there shouldn't be a downside to enabling this by default. 1547124 1 webkit-bug-importer 2019-06-22 13:25:21 -0700 <rdar://problem/52022337> 1547125 2 372686 mattbaker 2019-06-22 13:26:27 -0700 Created attachment 372686 Patch 1547871 3 hi 2019-06-25 16:27:57 -0700 I'm fine with this, as I always have Shadow DOM enabled. @rniwa (Ryosuke) or @joepeck (Joe) or @xenon (Tim) is there a reason we wouldn't want to do this? 1547883 4 372686 commit-queue 2019-06-25 16:45:44 -0700 Comment on attachment 372686 Patch Clearing flags on attachment: 372686 Committed r246821: <https://trac.webkit.org/changeset/246821> 1547884 5 commit-queue 2019-06-25 16:45:46 -0700 All reviewed patches have been landed. Closing bug. 1547895 6 mattbaker 2019-06-25 17:06:19 -0700 (In reply to Devin Rousso from comment #3) > I'm fine with this, as I always have Shadow DOM enabled. > > @rniwa (Ryosuke) or @joepeck (Joe) or @xenon (Tim) is there a reason we > wouldn't want to do this? I copied Ryosuke on the bug, since he is the domain expert. I think we should consider whether this warrants a toggle at all, and if it does, whether it needs to have such a prominent location (Elements tab navigation bar). I appreciate that shadow DOM is inherently an encapsulation mechanism, and as such it makes sense to hide the implementation details. That said, maybe it makes more sense to put this toggle in the Settings tab. 372686 2019-06-22 13:26:27 -0700 2019-06-25 16:45:44 -0700 Patch bug-199128-20190622132627.patch text/plain 2367 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi ZjY5ZDgwOTZkYmJlNDViNTAzZTA0ZTRjYmEyNWRhYmI3ZThjNDgzLi43Mjk3ZDFkMzQxNTVkYWQ0 NzU1ZjE0OTE2NmQ0YTRhMmFiMmQ0ZTAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNi0yMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWxlbWVudHM6IHNob3cgc2hhZG93IERPTSBieSBk ZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTkxMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzOgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9UZXN0L1Rlc3QuanM6CisgICAgICAgIChXSS5sb2FkZWQpOgorICAgICAgICBPdmVycmlkaW5n IHRoZSBkZWZhdWx0IHZhbHVlIGlzbid0IG5lY2Vzc2FyeSBzaW5jZSB0aGUgZGVmYXVsdCBpcyBu b3cgdHJ1ZS4KKwogMjAxOS0wNi0yMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVtb3ZlIHVudXNlZCBEYXRhR3JpZCBzdHlsZSAu Zm9yY2UtZm9jdXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvU2V0dGluZy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvU2V0dGluZy5qcwppbmRleCBiZmE5ODM4MDYzNTllMjIwODM4NjNiN2ZlNmRjMGU2ZmRl MmE1MGQzLi5kODc3ZGQzODdiMDliOTI1MDI1NjgzYjkzZDdhMWMwYmM0NjRiZTY3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpz CkBAIC0xNjgsNyArMTY4LDcgQEAgV0kuc2V0dGluZ3MgPSB7CiAgICAgc2hvd1J1bGVyczogbmV3 IFdJLlNldHRpbmcoInNob3ctcnVsZXJzIiwgZmFsc2UpLAogICAgIHNob3dSdWxlcnNEdXJpbmdF bGVtZW50U2VsZWN0aW9uOiBuZXcgV0kuU2V0dGluZygic2hvdy1ydWxlcnMtZHVyaW5nLWVsZW1l bnQtc2VsZWN0aW9uIiwgdHJ1ZSksCiAgICAgc2hvd1Njb3BlQ2hhaW5PblBhdXNlOiBuZXcgV0ku U2V0dGluZygic2hvdy1zY29wZS1jaGFpbi1zaWRlYmFyIiwgdHJ1ZSksCi0gICAgc2hvd1NoYWRv d0RPTTogbmV3IFdJLlNldHRpbmcoInNob3ctc2hhZG93LWRvbSIsIGZhbHNlKSwKKyAgICBzaG93 U2hhZG93RE9NOiBuZXcgV0kuU2V0dGluZygic2hvdy1zaGFkb3ctZG9tIiwgdHJ1ZSksCiAgICAg c2hvd1doaXRlc3BhY2VDaGFyYWN0ZXJzOiBuZXcgV0kuU2V0dGluZygic2hvdy13aGl0ZXNwYWNl LWNoYXJhY3RlcnMiLCBmYWxzZSksCiAgICAgdGFiU2l6ZTogbmV3IFdJLlNldHRpbmcoInRhYi1z aXplIiwgNCksCiAgICAgdGltZWxpbmVzQXV0b1N0b3A6IG5ldyBXSS5TZXR0aW5nKCJ0aW1lbGlu ZXMtYXV0by1zdG9wIiwgdHJ1ZSksCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9UZXN0L1Rlc3QuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9UZXN0L1Rlc3QuanMKaW5kZXggNzNhYzNkMzE3YzhmNDVlYjUxZTQ4ODM5MjU4OGMw Y2VkMjBjMzk3Yy4uNTA1NGY0ZDAyMzBkYjk3ZjFkZWFjODgzZDAzYWExOTdhMmZlZmJiMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGVzdC9UZXN0Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QvVGVzdC5qcwpA QCAtNjksOSArNjksNiBAQCBXSS5sb2FkZWQgPSBmdW5jdGlvbigpCiAgICAgLy8gUmVnaXN0ZXIg Zm9yIGV2ZW50cy4KICAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJET01Db250ZW50TG9h ZGVkIiwgV0kuY29udGVudExvYWRlZCk7CiAKLSAgICAvLyBOb24tZGVmYXVsdCBnbG9iYWwgc2V0 dGluZyB2YWx1ZXMgZm9yIHRlc3RzLgotICAgIFdJLnNldHRpbmdzLnNob3dTaGFkb3dET00udmFs dWUgPSB0cnVlOwotCiAgICAgLy8gVGFyZ2V0cy4KICAgICBXSS5iYWNrZW5kVGFyZ2V0ID0gbnVs bDsKICAgICBXSS5wYWdlVGFyZ2V0ID0gbnVsbDsK