199097 2019-06-20 19:05:01 -0700 Make sure to check for file descriptor value before using FD_CLR 2019-06-21 10:12:44 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1546783 0 youennf 2019-06-20 19:05:01 -0700 Make sure to check for file descriptor value before using FD_CLR 1546784 1 youennf 2019-06-20 19:05:25 -0700 <rdar://problem/51479074> 1546788 2 372609 youennf 2019-06-20 19:12:37 -0700 Created attachment 372609 Patch 1546894 3 372609 eric.carlson 2019-06-21 09:43:18 -0700 Comment on attachment 372609 Patch Is it worth adding a GetDescriptor() check in ProcessEvents, or is getsockopt() with an invalid file descriptor harmless? 1546902 4 youennf 2019-06-21 10:06:31 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 372609 [details] > Patch > > Is it worth adding a GetDescriptor() check in ProcessEvents, or is > getsockopt() with an invalid file descriptor harmless? I think this is fine, ProcessEvents should only be called with a dispatcher with a valid descriptor. 1546905 5 372609 commit-queue 2019-06-21 10:12:42 -0700 Comment on attachment 372609 Patch Clearing flags on attachment: 372609 Committed r246682: <https://trac.webkit.org/changeset/246682> 1546906 6 commit-queue 2019-06-21 10:12:44 -0700 All reviewed patches have been landed. Closing bug. 372609 2019-06-20 19:12:37 -0700 2019-06-21 10:12:42 -0700 Patch bug-199097-20190620191237.patch text/plain 4026 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA2NmE2MDI3OTI3ODljMmIyZTcyNzc2ODEzM2EzYzA5YTExMTkwZDBlLi5jZTll ODE1ZDhmZGQ2MDBlZDAxOWY1N2RmZWQ0ZTIxOWY3NmNhMGVlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wNi0yMCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBzdXJlIHRvIGNoZWNrIGZv ciBmaWxlIGRlc2NyaXB0b3IgdmFsdWUgYmVmb3JlIHVzaW5nIEZEX0NMUgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MDk3CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81MTQ3OTA3ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNvdXJjZS93ZWJydGMvcnRjX2Jhc2UvcGh5c2ljYWxzb2NrZXRzZXJ2 ZXIuY2M6CisgICAgICAgICogV2ViS2l0LzAwMDEtZml4LWZkLWNsci5wYXRjaDogQWRkZWQuCisK IDIwMTktMDYtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAg IE1ha2Ugc3VyZSBsaWJ3ZWJydGMgT2JqQyBjb2RlYyBpbnRlcmZhY2VzIGRvIG5vdCBjb25mbGlj dApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMv cnRjX2Jhc2UvcGh5c2ljYWxzb2NrZXRzZXJ2ZXIuY2MgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3 ZWJydGMvU291cmNlL3dlYnJ0Yy9ydGNfYmFzZS9waHlzaWNhbHNvY2tldHNlcnZlci5jYwppbmRl eCA5MWNiN2RhODM2NmUyZjFkZmNhMzYwYzU3ODgxZjk3MDdlNTRlMDA4Li4zY2YyZDMyMjFjNWZh ODNmMGI2OWU0ZmZhNTE4Njk3NjViNTUxNDdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9ydGNfYmFzZS9waHlzaWNhbHNvY2tldHNlcnZlci5j YworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9ydGNfYmFz ZS9waHlzaWNhbHNvY2tldHNlcnZlci5jYwpAQCAtMTQyNCw4ICsxNDI0LDEwIEBAIGJvb2wgUGh5 c2ljYWxTb2NrZXRTZXJ2ZXI6OldhaXRTZWxlY3QoaW50IGNtc1dhaXQsIGJvb2wgcHJvY2Vzc19p bykgewogICAgICAgICAvLyAic2VsZWN0ImluZyBhIGZpbGUgZGVzY3JpcHRvciB0aGF0IGlzIGVx dWFsIHRvIG9yIGxhcmdlciB0aGFuCiAgICAgICAgIC8vIEZEX1NFVFNJWkUgd2lsbCByZXN1bHQg aW4gdW5kZWZpbmVkIGJlaGF2aW9yLgogICAgICAgICBSVENfRENIRUNLX0xUKGZkLCBGRF9TRVRT SVpFKTsKKyNpZiBkZWZpbmVkKFdFQlJUQ19XRUJLSVRfQlVJTEQpCiAgICAgICAgIGlmIChmZCA8 IDAgfHwgZmQgPj0gRkRfU0VUU0laRSkKICAgICAgICAgICAgIGNvbnRpbnVlOworI2VuZGlmCiAg ICAgICAgIGlmIChmZCA+IGZkbWF4KQogICAgICAgICAgIGZkbWF4ID0gZmQ7CiAKQEAgLTE0NjIs NyArMTQ2NCwxMCBAQCBib29sIFBoeXNpY2FsU29ja2V0U2VydmVyOjpXYWl0U2VsZWN0KGludCBj bXNXYWl0LCBib29sIHByb2Nlc3NfaW8pIHsKICAgICAgIHByb2Nlc3NpbmdfZGlzcGF0Y2hlcnNf ID0gdHJ1ZTsKICAgICAgIGZvciAoRGlzcGF0Y2hlciogcGRpc3BhdGNoZXIgOiBkaXNwYXRjaGVy c18pIHsKICAgICAgICAgaW50IGZkID0gcGRpc3BhdGNoZXItPkdldERlc2NyaXB0b3IoKTsKLQor I2lmIGRlZmluZWQoV0VCUlRDX1dFQktJVF9CVUlMRCkKKyAgICAgICAgaWYgKGZkIDwgMCB8fCBm ZCA+PSBGRF9TRVRTSVpFKQorICAgICAgICAgIGNvbnRpbnVlOworI2VuZGlmCiAgICAgICAgIGJv b2wgcmVhZGFibGUgPSBGRF9JU1NFVChmZCwgJmZkc1JlYWQpOwogICAgICAgICBpZiAocmVhZGFi bGUpIHsKICAgICAgICAgICBGRF9DTFIoZmQsICZmZHNSZWFkKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9XZWJLaXQvMDAwMS1maXgtZmQtY2xyLnBhdGNoIGIvU291 cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1dlYktpdC8wMDAxLWZpeC1mZC1jbHIucGF0Y2gKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNzllNDJiZTY1NzU2NTI1NDQ5ZmE4ZWU5OTdjOWI4ZjkzZmFjZGEyMQotLS0gL2Rl di9udWxsCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9XZWJLaXQvMDAwMS1maXgt ZmQtY2xyLnBhdGNoCkBAIC0wLDAgKzEsMzkgQEAKK0Zyb20gY2UzYjVkMGRkMDAzYTUwMjkyMmVm MWJiMzRhMDkzNWRkOWZhMjZhOSBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKK0Zyb206IFlvdWVu biBGYWJsZXQgPHlvdWVubkBhcHBsZS5jb20+CitEYXRlOiBUaHUsIDIwIEp1biAyMDE5IDE5OjA5 OjU5IC0wNzAwCitTdWJqZWN0OiBbUEFUQ0hdIGZpeC1mZC1jbHIKKworLS0tCisgLi4uL1NvdXJj ZS93ZWJydGMvcnRjX2Jhc2UvcGh5c2ljYWxzb2NrZXRzZXJ2ZXIuY2MgICAgICAgICB8IDcgKysr KysrLQorIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKKwor ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3J0 Y19iYXNlL3BoeXNpY2Fsc29ja2V0c2VydmVyLmNjIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2Vi cnRjL1NvdXJjZS93ZWJydGMvcnRjX2Jhc2UvcGh5c2ljYWxzb2NrZXRzZXJ2ZXIuY2MKK2luZGV4 IDkxY2I3ZGE4MzY2Li4zY2YyZDMyMjFjNSAxMDA2NDQKKy0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3J0Y19iYXNlL3BoeXNpY2Fsc29ja2V0c2VydmVyLmNj CisrKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9ydGNfYmFz ZS9waHlzaWNhbHNvY2tldHNlcnZlci5jYworQEAgLTE0MjQsOCArMTQyNCwxMCBAQCBib29sIFBo eXNpY2FsU29ja2V0U2VydmVyOjpXYWl0U2VsZWN0KGludCBjbXNXYWl0LCBib29sIHByb2Nlc3Nf aW8pIHsKKyAgICAgICAgIC8vICJzZWxlY3QiaW5nIGEgZmlsZSBkZXNjcmlwdG9yIHRoYXQgaXMg ZXF1YWwgdG8gb3IgbGFyZ2VyIHRoYW4KKyAgICAgICAgIC8vIEZEX1NFVFNJWkUgd2lsbCByZXN1 bHQgaW4gdW5kZWZpbmVkIGJlaGF2aW9yLgorICAgICAgICAgUlRDX0RDSEVDS19MVChmZCwgRkRf U0VUU0laRSk7CisrI2lmIGRlZmluZWQoV0VCUlRDX1dFQktJVF9CVUlMRCkKKyAgICAgICAgIGlm IChmZCA8IDAgfHwgZmQgPj0gRkRfU0VUU0laRSkKKyAgICAgICAgICAgICBjb250aW51ZTsKKysj ZW5kaWYKKyAgICAgICAgIGlmIChmZCA+IGZkbWF4KQorICAgICAgICAgICBmZG1heCA9IGZkOwor IAorQEAgLTE0NjIsNyArMTQ2NCwxMCBAQCBib29sIFBoeXNpY2FsU29ja2V0U2VydmVyOjpXYWl0 U2VsZWN0KGludCBjbXNXYWl0LCBib29sIHByb2Nlc3NfaW8pIHsKKyAgICAgICBwcm9jZXNzaW5n X2Rpc3BhdGNoZXJzXyA9IHRydWU7CisgICAgICAgZm9yIChEaXNwYXRjaGVyKiBwZGlzcGF0Y2hl ciA6IGRpc3BhdGNoZXJzXykgeworICAgICAgICAgaW50IGZkID0gcGRpc3BhdGNoZXItPkdldERl c2NyaXB0b3IoKTsKKy0KKysjaWYgZGVmaW5lZChXRUJSVENfV0VCS0lUX0JVSUxEKQorKyAgICAg ICAgaWYgKGZkIDwgMCB8fCBmZCA+PSBGRF9TRVRTSVpFKQorKyAgICAgICAgICBjb250aW51ZTsK KysjZW5kaWYKKyAgICAgICAgIGJvb2wgcmVhZGFibGUgPSBGRF9JU1NFVChmZCwgJmZkc1JlYWQp OworICAgICAgICAgaWYgKHJlYWRhYmxlKSB7CisgICAgICAgICAgIEZEX0NMUihmZCwgJmZkc1Jl YWQpOworLS0gCisyLjIxLjAgKEFwcGxlIEdpdC0xMTgpCisK